bretton.dev / coves
A community based topic aggregation platform built on atproto
fork atom

feat: Implement union types for moderation configuration

- Replace single moderationConfig with union type supporting both moderator and sortition variants
- Add $type discriminator field following atProto patterns
- Separate tribunal-specific fields (tribunalThreshold, jurySize) to sortition variant only
- Update test files to use new union structure with proper $type fields
- Ensure type safety: only sortition communities can configure tribunal settings

This change improves the lexicon design by:
- Following atProto best practices for discriminated unions
- Providing clear separation between moderation types
- Enabling future extensibility for new moderation approaches
- Maintaining backwards compatibility through the union pattern

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

bretton.dev 20958ec6 3ce02d92

options
unified split
Changed files
+102 -22
internal
atproto
lexicon
social
coves
community
rules.json
tests
lexicon-test-data
community
rules-invalid-moderation.json
rules-invalid-sortition.json
rules-valid-moderator.json
rules-valid.json
+69 -11
internal/atproto/lexicon/social/coves/community/rules.json 
···

       
47

       
47

       
 

       
              "format": "did"


     

       
48

       
48

       
 

       
            }


     

       
49

       
49

       
 

       
          },


     

       
50

       

       
-

       
          "sortitionConfig": {


     

       
51

       

       
-

       
            "type": "ref",


     

       
52

       

       
-

       
            "ref": "#sortitionConfig",


     

       
53

       

       
-

       
            "description": "Configuration for sortition-based moderation"


     

       

       
50

       
+

       
          "moderationConfig": {


     

       

       
51

       
+

       
            "type": "union",


     

       

       
52

       
+

       
            "refs": ["#moderatorModeration", "#sortitionModeration"],


     

       

       
53

       
+

       
            "description": "Configuration for community moderation"


     

       
54

       
54

       
 

       
          }


     

       
55

       
55

       
 

       
        }


     

       
56

       
56

       
 

       
      }


     
···

       
78

       
78

       
 

       
          "type": "boolean",


     

       
79

       
79

       
 

       
          "default": true,


     

       
80

       
80

       
 

       
          "description": "Allow Article posts"


     

       

       
81

       
+

       
        },


     

       

       
82

       
+

       
        "allowMicroblog": {


     

       

       
83

       
+

       
          "type": "boolean",


     

       

       
84

       
+

       
          "default": true,


     

       

       
85

       
+

       
          "description": "Allow microblog posts (federated short-form content)"


     

       
81

       
86

       
 

       
        }


     

       
82

       
87

       
 

       
      }


     

       
83

       
88

       
 

       
    },


     
···

       
126

       
131

       
 

       
        }


     

       
127

       
132

       
 

       
      }


     

       
128

       
133

       
 

       
    },


     

       
129

       

       
-

       
    "sortitionConfig": {


     

       

       
134

       
+

       
    "moderatorModeration": {


     

       
130

       
135

       
 

       
      "type": "object",


     

       
131

       

       
-

       
      "description": "Configuration for sortition-based moderation",


     

       

       
136

       
+

       
      "description": "Moderation configuration for moderator-based communities",


     

       

       
137

       
+

       
      "required": ["$type"],


     

       
132

       
138

       
 

       
      "properties": {


     

       
133

       

       
-

       
        "tagThreshold": {


     

       

       
139

       
+

       
        "$type": {


     

       

       
140

       
+

       
          "type": "string",


     

       

       
141

       
+

       
          "description": "Discriminator for moderator-based moderation"


     

       

       
142

       
+

       
        },


     

       

       
143

       
+

       
        "negativeTags": {


     

       

       
144

       
+

       
          "type": "array",


     

       

       
145

       
+

       
          "description": "Default tags that count as negative",


     

       

       
146

       
+

       
          "default": ["spam", "hostile", "offtopic", "misleading"],


     

       

       
147

       
+

       
          "items": {


     

       

       
148

       
+

       
            "type": "string"


     

       

       
149

       
+

       
          }


     

       

       
150

       
+

       
        },


     

       

       
151

       
+

       
        "customNegativeTags": {


     

       

       
152

       
+

       
          "type": "array",


     

       

       
153

       
+

       
          "description": "Community-specific tags that count as negative",


     

       

       
154

       
+

       
          "items": {


     

       

       
155

       
+

       
            "type": "string"


     

       

       
156

       
+

       
          }


     

       

       
157

       
+

       
        },


     

       

       
158

       
+

       
        "hideThreshold": {


     

       
134

       
159

       
 

       
          "type": "integer",


     

       
135

       

       
-

       
          "minimum": 10,


     

       

       
160

       
+

       
          "minimum": 5,


     

       
136

       
161

       
 

       
          "default": 15,


     

       
137

       

       
-

       
          "description": "Number of tags needed to trigger action"


     

       

       
162

       
+

       
          "description": "Number of negative tags needed to hide content"


     

       

       
163

       
+

       
        }


     

       

       
164

       
+

       
      }


     

       

       
165

       
+

       
    },


     

       

       
166

       
+

       
    "sortitionModeration": {


     

       

       
167

       
+

       
      "type": "object",


     

       

       
168

       
+

       
      "description": "Moderation configuration for sortition-based communities",


     

       

       
169

       
+

       
      "required": ["$type"],


     

       

       
170

       
+

       
      "properties": {


     

       

       
171

       
+

       
        "$type": {


     

       

       
172

       
+

       
          "type": "string",


     

       

       
173

       
+

       
          "description": "Discriminator for sortition-based moderation"


     

       

       
174

       
+

       
        },


     

       

       
175

       
+

       
        "negativeTags": {


     

       

       
176

       
+

       
          "type": "array",


     

       

       
177

       
+

       
          "description": "Default tags that count as negative",


     

       

       
178

       
+

       
          "default": ["spam", "hostile", "offtopic", "misleading"],


     

       

       
179

       
+

       
          "items": {


     

       

       
180

       
+

       
            "type": "string"


     

       

       
181

       
+

       
          }


     

       

       
182

       
+

       
        },


     

       

       
183

       
+

       
        "customNegativeTags": {


     

       

       
184

       
+

       
          "type": "array",


     

       

       
185

       
+

       
          "description": "Community-specific tags that count as negative",


     

       

       
186

       
+

       
          "items": {


     

       

       
187

       
+

       
            "type": "string"


     

       

       
188

       
+

       
          }


     

       

       
189

       
+

       
        },


     

       

       
190

       
+

       
        "hideThreshold": {


     

       

       
191

       
+

       
          "type": "integer",


     

       

       
192

       
+

       
          "minimum": 5,


     

       

       
193

       
+

       
          "default": 15,


     

       

       
194

       
+

       
          "description": "Number of negative tags needed to hide content"


     

       
138

       
195

       
 

       
        },


     

       
139

       
196

       
 

       
        "tribunalThreshold": {


     

       
140

       
197

       
 

       
          "type": "integer",


     

       
141

       
198

       
 

       
          "minimum": 10,


     

       
142

       
199

       
 

       
          "default": 30,


     

       
143

       

       
-

       
          "description": "Number of tags to trigger tribunal review"


     

       

       
200

       
+

       
          "description": "Number of negative tags to trigger tribunal review"


     

       
144

       
201

       
 

       
        },


     

       
145

       
202

       
 

       
        "jurySize": {


     

       
146

       
203

       
 

       
          "type": "integer",


     

       
147

       

       
-

       
          "minimum": 9,


     

       

       
204

       
+

       
          "minimum": 5,


     

       

       
205

       
+

       
          "maximum": 21,


     

       
148

       
206

       
 

       
          "default": 9,


     

       
149

       
207

       
 

       
          "description": "Number of jurors for tribunal"


     

       
150

       
208

       
 

       
        }
+9
tests/lexicon-test-data/community/rules-invalid-moderation.json 
···

       

       
1

       
+

       
{


     

       

       
2

       
+

       
  "$type": "social.coves.community.rules",


     

       

       
3

       
+

       
  "moderationConfig": {


     

       

       
4

       
+

       
    "negativeTags": ["spam", "hostile"],


     

       

       
5

       
+

       
    "hideThreshold": 3,


     

       

       
6

       
+

       
    "tribunalThreshold": 30,


     

       

       
7

       
+

       
    "jurySize": 9


     

       

       
8

       
+

       
  }


     

       

       
9

       
+

       
}
-8
tests/lexicon-test-data/community/rules-invalid-sortition.json 
···

       
1

       

       
-

       
{


     

       
2

       

       
-

       
  "$type": "social.coves.community.rules",


     

       
3

       

       
-

       
  "sortitionConfig": {


     

       
4

       

       
-

       
    "tagThreshold": 5,


     

       
5

       

       
-

       
    "tribunalThreshold": 30,


     

       
6

       

       
-

       
    "jurySize": 9


     

       
7

       

       
-

       
  }


     

       
8

       

       
-

       
}
+17
tests/lexicon-test-data/community/rules-valid-moderator.json 
···

       

       
1

       
+

       
{


     

       

       
2

       
+

       
  "$type": "social.coves.community.rules",


     

       

       
3

       
+

       
  "postTypes": {


     

       

       
4

       
+

       
    "allowText": true,


     

       

       
5

       
+

       
    "allowVideo": false,


     

       

       
6

       
+

       
    "allowImage": true,


     

       

       
7

       
+

       
    "allowArticle": true,


     

       

       
8

       
+

       
    "allowMicroblog": false


     

       

       
9

       
+

       
  },


     

       

       
10

       
+

       
  "customTags": ["announcement", "pinned"],


     

       

       
11

       
+

       
  "moderationConfig": {


     

       

       
12

       
+

       
    "$type": "social.coves.community.rules#moderatorModeration",


     

       

       
13

       
+

       
    "negativeTags": ["spam", "hostile", "offtopic", "misleading"],


     

       

       
14

       
+

       
    "customNegativeTags": ["loweffort"],


     

       

       
15

       
+

       
    "hideThreshold": 20


     

       

       
16

       
+

       
  }


     

       

       
17

       
+

       
}
+7 -3
tests/lexicon-test-data/community/rules-valid.json 
···

       
4

       
4

       
 

       
    "allowText": true,


     

       
5

       
5

       
 

       
    "allowVideo": true,


     

       
6

       
6

       
 

       
    "allowImage": true,


     

       
7

       

       
-

       
    "allowArticle": true


     

       

       
7

       
+

       
    "allowArticle": true,


     

       

       
8

       
+

       
    "allowMicroblog": true


     

       
8

       
9

       
 

       
  },


     

       
9

       
10

       
 

       
  "contentRestrictions": {


     

       
10

       
11

       
 

       
    "blockedDomains": ["spam.com", "malware.com"],


     
···

       
36

       
37

       
 

       
      "isActive": true


     

       
37

       
38

       
 

       
    }


     

       
38

       
39

       
 

       
  ],


     

       
39

       

       
-

       
  "sortitionConfig": {


     

       
40

       

       
-

       
    "tagThreshold": 15,


     

       

       
40

       
+

       
  "moderationConfig": {


     

       

       
41

       
+

       
    "$type": "social.coves.community.rules#sortitionModeration",


     

       

       
42

       
+

       
    "negativeTags": ["spam", "hostile", "offtopic", "misleading"],


     

       

       
43

       
+

       
    "customNegativeTags": ["lowquality", "duplicate"],


     

       

       
44

       
+

       
    "hideThreshold": 15,


     

       
41

       
45

       
 

       
    "tribunalThreshold": 30,


     

       
42

       
46

       
 

       
    "jurySize": 9


     

       
43

       
47

       
 

       
  }