commit 39993d1ab20f154f011cb0927bf55b97df3f2e20 · bretton.dev/coves

+46

internal/api/handlers/communityFeed/errors.go

···

       1
       1
       +
       package communityFeed

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"Coves/internal/core/communityFeeds"

     

       5
       5
       +
       	"encoding/json"

     

       6
       6
       +
       	"errors"

     

       7
       7
       +
       	"log"

     

       8
       8
       +
       	"net/http"

     

       9
       9
       +
       )

     

       10
       10
       +
       

     

       11
       11
       +
       // ErrorResponse represents an XRPC error response

     

       12
       12
       +
       type ErrorResponse struct {

     

       13
       13
       +
       	Error   string `json:"error"`

     

       14
       14
       +
       	Message string `json:"message"`

     

       15
       15
       +
       }

     

       16
       16
       +
       

     

       17
       17
       +
       // writeError writes a JSON error response

     

       18
       18
       +
       func writeError(w http.ResponseWriter, statusCode int, errorType, message string) {

     

       19
       19
       +
       	w.Header().Set("Content-Type", "application/json")

     

       20
       20
       +
       	w.WriteHeader(statusCode)

     

       21
       21
       +
       	if err := json.NewEncoder(w).Encode(ErrorResponse{

     

       22
       22
       +
       		Error:   errorType,

     

       23
       23
       +
       		Message: message,

     

       24
       24
       +
       	}); err != nil {

     

       25
       25
       +
       		// Log encoding errors but can't send error response (headers already sent)

     

       26
       26
       +
       		log.Printf("ERROR: Failed to encode error response: %v", err)

     

       27
       27
       +
       	}

     

       28
       28
       +
       }

     

       29
       29
       +
       

     

       30
       30
       +
       // handleServiceError maps service errors to HTTP responses

     

       31
       31
       +
       func handleServiceError(w http.ResponseWriter, err error) {

     

       32
       32
       +
       	switch {

     

       33
       33
       +
       	case errors.Is(err, communityFeeds.ErrCommunityNotFound):

     

       34
       34
       +
       		writeError(w, http.StatusNotFound, "CommunityNotFound", "Community not found")

     

       35
       35
       +
       

     

       36
       36
       +
       	case errors.Is(err, communityFeeds.ErrInvalidCursor):

     

       37
       37
       +
       		writeError(w, http.StatusBadRequest, "InvalidCursor", "Invalid pagination cursor")

     

       38
       38
       +
       

     

       39
       39
       +
       	case communityFeeds.IsValidationError(err):

     

       40
       40
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", err.Error())

     

       41
       41
       +
       

     

       42
       42
       +
       	default:

     

       43
       43
       +
       		// Internal server error - don't leak details

     

       44
       44
       +
       		writeError(w, http.StatusInternalServerError, "InternalServerError", "An internal error occurred")

     

       45
       45
       +
       	}

     

       46
       46
       +
       }

+91

internal/api/handlers/communityFeed/get_community.go

···

       1
       1
       +
       package communityFeed

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"Coves/internal/core/communityFeeds"

     

       5
       5
       +
       	"encoding/json"

     

       6
       6
       +
       	"log"

     

       7
       7
       +
       	"net/http"

     

       8
       8
       +
       	"strconv"

     

       9
       9
       +
       )

     

       10
       10
       +
       

     

       11
       11
       +
       // GetCommunityHandler handles community feed retrieval

     

       12
       12
       +
       type GetCommunityHandler struct {

     

       13
       13
       +
       	service communityFeeds.Service

     

       14
       14
       +
       }

     

       15
       15
       +
       

     

       16
       16
       +
       // NewGetCommunityHandler creates a new community feed handler

     

       17
       17
       +
       func NewGetCommunityHandler(service communityFeeds.Service) *GetCommunityHandler {

     

       18
       18
       +
       	return &GetCommunityHandler{

     

       19
       19
       +
       		service: service,

     

       20
       20
       +
       	}

     

       21
       21
       +
       }

     

       22
       22
       +
       

     

       23
       23
       +
       // HandleGetCommunity retrieves posts from a community with sorting

     

       24
       24
       +
       // GET /xrpc/social.coves.communityFeed.getCommunity?community={did_or_handle}&sort=hot&limit=15&cursor=...

     

       25
       25
       +
       func (h *GetCommunityHandler) HandleGetCommunity(w http.ResponseWriter, r *http.Request) {

     

       26
       26
       +
       	if r.Method != http.MethodGet {

     

       27
       27
       +
       		http.Error(w, "Method not allowed", http.StatusMethodNotAllowed)

     

       28
       28
       +
       		return

     

       29
       29
       +
       	}

     

       30
       30
       +
       

     

       31
       31
       +
       	// Parse query parameters

     

       32
       32
       +
       	req, err := h.parseRequest(r)

     

       33
       33
       +
       	if err != nil {

     

       34
       34
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", err.Error())

     

       35
       35
       +
       		return

     

       36
       36
       +
       	}

     

       37
       37
       +
       

     

       38
       38
       +
       	// Alpha: No viewer context needed for basic community sorting

     

       39
       39
       +
       	// TODO(feed-generator): Extract viewer DID when implementing viewer-specific state

     

       40
       40
       +
       	//                       (blocks, upvotes, saves) in feed generator skeleton

     

       41
       41
       +
       

     

       42
       42
       +
       	// Get community feed

     

       43
       43
       +
       	response, err := h.service.GetCommunityFeed(r.Context(), req)

     

       44
       44
       +
       	if err != nil {

     

       45
       45
       +
       		handleServiceError(w, err)

     

       46
       46
       +
       		return

     

       47
       47
       +
       	}

     

       48
       48
       +
       

     

       49
       49
       +
       	// Return feed

     

       50
       50
       +
       	w.Header().Set("Content-Type", "application/json")

     

       51
       51
       +
       	w.WriteHeader(http.StatusOK)

     

       52
       52
       +
       	if err := json.NewEncoder(w).Encode(response); err != nil {

     

       53
       53
       +
       		// Log encoding errors but don't return error response (headers already sent)

     

       54
       54
       +
       		log.Printf("ERROR: Failed to encode feed response: %v", err)

     

       55
       55
       +
       	}

     

       56
       56
       +
       }

     

       57
       57
       +
       

     

       58
       58
       +
       // parseRequest parses query parameters into GetCommunityFeedRequest

     

       59
       59
       +
       func (h *GetCommunityHandler) parseRequest(r *http.Request) (communityFeeds.GetCommunityFeedRequest, error) {

     

       60
       60
       +
       	req := communityFeeds.GetCommunityFeedRequest{}

     

       61
       61
       +
       

     

       62
       62
       +
       	// Required: community

     

       63
       63
       +
       	req.Community = r.URL.Query().Get("community")

     

       64
       64
       +
       

     

       65
       65
       +
       	// Optional: sort (default: hot)

     

       66
       66
       +
       	req.Sort = r.URL.Query().Get("sort")

     

       67
       67
       +
       	if req.Sort == "" {

     

       68
       68
       +
       		req.Sort = "hot"

     

       69
       69
       +
       	}

     

       70
       70
       +
       

     

       71
       71
       +
       	// Optional: timeframe (default: day for top sort)

     

       72
       72
       +
       	req.Timeframe = r.URL.Query().Get("timeframe")

     

       73
       73
       +
       	if req.Timeframe == "" && req.Sort == "top" {

     

       74
       74
       +
       		req.Timeframe = "day"

     

       75
       75
       +
       	}

     

       76
       76
       +
       

     

       77
       77
       +
       	// Optional: limit (default: 15, max: 50)

     

       78
       78
       +
       	req.Limit = 15

     

       79
       79
       +
       	if limitStr := r.URL.Query().Get("limit"); limitStr != "" {

     

       80
       80
       +
       		if limit, err := strconv.Atoi(limitStr); err == nil {

     

       81
       81
       +
       			req.Limit = limit

     

       82
       82
       +
       		}

     

       83
       83
       +
       	}

     

       84
       84
       +
       

     

       85
       85
       +
       	// Optional: cursor

     

       86
       86
       +
       	if cursor := r.URL.Query().Get("cursor"); cursor != "" {

     

       87
       87
       +
       		req.Cursor = &cursor

     

       88
       88
       +
       	}

     

       89
       89
       +
       

     

       90
       90
       +
       	return req, nil

     

       91
       91
       +
       }

+23

internal/api/routes/communityFeed.go

···

       1
       1
       +
       package routes

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"Coves/internal/api/handlers/communityFeed"

     

       5
       5
       +
       	"Coves/internal/core/communityFeeds"

     

       6
       6
       +
       

     

       7
       7
       +
       	"github.com/go-chi/chi/v5"

     

       8
       8
       +
       )

     

       9
       9
       +
       

     

       10
       10
       +
       // RegisterCommunityFeedRoutes registers feed-related XRPC endpoints

     

       11
       11
       +
       func RegisterCommunityFeedRoutes(

     

       12
       12
       +
       	r chi.Router,

     

       13
       13
       +
       	feedService communityFeeds.Service,

     

       14
       14
       +
       ) {

     

       15
       15
       +
       	// Create handlers

     

       16
       16
       +
       	getCommunityHandler := communityFeed.NewGetCommunityHandler(feedService)

     

       17
       17
       +
       

     

       18
       18
       +
       	// GET /xrpc/social.coves.communityFeed.getCommunity

     

       19
       19
       +
       	// Public endpoint - basic community sorting only for Alpha

     

       20
       20
       +
       	// TODO(feed-generator): Add OptionalAuth middleware when implementing viewer-specific state

     

       21
       21
       +
       	//                       (blocks, upvotes, saves, etc.) in feed generator skeleton

     

       22
       22
       +
       	r.Get("/xrpc/social.coves.communityFeed.getCommunity", getCommunityHandler.HandleGetCommunity)

     

       23
       23
       +
       }