commit 40c22b2bae1fe465bf2374a55aada72a828a44bc · bretton.dev/coves

+14

internal/core/unfurl/errors.go

···

       1
       1
       +
       package unfurl

     

       2
       2
       +
       

     

       3
       3
       +
       import "errors"

     

       4
       4
       +
       

     

       5
       5
       +
       var (

     

       6
       6
       +
       	// ErrNotFound is returned when an unfurl cache entry is not found or has expired

     

       7
       7
       +
       	ErrNotFound = errors.New("unfurl cache entry not found or expired")

     

       8
       8
       +
       

     

       9
       9
       +
       	// ErrInvalidURL is returned when the provided URL is invalid

     

       10
       10
       +
       	ErrInvalidURL = errors.New("invalid URL")

     

       11
       11
       +
       

     

       12
       12
       +
       	// ErrInvalidTTL is returned when the provided TTL is invalid (e.g., negative or zero)

     

       13
       13
       +
       	ErrInvalidTTL = errors.New("invalid TTL: must be positive")

     

       14
       14
       +
       )

+19

internal/core/unfurl/interfaces.go

···

       1
       1
       +
       package unfurl

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"context"

     

       5
       5
       +
       	"time"

     

       6
       6
       +
       )

     

       7
       7
       +
       

     

       8
       8
       +
       // Repository defines the interface for unfurl cache persistence

     

       9
       9
       +
       type Repository interface {

     

       10
       10
       +
       	// Get retrieves a cached unfurl result for the given URL.

     

       11
       11
       +
       	// Returns nil, nil if not found or expired (not an error condition).

     

       12
       12
       +
       	// Returns error only on database failures.

     

       13
       13
       +
       	Get(ctx context.Context, url string) (*UnfurlResult, error)

     

       14
       14
       +
       

     

       15
       15
       +
       	// Set stores an unfurl result in the cache with the specified TTL.

     

       16
       16
       +
       	// If an entry already exists for the URL, it will be updated.

     

       17
       17
       +
       	// The expires_at is calculated as NOW() + ttl.

     

       18
       18
       +
       	Set(ctx context.Context, url string, result *UnfurlResult, ttl time.Duration) error

     

       19
       19
       +
       }

+117

internal/core/unfurl/repository.go

···

       1
       1
       +
       package unfurl

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"context"

     

       5
       5
       +
       	"database/sql"

     

       6
       6
       +
       	"encoding/json"

     

       7
       7
       +
       	"fmt"

     

       8
       8
       +
       	"time"

     

       9
       9
       +
       )

     

       10
       10
       +
       

     

       11
       11
       +
       type postgresUnfurlRepo struct {

     

       12
       12
       +
       	db *sql.DB

     

       13
       13
       +
       }

     

       14
       14
       +
       

     

       15
       15
       +
       // NewRepository creates a new PostgreSQL unfurl cache repository

     

       16
       16
       +
       func NewRepository(db *sql.DB) Repository {

     

       17
       17
       +
       	return &postgresUnfurlRepo{db: db}

     

       18
       18
       +
       }

     

       19
       19
       +
       

     

       20
       20
       +
       // Get retrieves a cached unfurl result for the given URL.

     

       21
       21
       +
       // Returns nil, nil if not found or expired (not an error condition).

     

       22
       22
       +
       // Returns error only on database failures.

     

       23
       23
       +
       func (r *postgresUnfurlRepo) Get(ctx context.Context, url string) (*UnfurlResult, error) {

     

       24
       24
       +
       	query := `

     

       25
       25
       +
       		SELECT metadata, thumbnail_url, provider

     

       26
       26
       +
       		FROM unfurl_cache

     

       27
       27
       +
       		WHERE url = $1 AND expires_at > NOW()

     

       28
       28
       +
       	`

     

       29
       29
       +
       

     

       30
       30
       +
       	var metadataJSON []byte

     

       31
       31
       +
       	var thumbnailURL sql.NullString

     

       32
       32
       +
       	var provider string

     

       33
       33
       +
       

     

       34
       34
       +
       	err := r.db.QueryRowContext(ctx, query, url).Scan(&metadataJSON, &thumbnailURL, &provider)

     

       35
       35
       +
       	if err == sql.ErrNoRows {

     

       36
       36
       +
       		// Not found or expired is not an error

     

       37
       37
       +
       		return nil, nil

     

       38
       38
       +
       	}

     

       39
       39
       +
       	if err != nil {

     

       40
       40
       +
       		return nil, fmt.Errorf("failed to get unfurl cache entry: %w", err)

     

       41
       41
       +
       	}

     

       42
       42
       +
       

     

       43
       43
       +
       	// Unmarshal metadata JSONB to UnfurlResult

     

       44
       44
       +
       	var result UnfurlResult

     

       45
       45
       +
       	if err := json.Unmarshal(metadataJSON, &result); err != nil {

     

       46
       46
       +
       		return nil, fmt.Errorf("failed to unmarshal metadata: %w", err)

     

       47
       47
       +
       	}

     

       48
       48
       +
       

     

       49
       49
       +
       	// Ensure provider and thumbnailURL are set (may not be in metadata JSON)

     

       50
       50
       +
       	result.Provider = provider

     

       51
       51
       +
       	if thumbnailURL.Valid {

     

       52
       52
       +
       		result.ThumbnailURL = thumbnailURL.String

     

       53
       53
       +
       	}

     

       54
       54
       +
       

     

       55
       55
       +
       	return &result, nil

     

       56
       56
       +
       }

     

       57
       57
       +
       

     

       58
       58
       +
       // Set stores an unfurl result in the cache with the specified TTL.

     

       59
       59
       +
       // If an entry already exists for the URL, it will be updated.

     

       60
       60
       +
       // The expires_at is calculated as NOW() + ttl.

     

       61
       61
       +
       func (r *postgresUnfurlRepo) Set(ctx context.Context, url string, result *UnfurlResult, ttl time.Duration) error {

     

       62
       62
       +
       	// Marshal UnfurlResult to JSON for metadata column

     

       63
       63
       +
       	metadataJSON, err := json.Marshal(result)

     

       64
       64
       +
       	if err != nil {

     

       65
       65
       +
       		return fmt.Errorf("failed to marshal metadata: %w", err)

     

       66
       66
       +
       	}

     

       67
       67
       +
       

     

       68
       68
       +
       	// Store thumbnail_url separately for potential queries

     

       69
       69
       +
       	var thumbnailURL sql.NullString

     

       70
       70
       +
       	if result.ThumbnailURL != "" {

     

       71
       71
       +
       		thumbnailURL.String = result.ThumbnailURL

     

       72
       72
       +
       		thumbnailURL.Valid = true

     

       73
       73
       +
       	}

     

       74
       74
       +
       

     

       75
       75
       +
       	// Convert Go duration to PostgreSQL interval string

     

       76
       76
       +
       	// e.g., "1 hour", "24 hours", "7 days"

     

       77
       77
       +
       	intervalStr := formatInterval(ttl)

     

       78
       78
       +
       

     

       79
       79
       +
       	query := `

     

       80
       80
       +
       		INSERT INTO unfurl_cache (url, provider, metadata, thumbnail_url, expires_at)

     

       81
       81
       +
       		VALUES ($1, $2, $3, $4, NOW() + $5::interval)

     

       82
       82
       +
       		ON CONFLICT (url) DO UPDATE

     

       83
       83
       +
       		SET provider = EXCLUDED.provider,

     

       84
       84
       +
       		    metadata = EXCLUDED.metadata,

     

       85
       85
       +
       		    thumbnail_url = EXCLUDED.thumbnail_url,

     

       86
       86
       +
       		    expires_at = EXCLUDED.expires_at,

     

       87
       87
       +
       		    fetched_at = NOW()

     

       88
       88
       +
       	`

     

       89
       89
       +
       

     

       90
       90
       +
       	_, err = r.db.ExecContext(ctx, query, url, result.Provider, metadataJSON, thumbnailURL, intervalStr)

     

       91
       91
       +
       	if err != nil {

     

       92
       92
       +
       		return fmt.Errorf("failed to insert/update unfurl cache entry: %w", err)

     

       93
       93
       +
       	}

     

       94
       94
       +
       

     

       95
       95
       +
       	return nil

     

       96
       96
       +
       }

     

       97
       97
       +
       

     

       98
       98
       +
       // formatInterval converts a Go duration to a PostgreSQL interval string

     

       99
       99
       +
       // PostgreSQL accepts intervals like "1 hour", "24 hours", "7 days"

     

       100
       100
       +
       func formatInterval(d time.Duration) string {

     

       101
       101
       +
       	seconds := int64(d.Seconds())

     

       102
       102
       +
       

     

       103
       103
       +
       	// Convert to appropriate unit for readability

     

       104
       104
       +
       	switch {

     

       105
       105
       +
       	case seconds >= 86400: // >= 1 day

     

       106
       106
       +
       		days := seconds / 86400

     

       107
       107
       +
       		return fmt.Sprintf("%d days", days)

     

       108
       108
       +
       	case seconds >= 3600: // >= 1 hour

     

       109
       109
       +
       		hours := seconds / 3600

     

       110
       110
       +
       		return fmt.Sprintf("%d hours", hours)

     

       111
       111
       +
       	case seconds >= 60: // >= 1 minute

     

       112
       112
       +
       		minutes := seconds / 60

     

       113
       113
       +
       		return fmt.Sprintf("%d minutes", minutes)

     

       114
       114
       +
       	default:

     

       115
       115
       +
       		return fmt.Sprintf("%d seconds", seconds)

     

       116
       116
       +
       	}

     

       117
       117
       +
       }

+23

internal/db/migrations/017_create_unfurl_cache.sql

···

       1
       1
       +
       -- +goose Up

     

       2
       2
       +
       CREATE TABLE unfurl_cache (

     

       3
       3
       +
           url TEXT PRIMARY KEY,

     

       4
       4
       +
           provider TEXT NOT NULL,

     

       5
       5
       +
           metadata JSONB NOT NULL,

     

       6
       6
       +
           thumbnail_url TEXT,

     

       7
       7
       +
           fetched_at TIMESTAMP NOT NULL DEFAULT NOW(),

     

       8
       8
       +
           expires_at TIMESTAMP NOT NULL,

     

       9
       9
       +
           created_at TIMESTAMP NOT NULL DEFAULT NOW()

     

       10
       10
       +
       );

     

       11
       11
       +
       

     

       12
       12
       +
       CREATE INDEX idx_unfurl_cache_expires ON unfurl_cache(expires_at);

     

       13
       13
       +
       

     

       14
       14
       +
       COMMENT ON TABLE unfurl_cache IS 'Cache for oEmbed/URL unfurl results to reduce external API calls';

     

       15
       15
       +
       COMMENT ON COLUMN unfurl_cache.url IS 'The URL that was unfurled (primary key)';

     

       16
       16
       +
       COMMENT ON COLUMN unfurl_cache.provider IS 'Provider name (streamable, youtube, reddit, etc.)';

     

       17
       17
       +
       COMMENT ON COLUMN unfurl_cache.metadata IS 'Full unfurl result as JSON (title, description, type, etc.)';

     

       18
       18
       +
       COMMENT ON COLUMN unfurl_cache.thumbnail_url IS 'URL of the thumbnail image';

     

       19
       19
       +
       COMMENT ON COLUMN unfurl_cache.expires_at IS 'When this cache entry should be refetched (TTL-based)';

     

       20
       20
       +
       

     

       21
       21
       +
       -- +goose Down

     

       22
       22
       +
       DROP INDEX IF EXISTS idx_unfurl_cache_expires;

     

       23
       23
       +
       DROP TABLE IF EXISTS unfurl_cache;