commit 5a3ad7c4ce77c389be63dac248b3d808674db0a6 · bretton.dev/coves

+1 -1

cmd/server/main.go

···

       322
       322
        
       		postJetstreamURL = "ws://localhost:6008/subscribe?wantedCollections=social.coves.community.post"

     

       323
       323
        
       	}

     

       324
       324
        
       

     

       325
       325
       -
       	postEventConsumer := jetstream.NewPostEventConsumer(postRepo, communityRepo, userService)

     

       325
       325
       +
       	postEventConsumer := jetstream.NewPostEventConsumer(postRepo, communityRepo, userService, db)

     

       326
       326
        
       	postJetstreamConnector := jetstream.NewPostJetstreamConnector(postEventConsumer, postJetstreamURL)

     

       327
       327
        
       

     

       328
       328
        
       	go func() {

+99 -9

internal/atproto/jetstream/post_consumer.go

···

       5
       5
        
       	"Coves/internal/core/posts"

     

       6
       6
        
       	"Coves/internal/core/users"

     

       7
       7
        
       	"context"

     

       8
       8
       +
       	"database/sql"

     

       8
       9
        
       	"encoding/json"

     

       9
       10
        
       	"fmt"

     

       10
       11
        
       	"log"

     
···

       19
       20
        
       	postRepo      posts.Repository

     

       20
       21
        
       	communityRepo communities.Repository

     

       21
       22
        
       	userService   users.UserService

     

       23
       23
       +
       	db            *sql.DB // Direct DB access for atomic count reconciliation

     

       22
       24
        
       }

     

       23
       25
        
       

     

       24
       26
        
       // NewPostEventConsumer creates a new Jetstream consumer for post events

     
···

       26
       28
        
       	postRepo posts.Repository,

     

       27
       29
        
       	communityRepo communities.Repository,

     

       28
       30
        
       	userService users.UserService,

     

       31
       31
       +
       	db *sql.DB,

     

       29
       32
        
       ) *PostEventConsumer {

     

       30
       33
        
       	return &PostEventConsumer{

     

       31
       34
        
       		postRepo:      postRepo,

     

       32
       35
        
       		communityRepo: communityRepo,

     

       33
       36
        
       		userService:   userService,

     

       37
       37
       +
       		db:            db,

     

       34
       38
        
       	}

     

       35
       39
        
       }

     

       36
       40
        
       

     
···

       127
       131
        
       		}

     

       128
       132
        
       	}

     

       129
       133
        
       

     

       130
       130
       -
       	// Index in AppView database (idempotent - safe for Jetstream replays)

     

       131
       131
       -
       	err = c.postRepo.Create(ctx, post)

     

       132
       132
       -
       	if err != nil {

     

       133
       133
       -
       		// Check if it already exists (idempotency)

     

       134
       134
       -
       		if posts.IsConflict(err) {

     

       135
       135
       -
       			log.Printf("Post already indexed: %s", uri)

     

       136
       136
       -
       			return nil

     

       137
       137
       -
       		}

     

       138
       138
       -
       		return fmt.Errorf("failed to index post: %w", err)

     

       134
       134
       +
       	// Atomically: Index post + Reconcile comment count for out-of-order arrivals

     

       135
       135
       +
       	if err := c.indexPostAndReconcileCounts(ctx, post); err != nil {

     

       136
       136
       +
       		return fmt.Errorf("failed to index post and reconcile counts: %w", err)

     

       139
       137
        
       	}

     

       140
       138
        
       

     

       141
       139
        
       	log.Printf("✓ Indexed post: %s (author: %s, community: %s, rkey: %s)",

     

       142
       140
        
       		uri, post.AuthorDID, post.CommunityDID, commit.RKey)

     

       141
       141
       +
       	return nil

     

       142
       142
       +
       }

     

       143
       143
       +
       

     

       144
       144
       +
       // indexPostAndReconcileCounts atomically indexes a post and reconciles comment counts

     

       145
       145
       +
       // This fixes the race condition where comments arrive before their parent post

     

       146
       146
       +
       func (c *PostEventConsumer) indexPostAndReconcileCounts(ctx context.Context, post *posts.Post) error {

     

       147
       147
       +
       	tx, err := c.db.BeginTx(ctx, nil)

     

       148
       148
       +
       	if err != nil {

     

       149
       149
       +
       		return fmt.Errorf("failed to begin transaction: %w", err)

     

       150
       150
       +
       	}

     

       151
       151
       +
       	defer func() {

     

       152
       152
       +
       		if rollbackErr := tx.Rollback(); rollbackErr != nil && rollbackErr != sql.ErrTxDone {

     

       153
       153
       +
       			log.Printf("Failed to rollback transaction: %v", rollbackErr)

     

       154
       154
       +
       		}

     

       155
       155
       +
       	}()

     

       156
       156
       +
       

     

       157
       157
       +
       	// 1. Insert the post (idempotent with RETURNING clause)

     

       158
       158
       +
       	var facetsJSON, embedJSON, labelsJSON sql.NullString

     

       159
       159
       +
       

     

       160
       160
       +
       	if post.ContentFacets != nil {

     

       161
       161
       +
       		facetsJSON.String = *post.ContentFacets

     

       162
       162
       +
       		facetsJSON.Valid = true

     

       163
       163
       +
       	}

     

       164
       164
       +
       

     

       165
       165
       +
       	if post.Embed != nil {

     

       166
       166
       +
       		embedJSON.String = *post.Embed

     

       167
       167
       +
       		embedJSON.Valid = true

     

       168
       168
       +
       	}

     

       169
       169
       +
       

     

       170
       170
       +
       	if post.ContentLabels != nil {

     

       171
       171
       +
       		labelsJSON.String = *post.ContentLabels

     

       172
       172
       +
       		labelsJSON.Valid = true

     

       173
       173
       +
       	}

     

       174
       174
       +
       

     

       175
       175
       +
       	insertQuery := `

     

       176
       176
       +
       		INSERT INTO posts (

     

       177
       177
       +
       			uri, cid, rkey, author_did, community_did,

     

       178
       178
       +
       			title, content, content_facets, embed, content_labels,

     

       179
       179
       +
       			created_at, indexed_at

     

       180
       180
       +
       		) VALUES (

     

       181
       181
       +
       			$1, $2, $3, $4, $5,

     

       182
       182
       +
       			$6, $7, $8, $9, $10,

     

       183
       183
       +
       			$11, NOW()

     

       184
       184
       +
       		)

     

       185
       185
       +
       		ON CONFLICT (uri) DO NOTHING

     

       186
       186
       +
       		RETURNING id

     

       187
       187
       +
       	`

     

       188
       188
       +
       

     

       189
       189
       +
       	var postID int64

     

       190
       190
       +
       	insertErr := tx.QueryRowContext(

     

       191
       191
       +
       		ctx, insertQuery,

     

       192
       192
       +
       		post.URI, post.CID, post.RKey, post.AuthorDID, post.CommunityDID,

     

       193
       193
       +
       		post.Title, post.Content, facetsJSON, embedJSON, labelsJSON,

     

       194
       194
       +
       		post.CreatedAt,

     

       195
       195
       +
       	).Scan(&postID)

     

       196
       196
       +
       

     

       197
       197
       +
       	// If no rows returned, post already exists (idempotent - OK for Jetstream replays)

     

       198
       198
       +
       	if insertErr == sql.ErrNoRows {

     

       199
       199
       +
       		log.Printf("Post already indexed: %s (idempotent)", post.URI)

     

       200
       200
       +
       		if commitErr := tx.Commit(); commitErr != nil {

     

       201
       201
       +
       			return fmt.Errorf("failed to commit transaction: %w", commitErr)

     

       202
       202
       +
       		}

     

       203
       203
       +
       		return nil

     

       204
       204
       +
       	}

     

       205
       205
       +
       

     

       206
       206
       +
       	if insertErr != nil {

     

       207
       207
       +
       		return fmt.Errorf("failed to insert post: %w", insertErr)

     

       208
       208
       +
       	}

     

       209
       209
       +
       

     

       210
       210
       +
       	// 2. Reconcile comment_count for this newly inserted post

     

       211
       211
       +
       	// In case any comments arrived out-of-order before this post was indexed

     

       212
       212
       +
       	// This is the CRITICAL FIX for the race condition identified in the PR review

     

       213
       213
       +
       	reconcileQuery := `

     

       214
       214
       +
       		UPDATE posts

     

       215
       215
       +
       		SET comment_count = (

     

       216
       216
       +
       			SELECT COUNT(*)

     

       217
       217
       +
       			FROM comments c

     

       218
       218
       +
       			WHERE c.parent_uri = $1 AND c.deleted_at IS NULL

     

       219
       219
       +
       		)

     

       220
       220
       +
       		WHERE id = $2

     

       221
       221
       +
       	`

     

       222
       222
       +
       	_, reconcileErr := tx.ExecContext(ctx, reconcileQuery, post.URI, postID)

     

       223
       223
       +
       	if reconcileErr != nil {

     

       224
       224
       +
       		log.Printf("Warning: Failed to reconcile comment_count for %s: %v", post.URI, reconcileErr)

     

       225
       225
       +
       		// Continue anyway - this is a best-effort reconciliation

     

       226
       226
       +
       	}

     

       227
       227
       +
       

     

       228
       228
       +
       	// Commit transaction

     

       229
       229
       +
       	if err := tx.Commit(); err != nil {

     

       230
       230
       +
       		return fmt.Errorf("failed to commit transaction: %w", err)

     

       231
       231
       +
       	}

     

       232
       232
       +
       

     

       143
       233
        
       	return nil

     

       144
       234
        
       }

     

       145
       235

+1 -1

tests/integration/aggregator_e2e_test.go

···

       75
       75
        
       

     

       76
       76
        
       	// Setup consumers

     

       77
       77
        
       	aggregatorConsumer := jetstream.NewAggregatorEventConsumer(aggregatorRepo)

     

       78
       78
       -
       	postConsumer := jetstream.NewPostEventConsumer(postRepo, communityRepo, userService)

     

       78
       78
       +
       	postConsumer := jetstream.NewPostEventConsumer(postRepo, communityRepo, userService, db)

     

       79
       79
        
       

     

       80
       80
        
       	// Setup HTTP handlers

     

       81
       81
        
       	getServicesHandler := aggregator.NewGetServicesHandler(aggregatorService)

+5 -5

tests/integration/post_e2e_test.go

···

       131
       131
        
       		}

     

       132
       132
        
       

     

       133
       133
        
       		// STEP 3: Process event through Jetstream consumer

     

       134
       134
       -
       		consumer := jetstream.NewPostEventConsumer(postRepo, communityRepo, userService)

     

       134
       134
       +
       		consumer := jetstream.NewPostEventConsumer(postRepo, communityRepo, userService, db)

     

       135
       135
        
       		err := consumer.HandleEvent(ctx, &jetstreamEvent)

     

       136
       136
        
       		if err != nil {

     

       137
       137
        
       			t.Fatalf("Jetstream consumer failed to process event: %v", err)

     
···

       201
       201
        
       			},

     

       202
       202
        
       		}

     

       203
       203
        
       

     

       204
       204
       -
       		consumer := jetstream.NewPostEventConsumer(postRepo, communityRepo, userService)

     

       204
       204
       +
       		consumer := jetstream.NewPostEventConsumer(postRepo, communityRepo, userService, db)

     

       205
       205
        
       		err := consumer.HandleEvent(ctx, &maliciousEvent)

     

       206
       206
        
       

     

       207
       207
        
       		// Should get security error

     
···

       241
       241
        
       			},

     

       242
       242
        
       		}

     

       243
       243
        
       

     

       244
       244
       -
       		consumer := jetstream.NewPostEventConsumer(postRepo, communityRepo, userService)

     

       244
       244
       +
       		consumer := jetstream.NewPostEventConsumer(postRepo, communityRepo, userService, db)

     

       245
       245
        
       

     

       246
       246
        
       		// First event - should succeed

     

       247
       247
        
       		err := consumer.HandleEvent(ctx, &event)

     
···

       295
       295
        
       			},

     

       296
       296
        
       		}

     

       297
       297
        
       

     

       298
       298
       -
       		consumer := jetstream.NewPostEventConsumer(postRepo, communityRepo, userService)

     

       298
       298
       +
       		consumer := jetstream.NewPostEventConsumer(postRepo, communityRepo, userService, db)

     

       299
       299
        
       

     

       300
       300
        
       		// Should log warning but NOT fail (eventual consistency)

     

       301
       301
        
       		// Note: This will fail due to foreign key constraint in current schema

     
···

       530
       530
        
       			userService := users.NewUserService(userRepo, identityResolver, pdsURL)

     

       531
       531
        
       

     

       532
       532
        
       			// Create post consumer (same as main.go)

     

       533
       533
       -
       			postConsumer := jetstream.NewPostEventConsumer(postRepo, communityRepo, userService)

     

       533
       533
       +
       			postConsumer := jetstream.NewPostEventConsumer(postRepo, communityRepo, userService, db)

     

       534
       534
        
       

     

       535
       535
        
       			// Channels to receive the event

     

       536
       536
        
       			eventChan := make(chan *jetstream.JetstreamEvent, 10)