commit 78803915a38ce6d4407a419c84b3e0fc39130c87 · bretton.dev/coves

+4 -2

tests/integration/comment_query_test.go

···

       785
       785
        
       	postRepo := postgres.NewPostRepository(db)

     

       786
       786
        
       	userRepo := postgres.NewUserRepository(db)

     

       787
       787
        
       	communityRepo := postgres.NewCommunityRepository(db)

     

       788
       788
       -
       	return comments.NewCommentService(commentRepo, userRepo, postRepo, communityRepo)

     

       788
       788
       +
       	// Use factory constructor with nil factory - these tests only use the read path (GetComments)

     

       789
       789
       +
       	return comments.NewCommentServiceWithPDSFactory(commentRepo, userRepo, postRepo, communityRepo, nil, nil)

     

       789
       790
        
       }

     

       790
       791
        
       

     

       791
       792
        
       // Helper: createTestCommentWithScore creates a comment with specific vote counts

     
···

       871
       872
        
       	postRepo := postgres.NewPostRepository(db)

     

       872
       873
        
       	userRepo := postgres.NewUserRepository(db)

     

       873
       874
        
       	communityRepo := postgres.NewCommunityRepository(db)

     

       874
       874
       -
       	service := comments.NewCommentService(commentRepo, userRepo, postRepo, communityRepo)

     

       875
       875
       +
       	// Use factory constructor with nil factory - these tests only use the read path (GetComments)

     

       876
       876
       +
       	service := comments.NewCommentServiceWithPDSFactory(commentRepo, userRepo, postRepo, communityRepo, nil, nil)

     

       875
       877
        
       	return &testCommentServiceAdapter{service: service}

     

       876
       878
        
       }

     

       877
       879

+6 -3

tests/integration/comment_vote_test.go

···

       417
       417
        
       		}

     

       418
       418
        
       

     

       419
       419
        
       		// Query comments with viewer authentication

     

       420
       420
       -
       		commentService := comments.NewCommentService(commentRepo, userRepo, postRepo, communityRepo)

     

       420
       420
       +
       		// Use factory constructor with nil factory - this test only uses the read path (GetComments)

     

       421
       421
       +
       		commentService := comments.NewCommentServiceWithPDSFactory(commentRepo, userRepo, postRepo, communityRepo, nil, nil)

     

       421
       422
        
       		response, err := commentService.GetComments(ctx, &comments.GetCommentsRequest{

     

       422
       423
        
       			PostURI:   testPostURI,

     

       423
       424
        
       			Sort:      "new",

     
···

       499
       500
        
       		}

     

       500
       501
        
       

     

       501
       502
        
       		// Query with authentication but no vote

     

       502
       502
       -
       		commentService := comments.NewCommentService(commentRepo, userRepo, postRepo, communityRepo)

     

       503
       503
       +
       		// Use factory constructor with nil factory - this test only uses the read path (GetComments)

     

       504
       504
       +
       		commentService := comments.NewCommentServiceWithPDSFactory(commentRepo, userRepo, postRepo, communityRepo, nil, nil)

     

       503
       505
        
       		response, err := commentService.GetComments(ctx, &comments.GetCommentsRequest{

     

       504
       506
        
       			PostURI:   testPostURI,

     

       505
       507
        
       			Sort:      "new",

     
···

       542
       544
        
       

     

       543
       545
        
       	t.Run("Unauthenticated request has no viewer state", func(t *testing.T) {

     

       544
       546
        
       		// Query without authentication

     

       545
       545
       -
       		commentService := comments.NewCommentService(commentRepo, userRepo, postRepo, communityRepo)

     

       547
       547
       +
       		// Use factory constructor with nil factory - this test only uses the read path (GetComments)

     

       548
       548
       +
       		commentService := comments.NewCommentServiceWithPDSFactory(commentRepo, userRepo, postRepo, communityRepo, nil, nil)

     

       546
       549
        
       		response, err := commentService.GetComments(ctx, &comments.GetCommentsRequest{

     

       547
       550
        
       			PostURI:   testPostURI,

     

       548
       551
        
       			Sort:      "new",

+808

tests/integration/comment_write_test.go

···

       1
       1
       +
       package integration

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"Coves/internal/atproto/jetstream"

     

       5
       5
       +
       	"Coves/internal/atproto/pds"

     

       6
       6
       +
       	"Coves/internal/atproto/utils"

     

       7
       7
       +
       	"Coves/internal/core/comments"

     

       8
       8
       +
       	"Coves/internal/db/postgres"

     

       9
       9
       +
       	"context"

     

       10
       10
       +
       	"database/sql"

     

       11
       11
       +
       	"encoding/json"

     

       12
       12
       +
       	"errors"

     

       13
       13
       +
       	"fmt"

     

       14
       14
       +
       	"io"

     

       15
       15
       +
       	"net/http"

     

       16
       16
       +
       	"os"

     

       17
       17
       +
       	"testing"

     

       18
       18
       +
       	"time"

     

       19
       19
       +
       

     

       20
       20
       +
       	oauthlib "github.com/bluesky-social/indigo/atproto/auth/oauth"

     

       21
       21
       +
       	"github.com/bluesky-social/indigo/atproto/syntax"

     

       22
       22
       +
       	_ "github.com/lib/pq"

     

       23
       23
       +
       	"github.com/pressly/goose/v3"

     

       24
       24
       +
       )

     

       25
       25
       +
       

     

       26
       26
       +
       // TestCommentWrite_CreateTopLevelComment tests creating a comment on a post via E2E flow

     

       27
       27
       +
       func TestCommentWrite_CreateTopLevelComment(t *testing.T) {

     

       28
       28
       +
       	// Skip in short mode since this requires real PDS

     

       29
       29
       +
       	if testing.Short() {

     

       30
       30
       +
       		t.Skip("Skipping E2E test in short mode")

     

       31
       31
       +
       	}

     

       32
       32
       +
       

     

       33
       33
       +
       	// Setup test database

     

       34
       34
       +
       	dbURL := os.Getenv("TEST_DATABASE_URL")

     

       35
       35
       +
       	if dbURL == "" {

     

       36
       36
       +
       		dbURL = "postgres://test_user:test_password@localhost:5434/coves_test?sslmode=disable"

     

       37
       37
       +
       	}

     

       38
       38
       +
       

     

       39
       39
       +
       	db, err := sql.Open("postgres", dbURL)

     

       40
       40
       +
       	if err != nil {

     

       41
       41
       +
       		t.Fatalf("Failed to connect to test database: %v", err)

     

       42
       42
       +
       	}

     

       43
       43
       +
       	defer func() {

     

       44
       44
       +
       		if closeErr := db.Close(); closeErr != nil {

     

       45
       45
       +
       			t.Logf("Failed to close database: %v", closeErr)

     

       46
       46
       +
       		}

     

       47
       47
       +
       	}()

     

       48
       48
       +
       

     

       49
       49
       +
       	// Run migrations

     

       50
       50
       +
       	if dialectErr := goose.SetDialect("postgres"); dialectErr != nil {

     

       51
       51
       +
       		t.Fatalf("Failed to set goose dialect: %v", dialectErr)

     

       52
       52
       +
       	}

     

       53
       53
       +
       	if migrateErr := goose.Up(db, "../../internal/db/migrations"); migrateErr != nil {

     

       54
       54
       +
       		t.Fatalf("Failed to run migrations: %v", migrateErr)

     

       55
       55
       +
       	}

     

       56
       56
       +
       

     

       57
       57
       +
       	// Check if PDS is running

     

       58
       58
       +
       	pdsURL := getTestPDSURL()

     

       59
       59
       +
       	healthResp, err := http.Get(pdsURL + "/xrpc/_health")

     

       60
       60
       +
       	if err != nil {

     

       61
       61
       +
       		t.Skipf("PDS not running at %s: %v", pdsURL, err)

     

       62
       62
       +
       	}

     

       63
       63
       +
       	func() {

     

       64
       64
       +
       		if closeErr := healthResp.Body.Close(); closeErr != nil {

     

       65
       65
       +
       			t.Logf("Failed to close health response: %v", closeErr)

     

       66
       66
       +
       		}

     

       67
       67
       +
       	}()

     

       68
       68
       +
       

     

       69
       69
       +
       	ctx := context.Background()

     

       70
       70
       +
       

     

       71
       71
       +
       	// Setup repositories

     

       72
       72
       +
       	commentRepo := postgres.NewCommentRepository(db)

     

       73
       73
       +
       	postRepo := postgres.NewPostRepository(db)

     

       74
       74
       +
       

     

       75
       75
       +
       	// Setup service with password-based PDS client factory for E2E testing

     

       76
       76
       +
       	// CommentPDSClientFactory creates a PDS client for comment operations

     

       77
       77
       +
       	commentPDSFactory := func(ctx context.Context, session *oauthlib.ClientSessionData) (pds.Client, error) {

     

       78
       78
       +
       		if session.AccessToken == "" {

     

       79
       79
       +
       			return nil, fmt.Errorf("session has no access token")

     

       80
       80
       +
       		}

     

       81
       81
       +
       		if session.HostURL == "" {

     

       82
       82
       +
       			return nil, fmt.Errorf("session has no host URL")

     

       83
       83
       +
       		}

     

       84
       84
       +
       

     

       85
       85
       +
       		return pds.NewFromAccessToken(session.HostURL, session.AccountDID.String(), session.AccessToken)

     

       86
       86
       +
       	}

     

       87
       87
       +
       

     

       88
       88
       +
       	commentService := comments.NewCommentServiceWithPDSFactory(

     

       89
       89
       +
       		commentRepo,

     

       90
       90
       +
       		nil, // userRepo not needed for write ops

     

       91
       91
       +
       		postRepo,

     

       92
       92
       +
       		nil, // communityRepo not needed for write ops

     

       93
       93
       +
       		nil, // logger

     

       94
       94
       +
       		commentPDSFactory,

     

       95
       95
       +
       	)

     

       96
       96
       +
       

     

       97
       97
       +
       	// Create test user on PDS

     

       98
       98
       +
       	testUserHandle := fmt.Sprintf("commenter-%d.local.coves.dev", time.Now().Unix())

     

       99
       99
       +
       	testUserEmail := fmt.Sprintf("commenter-%d@test.local", time.Now().Unix())

     

       100
       100
       +
       	testUserPassword := "test-password-123"

     

       101
       101
       +
       

     

       102
       102
       +
       	t.Logf("Creating test user on PDS: %s", testUserHandle)

     

       103
       103
       +
       	pdsAccessToken, userDID, err := createPDSAccount(pdsURL, testUserHandle, testUserEmail, testUserPassword)

     

       104
       104
       +
       	if err != nil {

     

       105
       105
       +
       		t.Fatalf("Failed to create test user on PDS: %v", err)

     

       106
       106
       +
       	}

     

       107
       107
       +
       	t.Logf("Test user created: DID=%s", userDID)

     

       108
       108
       +
       

     

       109
       109
       +
       	// Index user in AppView

     

       110
       110
       +
       	testUser := createTestUser(t, db, testUserHandle, userDID)

     

       111
       111
       +
       

     

       112
       112
       +
       	// Create test community and post to comment on

     

       113
       113
       +
       	testCommunityDID, err := createFeedTestCommunity(db, ctx, "test-community", "owner.test")

     

       114
       114
       +
       	if err != nil {

     

       115
       115
       +
       		t.Fatalf("Failed to create test community: %v", err)

     

       116
       116
       +
       	}

     

       117
       117
       +
       

     

       118
       118
       +
       	postURI := createTestPost(t, db, testCommunityDID, testUser.DID, "Test Post", 0, time.Now())

     

       119
       119
       +
       	postCID := "bafypost123"

     

       120
       120
       +
       

     

       121
       121
       +
       	// Create mock OAuth session for service layer

     

       122
       122
       +
       	mockStore := NewMockOAuthStore()

     

       123
       123
       +
       	mockStore.AddSessionWithPDS(userDID, "session-"+userDID, pdsAccessToken, pdsURL)

     

       124
       124
       +
       

     

       125
       125
       +
       	// ====================================================================================

     

       126
       126
       +
       	// TEST: Create top-level comment on post

     

       127
       127
       +
       	// ====================================================================================

     

       128
       128
       +
       	t.Logf("\n📝 Creating top-level comment via service...")

     

       129
       129
       +
       

     

       130
       130
       +
       	commentReq := comments.CreateCommentRequest{

     

       131
       131
       +
       		Reply: comments.ReplyRef{

     

       132
       132
       +
       			Root: comments.StrongRef{

     

       133
       133
       +
       				URI: postURI,

     

       134
       134
       +
       				CID: postCID,

     

       135
       135
       +
       			},

     

       136
       136
       +
       			Parent: comments.StrongRef{

     

       137
       137
       +
       				URI: postURI,

     

       138
       138
       +
       				CID: postCID,

     

       139
       139
       +
       			},

     

       140
       140
       +
       		},

     

       141
       141
       +
       		Content: "This is a test comment on the post",

     

       142
       142
       +
       		Langs:   []string{"en"},

     

       143
       143
       +
       	}

     

       144
       144
       +
       

     

       145
       145
       +
       	// Get session from store

     

       146
       146
       +
       	parsedDID, _ := parseTestDID(userDID)

     

       147
       147
       +
       	session, err := mockStore.GetSession(ctx, parsedDID, "session-"+userDID)

     

       148
       148
       +
       	if err != nil {

     

       149
       149
       +
       		t.Fatalf("Failed to get session: %v", err)

     

       150
       150
       +
       	}

     

       151
       151
       +
       

     

       152
       152
       +
       	commentResp, err := commentService.CreateComment(ctx, session, commentReq)

     

       153
       153
       +
       	if err != nil {

     

       154
       154
       +
       		t.Fatalf("Failed to create comment: %v", err)

     

       155
       155
       +
       	}

     

       156
       156
       +
       

     

       157
       157
       +
       	t.Logf("✅ Comment created:")

     

       158
       158
       +
       	t.Logf("   URI: %s", commentResp.URI)

     

       159
       159
       +
       	t.Logf("   CID: %s", commentResp.CID)

     

       160
       160
       +
       

     

       161
       161
       +
       	// Verify comment record was written to PDS

     

       162
       162
       +
       	t.Logf("\n🔍 Verifying comment record on PDS...")

     

       163
       163
       +
       	rkey := utils.ExtractRKeyFromURI(commentResp.URI)

     

       164
       164
       +
       	collection := "social.coves.community.comment"

     

       165
       165
       +
       

     

       166
       166
       +
       	pdsResp, pdsErr := http.Get(fmt.Sprintf("%s/xrpc/com.atproto.repo.getRecord?repo=%s&collection=%s&rkey=%s",

     

       167
       167
       +
       		pdsURL, userDID, collection, rkey))

     

       168
       168
       +
       	if pdsErr != nil {

     

       169
       169
       +
       		t.Fatalf("Failed to fetch comment record from PDS: %v", pdsErr)

     

       170
       170
       +
       	}

     

       171
       171
       +
       	defer func() {

     

       172
       172
       +
       		if closeErr := pdsResp.Body.Close(); closeErr != nil {

     

       173
       173
       +
       			t.Logf("Failed to close PDS response: %v", closeErr)

     

       174
       174
       +
       		}

     

       175
       175
       +
       	}()

     

       176
       176
       +
       

     

       177
       177
       +
       	if pdsResp.StatusCode != http.StatusOK {

     

       178
       178
       +
       		body, _ := io.ReadAll(pdsResp.Body)

     

       179
       179
       +
       		t.Fatalf("Comment record not found on PDS: status %d, body: %s", pdsResp.StatusCode, string(body))

     

       180
       180
       +
       	}

     

       181
       181
       +
       

     

       182
       182
       +
       	var pdsRecord struct {

     

       183
       183
       +
       		Value map[string]interface{} `json:"value"`

     

       184
       184
       +
       		CID   string                 `json:"cid"`

     

       185
       185
       +
       	}

     

       186
       186
       +
       	if decodeErr := json.NewDecoder(pdsResp.Body).Decode(&pdsRecord); decodeErr != nil {

     

       187
       187
       +
       		t.Fatalf("Failed to decode PDS record: %v", decodeErr)

     

       188
       188
       +
       	}

     

       189
       189
       +
       

     

       190
       190
       +
       	t.Logf("✅ Comment record found on PDS:")

     

       191
       191
       +
       	t.Logf("   CID: %s", pdsRecord.CID)

     

       192
       192
       +
       	t.Logf("   Content: %v", pdsRecord.Value["content"])

     

       193
       193
       +
       

     

       194
       194
       +
       	// Verify content

     

       195
       195
       +
       	if pdsRecord.Value["content"] != "This is a test comment on the post" {

     

       196
       196
       +
       		t.Errorf("Expected content 'This is a test comment on the post', got %v", pdsRecord.Value["content"])

     

       197
       197
       +
       	}

     

       198
       198
       +
       

     

       199
       199
       +
       	// Simulate Jetstream consumer indexing the comment

     

       200
       200
       +
       	t.Logf("\n🔄 Simulating Jetstream consumer indexing comment...")

     

       201
       201
       +
       	commentConsumer := jetstream.NewCommentEventConsumer(commentRepo, db)

     

       202
       202
       +
       

     

       203
       203
       +
       	commentEvent := jetstream.JetstreamEvent{

     

       204
       204
       +
       		Did:    userDID,

     

       205
       205
       +
       		TimeUS: time.Now().UnixMicro(),

     

       206
       206
       +
       		Kind:   "commit",

     

       207
       207
       +
       		Commit: &jetstream.CommitEvent{

     

       208
       208
       +
       			Rev:        "test-comment-rev",

     

       209
       209
       +
       			Operation:  "create",

     

       210
       210
       +
       			Collection: "social.coves.community.comment",

     

       211
       211
       +
       			RKey:       rkey,

     

       212
       212
       +
       			CID:        pdsRecord.CID,

     

       213
       213
       +
       			Record: map[string]interface{}{

     

       214
       214
       +
       				"$type": "social.coves.community.comment",

     

       215
       215
       +
       				"reply": map[string]interface{}{

     

       216
       216
       +
       					"root": map[string]interface{}{

     

       217
       217
       +
       						"uri": postURI,

     

       218
       218
       +
       						"cid": postCID,

     

       219
       219
       +
       					},

     

       220
       220
       +
       					"parent": map[string]interface{}{

     

       221
       221
       +
       						"uri": postURI,

     

       222
       222
       +
       						"cid": postCID,

     

       223
       223
       +
       					},

     

       224
       224
       +
       				},

     

       225
       225
       +
       				"content":   "This is a test comment on the post",

     

       226
       226
       +
       				"createdAt": time.Now().Format(time.RFC3339),

     

       227
       227
       +
       			},

     

       228
       228
       +
       		},

     

       229
       229
       +
       	}

     

       230
       230
       +
       

     

       231
       231
       +
       	if handleErr := commentConsumer.HandleEvent(ctx, &commentEvent); handleErr != nil {

     

       232
       232
       +
       		t.Fatalf("Failed to handle comment event: %v", handleErr)

     

       233
       233
       +
       	}

     

       234
       234
       +
       

     

       235
       235
       +
       	// Verify comment was indexed in AppView

     

       236
       236
       +
       	t.Logf("\n🔍 Verifying comment indexed in AppView...")

     

       237
       237
       +
       	indexedComment, err := commentRepo.GetByURI(ctx, commentResp.URI)

     

       238
       238
       +
       	if err != nil {

     

       239
       239
       +
       		t.Fatalf("Comment not indexed in AppView: %v", err)

     

       240
       240
       +
       	}

     

       241
       241
       +
       

     

       242
       242
       +
       	t.Logf("✅ Comment indexed in AppView:")

     

       243
       243
       +
       	t.Logf("   CommenterDID: %s", indexedComment.CommenterDID)

     

       244
       244
       +
       	t.Logf("   Content:      %s", indexedComment.Content)

     

       245
       245
       +
       	t.Logf("   RootURI:      %s", indexedComment.RootURI)

     

       246
       246
       +
       	t.Logf("   ParentURI:    %s", indexedComment.ParentURI)

     

       247
       247
       +
       

     

       248
       248
       +
       	// Verify comment details

     

       249
       249
       +
       	if indexedComment.CommenterDID != userDID {

     

       250
       250
       +
       		t.Errorf("Expected commenter_did %s, got %s", userDID, indexedComment.CommenterDID)

     

       251
       251
       +
       	}

     

       252
       252
       +
       	if indexedComment.RootURI != postURI {

     

       253
       253
       +
       		t.Errorf("Expected root_uri %s, got %s", postURI, indexedComment.RootURI)

     

       254
       254
       +
       	}

     

       255
       255
       +
       	if indexedComment.ParentURI != postURI {

     

       256
       256
       +
       		t.Errorf("Expected parent_uri %s, got %s", postURI, indexedComment.ParentURI)

     

       257
       257
       +
       	}

     

       258
       258
       +
       	if indexedComment.Content != "This is a test comment on the post" {

     

       259
       259
       +
       		t.Errorf("Expected content 'This is a test comment on the post', got %s", indexedComment.Content)

     

       260
       260
       +
       	}

     

       261
       261
       +
       

     

       262
       262
       +
       	// Verify post comment count updated

     

       263
       263
       +
       	t.Logf("\n🔍 Verifying post comment count updated...")

     

       264
       264
       +
       	updatedPost, err := postRepo.GetByURI(ctx, postURI)

     

       265
       265
       +
       	if err != nil {

     

       266
       266
       +
       		t.Fatalf("Failed to get updated post: %v", err)

     

       267
       267
       +
       	}

     

       268
       268
       +
       

     

       269
       269
       +
       	if updatedPost.CommentCount != 1 {

     

       270
       270
       +
       		t.Errorf("Expected comment_count = 1, got %d", updatedPost.CommentCount)

     

       271
       271
       +
       	}

     

       272
       272
       +
       

     

       273
       273
       +
       	t.Logf("✅ TRUE E2E COMMENT CREATE FLOW COMPLETE:")

     

       274
       274
       +
       	t.Logf("   Client → Service → PDS Write → Jetstream → Consumer → AppView ✓")

     

       275
       275
       +
       	t.Logf("   ✓ Comment written to PDS")

     

       276
       276
       +
       	t.Logf("   ✓ Comment indexed in AppView")

     

       277
       277
       +
       	t.Logf("   ✓ Post comment count updated")

     

       278
       278
       +
       }

     

       279
       279
       +
       

     

       280
       280
       +
       // TestCommentWrite_CreateNestedReply tests creating a reply to another comment

     

       281
       281
       +
       func TestCommentWrite_CreateNestedReply(t *testing.T) {

     

       282
       282
       +
       	if testing.Short() {

     

       283
       283
       +
       		t.Skip("Skipping E2E test in short mode")

     

       284
       284
       +
       	}

     

       285
       285
       +
       

     

       286
       286
       +
       	db := setupTestDB(t)

     

       287
       287
       +
       	defer func() { _ = db.Close() }()

     

       288
       288
       +
       

     

       289
       289
       +
       	ctx := context.Background()

     

       290
       290
       +
       	pdsURL := getTestPDSURL()

     

       291
       291
       +
       

     

       292
       292
       +
       	// Setup repositories and service

     

       293
       293
       +
       	commentRepo := postgres.NewCommentRepository(db)

     

       294
       294
       +
       	postRepo := postgres.NewPostRepository(db)

     

       295
       295
       +
       

     

       296
       296
       +
       	// CommentPDSClientFactory creates a PDS client for comment operations

     

       297
       297
       +
       	commentPDSFactory := func(ctx context.Context, session *oauthlib.ClientSessionData) (pds.Client, error) {

     

       298
       298
       +
       		if session.AccessToken == "" {

     

       299
       299
       +
       			return nil, fmt.Errorf("session has no access token")

     

       300
       300
       +
       		}

     

       301
       301
       +
       		if session.HostURL == "" {

     

       302
       302
       +
       			return nil, fmt.Errorf("session has no host URL")

     

       303
       303
       +
       		}

     

       304
       304
       +
       

     

       305
       305
       +
       		return pds.NewFromAccessToken(session.HostURL, session.AccountDID.String(), session.AccessToken)

     

       306
       306
       +
       	}

     

       307
       307
       +
       

     

       308
       308
       +
       	commentService := comments.NewCommentServiceWithPDSFactory(

     

       309
       309
       +
       		commentRepo,

     

       310
       310
       +
       		nil,

     

       311
       311
       +
       		postRepo,

     

       312
       312
       +
       		nil,

     

       313
       313
       +
       		nil,

     

       314
       314
       +
       		commentPDSFactory,

     

       315
       315
       +
       	)

     

       316
       316
       +
       

     

       317
       317
       +
       	// Create test user

     

       318
       318
       +
       	testUserHandle := fmt.Sprintf("replier-%d.local.coves.dev", time.Now().Unix())

     

       319
       319
       +
       	testUserEmail := fmt.Sprintf("replier-%d@test.local", time.Now().Unix())

     

       320
       320
       +
       	testUserPassword := "test-password-123"

     

       321
       321
       +
       

     

       322
       322
       +
       	pdsAccessToken, userDID, err := createPDSAccount(pdsURL, testUserHandle, testUserEmail, testUserPassword)

     

       323
       323
       +
       	if err != nil {

     

       324
       324
       +
       		t.Skipf("PDS not available: %v", err)

     

       325
       325
       +
       	}

     

       326
       326
       +
       

     

       327
       327
       +
       	testUser := createTestUser(t, db, testUserHandle, userDID)

     

       328
       328
       +
       

     

       329
       329
       +
       	// Create test post and parent comment

     

       330
       330
       +
       	testCommunityDID, _ := createFeedTestCommunity(db, ctx, "reply-community", "owner.test")

     

       331
       331
       +
       	postURI := createTestPost(t, db, testCommunityDID, testUser.DID, "Test Post", 0, time.Now())

     

       332
       332
       +
       	postCID := "bafypost456"

     

       333
       333
       +
       

     

       334
       334
       +
       	// Create parent comment directly in DB (simulating already-indexed comment)

     

       335
       335
       +
       	parentCommentURI := fmt.Sprintf("at://%s/social.coves.community.comment/parent123", userDID)

     

       336
       336
       +
       	parentCommentCID := "bafyparent123"

     

       337
       337
       +
       	_, err = db.ExecContext(ctx, `

     

       338
       338
       +
       		INSERT INTO comments (uri, cid, rkey, commenter_did, root_uri, root_cid, parent_uri, parent_cid, content, created_at)

     

       339
       339
       +
       		VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, NOW())

     

       340
       340
       +
       	`, parentCommentURI, parentCommentCID, "parent123", userDID, postURI, postCID, postURI, postCID, "Parent comment")

     

       341
       341
       +
       	if err != nil {

     

       342
       342
       +
       		t.Fatalf("Failed to create parent comment: %v", err)

     

       343
       343
       +
       	}

     

       344
       344
       +
       

     

       345
       345
       +
       	// Setup OAuth

     

       346
       346
       +
       	mockStore := NewMockOAuthStore()

     

       347
       347
       +
       	mockStore.AddSessionWithPDS(userDID, "session-"+userDID, pdsAccessToken, pdsURL)

     

       348
       348
       +
       

     

       349
       349
       +
       	// Create nested reply

     

       350
       350
       +
       	t.Logf("\n📝 Creating nested reply...")

     

       351
       351
       +
       	replyReq := comments.CreateCommentRequest{

     

       352
       352
       +
       		Reply: comments.ReplyRef{

     

       353
       353
       +
       			Root: comments.StrongRef{

     

       354
       354
       +
       				URI: postURI,

     

       355
       355
       +
       				CID: postCID,

     

       356
       356
       +
       			},

     

       357
       357
       +
       			Parent: comments.StrongRef{

     

       358
       358
       +
       				URI: parentCommentURI,

     

       359
       359
       +
       				CID: parentCommentCID,

     

       360
       360
       +
       			},

     

       361
       361
       +
       		},

     

       362
       362
       +
       		Content: "This is a reply to the parent comment",

     

       363
       363
       +
       		Langs:   []string{"en"},

     

       364
       364
       +
       	}

     

       365
       365
       +
       

     

       366
       366
       +
       	parsedDID, _ := parseTestDID(userDID)

     

       367
       367
       +
       	session, _ := mockStore.GetSession(ctx, parsedDID, "session-"+userDID)

     

       368
       368
       +
       

     

       369
       369
       +
       	replyResp, err := commentService.CreateComment(ctx, session, replyReq)

     

       370
       370
       +
       	if err != nil {

     

       371
       371
       +
       		t.Fatalf("Failed to create reply: %v", err)

     

       372
       372
       +
       	}

     

       373
       373
       +
       

     

       374
       374
       +
       	t.Logf("✅ Reply created: %s", replyResp.URI)

     

       375
       375
       +
       

     

       376
       376
       +
       	// Simulate Jetstream indexing

     

       377
       377
       +
       	rkey := utils.ExtractRKeyFromURI(replyResp.URI)

     

       378
       378
       +
       	commentConsumer := jetstream.NewCommentEventConsumer(commentRepo, db)

     

       379
       379
       +
       

     

       380
       380
       +
       	replyEvent := jetstream.JetstreamEvent{

     

       381
       381
       +
       		Did:    userDID,

     

       382
       382
       +
       		TimeUS: time.Now().UnixMicro(),

     

       383
       383
       +
       		Kind:   "commit",

     

       384
       384
       +
       		Commit: &jetstream.CommitEvent{

     

       385
       385
       +
       			Rev:        "test-reply-rev",

     

       386
       386
       +
       			Operation:  "create",

     

       387
       387
       +
       			Collection: "social.coves.community.comment",

     

       388
       388
       +
       			RKey:       rkey,

     

       389
       389
       +
       			CID:        replyResp.CID,

     

       390
       390
       +
       			Record: map[string]interface{}{

     

       391
       391
       +
       				"$type": "social.coves.community.comment",

     

       392
       392
       +
       				"reply": map[string]interface{}{

     

       393
       393
       +
       					"root": map[string]interface{}{

     

       394
       394
       +
       						"uri": postURI,

     

       395
       395
       +
       						"cid": postCID,

     

       396
       396
       +
       					},

     

       397
       397
       +
       					"parent": map[string]interface{}{

     

       398
       398
       +
       						"uri": parentCommentURI,

     

       399
       399
       +
       						"cid": parentCommentCID,

     

       400
       400
       +
       					},

     

       401
       401
       +
       				},

     

       402
       402
       +
       				"content":   "This is a reply to the parent comment",

     

       403
       403
       +
       				"createdAt": time.Now().Format(time.RFC3339),

     

       404
       404
       +
       			},

     

       405
       405
       +
       		},

     

       406
       406
       +
       	}

     

       407
       407
       +
       

     

       408
       408
       +
       	if handleErr := commentConsumer.HandleEvent(ctx, &replyEvent); handleErr != nil {

     

       409
       409
       +
       		t.Fatalf("Failed to handle reply event: %v", handleErr)

     

       410
       410
       +
       	}

     

       411
       411
       +
       

     

       412
       412
       +
       	// Verify reply was indexed with correct parent

     

       413
       413
       +
       	indexedReply, err := commentRepo.GetByURI(ctx, replyResp.URI)

     

       414
       414
       +
       	if err != nil {

     

       415
       415
       +
       		t.Fatalf("Reply not indexed: %v", err)

     

       416
       416
       +
       	}

     

       417
       417
       +
       

     

       418
       418
       +
       	if indexedReply.RootURI != postURI {

     

       419
       419
       +
       		t.Errorf("Expected root_uri %s, got %s", postURI, indexedReply.RootURI)

     

       420
       420
       +
       	}

     

       421
       421
       +
       	if indexedReply.ParentURI != parentCommentURI {

     

       422
       422
       +
       		t.Errorf("Expected parent_uri %s, got %s", parentCommentURI, indexedReply.ParentURI)

     

       423
       423
       +
       	}

     

       424
       424
       +
       

     

       425
       425
       +
       	t.Logf("✅ NESTED REPLY FLOW COMPLETE:")

     

       426
       426
       +
       	t.Logf("   ✓ Reply created with correct parent reference")

     

       427
       427
       +
       	t.Logf("   ✓ Reply indexed in AppView")

     

       428
       428
       +
       }

     

       429
       429
       +
       

     

       430
       430
       +
       // TestCommentWrite_UpdateComment tests updating an existing comment

     

       431
       431
       +
       func TestCommentWrite_UpdateComment(t *testing.T) {

     

       432
       432
       +
       	if testing.Short() {

     

       433
       433
       +
       		t.Skip("Skipping E2E test in short mode")

     

       434
       434
       +
       	}

     

       435
       435
       +
       

     

       436
       436
       +
       	db := setupTestDB(t)

     

       437
       437
       +
       	defer func() { _ = db.Close() }()

     

       438
       438
       +
       

     

       439
       439
       +
       	ctx := context.Background()

     

       440
       440
       +
       	pdsURL := getTestPDSURL()

     

       441
       441
       +
       

     

       442
       442
       +
       	// Setup repositories and service

     

       443
       443
       +
       	commentRepo := postgres.NewCommentRepository(db)

     

       444
       444
       +
       

     

       445
       445
       +
       	// CommentPDSClientFactory creates a PDS client for comment operations

     

       446
       446
       +
       	commentPDSFactory := func(ctx context.Context, session *oauthlib.ClientSessionData) (pds.Client, error) {

     

       447
       447
       +
       		if session.AccessToken == "" {

     

       448
       448
       +
       			return nil, fmt.Errorf("session has no access token")

     

       449
       449
       +
       		}

     

       450
       450
       +
       		if session.HostURL == "" {

     

       451
       451
       +
       			return nil, fmt.Errorf("session has no host URL")

     

       452
       452
       +
       		}

     

       453
       453
       +
       

     

       454
       454
       +
       		return pds.NewFromAccessToken(session.HostURL, session.AccountDID.String(), session.AccessToken)

     

       455
       455
       +
       	}

     

       456
       456
       +
       

     

       457
       457
       +
       	commentService := comments.NewCommentServiceWithPDSFactory(

     

       458
       458
       +
       		commentRepo,

     

       459
       459
       +
       		nil,

     

       460
       460
       +
       		nil,

     

       461
       461
       +
       		nil,

     

       462
       462
       +
       		nil,

     

       463
       463
       +
       		commentPDSFactory,

     

       464
       464
       +
       	)

     

       465
       465
       +
       

     

       466
       466
       +
       	// Create test user

     

       467
       467
       +
       	testUserHandle := fmt.Sprintf("updater-%d.local.coves.dev", time.Now().Unix())

     

       468
       468
       +
       	testUserEmail := fmt.Sprintf("updater-%d@test.local", time.Now().Unix())

     

       469
       469
       +
       	testUserPassword := "test-password-123"

     

       470
       470
       +
       

     

       471
       471
       +
       	pdsAccessToken, userDID, err := createPDSAccount(pdsURL, testUserHandle, testUserEmail, testUserPassword)

     

       472
       472
       +
       	if err != nil {

     

       473
       473
       +
       		t.Skipf("PDS not available: %v", err)

     

       474
       474
       +
       	}

     

       475
       475
       +
       

     

       476
       476
       +
       	// Setup OAuth

     

       477
       477
       +
       	mockStore := NewMockOAuthStore()

     

       478
       478
       +
       	mockStore.AddSessionWithPDS(userDID, "session-"+userDID, pdsAccessToken, pdsURL)

     

       479
       479
       +
       

     

       480
       480
       +
       	parsedDID, _ := parseTestDID(userDID)

     

       481
       481
       +
       	session, _ := mockStore.GetSession(ctx, parsedDID, "session-"+userDID)

     

       482
       482
       +
       

     

       483
       483
       +
       	// First, create a comment to update

     

       484
       484
       +
       	t.Logf("\n📝 Creating initial comment...")

     

       485
       485
       +
       	createReq := comments.CreateCommentRequest{

     

       486
       486
       +
       		Reply: comments.ReplyRef{

     

       487
       487
       +
       			Root: comments.StrongRef{

     

       488
       488
       +
       				URI: "at://did:plc:test/social.coves.community.post/test123",

     

       489
       489
       +
       				CID: "bafypost",

     

       490
       490
       +
       			},

     

       491
       491
       +
       			Parent: comments.StrongRef{

     

       492
       492
       +
       				URI: "at://did:plc:test/social.coves.community.post/test123",

     

       493
       493
       +
       				CID: "bafypost",

     

       494
       494
       +
       			},

     

       495
       495
       +
       		},

     

       496
       496
       +
       		Content: "Original content",

     

       497
       497
       +
       		Langs:   []string{"en"},

     

       498
       498
       +
       	}

     

       499
       499
       +
       

     

       500
       500
       +
       	createResp, err := commentService.CreateComment(ctx, session, createReq)

     

       501
       501
       +
       	if err != nil {

     

       502
       502
       +
       		t.Fatalf("Failed to create comment: %v", err)

     

       503
       503
       +
       	}

     

       504
       504
       +
       

     

       505
       505
       +
       	t.Logf("✅ Initial comment created: %s", createResp.URI)

     

       506
       506
       +
       

     

       507
       507
       +
       	// Now update the comment

     

       508
       508
       +
       	t.Logf("\n📝 Updating comment...")

     

       509
       509
       +
       	updateReq := comments.UpdateCommentRequest{

     

       510
       510
       +
       		URI:     createResp.URI,

     

       511
       511
       +
       		Content: "Updated content - this has been edited",

     

       512
       512
       +
       	}

     

       513
       513
       +
       

     

       514
       514
       +
       	updateResp, err := commentService.UpdateComment(ctx, session, updateReq)

     

       515
       515
       +
       	if err != nil {

     

       516
       516
       +
       		t.Fatalf("Failed to update comment: %v", err)

     

       517
       517
       +
       	}

     

       518
       518
       +
       

     

       519
       519
       +
       	t.Logf("✅ Comment updated:")

     

       520
       520
       +
       	t.Logf("   URI: %s", updateResp.URI)

     

       521
       521
       +
       	t.Logf("   New CID: %s", updateResp.CID)

     

       522
       522
       +
       

     

       523
       523
       +
       	// Verify the update on PDS

     

       524
       524
       +
       	rkey := utils.ExtractRKeyFromURI(updateResp.URI)

     

       525
       525
       +
       	pdsResp, _ := http.Get(fmt.Sprintf("%s/xrpc/com.atproto.repo.getRecord?repo=%s&collection=social.coves.community.comment&rkey=%s",

     

       526
       526
       +
       		pdsURL, userDID, rkey))

     

       527
       527
       +
       	defer pdsResp.Body.Close()

     

       528
       528
       +
       

     

       529
       529
       +
       	var pdsRecord struct {

     

       530
       530
       +
       		Value map[string]interface{} `json:"value"`

     

       531
       531
       +
       		CID   string                 `json:"cid"`

     

       532
       532
       +
       	}

     

       533
       533
       +
       	json.NewDecoder(pdsResp.Body).Decode(&pdsRecord)

     

       534
       534
       +
       

     

       535
       535
       +
       	if pdsRecord.Value["content"] != "Updated content - this has been edited" {

     

       536
       536
       +
       		t.Errorf("Expected updated content, got %v", pdsRecord.Value["content"])

     

       537
       537
       +
       	}

     

       538
       538
       +
       

     

       539
       539
       +
       	t.Logf("✅ UPDATE FLOW COMPLETE:")

     

       540
       540
       +
       	t.Logf("   ✓ Comment updated on PDS")

     

       541
       541
       +
       	t.Logf("   ✓ New CID generated")

     

       542
       542
       +
       	t.Logf("   ✓ Content verified")

     

       543
       543
       +
       }

     

       544
       544
       +
       

     

       545
       545
       +
       // TestCommentWrite_DeleteComment tests deleting a comment

     

       546
       546
       +
       func TestCommentWrite_DeleteComment(t *testing.T) {

     

       547
       547
       +
       	if testing.Short() {

     

       548
       548
       +
       		t.Skip("Skipping E2E test in short mode")

     

       549
       549
       +
       	}

     

       550
       550
       +
       

     

       551
       551
       +
       	db := setupTestDB(t)

     

       552
       552
       +
       	defer func() { _ = db.Close() }()

     

       553
       553
       +
       

     

       554
       554
       +
       	ctx := context.Background()

     

       555
       555
       +
       	pdsURL := getTestPDSURL()

     

       556
       556
       +
       

     

       557
       557
       +
       	// Setup repositories and service

     

       558
       558
       +
       	commentRepo := postgres.NewCommentRepository(db)

     

       559
       559
       +
       

     

       560
       560
       +
       	// CommentPDSClientFactory creates a PDS client for comment operations

     

       561
       561
       +
       	commentPDSFactory := func(ctx context.Context, session *oauthlib.ClientSessionData) (pds.Client, error) {

     

       562
       562
       +
       		if session.AccessToken == "" {

     

       563
       563
       +
       			return nil, fmt.Errorf("session has no access token")

     

       564
       564
       +
       		}

     

       565
       565
       +
       		if session.HostURL == "" {

     

       566
       566
       +
       			return nil, fmt.Errorf("session has no host URL")

     

       567
       567
       +
       		}

     

       568
       568
       +
       

     

       569
       569
       +
       		return pds.NewFromAccessToken(session.HostURL, session.AccountDID.String(), session.AccessToken)

     

       570
       570
       +
       	}

     

       571
       571
       +
       

     

       572
       572
       +
       	commentService := comments.NewCommentServiceWithPDSFactory(

     

       573
       573
       +
       		commentRepo,

     

       574
       574
       +
       		nil,

     

       575
       575
       +
       		nil,

     

       576
       576
       +
       		nil,

     

       577
       577
       +
       		nil,

     

       578
       578
       +
       		commentPDSFactory,

     

       579
       579
       +
       	)

     

       580
       580
       +
       

     

       581
       581
       +
       	// Create test user

     

       582
       582
       +
       	testUserHandle := fmt.Sprintf("deleter-%d.local.coves.dev", time.Now().Unix())

     

       583
       583
       +
       	testUserEmail := fmt.Sprintf("deleter-%d@test.local", time.Now().Unix())

     

       584
       584
       +
       	testUserPassword := "test-password-123"

     

       585
       585
       +
       

     

       586
       586
       +
       	pdsAccessToken, userDID, err := createPDSAccount(pdsURL, testUserHandle, testUserEmail, testUserPassword)

     

       587
       587
       +
       	if err != nil {

     

       588
       588
       +
       		t.Skipf("PDS not available: %v", err)

     

       589
       589
       +
       	}

     

       590
       590
       +
       

     

       591
       591
       +
       	// Setup OAuth

     

       592
       592
       +
       	mockStore := NewMockOAuthStore()

     

       593
       593
       +
       	mockStore.AddSessionWithPDS(userDID, "session-"+userDID, pdsAccessToken, pdsURL)

     

       594
       594
       +
       

     

       595
       595
       +
       	parsedDID, _ := parseTestDID(userDID)

     

       596
       596
       +
       	session, _ := mockStore.GetSession(ctx, parsedDID, "session-"+userDID)

     

       597
       597
       +
       

     

       598
       598
       +
       	// First, create a comment to delete

     

       599
       599
       +
       	t.Logf("\n📝 Creating comment to delete...")

     

       600
       600
       +
       	createReq := comments.CreateCommentRequest{

     

       601
       601
       +
       		Reply: comments.ReplyRef{

     

       602
       602
       +
       			Root: comments.StrongRef{

     

       603
       603
       +
       				URI: "at://did:plc:test/social.coves.community.post/test123",

     

       604
       604
       +
       				CID: "bafypost",

     

       605
       605
       +
       			},

     

       606
       606
       +
       			Parent: comments.StrongRef{

     

       607
       607
       +
       				URI: "at://did:plc:test/social.coves.community.post/test123",

     

       608
       608
       +
       				CID: "bafypost",

     

       609
       609
       +
       			},

     

       610
       610
       +
       		},

     

       611
       611
       +
       		Content: "This comment will be deleted",

     

       612
       612
       +
       		Langs:   []string{"en"},

     

       613
       613
       +
       	}

     

       614
       614
       +
       

     

       615
       615
       +
       	createResp, err := commentService.CreateComment(ctx, session, createReq)

     

       616
       616
       +
       	if err != nil {

     

       617
       617
       +
       		t.Fatalf("Failed to create comment: %v", err)

     

       618
       618
       +
       	}

     

       619
       619
       +
       

     

       620
       620
       +
       	t.Logf("✅ Comment created: %s", createResp.URI)

     

       621
       621
       +
       

     

       622
       622
       +
       	// Now delete the comment

     

       623
       623
       +
       	t.Logf("\n📝 Deleting comment...")

     

       624
       624
       +
       	deleteReq := comments.DeleteCommentRequest{

     

       625
       625
       +
       		URI: createResp.URI,

     

       626
       626
       +
       	}

     

       627
       627
       +
       

     

       628
       628
       +
       	err = commentService.DeleteComment(ctx, session, deleteReq)

     

       629
       629
       +
       	if err != nil {

     

       630
       630
       +
       		t.Fatalf("Failed to delete comment: %v", err)

     

       631
       631
       +
       	}

     

       632
       632
       +
       

     

       633
       633
       +
       	t.Logf("✅ Comment deleted")

     

       634
       634
       +
       

     

       635
       635
       +
       	// Verify deletion on PDS

     

       636
       636
       +
       	rkey := utils.ExtractRKeyFromURI(createResp.URI)

     

       637
       637
       +
       	pdsResp, _ := http.Get(fmt.Sprintf("%s/xrpc/com.atproto.repo.getRecord?repo=%s&collection=social.coves.community.comment&rkey=%s",

     

       638
       638
       +
       		pdsURL, userDID, rkey))

     

       639
       639
       +
       	defer pdsResp.Body.Close()

     

       640
       640
       +
       

     

       641
       641
       +
       	if pdsResp.StatusCode != http.StatusBadRequest && pdsResp.StatusCode != http.StatusNotFound {

     

       642
       642
       +
       		t.Errorf("Expected 400 or 404 for deleted comment, got %d", pdsResp.StatusCode)

     

       643
       643
       +
       	}

     

       644
       644
       +
       

     

       645
       645
       +
       	t.Logf("✅ DELETE FLOW COMPLETE:")

     

       646
       646
       +
       	t.Logf("   ✓ Comment deleted from PDS")

     

       647
       647
       +
       	t.Logf("   ✓ Record no longer accessible")

     

       648
       648
       +
       }

     

       649
       649
       +
       

     

       650
       650
       +
       // TestCommentWrite_CannotUpdateOthersComment tests authorization for updates

     

       651
       651
       +
       func TestCommentWrite_CannotUpdateOthersComment(t *testing.T) {

     

       652
       652
       +
       	if testing.Short() {

     

       653
       653
       +
       		t.Skip("Skipping E2E test in short mode")

     

       654
       654
       +
       	}

     

       655
       655
       +
       

     

       656
       656
       +
       	db := setupTestDB(t)

     

       657
       657
       +
       	defer func() { _ = db.Close() }()

     

       658
       658
       +
       

     

       659
       659
       +
       	ctx := context.Background()

     

       660
       660
       +
       	pdsURL := getTestPDSURL()

     

       661
       661
       +
       

     

       662
       662
       +
       	// CommentPDSClientFactory creates a PDS client for comment operations

     

       663
       663
       +
       	commentPDSFactory := func(ctx context.Context, session *oauthlib.ClientSessionData) (pds.Client, error) {

     

       664
       664
       +
       		if session.AccessToken == "" {

     

       665
       665
       +
       			return nil, fmt.Errorf("session has no access token")

     

       666
       666
       +
       		}

     

       667
       667
       +
       		if session.HostURL == "" {

     

       668
       668
       +
       			return nil, fmt.Errorf("session has no host URL")

     

       669
       669
       +
       		}

     

       670
       670
       +
       

     

       671
       671
       +
       		return pds.NewFromAccessToken(session.HostURL, session.AccountDID.String(), session.AccessToken)

     

       672
       672
       +
       	}

     

       673
       673
       +
       

     

       674
       674
       +
       	// Setup service

     

       675
       675
       +
       	commentService := comments.NewCommentServiceWithPDSFactory(

     

       676
       676
       +
       		nil,

     

       677
       677
       +
       		nil,

     

       678
       678
       +
       		nil,

     

       679
       679
       +
       		nil,

     

       680
       680
       +
       		nil,

     

       681
       681
       +
       		commentPDSFactory,

     

       682
       682
       +
       	)

     

       683
       683
       +
       

     

       684
       684
       +
       	// Create first user (comment owner)

     

       685
       685
       +
       	ownerHandle := fmt.Sprintf("owner-%d.local.coves.dev", time.Now().Unix())

     

       686
       686
       +
       	ownerEmail := fmt.Sprintf("owner-%d@test.local", time.Now().Unix())

     

       687
       687
       +
       	_, ownerDID, err := createPDSAccount(pdsURL, ownerHandle, ownerEmail, "password123")

     

       688
       688
       +
       	if err != nil {

     

       689
       689
       +
       		t.Skipf("PDS not available: %v", err)

     

       690
       690
       +
       	}

     

       691
       691
       +
       

     

       692
       692
       +
       	// Create second user (attacker)

     

       693
       693
       +
       	attackerHandle := fmt.Sprintf("attacker-%d.local.coves.dev", time.Now().Unix())

     

       694
       694
       +
       	attackerEmail := fmt.Sprintf("attacker-%d@test.local", time.Now().Unix())

     

       695
       695
       +
       	attackerToken, attackerDID, err := createPDSAccount(pdsURL, attackerHandle, attackerEmail, "password123")

     

       696
       696
       +
       	if err != nil {

     

       697
       697
       +
       		t.Skipf("PDS not available: %v", err)

     

       698
       698
       +
       	}

     

       699
       699
       +
       

     

       700
       700
       +
       	// Setup OAuth for attacker

     

       701
       701
       +
       	mockStore := NewMockOAuthStore()

     

       702
       702
       +
       	mockStore.AddSessionWithPDS(attackerDID, "session-"+attackerDID, attackerToken, pdsURL)

     

       703
       703
       +
       

     

       704
       704
       +
       	parsedDID, _ := parseTestDID(attackerDID)

     

       705
       705
       +
       	session, _ := mockStore.GetSession(ctx, parsedDID, "session-"+attackerDID)

     

       706
       706
       +
       

     

       707
       707
       +
       	// Try to update comment owned by different user

     

       708
       708
       +
       	t.Logf("\n🚨 Attempting to update another user's comment...")

     

       709
       709
       +
       	updateReq := comments.UpdateCommentRequest{

     

       710
       710
       +
       		URI:     fmt.Sprintf("at://%s/social.coves.community.comment/test123", ownerDID),

     

       711
       711
       +
       		Content: "Malicious update attempt",

     

       712
       712
       +
       	}

     

       713
       713
       +
       

     

       714
       714
       +
       	_, err = commentService.UpdateComment(ctx, session, updateReq)

     

       715
       715
       +
       

     

       716
       716
       +
       	// Verify authorization error

     

       717
       717
       +
       	if err == nil {

     

       718
       718
       +
       		t.Fatal("Expected authorization error, got nil")

     

       719
       719
       +
       	}

     

       720
       720
       +
       	if !errors.Is(err, comments.ErrNotAuthorized) {

     

       721
       721
       +
       		t.Errorf("Expected ErrNotAuthorized, got: %v", err)

     

       722
       722
       +
       	}

     

       723
       723
       +
       

     

       724
       724
       +
       	t.Logf("✅ AUTHORIZATION CHECK PASSED:")

     

       725
       725
       +
       	t.Logf("   ✓ User cannot update others' comments")

     

       726
       726
       +
       }

     

       727
       727
       +
       

     

       728
       728
       +
       // TestCommentWrite_CannotDeleteOthersComment tests authorization for deletes

     

       729
       729
       +
       func TestCommentWrite_CannotDeleteOthersComment(t *testing.T) {

     

       730
       730
       +
       	if testing.Short() {

     

       731
       731
       +
       		t.Skip("Skipping E2E test in short mode")

     

       732
       732
       +
       	}

     

       733
       733
       +
       

     

       734
       734
       +
       	db := setupTestDB(t)

     

       735
       735
       +
       	defer func() { _ = db.Close() }()

     

       736
       736
       +
       

     

       737
       737
       +
       	ctx := context.Background()

     

       738
       738
       +
       	pdsURL := getTestPDSURL()

     

       739
       739
       +
       

     

       740
       740
       +
       	// CommentPDSClientFactory creates a PDS client for comment operations

     

       741
       741
       +
       	commentPDSFactory := func(ctx context.Context, session *oauthlib.ClientSessionData) (pds.Client, error) {

     

       742
       742
       +
       		if session.AccessToken == "" {

     

       743
       743
       +
       			return nil, fmt.Errorf("session has no access token")

     

       744
       744
       +
       		}

     

       745
       745
       +
       		if session.HostURL == "" {

     

       746
       746
       +
       			return nil, fmt.Errorf("session has no host URL")

     

       747
       747
       +
       		}

     

       748
       748
       +
       

     

       749
       749
       +
       		return pds.NewFromAccessToken(session.HostURL, session.AccountDID.String(), session.AccessToken)

     

       750
       750
       +
       	}

     

       751
       751
       +
       

     

       752
       752
       +
       	// Setup service

     

       753
       753
       +
       	commentService := comments.NewCommentServiceWithPDSFactory(

     

       754
       754
       +
       		nil,

     

       755
       755
       +
       		nil,

     

       756
       756
       +
       		nil,

     

       757
       757
       +
       		nil,

     

       758
       758
       +
       		nil,

     

       759
       759
       +
       		commentPDSFactory,

     

       760
       760
       +
       	)

     

       761
       761
       +
       

     

       762
       762
       +
       	// Create first user (comment owner)

     

       763
       763
       +
       	ownerHandle := fmt.Sprintf("owner-%d.local.coves.dev", time.Now().Unix())

     

       764
       764
       +
       	ownerEmail := fmt.Sprintf("owner-%d@test.local", time.Now().Unix())

     

       765
       765
       +
       	_, ownerDID, err := createPDSAccount(pdsURL, ownerHandle, ownerEmail, "password123")

     

       766
       766
       +
       	if err != nil {

     

       767
       767
       +
       		t.Skipf("PDS not available: %v", err)

     

       768
       768
       +
       	}

     

       769
       769
       +
       

     

       770
       770
       +
       	// Create second user (attacker)

     

       771
       771
       +
       	attackerHandle := fmt.Sprintf("attacker-%d.local.coves.dev", time.Now().Unix())

     

       772
       772
       +
       	attackerEmail := fmt.Sprintf("attacker-%d@test.local", time.Now().Unix())

     

       773
       773
       +
       	attackerToken, attackerDID, err := createPDSAccount(pdsURL, attackerHandle, attackerEmail, "password123")

     

       774
       774
       +
       	if err != nil {

     

       775
       775
       +
       		t.Skipf("PDS not available: %v", err)

     

       776
       776
       +
       	}

     

       777
       777
       +
       

     

       778
       778
       +
       	// Setup OAuth for attacker

     

       779
       779
       +
       	mockStore := NewMockOAuthStore()

     

       780
       780
       +
       	mockStore.AddSessionWithPDS(attackerDID, "session-"+attackerDID, attackerToken, pdsURL)

     

       781
       781
       +
       

     

       782
       782
       +
       	parsedDID, _ := parseTestDID(attackerDID)

     

       783
       783
       +
       	session, _ := mockStore.GetSession(ctx, parsedDID, "session-"+attackerDID)

     

       784
       784
       +
       

     

       785
       785
       +
       	// Try to delete comment owned by different user

     

       786
       786
       +
       	t.Logf("\n🚨 Attempting to delete another user's comment...")

     

       787
       787
       +
       	deleteReq := comments.DeleteCommentRequest{

     

       788
       788
       +
       		URI: fmt.Sprintf("at://%s/social.coves.community.comment/test123", ownerDID),

     

       789
       789
       +
       	}

     

       790
       790
       +
       

     

       791
       791
       +
       	err = commentService.DeleteComment(ctx, session, deleteReq)

     

       792
       792
       +
       

     

       793
       793
       +
       	// Verify authorization error

     

       794
       794
       +
       	if err == nil {

     

       795
       795
       +
       		t.Fatal("Expected authorization error, got nil")

     

       796
       796
       +
       	}

     

       797
       797
       +
       	if !errors.Is(err, comments.ErrNotAuthorized) {

     

       798
       798
       +
       		t.Errorf("Expected ErrNotAuthorized, got: %v", err)

     

       799
       799
       +
       	}

     

       800
       800
       +
       

     

       801
       801
       +
       	t.Logf("✅ AUTHORIZATION CHECK PASSED:")

     

       802
       802
       +
       	t.Logf("   ✓ User cannot delete others' comments")

     

       803
       803
       +
       }

     

       804
       804
       +
       

     

       805
       805
       +
       // Helper function to parse DID for testing

     

       806
       806
       +
       func parseTestDID(did string) (syntax.DID, error) {

     

       807
       807
       +
       	return syntax.ParseDID(did)

     

       808
       808
       +
       }

+2 -1

tests/integration/concurrent_scenarios_test.go

···

       454
       454
        
       		}

     

       455
       455
        
       

     

       456
       456
        
       		// Verify all comments are retrievable via service

     

       457
       457
       -
       		commentService := comments.NewCommentService(commentRepo, userRepo, postRepo, communityRepo)

     

       457
       457
       +
       		// Use factory constructor with nil factory - this test only uses the read path (GetComments)

     

       458
       458
       +
       		commentService := comments.NewCommentServiceWithPDSFactory(commentRepo, userRepo, postRepo, communityRepo, nil, nil)

     

       458
       459
        
       		response, err := commentService.GetComments(ctx, &comments.GetCommentsRequest{

     

       459
       460
        
       			PostURI:   postURI,

     

       460
       461
        
       			Sort:      "new",