commit 830a552432ff0dac38b12f5a1c2c8e222811da34 · bretton.dev/coves

+103 -5

docs/PRD_BACKLOG.md

···

       2
       2
        
       

     

       3
       3
        
       **Status:** Ongoing

     

       4
       4
        
       **Owner:** Platform Team

     

       5
       5
       -
       **Last Updated:** 2025-10-16

     

       5
       5
       +
       **Last Updated:** 2025-10-17

     

       6
       6
        
       

     

       7
       7
        
       ## Overview

     

       8
       8
        
       

     
···

       49
       49
        
       

     

       50
       50
        
       ---

     

       51
       51
        
       

     

       52
       52
       -
       ### Token Refresh Logic for Community Credentials

     

       53
       53
       -
       **Added:** 2025-10-11 | **Effort:** 1-2 days | **Priority:** ALPHA BLOCKER

     

       52
       52
       +
       ### ✅ Token Refresh Logic for Community Credentials - COMPLETE

     

       53
       53
       +
       **Added:** 2025-10-11 | **Completed:** 2025-10-17 | **Effort:** 1.5 days | **Status:** ✅ DONE

     

       54
       54
        
       

     

       55
       55
        
       **Problem:** Community PDS access tokens expire (~2hrs). Updates fail until manual intervention.

     

       56
       56
        
       

     

       57
       57
       -
       **Solution:** Auto-refresh tokens before PDS operations. Parse JWT exp claim, use refresh token when expired, update DB.

     

       57
       57
       +
       **Solution Implemented:**

     

       58
       58
       +
       - ✅ Automatic token refresh before PDS operations (5-minute buffer before expiration)

     

       59
       59
       +
       - ✅ JWT expiration parsing without signature verification (`parseJWTExpiration`, `needsRefresh`)

     

       60
       60
       +
       - ✅ Token refresh using Indigo SDK (`atproto.ServerRefreshSession`)

     

       61
       61
       +
       - ✅ Password fallback when refresh tokens expire (~2 months) via `atproto.ServerCreateSession`

     

       62
       62
       +
       - ✅ Atomic credential updates (`UpdateCredentials` repository method)

     

       63
       63
       +
       - ✅ Concurrency-safe with per-community mutex locking

     

       64
       64
       +
       - ✅ Structured logging for monitoring (`[TOKEN-REFRESH]` events)

     

       65
       65
       +
       - ✅ Integration tests for token expiration detection and credential updates

     

       58
       66
        
       

     

       59
       59
       -
       **Code:** TODO in [communities/service.go:123](../internal/core/communities/service.go#L123)

     

       67
       67
       +
       **Files Created:**

     

       68
       68
       +
       - [internal/core/communities/token_utils.go](../internal/core/communities/token_utils.go) - JWT parsing utilities

     

       69
       69
       +
       - [internal/core/communities/token_refresh.go](../internal/core/communities/token_refresh.go) - Refresh and re-auth logic

     

       70
       70
       +
       - [tests/integration/token_refresh_test.go](../tests/integration/token_refresh_test.go) - Integration tests

     

       71
       71
       +
       

     

       72
       72
       +
       **Files Modified:**

     

       73
       73
       +
       - [internal/core/communities/service.go](../internal/core/communities/service.go) - Added `ensureFreshToken` + concurrency control

     

       74
       74
       +
       - [internal/core/communities/interfaces.go](../internal/core/communities/interfaces.go) - Added `UpdateCredentials` interface

     

       75
       75
       +
       - [internal/db/postgres/community_repo.go](../internal/db/postgres/community_repo.go) - Implemented `UpdateCredentials`

     

       76
       76
       +
       

     

       77
       77
       +
       **Documentation:** See [IMPLEMENTATION_TOKEN_REFRESH.md](../docs/IMPLEMENTATION_TOKEN_REFRESH.md) for full details

     

       78
       78
       +
       

     

       79
       79
       +
       **Impact:** ✅ Communities can now be updated 24+ hours after creation without manual intervention

     

       60
       80
        
       

     

       61
       81
        
       ---

     

       62
       82
        
       

     
···

       112
       132
        
       

     

       113
       133
        
       ---

     

       114
       134
        
       

     

       135
       135
       +
       ## 🔴 P1.5: Federation Blockers (Beta Launch)

     

       136
       136
       +
       

     

       137
       137
       +
       ### Cross-PDS Write-Forward Support

     

       138
       138
       +
       **Added:** 2025-10-17 | **Effort:** 3-4 hours | **Priority:** FEDERATION BLOCKER (Beta)

     

       139
       139
       +
       

     

       140
       140
       +
       **Problem:** Current write-forward implementation assumes all users are on the same PDS as the Coves instance. This breaks federation when users from external PDSs try to interact with communities.

     

       141
       141
       +
       

     

       142
       142
       +
       **Current Behavior:**

     

       143
       143
       +
       - User on `pds.bsky.social` subscribes to community on `coves.social`

     

       144
       144
       +
       - Coves calls `s.pdsURL` (instance default: `http://localhost:3001`)

     

       145
       145
       +
       - Write goes to WRONG PDS → fails with 401/403

     

       146
       146
       +
       

     

       147
       147
       +
       **Impact:**

     

       148
       148
       +
       - ✅ **Alpha**: Works fine (single PDS deployment)

     

       149
       149
       +
       - ❌ **Beta**: Breaks federation (users on different PDSs can't subscribe/interact)

     

       150
       150
       +
       

     

       151
       151
       +
       **Root Cause:**

     

       152
       152
       +
       - [service.go:736](../internal/core/communities/service.go#L736): `createRecordOnPDSAs` hardcodes `s.pdsURL`

     

       153
       153
       +
       - [service.go:753](../internal/core/communities/service.go#L753): `putRecordOnPDSAs` hardcodes `s.pdsURL`

     

       154
       154
       +
       - [service.go:767](../internal/core/communities/service.go#L767): `deleteRecordOnPDSAs` hardcodes `s.pdsURL`

     

       155
       155
       +
       

     

       156
       156
       +
       **Solution:**

     

       157
       157
       +
       1. Add identity resolver dependency to `CommunityService`

     

       158
       158
       +
       2. Before write-forward, resolve user's DID → extract PDS URL

     

       159
       159
       +
       3. Call user's actual PDS instead of `s.pdsURL`

     

       160
       160
       +
       

     

       161
       161
       +
       **Implementation:**

     

       162
       162
       +
       ```go

     

       163
       163
       +
       // Before write-forward to user's repo:

     

       164
       164
       +
       userIdentity, err := s.identityResolver.ResolveDID(ctx, userDID)

     

       165
       165
       +
       if err != nil {

     

       166
       166
       +
           return fmt.Errorf("failed to resolve user PDS: %w", err)

     

       167
       167
       +
       }

     

       168
       168
       +
       

     

       169
       169
       +
       // Use user's actual PDS URL

     

       170
       170
       +
       endpoint := fmt.Sprintf("%s/xrpc/com.atproto.repo.createRecord", userIdentity.PDSURL)

     

       171
       171
       +
       ```

     

       172
       172
       +
       

     

       173
       173
       +
       **Files to Modify:**

     

       174
       174
       +
       - `internal/core/communities/service.go` - Add resolver, modify write-forward methods

     

       175
       175
       +
       - `cmd/server/main.go` - Pass identity resolver to community service constructor

     

       176
       176
       +
       - Tests - Add cross-PDS scenarios

     

       177
       177
       +
       

     

       178
       178
       +
       **Testing:**

     

       179
       179
       +
       - User on external PDS subscribes to community

     

       180
       180
       +
       - User on external PDS blocks community

     

       181
       181
       +
       - Community updates still work (communities ARE on instance PDS)

     

       182
       182
       +
       

     

       183
       183
       +
       ---

     

       184
       184
       +
       

     

       115
       185
        
       ## 🟢 P2: Nice-to-Have

     

       116
       186
        
       

     

       117
       187
        
       ### Remove Categories from Community Lexicon

     
···

       222
       292
        
       ---

     

       223
       293
        
       

     

       224
       294
        
       ## Recent Completions

     

       295
       295
       +
       

     

       296
       296
       +
       ### ✅ Token Refresh for Community Credentials (2025-10-17)

     

       297
       297
       +
       **Completed:** Automatic token refresh prevents communities from breaking after 2 hours

     

       298
       298
       +
       

     

       299
       299
       +
       **Implementation:**

     

       300
       300
       +
       - ✅ JWT expiration parsing and refresh detection (5-minute buffer)

     

       301
       301
       +
       - ✅ Token refresh using Indigo SDK (`atproto.ServerRefreshSession`)

     

       302
       302
       +
       - ✅ Password fallback when refresh tokens expire (`atproto.ServerCreateSession`)

     

       303
       303
       +
       - ✅ Atomic credential updates in database (`UpdateCredentials`)

     

       304
       304
       +
       - ✅ Concurrency-safe with per-community mutex locking

     

       305
       305
       +
       - ✅ Structured logging for monitoring (`[TOKEN-REFRESH]` events)

     

       306
       306
       +
       - ✅ Integration tests for expiration detection and credential updates

     

       307
       307
       +
       

     

       308
       308
       +
       **Files Created:**

     

       309
       309
       +
       - [internal/core/communities/token_utils.go](../internal/core/communities/token_utils.go)

     

       310
       310
       +
       - [internal/core/communities/token_refresh.go](../internal/core/communities/token_refresh.go)

     

       311
       311
       +
       - [tests/integration/token_refresh_test.go](../tests/integration/token_refresh_test.go)

     

       312
       312
       +
       

     

       313
       313
       +
       **Files Modified:**

     

       314
       314
       +
       - [internal/core/communities/service.go](../internal/core/communities/service.go) - Added `ensureFreshToken` method

     

       315
       315
       +
       - [internal/core/communities/interfaces.go](../internal/core/communities/interfaces.go) - Added `UpdateCredentials` interface

     

       316
       316
       +
       - [internal/db/postgres/community_repo.go](../internal/db/postgres/community_repo.go) - Implemented `UpdateCredentials`

     

       317
       317
       +
       

     

       318
       318
       +
       **Documentation:** [IMPLEMENTATION_TOKEN_REFRESH.md](../docs/IMPLEMENTATION_TOKEN_REFRESH.md)

     

       319
       319
       +
       

     

       320
       320
       +
       **Impact:** Communities now work indefinitely without manual token management

     

       321
       321
       +
       

     

       322
       322
       +
       ---

     

       225
       323
        
       

     

       226
       324
        
       ### ✅ OAuth Authentication for Community Actions (2025-10-16)

     

       227
       325
        
       **Completed:** Full OAuth JWT authentication flow for protected endpoints

+25 -12

docs/PRD_COMMUNITIES.md

···

       2
       2
        
       

     

       3
       3
        
       **Status:** In Development

     

       4
       4
        
       **Owner:** Platform Team

     

       5
       5
       -
       **Last Updated:** 2025-10-16

     

       5
       5
       +
       **Last Updated:** 2025-10-17

     

       6
       6
        
       

     

       7
       7
        
       ## Overview

     

       8
       8
        
       

     
···

       33
       33
        
       

     

       34
       34
        
       ---

     

       35
       35
        
       

     

       36
       36
       -
       ## ✅ Completed Features (2025-10-10)

     

       36
       36
       +
       ## ✅ Completed Features (Updated 2025-10-17)

     

       37
       37
        
       

     

       38
       38
        
       ### Core Infrastructure

     

       39
       39
        
       - [x] **V2 Architecture:** Communities own their own repositories

     

       40
       40
        
       - [x] **PDS Account Provisioning:** Automatic account creation for each community

     

       41
       41
        
       - [x] **Credential Management:** Secure storage of community PDS credentials

     

       42
       42
       +
       - [x] **Token Refresh:** Automatic refresh of expired access tokens (completed 2025-10-17)

     

       42
       43
        
       - [x] **Encryption at Rest:** PostgreSQL pgcrypto for sensitive credentials

     

       43
       44
        
       - [x] **Write-Forward Pattern:** Service → PDS → Firehose → AppView

     

       44
       45
        
       - [x] **Jetstream Consumer:** Real-time indexing from firehose

     
···

       47
       48
        
       ### Security & Data Protection

     

       48
       49
        
       - [x] **Encrypted Credentials:** Access/refresh tokens encrypted in database

     

       49
       50
        
       - [x] **Credential Persistence:** PDS credentials survive server restarts

     

       51
       51
       +
       - [x] **Automatic Token Refresh:** Tokens refresh 5 minutes before expiration (completed 2025-10-17)

     

       52
       52
       +
       - [x] **Password Fallback:** Re-authentication when refresh tokens expire

     

       53
       53
       +
       - [x] **Concurrency Safety:** Per-community mutex prevents refresh race conditions

     

       50
       54
        
       - [x] **JSON Exclusion:** Credentials never exposed in API responses (`json:"-"` tags)

     

       51
       51
       -
       - [x] **Password Hashing:** bcrypt for PDS account passwords

     

       55
       55
       +
       - [x] **Password Encryption:** Encrypted (not hashed) for session creation fallback

     

       52
       56
        
       - [x] **Timeout Handling:** 30s timeout for write operations, 10s for reads

     

       53
       57
        
       

     

       54
       58
        
       ### Database Schema

     
···

       79
       83
        
       ### Testing Coverage

     

       80
       84
        
       - [x] **Integration Tests:** Full CRUD operations

     

       81
       85
        
       - [x] **Credential Tests:** Persistence, encryption, decryption

     

       86
       86
       +
       - [x] **Token Refresh Tests:** JWT parsing, credential updates, concurrency (completed 2025-10-17)

     

       82
       87
        
       - [x] **V2 Validation Tests:** Rkey enforcement, self-ownership

     

       83
       88
        
       - [x] **Consumer Tests:** Firehose event processing

     

       84
       89
        
       - [x] **Repository Tests:** Database operations

     
···

       112
       117
        
       ## ⚠️ Alpha Blockers (Must Complete Before Alpha Launch)

     

       113
       118
        
       

     

       114
       119
        
       ### Critical Missing Features

     

       115
       115
       -
       - [ ] **Community Blocking:** Users can block communities from their feeds

     

       116
       116
       -
         - Lexicon: ❌ Need new record type (extend `social.coves.actor.block` or create new)

     

       117
       117
       -
         - Service: ❌ No implementation (`BlockCommunity()` / `UnblockCommunity()`)

     

       118
       118
       -
         - Handler: ❌ No endpoints

     

       119
       119
       -
         - Repository: ❌ No methods

     

       120
       120
       -
         - **Impact:** Users have no way to hide unwanted communities

     

       120
       120
       +
       - [x] **Community Blocking:** ✅ COMPLETE - Users can block communities from their feeds

     

       121
       121
       +
         - ✅ Lexicon: `social.coves.community.block` record type implemented

     

       122
       122
       +
         - ✅ Service: `BlockCommunity()` / `UnblockCommunity()` / `GetBlockedCommunities()` / `IsBlocked()`

     

       123
       123
       +
         - ✅ Handlers: Block/unblock endpoints implemented

     

       124
       124
       +
         - ✅ Repository: Full blocking methods with indexing

     

       125
       125
       +
         - ✅ Jetstream Consumer: Real-time indexing of block events

     

       126
       126
       +
         - ✅ Integration tests: Comprehensive coverage

     

       127
       127
       +
         - **Completed:** 2025-10-16

     

       128
       128
       +
         - **Impact:** Users can now hide unwanted communities from their feeds

     

       121
       129
        
       

     

       122
       130
        
       ### ✅ Critical Infrastructure - RESOLVED (2025-10-16)

     

       123
       131
        
       - [x] **✅ Subscription Indexing & ContentVisibility - COMPLETE**

     
···

       159
       167
        
         - ✅ All E2E tests pass with real PDS authentication

     

       160
       168
        
         - **Completed:** 2025-10-16

     

       161
       169
        
       

     

       162
       162
       -
       - [ ] **Token Refresh Logic:** Auto-refresh expired PDS access tokens

     

       163
       163
       -
         - **Impact:** Communities break after ~2 hours when tokens expire

     

       164
       164
       -
         - **See:** [PRD_BACKLOG.md P1 Priority](docs/PRD_BACKLOG.md#L31-L38)

     

       170
       170
       +
       - [x] **Token Refresh Logic:** ✅ COMPLETE - Auto-refresh expired PDS access tokens

     

       171
       171
       +
         - ✅ Automatic token refresh before PDS operations (5-minute buffer)

     

       172
       172
       +
         - ✅ Password fallback when refresh tokens expire (~2 months)

     

       173
       173
       +
         - ✅ Concurrency-safe with per-community mutex locking

     

       174
       174
       +
         - ✅ Atomic credential updates in database

     

       175
       175
       +
         - ✅ Integration tests and structured logging

     

       176
       176
       +
         - **Completed:** 2025-10-17

     

       177
       177
       +
         - **See:** [IMPLEMENTATION_TOKEN_REFRESH.md](docs/IMPLEMENTATION_TOKEN_REFRESH.md)

     

       165
       178
        
       

     

       166
       179
        
       ---

     

       167
       180

internal/core/communities/interfaces.go

···

       12
       12
        
       	Update(ctx context.Context, community *Community) (*Community, error)

     

       13
       13
        
       	Delete(ctx context.Context, did string) error

     

       14
       14
        
       

     

       15
       15
       +
       	// Credential Management (for token refresh)

     

       16
       16
       +
       	UpdateCredentials(ctx context.Context, did, accessToken, refreshToken string) error

     

       17
       17
       +
       

     

       15
       18
        
       	// Listing & Search

     

       16
       19
        
       	List(ctx context.Context, req ListCommunitiesRequest) ([]*Community, int, error) // Returns communities + total count

     

       17
       20
        
       	Search(ctx context.Context, req SearchCommunitiesRequest) ([]*Community, int, error)

+167 -2

internal/core/communities/service.go

···

       12
       12
        
       	"net/http"

     

       13
       13
        
       	"regexp"

     

       14
       14
        
       	"strings"

     

       15
       15
       +
       	"sync"

     

       15
       16
        
       	"time"

     

       16
       17
        
       )

     

       17
       18
        
       

     
···

       20
       21
        
       var communityHandleRegex = regexp.MustCompile(`^([a-zA-Z0-9]([a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?\.)+[a-zA-Z]([a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?$`)

     

       21
       22
        
       

     

       22
       23
        
       type communityService struct {

     

       23
       23
       -
       	repo           Repository

     

       24
       24
       -
       	provisioner    *PDSAccountProvisioner

     

       24
       24
       +
       	// Interfaces and pointers first (better alignment)

     

       25
       25
       +
       	repo        Repository

     

       26
       26
       +
       	provisioner *PDSAccountProvisioner

     

       27
       27
       +
       

     

       28
       28
       +
       	// Token refresh concurrency control

     

       29
       29
       +
       	// Each community gets its own mutex to prevent concurrent refresh attempts

     

       30
       30
       +
       	refreshMutexes map[string]*sync.Mutex

     

       31
       31
       +
       

     

       32
       32
       +
       	// Strings

     

       25
       33
        
       	pdsURL         string

     

       26
       34
        
       	instanceDID    string

     

       27
       35
        
       	instanceDomain string

     

       28
       36
        
       	pdsAccessToken string

     

       37
       37
       +
       

     

       38
       38
       +
       	// Sync primitives last

     

       39
       39
       +
       	mapMutex sync.RWMutex // Protects refreshMutexes map itself

     

       29
       40
        
       }

     

       41
       41
       +
       

     

       42
       42
       +
       const (

     

       43
       43
       +
       	// Maximum recommended size for mutex cache (warning threshold, not hard limit)

     

       44
       44
       +
       	// At 10,000 entries × 16 bytes = ~160KB memory (negligible overhead)

     

       45
       45
       +
       	// Map can grow larger in production - even 100,000 entries = 1.6MB is acceptable

     

       46
       46
       +
       	maxMutexCacheSize = 10000

     

       47
       47
       +
       )

     

       30
       48
        
       

     

       31
       49
        
       // NewCommunityService creates a new community service

     

       32
       50
        
       func NewCommunityService(repo Repository, pdsURL, instanceDID, instanceDomain string, provisioner *PDSAccountProvisioner) Service {

     
···

       50
       68
        
       		instanceDID:    instanceDID,

     

       51
       69
        
       		instanceDomain: instanceDomain,

     

       52
       70
        
       		provisioner:    provisioner,

     

       71
       71
       +
       		refreshMutexes: make(map[string]*sync.Mutex),

     

       53
       72
        
       	}

     

       54
       73
        
       }

     

       55
       74
        
       

     
···

       235
       254
        
       		return nil, err

     

       236
       255
        
       	}

     

       237
       256
        
       

     

       257
       257
       +
       	// CRITICAL: Ensure fresh PDS access token before write operation

     

       258
       258
       +
       	// Community PDS tokens expire every ~2 hours and must be refreshed

     

       259
       259
       +
       	existing, err = s.ensureFreshToken(ctx, existing)

     

       260
       260
       +
       	if err != nil {

     

       261
       261
       +
       		return nil, fmt.Errorf("failed to ensure fresh credentials: %w", err)

     

       262
       262
       +
       	}

     

       263
       263
       +
       

     

       238
       264
        
       	// Authorization: verify user is the creator

     

       239
       265
        
       	// TODO(Communities-Auth): Add moderator check when moderation system is implemented

     

       240
       266
        
       	if existing.CreatedByDID != req.UpdatedByDID {

     
···

       347
       373
        
       	updated.UpdatedAt = time.Now()

     

       348
       374
        
       

     

       349
       375
        
       	return &updated, nil

     

       376
       376
       +
       }

     

       377
       377
       +
       

     

       378
       378
       +
       // getOrCreateRefreshMutex returns a mutex for the given community DID

     

       379
       379
       +
       // Thread-safe with read-lock fast path for existing entries

     

       380
       380
       +
       // SAFETY: Does NOT evict entries to avoid race condition where:

     

       381
       381
       +
       //  1. Thread A holds mutex for community-123

     

       382
       382
       +
       //  2. Thread B evicts community-123 from map

     

       383
       383
       +
       //  3. Thread C creates NEW mutex for community-123

     

       384
       384
       +
       //  4. Now two threads can refresh community-123 concurrently (mutex defeated!)

     

       385
       385
       +
       func (s *communityService) getOrCreateRefreshMutex(did string) *sync.Mutex {

     

       386
       386
       +
       	// Fast path: check if mutex already exists (read lock)

     

       387
       387
       +
       	s.mapMutex.RLock()

     

       388
       388
       +
       	mutex, exists := s.refreshMutexes[did]

     

       389
       389
       +
       	s.mapMutex.RUnlock()

     

       390
       390
       +
       

     

       391
       391
       +
       	if exists {

     

       392
       392
       +
       		return mutex

     

       393
       393
       +
       	}

     

       394
       394
       +
       

     

       395
       395
       +
       	// Slow path: create new mutex (write lock)

     

       396
       396
       +
       	s.mapMutex.Lock()

     

       397
       397
       +
       	defer s.mapMutex.Unlock()

     

       398
       398
       +
       

     

       399
       399
       +
       	// Double-check after acquiring write lock (another goroutine might have created it)

     

       400
       400
       +
       	mutex, exists = s.refreshMutexes[did]

     

       401
       401
       +
       	if exists {

     

       402
       402
       +
       		return mutex

     

       403
       403
       +
       	}

     

       404
       404
       +
       

     

       405
       405
       +
       	// Create new mutex

     

       406
       406
       +
       	mutex = &sync.Mutex{}

     

       407
       407
       +
       	s.refreshMutexes[did] = mutex

     

       408
       408
       +
       

     

       409
       409
       +
       	// SAFETY: No eviction to prevent race condition

     

       410
       410
       +
       	// Map will grow beyond maxMutexCacheSize but this is safer than evicting in-use mutexes

     

       411
       411
       +
       	if len(s.refreshMutexes) > maxMutexCacheSize {

     

       412
       412
       +
       		memoryKB := len(s.refreshMutexes) * 16 / 1024

     

       413
       413
       +
       		log.Printf("[TOKEN-REFRESH] WARN: Mutex cache size (%d) exceeds recommended limit (%d) - this is safe but may indicate high community churn. Memory usage: ~%d KB",

     

       414
       414
       +
       			len(s.refreshMutexes), maxMutexCacheSize, memoryKB)

     

       415
       415
       +
       	}

     

       416
       416
       +
       

     

       417
       417
       +
       	return mutex

     

       418
       418
       +
       }

     

       419
       419
       +
       

     

       420
       420
       +
       // ensureFreshToken checks if a community's access token needs refresh and updates if needed

     

       421
       421
       +
       // Returns updated community with fresh credentials (or original if no refresh needed)

     

       422
       422
       +
       // Thread-safe: Uses per-community mutex to prevent concurrent refresh attempts

     

       423
       423
       +
       func (s *communityService) ensureFreshToken(ctx context.Context, community *Community) (*Community, error) {

     

       424
       424
       +
       	// Get or create mutex for this specific community DID

     

       425
       425
       +
       	mutex := s.getOrCreateRefreshMutex(community.DID)

     

       426
       426
       +
       

     

       427
       427
       +
       	// Lock for this specific community (allows other communities to refresh concurrently)

     

       428
       428
       +
       	mutex.Lock()

     

       429
       429
       +
       	defer mutex.Unlock()

     

       430
       430
       +
       

     

       431
       431
       +
       	// Re-fetch community from DB (another goroutine might have already refreshed it)

     

       432
       432
       +
       	fresh, err := s.repo.GetByDID(ctx, community.DID)

     

       433
       433
       +
       	if err != nil {

     

       434
       434
       +
       		return nil, fmt.Errorf("failed to re-fetch community: %w", err)

     

       435
       435
       +
       	}

     

       436
       436
       +
       

     

       437
       437
       +
       	// Check if token needs refresh (5-minute buffer before expiration)

     

       438
       438
       +
       	needsRefresh, err := NeedsRefresh(fresh.PDSAccessToken)

     

       439
       439
       +
       	if err != nil {

     

       440
       440
       +
       		log.Printf("[TOKEN-REFRESH] Community: %s, Event: token_parse_failed, Error: %v", fresh.DID, err)

     

       441
       441
       +
       		return nil, fmt.Errorf("failed to check token expiration: %w", err)

     

       442
       442
       +
       	}

     

       443
       443
       +
       

     

       444
       444
       +
       	if !needsRefresh {

     

       445
       445
       +
       		// Token still valid, no refresh needed

     

       446
       446
       +
       		return fresh, nil

     

       447
       447
       +
       	}

     

       448
       448
       +
       

     

       449
       449
       +
       	log.Printf("[TOKEN-REFRESH] Community: %s, Event: token_refresh_started, Message: Access token expiring soon", fresh.DID)

     

       450
       450
       +
       

     

       451
       451
       +
       	// Attempt token refresh using refresh token

     

       452
       452
       +
       	newAccessToken, newRefreshToken, err := refreshPDSToken(ctx, fresh.PDSURL, fresh.PDSAccessToken, fresh.PDSRefreshToken)

     

       453
       453
       +
       	if err != nil {

     

       454
       454
       +
       		// Check if refresh token expired (need password fallback)

     

       455
       455
       +
       		if strings.Contains(err.Error(), "expired or invalid") {

     

       456
       456
       +
       			log.Printf("[TOKEN-REFRESH] Community: %s, Event: refresh_token_expired, Message: Re-authenticating with password", fresh.DID)

     

       457
       457
       +
       

     

       458
       458
       +
       			// Fallback: Re-authenticate with stored password

     

       459
       459
       +
       			newAccessToken, newRefreshToken, err = reauthenticateWithPassword(

     

       460
       460
       +
       				ctx,

     

       461
       461
       +
       				fresh.PDSURL,

     

       462
       462
       +
       				fresh.PDSEmail,

     

       463
       463
       +
       				fresh.PDSPassword, // Retrieved decrypted from DB

     

       464
       464
       +
       			)

     

       465
       465
       +
       			if err != nil {

     

       466
       466
       +
       				log.Printf("[TOKEN-REFRESH] Community: %s, Event: password_auth_failed, Error: %v", fresh.DID, err)

     

       467
       467
       +
       				return nil, fmt.Errorf("failed to re-authenticate community: %w", err)

     

       468
       468
       +
       			}

     

       469
       469
       +
       

     

       470
       470
       +
       			log.Printf("[TOKEN-REFRESH] Community: %s, Event: password_fallback_success, Message: Re-authenticated after refresh token expiry", fresh.DID)

     

       471
       471
       +
       		} else {

     

       472
       472
       +
       			log.Printf("[TOKEN-REFRESH] Community: %s, Event: refresh_failed, Error: %v", fresh.DID, err)

     

       473
       473
       +
       			return nil, fmt.Errorf("failed to refresh token: %w", err)

     

       474
       474
       +
       		}

     

       475
       475
       +
       	}

     

       476
       476
       +
       

     

       477
       477
       +
       	// CRITICAL: Update database with new tokens immediately

     

       478
       478
       +
       	// Refresh tokens are SINGLE-USE - old one is now invalid

     

       479
       479
       +
       	// Use retry logic to handle transient DB failures

     

       480
       480
       +
       	const maxRetries = 3

     

       481
       481
       +
       	var updateErr error

     

       482
       482
       +
       	for attempt := 0; attempt < maxRetries; attempt++ {

     

       483
       483
       +
       		updateErr = s.repo.UpdateCredentials(ctx, fresh.DID, newAccessToken, newRefreshToken)

     

       484
       484
       +
       		if updateErr == nil {

     

       485
       485
       +
       			break // Success

     

       486
       486
       +
       		}

     

       487
       487
       +
       

     

       488
       488
       +
       		log.Printf("[TOKEN-REFRESH] Community: %s, Event: db_update_retry, Attempt: %d/%d, Error: %v",

     

       489
       489
       +
       			fresh.DID, attempt+1, maxRetries, updateErr)

     

       490
       490
       +
       

     

       491
       491
       +
       		if attempt < maxRetries-1 {

     

       492
       492
       +
       			// Exponential backoff: 100ms, 200ms, 400ms

     

       493
       493
       +
       			backoff := time.Duration(1<<attempt) * 100 * time.Millisecond

     

       494
       494
       +
       			time.Sleep(backoff)

     

       495
       495
       +
       		}

     

       496
       496
       +
       	}

     

       497
       497
       +
       

     

       498
       498
       +
       	if updateErr != nil {

     

       499
       499
       +
       		// CRITICAL: Community is now locked out - old refresh token invalid, new one not saved

     

       500
       500
       +
       		log.Printf("[TOKEN-REFRESH] CRITICAL: Community %s LOCKED OUT - failed to persist credentials after %d retries: %v",

     

       501
       501
       +
       			fresh.DID, maxRetries, updateErr)

     

       502
       502
       +
       		// TODO: Send alert to monitoring system (add in Beta)

     

       503
       503
       +
       		return nil, fmt.Errorf("failed to persist refreshed credentials after %d retries (COMMUNITY LOCKED OUT): %w",

     

       504
       504
       +
       			maxRetries, updateErr)

     

       505
       505
       +
       	}

     

       506
       506
       +
       

     

       507
       507
       +
       	// Return updated community object with fresh tokens

     

       508
       508
       +
       	updatedCommunity := *fresh

     

       509
       509
       +
       	updatedCommunity.PDSAccessToken = newAccessToken

     

       510
       510
       +
       	updatedCommunity.PDSRefreshToken = newRefreshToken

     

       511
       511
       +
       

     

       512
       512
       +
       	log.Printf("[TOKEN-REFRESH] Community: %s, Event: token_refreshed, Message: Access token refreshed successfully", fresh.DID)

     

       513
       513
       +
       

     

       514
       514
       +
       	return &updatedCommunity, nil

     

       350
       515
        
       }

     

       351
       516
        
       

     

       352
       517
        
       // ListCommunities queries AppView DB for communities with filters

+99

internal/core/communities/token_refresh.go

···

       1
       1
       +
       package communities

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"context"

     

       5
       5
       +
       	"errors"

     

       6
       6
       +
       	"fmt"

     

       7
       7
       +
       	"strings"

     

       8
       8
       +
       

     

       9
       9
       +
       	"github.com/bluesky-social/indigo/api/atproto"

     

       10
       10
       +
       	"github.com/bluesky-social/indigo/xrpc"

     

       11
       11
       +
       )

     

       12
       12
       +
       

     

       13
       13
       +
       // refreshPDSToken exchanges a refresh token for new access and refresh tokens

     

       14
       14
       +
       // Uses com.atproto.server.refreshSession endpoint via Indigo SDK

     

       15
       15
       +
       // CRITICAL: Refresh tokens are single-use - old refresh token is revoked on success

     

       16
       16
       +
       func refreshPDSToken(ctx context.Context, pdsURL, currentAccessToken, refreshToken string) (newAccessToken, newRefreshToken string, err error) {

     

       17
       17
       +
       	if pdsURL == "" {

     

       18
       18
       +
       		return "", "", fmt.Errorf("PDS URL is required")

     

       19
       19
       +
       	}

     

       20
       20
       +
       	if refreshToken == "" {

     

       21
       21
       +
       		return "", "", fmt.Errorf("refresh token is required")

     

       22
       22
       +
       	}

     

       23
       23
       +
       

     

       24
       24
       +
       	// Create XRPC client with auth credentials

     

       25
       25
       +
       	// The refresh endpoint requires authentication with the refresh token

     

       26
       26
       +
       	client := &xrpc.Client{

     

       27
       27
       +
       		Host: pdsURL,

     

       28
       28
       +
       		Auth: &xrpc.AuthInfo{

     

       29
       29
       +
       			AccessJwt:  currentAccessToken, // Can be expired (not used for refresh auth)

     

       30
       30
       +
       			RefreshJwt: refreshToken,       // This is what authenticates the refresh request

     

       31
       31
       +
       		},

     

       32
       32
       +
       	}

     

       33
       33
       +
       

     

       34
       34
       +
       	// Call com.atproto.server.refreshSession

     

       35
       35
       +
       	output, err := atproto.ServerRefreshSession(ctx, client)

     

       36
       36
       +
       	if err != nil {

     

       37
       37
       +
       		// Check for expired refresh token (401 Unauthorized)

     

       38
       38
       +
       		// Try typed error first (more reliable), fallback to string check

     

       39
       39
       +
       		var xrpcErr *xrpc.Error

     

       40
       40
       +
       		if errors.As(err, &xrpcErr) && xrpcErr.StatusCode == 401 {

     

       41
       41
       +
       			return "", "", fmt.Errorf("refresh token expired or invalid (needs password re-auth)")

     

       42
       42
       +
       		}

     

       43
       43
       +
       

     

       44
       44
       +
       		// Fallback: string-based detection (in case error isn't wrapped as xrpc.Error)

     

       45
       45
       +
       		errStr := err.Error()

     

       46
       46
       +
       		if strings.Contains(errStr, "401") || strings.Contains(errStr, "Unauthorized") {

     

       47
       47
       +
       			return "", "", fmt.Errorf("refresh token expired or invalid (needs password re-auth)")

     

       48
       48
       +
       		}

     

       49
       49
       +
       

     

       50
       50
       +
       		return "", "", fmt.Errorf("failed to refresh session: %w", err)

     

       51
       51
       +
       	}

     

       52
       52
       +
       

     

       53
       53
       +
       	// Validate response

     

       54
       54
       +
       	if output.AccessJwt == "" || output.RefreshJwt == "" {

     

       55
       55
       +
       		return "", "", fmt.Errorf("refresh response missing tokens")

     

       56
       56
       +
       	}

     

       57
       57
       +
       

     

       58
       58
       +
       	return output.AccessJwt, output.RefreshJwt, nil

     

       59
       59
       +
       }

     

       60
       60
       +
       

     

       61
       61
       +
       // reauthenticateWithPassword creates a new session using stored credentials

     

       62
       62
       +
       // This is the fallback when refresh tokens expire (after ~2 months)

     

       63
       63
       +
       // Uses com.atproto.server.createSession endpoint via Indigo SDK

     

       64
       64
       +
       func reauthenticateWithPassword(ctx context.Context, pdsURL, email, password string) (accessToken, refreshToken string, err error) {

     

       65
       65
       +
       	if pdsURL == "" {

     

       66
       66
       +
       		return "", "", fmt.Errorf("PDS URL is required")

     

       67
       67
       +
       	}

     

       68
       68
       +
       	if email == "" {

     

       69
       69
       +
       		return "", "", fmt.Errorf("email is required")

     

       70
       70
       +
       	}

     

       71
       71
       +
       	if password == "" {

     

       72
       72
       +
       		return "", "", fmt.Errorf("password is required")

     

       73
       73
       +
       	}

     

       74
       74
       +
       

     

       75
       75
       +
       	// Create unauthenticated XRPC client

     

       76
       76
       +
       	client := &xrpc.Client{

     

       77
       77
       +
       		Host: pdsURL,

     

       78
       78
       +
       	}

     

       79
       79
       +
       

     

       80
       80
       +
       	// Prepare createSession input

     

       81
       81
       +
       	// The identifier can be either email or handle

     

       82
       82
       +
       	input := &atproto.ServerCreateSession_Input{

     

       83
       83
       +
       		Identifier: email,

     

       84
       84
       +
       		Password:   password,

     

       85
       85
       +
       	}

     

       86
       86
       +
       

     

       87
       87
       +
       	// Call com.atproto.server.createSession

     

       88
       88
       +
       	output, err := atproto.ServerCreateSession(ctx, client, input)

     

       89
       89
       +
       	if err != nil {

     

       90
       90
       +
       		return "", "", fmt.Errorf("failed to create session: %w", err)

     

       91
       91
       +
       	}

     

       92
       92
       +
       

     

       93
       93
       +
       	// Validate response

     

       94
       94
       +
       	if output.AccessJwt == "" || output.RefreshJwt == "" {

     

       95
       95
       +
       		return "", "", fmt.Errorf("createSession response missing tokens")

     

       96
       96
       +
       	}

     

       97
       97
       +
       

     

       98
       98
       +
       	return output.AccessJwt, output.RefreshJwt, nil

     

       99
       99
       +
       }

+66

internal/core/communities/token_utils.go

···

       1
       1
       +
       package communities

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"encoding/base64"

     

       5
       5
       +
       	"encoding/json"

     

       6
       6
       +
       	"fmt"

     

       7
       7
       +
       	"strings"

     

       8
       8
       +
       	"time"

     

       9
       9
       +
       )

     

       10
       10
       +
       

     

       11
       11
       +
       // parseJWTExpiration extracts the expiration time from a JWT access token

     

       12
       12
       +
       // This function does NOT verify the signature - it only parses the exp claim

     

       13
       13
       +
       // atproto access tokens use standard JWT format with 'exp' claim (Unix timestamp)

     

       14
       14
       +
       func parseJWTExpiration(token string) (time.Time, error) {

     

       15
       15
       +
       	// Remove "Bearer " prefix if present

     

       16
       16
       +
       	token = strings.TrimPrefix(token, "Bearer ")

     

       17
       17
       +
       	token = strings.TrimSpace(token)

     

       18
       18
       +
       

     

       19
       19
       +
       	// JWT format: header.payload.signature

     

       20
       20
       +
       	parts := strings.Split(token, ".")

     

       21
       21
       +
       	if len(parts) != 3 {

     

       22
       22
       +
       		return time.Time{}, fmt.Errorf("invalid JWT format: expected 3 parts, got %d", len(parts))

     

       23
       23
       +
       	}

     

       24
       24
       +
       

     

       25
       25
       +
       	// Decode payload (second part) - use RawURLEncoding (no padding)

     

       26
       26
       +
       	payload, err := base64.RawURLEncoding.DecodeString(parts[1])

     

       27
       27
       +
       	if err != nil {

     

       28
       28
       +
       		return time.Time{}, fmt.Errorf("failed to decode JWT payload: %w", err)

     

       29
       29
       +
       	}

     

       30
       30
       +
       

     

       31
       31
       +
       	// Extract exp claim (Unix timestamp)

     

       32
       32
       +
       	var claims struct {

     

       33
       33
       +
       		Exp int64 `json:"exp"` // Expiration time (seconds since Unix epoch)

     

       34
       34
       +
       	}

     

       35
       35
       +
       	if err := json.Unmarshal(payload, &claims); err != nil {

     

       36
       36
       +
       		return time.Time{}, fmt.Errorf("failed to parse JWT claims: %w", err)

     

       37
       37
       +
       	}

     

       38
       38
       +
       

     

       39
       39
       +
       	if claims.Exp == 0 {

     

       40
       40
       +
       		return time.Time{}, fmt.Errorf("JWT missing 'exp' claim")

     

       41
       41
       +
       	}

     

       42
       42
       +
       

     

       43
       43
       +
       	// Convert Unix timestamp to time.Time

     

       44
       44
       +
       	return time.Unix(claims.Exp, 0), nil

     

       45
       45
       +
       }

     

       46
       46
       +
       

     

       47
       47
       +
       // NeedsRefresh checks if an access token should be refreshed

     

       48
       48
       +
       // Returns true if the token expires within the next 5 minutes (or is already expired)

     

       49
       49
       +
       // Uses a 5-minute buffer to ensure we refresh before actual expiration

     

       50
       50
       +
       func NeedsRefresh(accessToken string) (bool, error) {

     

       51
       51
       +
       	if accessToken == "" {

     

       52
       52
       +
       		return false, fmt.Errorf("access token is empty")

     

       53
       53
       +
       	}

     

       54
       54
       +
       

     

       55
       55
       +
       	expiration, err := parseJWTExpiration(accessToken)

     

       56
       56
       +
       	if err != nil {

     

       57
       57
       +
       		return false, fmt.Errorf("failed to parse token expiration: %w", err)

     

       58
       58
       +
       	}

     

       59
       59
       +
       

     

       60
       60
       +
       	// Refresh if token expires within 5 minutes

     

       61
       61
       +
       	// This prevents service interruptions from expired tokens

     

       62
       62
       +
       	bufferTime := 5 * time.Minute

     

       63
       63
       +
       	expiresWithinBuffer := time.Now().Add(bufferTime).After(expiration)

     

       64
       64
       +
       

     

       65
       65
       +
       	return expiresWithinBuffer, nil

     

       66
       66
       +
       }

+26

internal/db/postgres/community_repo.go

···

       291
       291
        
       	return community, nil

     

       292
       292
        
       }

     

       293
       293
        
       

     

       294
       294
       +
       // UpdateCredentials atomically updates community's PDS access and refresh tokens

     

       295
       295
       +
       // CRITICAL: Both tokens must be updated together because refresh tokens are single-use

     

       296
       296
       +
       // After a successful token refresh, the old refresh token is immediately revoked by the PDS

     

       297
       297
       +
       func (r *postgresCommunityRepo) UpdateCredentials(ctx context.Context, did, accessToken, refreshToken string) error {

     

       298
       298
       +
       	query := `

     

       299
       299
       +
       		UPDATE communities

     

       300
       300
       +
       		SET

     

       301
       301
       +
       			pds_access_token_encrypted = pgp_sym_encrypt($2, (SELECT encode(key_data, 'hex') FROM encryption_keys WHERE id = 1)),

     

       302
       302
       +
       			pds_refresh_token_encrypted = pgp_sym_encrypt($3, (SELECT encode(key_data, 'hex') FROM encryption_keys WHERE id = 1)),

     

       303
       303
       +
       			updated_at = NOW()

     

       304
       304
       +
       		WHERE did = $1

     

       305
       305
       +
       		RETURNING did`

     

       306
       306
       +
       

     

       307
       307
       +
       	var returnedDID string

     

       308
       308
       +
       	err := r.db.QueryRowContext(ctx, query, did, accessToken, refreshToken).Scan(&returnedDID)

     

       309
       309
       +
       

     

       310
       310
       +
       	if err == sql.ErrNoRows {

     

       311
       311
       +
       		return communities.ErrCommunityNotFound

     

       312
       312
       +
       	}

     

       313
       313
       +
       	if err != nil {

     

       314
       314
       +
       		return fmt.Errorf("failed to update credentials: %w", err)

     

       315
       315
       +
       	}

     

       316
       316
       +
       

     

       317
       317
       +
       	return nil

     

       318
       318
       +
       }

     

       319
       319
       +
       

     

       294
       320
        
       // Delete removes a community from the database

     

       295
       321
        
       func (r *postgresCommunityRepo) Delete(ctx context.Context, did string) error {

     

       296
       322
        
       	query := `DELETE FROM communities WHERE did = $1`

+243

tests/integration/token_refresh_test.go

···

       1
       1
       +
       package integration

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"Coves/internal/core/communities"

     

       5
       5
       +
       	"Coves/internal/db/postgres"

     

       6
       6
       +
       	"context"

     

       7
       7
       +
       	"encoding/base64"

     

       8
       8
       +
       	"encoding/json"

     

       9
       9
       +
       	"fmt"

     

       10
       10
       +
       	"testing"

     

       11
       11
       +
       	"time"

     

       12
       12
       +
       )

     

       13
       13
       +
       

     

       14
       14
       +
       // TestTokenRefresh_ExpirationDetection tests the NeedsRefresh function with various token states

     

       15
       15
       +
       func TestTokenRefresh_ExpirationDetection(t *testing.T) {

     

       16
       16
       +
       	tests := []struct {

     

       17
       17
       +
       		name          string

     

       18
       18
       +
       		token         string

     

       19
       19
       +
       		shouldRefresh bool

     

       20
       20
       +
       		expectError   bool

     

       21
       21
       +
       	}{

     

       22
       22
       +
       		{

     

       23
       23
       +
       			name:          "Token expiring in 2 minutes (should refresh)",

     

       24
       24
       +
       			token:         createTestJWT(time.Now().Add(2 * time.Minute)),

     

       25
       25
       +
       			shouldRefresh: true,

     

       26
       26
       +
       			expectError:   false,

     

       27
       27
       +
       		},

     

       28
       28
       +
       		{

     

       29
       29
       +
       			name:          "Token expiring in 10 minutes (should not refresh)",

     

       30
       30
       +
       			token:         createTestJWT(time.Now().Add(10 * time.Minute)),

     

       31
       31
       +
       			shouldRefresh: false,

     

       32
       32
       +
       			expectError:   false,

     

       33
       33
       +
       		},

     

       34
       34
       +
       		{

     

       35
       35
       +
       			name:          "Token already expired (should refresh)",

     

       36
       36
       +
       			token:         createTestJWT(time.Now().Add(-1 * time.Minute)),

     

       37
       37
       +
       			shouldRefresh: true,

     

       38
       38
       +
       			expectError:   false,

     

       39
       39
       +
       		},

     

       40
       40
       +
       		{

     

       41
       41
       +
       			name:          "Token expiring in exactly 5 minutes (should not refresh - edge case)",

     

       42
       42
       +
       			token:         createTestJWT(time.Now().Add(6 * time.Minute)),

     

       43
       43
       +
       			shouldRefresh: false,

     

       44
       44
       +
       			expectError:   false,

     

       45
       45
       +
       		},

     

       46
       46
       +
       		{

     

       47
       47
       +
       			name:          "Token expiring in 4 minutes (should refresh)",

     

       48
       48
       +
       			token:         createTestJWT(time.Now().Add(4 * time.Minute)),

     

       49
       49
       +
       			shouldRefresh: true,

     

       50
       50
       +
       			expectError:   false,

     

       51
       51
       +
       		},

     

       52
       52
       +
       		{

     

       53
       53
       +
       			name:          "Invalid JWT format (too many parts)",

     

       54
       54
       +
       			token:         "not.a.valid.jwt.format.extra",

     

       55
       55
       +
       			shouldRefresh: false,

     

       56
       56
       +
       			expectError:   true,

     

       57
       57
       +
       		},

     

       58
       58
       +
       		{

     

       59
       59
       +
       			name:          "Invalid JWT format (too few parts)",

     

       60
       60
       +
       			token:         "invalid.token",

     

       61
       61
       +
       			shouldRefresh: false,

     

       62
       62
       +
       			expectError:   true,

     

       63
       63
       +
       		},

     

       64
       64
       +
       		{

     

       65
       65
       +
       			name:          "Empty token",

     

       66
       66
       +
       			token:         "",

     

       67
       67
       +
       			shouldRefresh: false,

     

       68
       68
       +
       			expectError:   true,

     

       69
       69
       +
       		},

     

       70
       70
       +
       	}

     

       71
       71
       +
       

     

       72
       72
       +
       	for _, tt := range tests {

     

       73
       73
       +
       		t.Run(tt.name, func(t *testing.T) {

     

       74
       74
       +
       			result, err := communities.NeedsRefresh(tt.token)

     

       75
       75
       +
       

     

       76
       76
       +
       			if tt.expectError {

     

       77
       77
       +
       				if err == nil {

     

       78
       78
       +
       					t.Errorf("Expected error but got none")

     

       79
       79
       +
       				}

     

       80
       80
       +
       				return

     

       81
       81
       +
       			}

     

       82
       82
       +
       

     

       83
       83
       +
       			if err != nil {

     

       84
       84
       +
       				t.Fatalf("Unexpected error: %v", err)

     

       85
       85
       +
       			}

     

       86
       86
       +
       

     

       87
       87
       +
       			if result != tt.shouldRefresh {

     

       88
       88
       +
       				t.Errorf("Expected NeedsRefresh=%v, got %v", tt.shouldRefresh, result)

     

       89
       89
       +
       			}

     

       90
       90
       +
       		})

     

       91
       91
       +
       	}

     

       92
       92
       +
       }

     

       93
       93
       +
       

     

       94
       94
       +
       // TestTokenRefresh_UpdateCredentials tests the repository UpdateCredentials method

     

       95
       95
       +
       func TestTokenRefresh_UpdateCredentials(t *testing.T) {

     

       96
       96
       +
       	if testing.Short() {

     

       97
       97
       +
       		t.Skip("skipping integration test in short mode")

     

       98
       98
       +
       	}

     

       99
       99
       +
       

     

       100
       100
       +
       	ctx := context.Background()

     

       101
       101
       +
       	db := setupTestDB(t)

     

       102
       102
       +
       	defer func() {

     

       103
       103
       +
       		if err := db.Close(); err != nil {

     

       104
       104
       +
       			t.Logf("Failed to close database: %v", err)

     

       105
       105
       +
       		}

     

       106
       106
       +
       	}()

     

       107
       107
       +
       

     

       108
       108
       +
       	repo := postgres.NewCommunityRepository(db)

     

       109
       109
       +
       

     

       110
       110
       +
       	// Create a test community first

     

       111
       111
       +
       	community := &communities.Community{

     

       112
       112
       +
       		DID:             "did:plc:test123",

     

       113
       113
       +
       		Handle:          "test.communities.coves.social",

     

       114
       114
       +
       		Name:            "test",

     

       115
       115
       +
       		OwnerDID:        "did:plc:test123",

     

       116
       116
       +
       		CreatedByDID:    "did:plc:creator",

     

       117
       117
       +
       		HostedByDID:     "did:web:coves.social",

     

       118
       118
       +
       		PDSEmail:        "test@coves.social",

     

       119
       119
       +
       		PDSPassword:     "original-password",

     

       120
       120
       +
       		PDSAccessToken:  "original-access-token",

     

       121
       121
       +
       		PDSRefreshToken: "original-refresh-token",

     

       122
       122
       +
       		PDSURL:          "http://localhost:3001",

     

       123
       123
       +
       		Visibility:      "public",

     

       124
       124
       +
       		MemberCount:     0,

     

       125
       125
       +
       		SubscriberCount: 0,

     

       126
       126
       +
       		RecordURI:       "at://did:plc:test123/social.coves.community.profile/self",

     

       127
       127
       +
       		RecordCID:       "bafytest",

     

       128
       128
       +
       	}

     

       129
       129
       +
       

     

       130
       130
       +
       	created, err := repo.Create(ctx, community)

     

       131
       131
       +
       	if err != nil {

     

       132
       132
       +
       		t.Fatalf("Failed to create test community: %v", err)

     

       133
       133
       +
       	}

     

       134
       134
       +
       

     

       135
       135
       +
       	// Update credentials

     

       136
       136
       +
       	newAccessToken := "new-access-token-12345"

     

       137
       137
       +
       	newRefreshToken := "new-refresh-token-67890"

     

       138
       138
       +
       

     

       139
       139
       +
       	err = repo.UpdateCredentials(ctx, created.DID, newAccessToken, newRefreshToken)

     

       140
       140
       +
       	if err != nil {

     

       141
       141
       +
       		t.Fatalf("UpdateCredentials failed: %v", err)

     

       142
       142
       +
       	}

     

       143
       143
       +
       

     

       144
       144
       +
       	// Verify tokens were updated

     

       145
       145
       +
       	retrieved, err := repo.GetByDID(ctx, created.DID)

     

       146
       146
       +
       	if err != nil {

     

       147
       147
       +
       		t.Fatalf("Failed to retrieve community: %v", err)

     

       148
       148
       +
       	}

     

       149
       149
       +
       

     

       150
       150
       +
       	if retrieved.PDSAccessToken != newAccessToken {

     

       151
       151
       +
       		t.Errorf("Access token not updated: expected %q, got %q", newAccessToken, retrieved.PDSAccessToken)

     

       152
       152
       +
       	}

     

       153
       153
       +
       

     

       154
       154
       +
       	if retrieved.PDSRefreshToken != newRefreshToken {

     

       155
       155
       +
       		t.Errorf("Refresh token not updated: expected %q, got %q", newRefreshToken, retrieved.PDSRefreshToken)

     

       156
       156
       +
       	}

     

       157
       157
       +
       

     

       158
       158
       +
       	// Verify password unchanged (should not be affected)

     

       159
       159
       +
       	if retrieved.PDSPassword != "original-password" {

     

       160
       160
       +
       		t.Errorf("Password should remain unchanged: expected %q, got %q", "original-password", retrieved.PDSPassword)

     

       161
       161
       +
       	}

     

       162
       162
       +
       }

     

       163
       163
       +
       

     

       164
       164
       +
       // TestTokenRefresh_E2E_UpdateAfterTokenRefresh tests end-to-end token refresh during community update

     

       165
       165
       +
       func TestTokenRefresh_E2E_UpdateAfterTokenRefresh(t *testing.T) {

     

       166
       166
       +
       	if testing.Short() {

     

       167
       167
       +
       		t.Skip("skipping E2E test in short mode")

     

       168
       168
       +
       	}

     

       169
       169
       +
       

     

       170
       170
       +
       	ctx := context.Background()

     

       171
       171
       +
       	db := setupTestDB(t)

     

       172
       172
       +
       	defer func() {

     

       173
       173
       +
       		if err := db.Close(); err != nil {

     

       174
       174
       +
       			t.Logf("Failed to close database: %v", err)

     

       175
       175
       +
       		}

     

       176
       176
       +
       	}()

     

       177
       177
       +
       

     

       178
       178
       +
       	// This test requires a real PDS for token refresh

     

       179
       179
       +
       	// For now, we'll test the token expiration detection logic

     

       180
       180
       +
       	// Full E2E test with PDS will be added in manual testing phase

     

       181
       181
       +
       

     

       182
       182
       +
       	repo := postgres.NewCommunityRepository(db)

     

       183
       183
       +
       

     

       184
       184
       +
       	// Create community with expiring token

     

       185
       185
       +
       	expiringToken := createTestJWT(time.Now().Add(2 * time.Minute)) // Expires in 2 minutes

     

       186
       186
       +
       

     

       187
       187
       +
       	community := &communities.Community{

     

       188
       188
       +
       		DID:             "did:plc:expiring123",

     

       189
       189
       +
       		Handle:          "expiring.communities.coves.social",

     

       190
       190
       +
       		Name:            "expiring",

     

       191
       191
       +
       		OwnerDID:        "did:plc:expiring123",

     

       192
       192
       +
       		CreatedByDID:    "did:plc:creator",

     

       193
       193
       +
       		HostedByDID:     "did:web:coves.social",

     

       194
       194
       +
       		PDSEmail:        "expiring@coves.social",

     

       195
       195
       +
       		PDSPassword:     "test-password",

     

       196
       196
       +
       		PDSAccessToken:  expiringToken,

     

       197
       197
       +
       		PDSRefreshToken: "test-refresh-token",

     

       198
       198
       +
       		PDSURL:          "http://localhost:3001",

     

       199
       199
       +
       		Visibility:      "public",

     

       200
       200
       +
       		RecordURI:       "at://did:plc:expiring123/social.coves.community.profile/self",

     

       201
       201
       +
       		RecordCID:       "bafytest",

     

       202
       202
       +
       	}

     

       203
       203
       +
       

     

       204
       204
       +
       	created, err := repo.Create(ctx, community)

     

       205
       205
       +
       	if err != nil {

     

       206
       206
       +
       		t.Fatalf("Failed to create community: %v", err)

     

       207
       207
       +
       	}

     

       208
       208
       +
       

     

       209
       209
       +
       	// Verify token is stored

     

       210
       210
       +
       	if created.PDSAccessToken != expiringToken {

     

       211
       211
       +
       		t.Errorf("Token not stored correctly")

     

       212
       212
       +
       	}

     

       213
       213
       +
       

     

       214
       214
       +
       	t.Logf("✅ Created community with expiring token (expires in 2 minutes)")

     

       215
       215
       +
       	t.Logf("   Community DID: %s", created.DID)

     

       216
       216
       +
       	t.Logf("   NOTE: Full refresh flow requires real PDS - tested in manual/staging tests")

     

       217
       217
       +
       }

     

       218
       218
       +
       

     

       219
       219
       +
       // Helper: Create a test JWT with specific expiration time

     

       220
       220
       +
       func createTestJWT(expiresAt time.Time) string {

     

       221
       221
       +
       	// Create JWT header

     

       222
       222
       +
       	header := map[string]interface{}{

     

       223
       223
       +
       		"alg": "ES256",

     

       224
       224
       +
       		"typ": "JWT",

     

       225
       225
       +
       	}

     

       226
       226
       +
       	headerJSON, _ := json.Marshal(header)

     

       227
       227
       +
       	headerB64 := base64.RawURLEncoding.EncodeToString(headerJSON)

     

       228
       228
       +
       

     

       229
       229
       +
       	// Create JWT payload with expiration

     

       230
       230
       +
       	payload := map[string]interface{}{

     

       231
       231
       +
       		"sub": "did:plc:test",

     

       232
       232
       +
       		"iss": "https://pds.example.com",

     

       233
       233
       +
       		"exp": expiresAt.Unix(),

     

       234
       234
       +
       		"iat": time.Now().Unix(),

     

       235
       235
       +
       	}

     

       236
       236
       +
       	payloadJSON, _ := json.Marshal(payload)

     

       237
       237
       +
       	payloadB64 := base64.RawURLEncoding.EncodeToString(payloadJSON)

     

       238
       238
       +
       

     

       239
       239
       +
       	// Fake signature (not verified in our tests)

     

       240
       240
       +
       	signature := base64.RawURLEncoding.EncodeToString([]byte("fake-signature"))

     

       241
       241
       +
       

     

       242
       242
       +
       	return fmt.Sprintf("%s.%s.%s", headerB64, payloadB64, signature)

     

       243
       243
       +
       }