commit 934f4e867fe386857524fe245348872394eae529 · bretton.dev/coves

bretton.dev / coves

A community based topic aggregation platform built on atproto

fix(api): Add error logging to community XRPC handlers

Add logging for internal server errors in community XRPC handlers to
aid debugging during development. Internal errors are now logged before
returning generic error responses to clients.

Changes:
- Add log import to errors.go
- Log actual error details when returning InternalServerError
- Add TODO comment to migrate to proper structured logger

Rationale:
During E2E testing, internal errors were being silently swallowed making
debugging difficult. This change logs the actual error while still
returning safe generic error messages to clients.

Security note:
- Internal error details are NOT exposed to clients
- Logging is for server-side debugging only
- Generic "InternalServerError" message still returned to clients

TODO: Replace log.Printf with structured logger (e.g., zerolog/zap)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

bretton.dev 2 months ago 934f4e86 8e183593

options

unified split

Changed files

+4 -1

internal

api

handlers

community

errors.go

+4 -1

internal/api/handlers/community/errors.go

···

       2
       2
        
       

     

       3
       3
        
       import (

     

       4
       4
        
       	"encoding/json"

     

       5
       5
       +
       	"log"

     

       5
       6
        
       	"net/http"

     

       6
       7
        
       

     

       7
       8
        
       	"Coves/internal/core/communities"

     
···

       41
       42
        
       	case err == communities.ErrMemberBanned:

     

       42
       43
        
       		writeError(w, http.StatusForbidden, "Blocked", "You are blocked from this community")

     

       43
       44
        
       	default:

     

       44
       44
       -
       		// Internal server error

     

       45
       45
       +
       		// Internal server error - log the actual error for debugging

     

       46
       46
       +
       		// TODO: Use proper logger instead of log package

     

       47
       47
       +
       		log.Printf("XRPC handler error: %v", err)

     

       45
       48
        
       		writeError(w, http.StatusInternalServerError, "InternalServerError", "An internal error occurred")

     

       46
       49
        
       	}

     

       47
       50
        
       }