commit 993e5a5f3ffcb6adbf26fb7102c095334f918d8c · bretton.dev/coves

+54
docs/PRD_BACKLOG.md
···

       418
       418
        
       

     

       419
       419
        
       ---

     

       420
       420
        
       

     

       421
       421
       +
       ### Post comment_count Reconciliation Missing

     

       422
       422
       +
       **Added:** 2025-11-04 | **Effort:** 2-3 hours | **Priority:** ALPHA BLOCKER

     

       423
       423
       +
       

     

       424
       424
       +
       **Problem:**

     

       425
       425
       +
       When comments arrive before their parent post is indexed (common with cross-repo Jetstream ordering), the post's `comment_count` is never reconciled. Later, when the post consumer indexes the post, there's no logic to count pre-existing comments. This causes posts to have permanently stale `comment_count` values.

     

       426
       426
       +
       

     

       427
       427
       +
       **End-User Impact:**

     

       428
       428
       +
       - 🔴 Posts show "0 comments" when they actually have comments

     

       429
       429
       +
       - ❌ Broken engagement signals (users don't know there are discussions)

     

       430
       430
       +
       - ❌ UI inconsistency (thread page shows comments, but counter says "0")

     

       431
       431
       +
       - ⚠️ Users may not click into posts thinking they're empty

     

       432
       432
       +
       - 📉 Reduced engagement due to misleading counters

     

       433
       433
       +
       

     

       434
       434
       +
       **Root Cause:**

     

       435
       435
       +
       - Comment consumer updates post counts when processing comment events ([comment_consumer.go:323-343](../internal/atproto/jetstream/comment_consumer.go#L323-L343))

     

       436
       436
       +
       - If comment arrives BEFORE post is indexed, update query returns 0 rows (only logs warning)

     

       437
       437
       +
       - When post consumer later indexes the post, it sets `comment_count = 0` with NO reconciliation

     

       438
       438
       +
       - Comments already exist in DB, but post never "discovers" them

     

       439
       439
       +
       

     

       440
       440
       +
       **Solution:**

     

       441
       441
       +
       Post consumer MUST implement the same reconciliation pattern as comment consumer (see [comment_consumer.go:292-305](../internal/atproto/jetstream/comment_consumer.go#L292-L305)):

     

       442
       442
       +
       

     

       443
       443
       +
       ```go

     

       444
       444
       +
       // After inserting new post, reconcile comment_count for out-of-order comments

     

       445
       445
       +
       reconcileQuery := `

     

       446
       446
       +
           UPDATE posts

     

       447
       447
       +
           SET comment_count = (

     

       448
       448
       +
               SELECT COUNT(*)

     

       449
       449
       +
               FROM comments c

     

       450
       450
       +
               WHERE c.parent_uri = $1 AND c.deleted_at IS NULL

     

       451
       451
       +
           )

     

       452
       452
       +
           WHERE id = $2

     

       453
       453
       +
       `

     

       454
       454
       +
       _, reconcileErr := tx.ExecContext(ctx, reconcileQuery, postURI, postID)

     

       455
       455
       +
       ```

     

       456
       456
       +
       

     

       457
       457
       +
       **Affected Operations:**

     

       458
       458
       +
       - Post indexing from Jetstream ([post_consumer.go](../internal/atproto/jetstream/post_consumer.go))

     

       459
       459
       +
       - Any cross-repo event ordering (community DID ≠ author DID)

     

       460
       460
       +
       

     

       461
       461
       +
       **Current Status:**

     

       462
       462
       +
       - 🔴 Issue documented with FIXME(P1) comment at [comment_consumer.go:311-321](../internal/atproto/jetstream/comment_consumer.go#L311-L321)

     

       463
       463
       +
       - ⚠️ Test demonstrating limitation exists: `TestCommentConsumer_PostCountReconciliation_Limitation`

     

       464
       464
       +
       - 📋 Fix required in post consumer (out of scope for comment system PR)

     

       465
       465
       +
       

     

       466
       466
       +
       **Files to Modify:**

     

       467
       467
       +
       - `internal/atproto/jetstream/post_consumer.go` - Add reconciliation after post creation

     

       468
       468
       +
       - `tests/integration/post_consumer_test.go` - Add test for out-of-order comment reconciliation

     

       469
       469
       +
       

     

       470
       470
       +
       **Similar Issue Fixed:**

     

       471
       471
       +
       - ✅ Comment reply_count reconciliation - Fixed in comment system implementation (2025-11-04)

     

       472
       472
       +
       

     

       473
       473
       +
       ---

     

       474
       474
       +
       

     

       421
       475
        
       ## 🔴 P1.5: Federation Blockers (Beta Launch)

     

       422
       476
        
       

     

       423
       477
        
       ### Cross-PDS Write-Forward Support for Community Service