commit b1f9959c8ba58d508feaec349279289de197ab9e · bretton.dev/coves

+35 -52

docs/PRD_BACKLOG.md

···

       265
        
       ```

     

       266
        
       

     

       267
        
       **Implementation Plan:**

     

       268
       -
       1. ✅ **Phase 1 (Alpha Blocker):** Fix post creation endpoint

     

       269
       -
          - Update handler validation in `internal/api/handlers/post/create.go`

     

       270
       -
          - Update service validation in `internal/core/posts/service.go`

     

       271
       -
          - Add integration tests for handle resolution in post creation

     

       272
        
       

     

       273
        
       2. 📋 **Phase 2 (Beta):** Fix subscription endpoints

     

       274
        
          - Update subscribe/unsubscribe handlers

     

       275
        
          - Add tests for handle resolution in subscriptions

     

       276
        
       

     

       277
       -
       3. 📋 **Phase 3 (Beta):** Fix block endpoints

     

       278
       -
          - Update lexicon from `"format": "did"` → `"format": "at-identifier"`

     

       279
       -
          - Update block/unblock handlers

     

       280
       -
          - Add tests for handle resolution in blocking

     

       0
        
       
     

       281
        
       

     

       282
       -
       **Files to Modify (Phase 1 - Post Creation):**

     

       283
       -
       - `internal/api/handlers/post/create.go` - Remove DID validation, add handle resolution

     

       284
       -
       - `internal/core/posts/service.go` - Remove DID validation, add handle resolution

     

       285
       -
       - `internal/core/posts/interfaces.go` - Add `CommunityService` dependency

     

       286
       -
       - `cmd/server/main.go` - Pass community service to post service constructor

     

       287
       -
       - `tests/integration/post_creation_test.go` - Add handle resolution test cases

     

       288
        
       

     

       289
        
       **Existing Infrastructure:**

     

       290
       -
       ✅ `ResolveCommunityIdentifier()` already implemented at [service.go:843](../internal/core/communities/service.go#L843)

     

       291
        
       ✅ `identity.CachingResolver` handles bidirectional verification and caching

     

       292
        
       ✅ Supports both handle (`!name.communities.instance.com`) and DID formats

     

       293
        
       

     

       294
        
       **Current Status:**

     

       295
       -
       - ⚠️ **BLOCKING POST CREATION PR**: Identified as P0 issue in code review

     

       296
       -
       - 📋 Phase 1 (post creation) - To be implemented immediately

     

       297
       -
       - 📋 Phase 2-3 (other endpoints) - Deferred to Beta

     

       298
        
       

     

       299
        
       ---

     

       300
        
       

     
···

       418
        
       

     

       419
        
       ---

     

       420
        
       

     

       421
       -
       ### Post comment_count Reconciliation Missing

     

       422
       -
       **Added:** 2025-11-04 | **Effort:** 2-3 hours | **Priority:** ALPHA BLOCKER

     

       423
        
       

     

       424
        
       **Problem:**

     

       425
       -
       When comments arrive before their parent post is indexed (common with cross-repo Jetstream ordering), the post's `comment_count` is never reconciled. Later, when the post consumer indexes the post, there's no logic to count pre-existing comments. This causes posts to have permanently stale `comment_count` values.

     

       426
        
       

     

       427
       -
       **End-User Impact:**

     

       428
       -
       - 🔴 Posts show "0 comments" when they actually have comments

     

       429
       -
       - ❌ Broken engagement signals (users don't know there are discussions)

     

       430
       -
       - ❌ UI inconsistency (thread page shows comments, but counter says "0")

     

       431
       -
       - ⚠️ Users may not click into posts thinking they're empty

     

       432
       -
       - 📉 Reduced engagement due to misleading counters

     

       433
       -
       

     

       434
       -
       **Root Cause:**

     

       435
       -
       - Comment consumer updates post counts when processing comment events ([comment_consumer.go:323-343](../internal/atproto/jetstream/comment_consumer.go#L323-L343))

     

       436
       -
       - If comment arrives BEFORE post is indexed, update query returns 0 rows (only logs warning)

     

       437
       -
       - When post consumer later indexes the post, it sets `comment_count = 0` with NO reconciliation

     

       438
       -
       - Comments already exist in DB, but post never "discovers" them

     

       439
       -
       

     

       440
       -
       **Solution:**

     

       441
       -
       Post consumer MUST implement the same reconciliation pattern as comment consumer (see [comment_consumer.go:292-305](../internal/atproto/jetstream/comment_consumer.go#L292-L305)):

     

       442
        
       

     

       0
        
       
     

       443
        
       ```go

     

       444
       -
       // After inserting new post, reconcile comment_count for out-of-order comments

     

       445
        
       reconcileQuery := `

     

       446
        
           UPDATE posts

     

       447
        
           SET comment_count = (

     
···

       451
        
           )

     

       452
        
           WHERE id = $2

     

       453
        
       `

     

       454
       -
       _, reconcileErr := tx.ExecContext(ctx, reconcileQuery, postURI, postID)

     

       455
        
       ```

     

       456
        
       

     

       457
       -
       **Affected Operations:**

     

       458
       -
       - Post indexing from Jetstream ([post_consumer.go](../internal/atproto/jetstream/post_consumer.go))

     

       459
       -
       - Any cross-repo event ordering (community DID ≠ author DID)

     

       460
        
       

     

       461
       -
       **Current Status:**

     

       462
       -
       - 🔴 Issue documented with FIXME(P1) comment at [comment_consumer.go:311-321](../internal/atproto/jetstream/comment_consumer.go#L311-L321)

     

       463
       -
       - ⚠️ Test demonstrating limitation exists: `TestCommentConsumer_PostCountReconciliation_Limitation`

     

       464
       -
       - 📋 Fix required in post consumer (out of scope for comment system PR)

     

       465
       -
       

     

       466
       -
       **Files to Modify:**

     

       467
       -
       - `internal/atproto/jetstream/post_consumer.go` - Add reconciliation after post creation

     

       468
       -
       - `tests/integration/post_consumer_test.go` - Add test for out-of-order comment reconciliation

     

       469
       -
       

     

       470
       -
       **Similar Issue Fixed:**

     

       471
       -
       - ✅ Comment reply_count reconciliation - Fixed in comment system implementation (2025-11-04)

     

       472
        
       

     

       473
        
       ---

     

       474

···

       265
        
       ```

     

       266
        
       

     

       267
        
       **Implementation Plan:**

     

       268
       +
       1. ✅ **Phase 1 (Alpha Blocker):** Fix post creation endpoint - COMPLETE (2025-10-18)

     

       269
       +
          - Post creation already uses `ResolveCommunityIdentifier()` at [service.go:100](../internal/core/posts/service.go#L100)

     

       270
       +
          - Supports handles, DIDs, and scoped formats

     

       0
        
       
     

       271
        
       

     

       272
        
       2. 📋 **Phase 2 (Beta):** Fix subscription endpoints

     

       273
        
          - Update subscribe/unsubscribe handlers

     

       274
        
          - Add tests for handle resolution in subscriptions

     

       275
        
       

     

       276
       +
       3. ✅ **Phase 3 (Beta):** Fix block endpoints - COMPLETE (2025-11-16)

     

       277
       +
          - Updated block/unblock handlers to use `ResolveCommunityIdentifier()`

     

       278
       +
          - Accepts handles (`@gaming.community.coves.social`), DIDs, and scoped format (`!gaming@coves.social`)

     

       279
       +
          - Added comprehensive tests: [block_handle_resolution_test.go](../tests/integration/block_handle_resolution_test.go)

     

       280
       +
          - All 7 test cases passing

     

       281
        
       

     

       282
       +
       **Files Modified (Phase 3 - Block Endpoints):**

     

       283
       +
       - `internal/api/handlers/community/block.go` - Added `ResolveCommunityIdentifier()` calls

     

       284
       +
       - `tests/integration/block_handle_resolution_test.go` - Comprehensive test coverage

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       285
        
       

     

       286
        
       **Existing Infrastructure:**

     

       287
       +
       ✅ `ResolveCommunityIdentifier()` already implemented at [service.go:852](../internal/core/communities/service.go#L852)

     

       288
        
       ✅ `identity.CachingResolver` handles bidirectional verification and caching

     

       289
        
       ✅ Supports both handle (`!name.communities.instance.com`) and DID formats

     

       290
        
       

     

       291
        
       **Current Status:**

     

       292
       +
       - ✅ Phase 1 (post creation) - Already implemented

     

       293
       +
       - 📋 Phase 2 (subscriptions) - Deferred to Beta (lower priority)

     

       294
       +
       - ✅ Phase 3 (block endpoints) - COMPLETE (2025-11-16)

     

       295
        
       

     

       296
        
       ---

     

       297
        
       

     
···

       415
        
       

     

       416
        
       ---

     

       417
        
       

     

       418
       +
       ### ✅ Post comment_count Reconciliation - COMPLETE

     

       419
       +
       **Added:** 2025-11-04 | **Completed:** 2025-11-16 | **Effort:** 2 hours | **Status:** ✅ DONE

     

       420
        
       

     

       421
        
       **Problem:**

     

       422
       +
       When comments arrive before their parent post is indexed (common with cross-repo Jetstream ordering), the post's `comment_count` was never reconciled, causing posts to show permanently stale "0 comments" counters.

     

       423
        
       

     

       424
       +
       **Solution Implemented:**

     

       425
       +
       - ✅ Post consumer reconciliation logic WAS already implemented at [post_consumer.go:210-226](../internal/atproto/jetstream/post_consumer.go#L210-L226)

     

       426
       +
       - ✅ Reconciliation query counts pre-existing comments when indexing new posts

     

       427
       +
       - ✅ Comprehensive test suite added: [post_consumer_test.go](../tests/integration/post_consumer_test.go)

     

       428
       +
         - Single comment before post

     

       429
       +
         - Multiple comments before post

     

       430
       +
         - Mixed before/after ordering

     

       431
       +
         - Idempotent indexing preserves counts

     

       432
       +
       - ✅ Updated outdated FIXME comment at [comment_consumer.go:362](../internal/atproto/jetstream/comment_consumer.go#L362)

     

       433
       +
       - ✅ All 4 test cases passing

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       434
        
       

     

       435
       +
       **Implementation:**

     

       436
        
       ```go

     

       437
       +
       // Post consumer reconciliation (lines 210-226)

     

       438
        
       reconcileQuery := `

     

       439
        
           UPDATE posts

     

       440
        
           SET comment_count = (

     
···

       444
        
           )

     

       445
        
           WHERE id = $2

     

       446
        
       `

     

       447
       +
       _, reconcileErr := tx.ExecContext(ctx, reconcileQuery, post.URI, postID)

     

       448
        
       ```

     

       449
        
       

     

       450
       +
       **Files Modified:**

     

       451
       +
       - `internal/atproto/jetstream/comment_consumer.go` - Updated documentation

     

       452
       +
       - `tests/integration/post_consumer_test.go` - Added comprehensive test coverage

     

       453
        
       

     

       454
       +
       **Impact:** ✅ Post comment counters are now accurate regardless of Jetstream event ordering

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       455
        
       

     

       456
        
       ---

     

       457

+45 -44

internal/api/handlers/community/block.go

···

       6
        
       	"encoding/json"

     

       7
        
       	"log"

     

       8
        
       	"net/http"

     

       9
       -
       	"regexp"

     

       10
       -
       	"strings"

     

       11
       -
       )

     

       12
       -
       

     

       13
       -
       // Package-level compiled regex for DID validation (compiled once at startup)

     

       14
       -
       var (

     

       15
       -
       	didRegex = regexp.MustCompile(`^did:(plc|web):[a-zA-Z0-9._:%-]+$`)

     

       16
        
       )

     

       17
        
       

     

       18
        
       // BlockHandler handles community blocking operations

     
···

       30
        
       // HandleBlock blocks a community

     

       31
        
       // POST /xrpc/social.coves.community.blockCommunity

     

       32
        
       //

     

       33
       -
       // Request body: { "community": "did:plc:xxx" }

     

       34
       -
       // Note: Per lexicon spec, only DIDs are accepted (not handles).

     

       35
       -
       // The block record's "subject" field requires format: "did".

     

       36
        
       func (h *BlockHandler) HandleBlock(w http.ResponseWriter, r *http.Request) {

     

       37
        
       	if r.Method != http.MethodPost {

     

       38
        
       		http.Error(w, "Method not allowed", http.StatusMethodNotAllowed)

     
···

       41
        
       

     

       42
        
       	// Parse request body

     

       43
        
       	var req struct {

     

       44
       -
       		Community string `json:"community"` // DID only (per lexicon)

     

       45
        
       	}

     

       46
        
       

     

       47
        
       	if err := json.NewDecoder(r.Body).Decode(&req); err != nil {

     
···

       54
        
       		return

     

       55
        
       	}

     

       56
        
       

     

       57
       -
       	// Validate DID format (per lexicon: format must be "did")

     

       58
       -
       	if !strings.HasPrefix(req.Community, "did:") {

     

       59
       -
       		writeError(w, http.StatusBadRequest, "InvalidRequest",

     

       60
       -
       			"community must be a DID (did:plc:... or did:web:...)")

     

       61
       -
       		return

     

       62
       -
       	}

     

       63
       -
       

     

       64
       -
       	// Validate DID format with regex: did:method:identifier

     

       65
       -
       	if !didRegex.MatchString(req.Community) {

     

       66
       -
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "invalid DID format")

     

       67
       -
       		return

     

       68
       -
       	}

     

       69
       -
       

     

       70
        
       	// Extract authenticated user DID and access token from request context (injected by auth middleware)

     

       71
        
       	userDID := middleware.GetUserDID(r)

     

       72
        
       	if userDID == "" {

     
···

       80
        
       		return

     

       81
        
       	}

     

       82
        
       

     

       83
       -
       	// Block via service (write-forward to PDS)

     

       84
       -
       	block, err := h.service.BlockCommunity(r.Context(), userDID, userAccessToken, req.Community)

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       85
        
       	if err != nil {

     

       86
        
       		handleServiceError(w, err)

     

       87
        
       		return

     
···

       105
        
       // HandleUnblock unblocks a community

     

       106
        
       // POST /xrpc/social.coves.community.unblockCommunity

     

       107
        
       //

     

       108
       -
       // Request body: { "community": "did:plc:xxx" }

     

       109
       -
       // Note: Per lexicon spec, only DIDs are accepted (not handles).

     

       110
        
       func (h *BlockHandler) HandleUnblock(w http.ResponseWriter, r *http.Request) {

     

       111
        
       	if r.Method != http.MethodPost {

     

       112
        
       		http.Error(w, "Method not allowed", http.StatusMethodNotAllowed)

     
···

       115
        
       

     

       116
        
       	// Parse request body

     

       117
        
       	var req struct {

     

       118
       -
       		Community string `json:"community"` // DID only (per lexicon)

     

       119
        
       	}

     

       120
        
       

     

       121
        
       	if err := json.NewDecoder(r.Body).Decode(&req); err != nil {

     
···

       128
        
       		return

     

       129
        
       	}

     

       130
        
       

     

       131
       -
       	// Validate DID format (per lexicon: format must be "did")

     

       132
       -
       	if !strings.HasPrefix(req.Community, "did:") {

     

       133
       -
       		writeError(w, http.StatusBadRequest, "InvalidRequest",

     

       134
       -
       			"community must be a DID (did:plc:... or did:web:...)")

     

       135
       -
       		return

     

       136
       -
       	}

     

       137
       -
       

     

       138
       -
       	// Validate DID format with regex: did:method:identifier

     

       139
       -
       	if !didRegex.MatchString(req.Community) {

     

       140
       -
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "invalid DID format")

     

       141
       -
       		return

     

       142
       -
       	}

     

       143
       -
       

     

       144
        
       	// Extract authenticated user DID and access token from request context (injected by auth middleware)

     

       145
        
       	userDID := middleware.GetUserDID(r)

     

       146
        
       	if userDID == "" {

     
···

       154
        
       		return

     

       155
        
       	}

     

       156
        
       

     

       157
       -
       	// Unblock via service (delete record on PDS)

     

       158
       -
       	err := h.service.UnblockCommunity(r.Context(), userDID, userAccessToken, req.Community)

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       159
        
       	if err != nil {

     

       160
        
       		handleServiceError(w, err)

     

       161
        
       		return

···

       6
        
       	"encoding/json"

     

       7
        
       	"log"

     

       8
        
       	"net/http"

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       9
        
       )

     

       10
        
       

     

       11
        
       // BlockHandler handles community blocking operations

     
···

       23
        
       // HandleBlock blocks a community

     

       24
        
       // POST /xrpc/social.coves.community.blockCommunity

     

       25
        
       //

     

       26
       +
       // Request body: { "community": "at-identifier" }

     

       27
       +
       // Accepts DIDs (did:plc:xxx), handles (@gaming.community.coves.social), or scoped (!gaming@coves.social)

     

       28
       +
       // The block record's "subject" field requires format: "did", so we resolve the identifier internally.

     

       29
        
       func (h *BlockHandler) HandleBlock(w http.ResponseWriter, r *http.Request) {

     

       30
        
       	if r.Method != http.MethodPost {

     

       31
        
       		http.Error(w, "Method not allowed", http.StatusMethodNotAllowed)

     
···

       34
        
       

     

       35
        
       	// Parse request body

     

       36
        
       	var req struct {

     

       37
       +
       		Community string `json:"community"` // at-identifier (DID or handle)

     

       38
        
       	}

     

       39
        
       

     

       40
        
       	if err := json.NewDecoder(r.Body).Decode(&req); err != nil {

     
···

       47
        
       		return

     

       48
        
       	}

     

       49
        
       

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       50
        
       	// Extract authenticated user DID and access token from request context (injected by auth middleware)

     

       51
        
       	userDID := middleware.GetUserDID(r)

     

       52
        
       	if userDID == "" {

     
···

       60
        
       		return

     

       61
        
       	}

     

       62
        
       

     

       63
       +
       	// Resolve community identifier (handle or DID) to DID

     

       64
       +
       	// This allows users to block by handle: @gaming.community.coves.social or !gaming@coves.social

     

       65
       +
       	communityDID, err := h.service.ResolveCommunityIdentifier(r.Context(), req.Community)

     

       66
       +
       	if err != nil {

     

       67
       +
       		if communities.IsNotFound(err) {

     

       68
       +
       			writeError(w, http.StatusNotFound, "CommunityNotFound", "Community not found")

     

       69
       +
       			return

     

       70
       +
       		}

     

       71
       +
       		if communities.IsValidationError(err) {

     

       72
       +
       			writeError(w, http.StatusBadRequest, "InvalidRequest", err.Error())

     

       73
       +
       			return

     

       74
       +
       		}

     

       75
       +
       		log.Printf("Failed to resolve community identifier %s: %v", req.Community, err)

     

       76
       +
       		writeError(w, http.StatusInternalServerError, "InternalError", "Failed to resolve community")

     

       77
       +
       		return

     

       78
       +
       	}

     

       79
       +
       

     

       80
       +
       	// Block via service (write-forward to PDS) using resolved DID

     

       81
       +
       	block, err := h.service.BlockCommunity(r.Context(), userDID, userAccessToken, communityDID)

     

       82
        
       	if err != nil {

     

       83
        
       		handleServiceError(w, err)

     

       84
        
       		return

     
···

       102
        
       // HandleUnblock unblocks a community

     

       103
        
       // POST /xrpc/social.coves.community.unblockCommunity

     

       104
        
       //

     

       105
       +
       // Request body: { "community": "at-identifier" }

     

       106
       +
       // Accepts DIDs (did:plc:xxx), handles (@gaming.community.coves.social), or scoped (!gaming@coves.social)

     

       107
        
       func (h *BlockHandler) HandleUnblock(w http.ResponseWriter, r *http.Request) {

     

       108
        
       	if r.Method != http.MethodPost {

     

       109
        
       		http.Error(w, "Method not allowed", http.StatusMethodNotAllowed)

     
···

       112
        
       

     

       113
        
       	// Parse request body

     

       114
        
       	var req struct {

     

       115
       +
       		Community string `json:"community"` // at-identifier (DID or handle)

     

       116
        
       	}

     

       117
        
       

     

       118
        
       	if err := json.NewDecoder(r.Body).Decode(&req); err != nil {

     
···

       125
        
       		return

     

       126
        
       	}

     

       127
        
       

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       128
        
       	// Extract authenticated user DID and access token from request context (injected by auth middleware)

     

       129
        
       	userDID := middleware.GetUserDID(r)

     

       130
        
       	if userDID == "" {

     
···

       138
        
       		return

     

       139
        
       	}

     

       140
        
       

     

       141
       +
       	// Resolve community identifier (handle or DID) to DID

     

       142
       +
       	// This allows users to unblock by handle: @gaming.community.coves.social or !gaming@coves.social

     

       143
       +
       	communityDID, err := h.service.ResolveCommunityIdentifier(r.Context(), req.Community)

     

       144
       +
       	if err != nil {

     

       145
       +
       		if communities.IsNotFound(err) {

     

       146
       +
       			writeError(w, http.StatusNotFound, "CommunityNotFound", "Community not found")

     

       147
       +
       			return

     

       148
       +
       		}

     

       149
       +
       		if communities.IsValidationError(err) {

     

       150
       +
       			writeError(w, http.StatusBadRequest, "InvalidRequest", err.Error())

     

       151
       +
       			return

     

       152
       +
       		}

     

       153
       +
       		log.Printf("Failed to resolve community identifier %s: %v", req.Community, err)

     

       154
       +
       		writeError(w, http.StatusInternalServerError, "InternalError", "Failed to resolve community")

     

       155
       +
       		return

     

       156
       +
       	}

     

       157
       +
       

     

       158
       +
       	// Unblock via service (delete record on PDS) using resolved DID

     

       159
       +
       	err = h.service.UnblockCommunity(r.Context(), userDID, userAccessToken, communityDID)

     

       160
        
       	if err != nil {

     

       161
        
       		handleServiceError(w, err)

     

       162
        
       		return

+6 -10

internal/atproto/jetstream/comment_consumer.go

···

       359
        
       	// Parent could be a post (increment comment_count) or a comment (increment reply_count)

     

       360
        
       	// Parse collection from parent URI to determine target table

     

       361
        
       	//

     

       362
       -
       	// FIXME(P1): Post comment_count reconciliation not implemented

     

       363
       -
       	// When a comment arrives before its parent post (common with cross-repo Jetstream ordering),

     

       364
       -
       	// the post update below returns 0 rows and we only log a warning. Later, when the post

     

       365
       -
       	// is indexed by the post consumer, there's NO reconciliation logic to count pre-existing

     

       366
       -
       	// comments. This causes posts to have permanently stale comment_count values.

     

       367
       -
       	//

     

       368
       -
       	// FIX REQUIRED: Post consumer MUST implement the same reconciliation pattern as comments

     

       369
       -
       	// (see lines 292-305 above). When indexing a new post, count any comments where parent_uri

     

       370
       -
       	// matches the post URI and set comment_count accordingly.

     

       371
        
       	//

     

       372
       -
       	// Test demonstrating issue: TestCommentConsumer_PostCountReconciliation_Limitation

     

       373
        
       	collection := utils.ExtractCollectionFromURI(comment.ParentURI)

     

       374
        
       

     

       375
        
       	var updateQuery string

···

       359
        
       	// Parent could be a post (increment comment_count) or a comment (increment reply_count)

     

       360
        
       	// Parse collection from parent URI to determine target table

     

       361
        
       	//

     

       362
       +
       	// NOTE: Post comment_count reconciliation IS implemented in post_consumer.go:210-226

     

       363
       +
       	// When a comment arrives before its parent post, the post update below returns 0 rows

     

       364
       +
       	// and we log a warning. Later, when the post is indexed, the post consumer reconciles

     

       365
       +
       	// comment_count by counting all pre-existing comments. This ensures accurate counts

     

       366
       +
       	// despite out-of-order Jetstream event delivery.

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       367
        
       	//

     

       368
       +
       	// Test coverage: TestPostConsumer_CommentCountReconciliation in post_consumer_test.go

     

       369
        
       	collection := utils.ExtractCollectionFromURI(comment.ParentURI)

     

       370
        
       

     

       371
        
       	var updateQuery string

+3 -2

internal/core/unfurl/providers.go

···

       108
        
       

     

       109
        
       // normalizeURL converts protocol-relative URLs to HTTPS

     

       110
        
       // Examples:

     

       111
       -
       //   "//example.com/image.jpg" -> "https://example.com/image.jpg"

     

       112
       -
       //   "https://example.com/image.jpg" -> "https://example.com/image.jpg" (unchanged)

     

       0
        
       
     

       113
        
       func normalizeURL(urlStr string) string {

     

       114
        
       	if strings.HasPrefix(urlStr, "//") {

     

       115
        
       		return "https:" + urlStr

···

       108
        
       

     

       109
        
       // normalizeURL converts protocol-relative URLs to HTTPS

     

       110
        
       // Examples:

     

       111
       +
       //

     

       112
       +
       //	"//example.com/image.jpg" -> "https://example.com/image.jpg"

     

       113
       +
       //	"https://example.com/image.jpg" -> "https://example.com/image.jpg" (unchanged)

     

       114
        
       func normalizeURL(urlStr string) string {

     

       115
        
       	if strings.HasPrefix(urlStr, "//") {

     

       116
        
       		return "https:" + urlStr

-1

internal/core/unfurl/providers_test.go

+337

tests/integration/block_handle_resolution_test.go

···

       1
       +
       package integration

     

       2
       +
       

     

       3
       +
       import (

     

       4
       +
       	"Coves/internal/api/handlers/community"

     

       5
       +
       	"Coves/internal/api/middleware"

     

       6
       +
       	"Coves/internal/core/communities"

     

       7
       +
       	postgresRepo "Coves/internal/db/postgres"

     

       8
       +
       	"bytes"

     

       9
       +
       	"context"

     

       10
       +
       	"encoding/json"

     

       11
       +
       	"fmt"

     

       12
       +
       	"net/http"

     

       13
       +
       	"net/http/httptest"

     

       14
       +
       	"testing"

     

       15
       +
       )

     

       16
       +
       

     

       17
       +
       // TestBlockHandler_HandleResolution tests that the block handler accepts handles

     

       18
       +
       // in addition to DIDs and resolves them correctly

     

       19
       +
       func TestBlockHandler_HandleResolution(t *testing.T) {

     

       20
       +
       	db := setupTestDB(t)

     

       21
       +
       	defer func() {

     

       22
       +
       		if err := db.Close(); err != nil {

     

       23
       +
       			t.Logf("Failed to close database: %v", err)

     

       24
       +
       		}

     

       25
       +
       	}()

     

       26
       +
       

     

       27
       +
       	ctx := context.Background()

     

       28
       +
       

     

       29
       +
       	// Set up repositories and services

     

       30
       +
       	communityRepo := postgresRepo.NewCommunityRepository(db)

     

       31
       +
       	communityService := communities.NewCommunityService(

     

       32
       +
       		communityRepo,

     

       33
       +
       		getTestPDSURL(),

     

       34
       +
       		getTestInstanceDID(),

     

       35
       +
       		"coves.social",

     

       36
       +
       		nil, // No PDS HTTP client for this test

     

       37
       +
       	)

     

       38
       +
       

     

       39
       +
       	blockHandler := community.NewBlockHandler(communityService)

     

       40
       +
       

     

       41
       +
       	// Create test community

     

       42
       +
       	testCommunity, err := createFeedTestCommunity(db, ctx, "gaming", "owner.test")

     

       43
       +
       	if err != nil {

     

       44
       +
       		t.Fatalf("Failed to create test community: %v", err)

     

       45
       +
       	}

     

       46
       +
       

     

       47
       +
       	// Get community to check its handle

     

       48
       +
       	comm, err := communityRepo.GetByDID(ctx, testCommunity)

     

       49
       +
       	if err != nil {

     

       50
       +
       		t.Fatalf("Failed to get community: %v", err)

     

       51
       +
       	}

     

       52
       +
       

     

       53
       +
       	t.Run("Block with canonical handle", func(t *testing.T) {

     

       54
       +
       		// Note: This test verifies resolution logic, not actual blocking

     

       55
       +
       		// Actual blocking would require auth middleware and PDS interaction

     

       56
       +
       

     

       57
       +
       		reqBody := map[string]string{

     

       58
       +
       			"community": comm.Handle, // Use handle instead of DID

     

       59
       +
       		}

     

       60
       +
       		reqJSON, _ := json.Marshal(reqBody)

     

       61
       +
       

     

       62
       +
       		req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.community.blockCommunity", bytes.NewBuffer(reqJSON))

     

       63
       +
       		req.Header.Set("Content-Type", "application/json")

     

       64
       +
       

     

       65
       +
       		// Add mock auth context (normally done by middleware)

     

       66
       +
       		// For this test, we'll skip auth and just test resolution

     

       67
       +
       		// The handler will fail at auth check, but that's OK - we're testing the resolution path

     

       68
       +
       

     

       69
       +
       		w := httptest.NewRecorder()

     

       70
       +
       		blockHandler.HandleBlock(w, req)

     

       71
       +
       

     

       72
       +
       		// We expect 401 (no auth) but verify the error is NOT "Community not found"

     

       73
       +
       		// If handle resolution worked, we'd get past that validation

     

       74
       +
       		resp := w.Result()

     

       75
       +
       		defer resp.Body.Close()

     

       76
       +
       

     

       77
       +
       		if resp.StatusCode == http.StatusNotFound {

     

       78
       +
       			t.Errorf("Handle resolution failed - got 404 CommunityNotFound")

     

       79
       +
       		}

     

       80
       +
       

     

       81
       +
       		// Expected: 401 Unauthorized (because we didn't add auth context)

     

       82
       +
       		if resp.StatusCode != http.StatusUnauthorized {

     

       83
       +
       			var errorResp map[string]interface{}

     

       84
       +
       			json.NewDecoder(resp.Body).Decode(&errorResp)

     

       85
       +
       			t.Logf("Response status: %d, body: %+v", resp.StatusCode, errorResp)

     

       86
       +
       		}

     

       87
       +
       	})

     

       88
       +
       

     

       89
       +
       	t.Run("Block with @-prefixed handle", func(t *testing.T) {

     

       90
       +
       		reqBody := map[string]string{

     

       91
       +
       			"community": "@" + comm.Handle, // Use @-prefixed handle

     

       92
       +
       		}

     

       93
       +
       		reqJSON, _ := json.Marshal(reqBody)

     

       94
       +
       

     

       95
       +
       		req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.community.blockCommunity", bytes.NewBuffer(reqJSON))

     

       96
       +
       		req.Header.Set("Content-Type", "application/json")

     

       97
       +
       

     

       98
       +
       		w := httptest.NewRecorder()

     

       99
       +
       		blockHandler.HandleBlock(w, req)

     

       100
       +
       

     

       101
       +
       		resp := w.Result()

     

       102
       +
       		defer resp.Body.Close()

     

       103
       +
       

     

       104
       +
       		if resp.StatusCode == http.StatusNotFound {

     

       105
       +
       			t.Errorf("@-prefixed handle resolution failed - got 404 CommunityNotFound")

     

       106
       +
       		}

     

       107
       +
       	})

     

       108
       +
       

     

       109
       +
       	t.Run("Block with scoped format", func(t *testing.T) {

     

       110
       +
       		// Format: !name@instance

     

       111
       +
       		reqBody := map[string]string{

     

       112
       +
       			"community": fmt.Sprintf("!%s@coves.social", "gaming"),

     

       113
       +
       		}

     

       114
       +
       		reqJSON, _ := json.Marshal(reqBody)

     

       115
       +
       

     

       116
       +
       		req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.community.blockCommunity", bytes.NewBuffer(reqJSON))

     

       117
       +
       		req.Header.Set("Content-Type", "application/json")

     

       118
       +
       

     

       119
       +
       		w := httptest.NewRecorder()

     

       120
       +
       		blockHandler.HandleBlock(w, req)

     

       121
       +
       

     

       122
       +
       		resp := w.Result()

     

       123
       +
       		defer resp.Body.Close()

     

       124
       +
       

     

       125
       +
       		if resp.StatusCode == http.StatusNotFound {

     

       126
       +
       			t.Errorf("Scoped format resolution failed - got 404 CommunityNotFound")

     

       127
       +
       		}

     

       128
       +
       	})

     

       129
       +
       

     

       130
       +
       	t.Run("Block with DID still works", func(t *testing.T) {

     

       131
       +
       		reqBody := map[string]string{

     

       132
       +
       			"community": testCommunity, // Use DID directly

     

       133
       +
       		}

     

       134
       +
       		reqJSON, _ := json.Marshal(reqBody)

     

       135
       +
       

     

       136
       +
       		req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.community.blockCommunity", bytes.NewBuffer(reqJSON))

     

       137
       +
       		req.Header.Set("Content-Type", "application/json")

     

       138
       +
       

     

       139
       +
       		w := httptest.NewRecorder()

     

       140
       +
       		blockHandler.HandleBlock(w, req)

     

       141
       +
       

     

       142
       +
       		resp := w.Result()

     

       143
       +
       		defer resp.Body.Close()

     

       144
       +
       

     

       145
       +
       		if resp.StatusCode == http.StatusNotFound {

     

       146
       +
       			t.Errorf("DID resolution failed - got 404 CommunityNotFound")

     

       147
       +
       		}

     

       148
       +
       

     

       149
       +
       		// Expected: 401 Unauthorized (no auth context)

     

       150
       +
       		if resp.StatusCode != http.StatusUnauthorized {

     

       151
       +
       			t.Logf("Unexpected status: %d (expected 401)", resp.StatusCode)

     

       152
       +
       		}

     

       153
       +
       	})

     

       154
       +
       

     

       155
       +
       	t.Run("Block with malformed identifier returns 400", func(t *testing.T) {

     

       156
       +
       		// Test validation errors are properly mapped to 400 Bad Request

     

       157
       +
       		// We add auth context so we can get past the auth check and test resolution validation

     

       158
       +
       		testCases := []struct {

     

       159
       +
       			name       string

     

       160
       +
       			identifier string

     

       161
       +
       			wantError  string

     

       162
       +
       		}{

     

       163
       +
       			{

     

       164
       +
       				name:       "scoped without @ symbol",

     

       165
       +
       				identifier: "!gaming",

     

       166
       +
       				wantError:  "scoped identifier must include @ symbol",

     

       167
       +
       			},

     

       168
       +
       			{

     

       169
       +
       				name:       "scoped with wrong instance",

     

       170
       +
       				identifier: "!gaming@wrong.social",

     

       171
       +
       				wantError:  "community is not hosted on this instance",

     

       172
       +
       			},

     

       173
       +
       			{

     

       174
       +
       				name:       "scoped with empty name",

     

       175
       +
       				identifier: "!@coves.social",

     

       176
       +
       				wantError:  "community name cannot be empty",

     

       177
       +
       			},

     

       178
       +
       			{

     

       179
       +
       				name:       "plain string without dots",

     

       180
       +
       				identifier: "gaming",

     

       181
       +
       				wantError:  "must be a DID, handle, or scoped identifier",

     

       182
       +
       			},

     

       183
       +
       		}

     

       184
       +
       

     

       185
       +
       		for _, tc := range testCases {

     

       186
       +
       			t.Run(tc.name, func(t *testing.T) {

     

       187
       +
       				reqBody := map[string]string{

     

       188
       +
       					"community": tc.identifier,

     

       189
       +
       				}

     

       190
       +
       				reqJSON, _ := json.Marshal(reqBody)

     

       191
       +
       

     

       192
       +
       				req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.community.blockCommunity", bytes.NewBuffer(reqJSON))

     

       193
       +
       				req.Header.Set("Content-Type", "application/json")

     

       194
       +
       

     

       195
       +
       				// Add auth context so we get past auth checks and test resolution validation

     

       196
       +
       				ctx := context.WithValue(req.Context(), middleware.UserDIDKey, "did:plc:test123")

     

       197
       +
       				ctx = context.WithValue(ctx, middleware.UserAccessToken, "test-token")

     

       198
       +
       				req = req.WithContext(ctx)

     

       199
       +
       

     

       200
       +
       				w := httptest.NewRecorder()

     

       201
       +
       				blockHandler.HandleBlock(w, req)

     

       202
       +
       

     

       203
       +
       				resp := w.Result()

     

       204
       +
       				defer resp.Body.Close()

     

       205
       +
       

     

       206
       +
       				// Should return 400 Bad Request for validation errors

     

       207
       +
       				if resp.StatusCode != http.StatusBadRequest {

     

       208
       +
       					t.Errorf("Expected 400 Bad Request, got %d", resp.StatusCode)

     

       209
       +
       				}

     

       210
       +
       

     

       211
       +
       				var errorResp map[string]interface{}

     

       212
       +
       				json.NewDecoder(resp.Body).Decode(&errorResp)

     

       213
       +
       

     

       214
       +
       				if errorCode, ok := errorResp["error"].(string); !ok || errorCode != "InvalidRequest" {

     

       215
       +
       					t.Errorf("Expected error code 'InvalidRequest', got %v", errorResp["error"])

     

       216
       +
       				}

     

       217
       +
       

     

       218
       +
       				// Verify error message contains expected validation text

     

       219
       +
       				if errMsg, ok := errorResp["message"].(string); ok {

     

       220
       +
       					if errMsg == "" {

     

       221
       +
       						t.Errorf("Expected non-empty error message")

     

       222
       +
       					}

     

       223
       +
       				}

     

       224
       +
       			})

     

       225
       +
       		}

     

       226
       +
       	})

     

       227
       +
       

     

       228
       +
       	t.Run("Block with invalid handle", func(t *testing.T) {

     

       229
       +
       		// Note: Without auth context, this will return 401 before reaching resolution

     

       230
       +
       		// To properly test invalid handle → 404, we'd need to add auth middleware context

     

       231
       +
       		// For now, we just verify that the resolution code doesn't crash

     

       232
       +
       		reqBody := map[string]string{

     

       233
       +
       			"community": "nonexistent.community.coves.social",

     

       234
       +
       		}

     

       235
       +
       		reqJSON, _ := json.Marshal(reqBody)

     

       236
       +
       

     

       237
       +
       		req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.community.blockCommunity", bytes.NewBuffer(reqJSON))

     

       238
       +
       		req.Header.Set("Content-Type", "application/json")

     

       239
       +
       

     

       240
       +
       		w := httptest.NewRecorder()

     

       241
       +
       		blockHandler.HandleBlock(w, req)

     

       242
       +
       

     

       243
       +
       		resp := w.Result()

     

       244
       +
       		defer resp.Body.Close()

     

       245
       +
       

     

       246
       +
       		// Expected: 401 (auth check happens before resolution)

     

       247
       +
       		// In a real scenario with auth, invalid handle would return 404

     

       248
       +
       		if resp.StatusCode != http.StatusUnauthorized && resp.StatusCode != http.StatusNotFound {

     

       249
       +
       			t.Errorf("Expected 401 or 404, got %d", resp.StatusCode)

     

       250
       +
       		}

     

       251
       +
       	})

     

       252
       +
       }

     

       253
       +
       

     

       254
       +
       // TestUnblockHandler_HandleResolution tests that the unblock handler accepts handles

     

       255
       +
       func TestUnblockHandler_HandleResolution(t *testing.T) {

     

       256
       +
       	db := setupTestDB(t)

     

       257
       +
       	defer func() {

     

       258
       +
       		if err := db.Close(); err != nil {

     

       259
       +
       			t.Logf("Failed to close database: %v", err)

     

       260
       +
       		}

     

       261
       +
       	}()

     

       262
       +
       

     

       263
       +
       	ctx := context.Background()

     

       264
       +
       

     

       265
       +
       	// Set up repositories and services

     

       266
       +
       	communityRepo := postgresRepo.NewCommunityRepository(db)

     

       267
       +
       	communityService := communities.NewCommunityService(

     

       268
       +
       		communityRepo,

     

       269
       +
       		getTestPDSURL(),

     

       270
       +
       		getTestInstanceDID(),

     

       271
       +
       		"coves.social",

     

       272
       +
       		nil,

     

       273
       +
       	)

     

       274
       +
       

     

       275
       +
       	blockHandler := community.NewBlockHandler(communityService)

     

       276
       +
       

     

       277
       +
       	// Create test community

     

       278
       +
       	testCommunity, err := createFeedTestCommunity(db, ctx, "gaming-unblock", "owner2.test")

     

       279
       +
       	if err != nil {

     

       280
       +
       		t.Fatalf("Failed to create test community: %v", err)

     

       281
       +
       	}

     

       282
       +
       

     

       283
       +
       	comm, err := communityRepo.GetByDID(ctx, testCommunity)

     

       284
       +
       	if err != nil {

     

       285
       +
       		t.Fatalf("Failed to get community: %v", err)

     

       286
       +
       	}

     

       287
       +
       

     

       288
       +
       	t.Run("Unblock with handle", func(t *testing.T) {

     

       289
       +
       		reqBody := map[string]string{

     

       290
       +
       			"community": comm.Handle,

     

       291
       +
       		}

     

       292
       +
       		reqJSON, _ := json.Marshal(reqBody)

     

       293
       +
       

     

       294
       +
       		req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.community.unblockCommunity", bytes.NewBuffer(reqJSON))

     

       295
       +
       		req.Header.Set("Content-Type", "application/json")

     

       296
       +
       

     

       297
       +
       		w := httptest.NewRecorder()

     

       298
       +
       		blockHandler.HandleUnblock(w, req)

     

       299
       +
       

     

       300
       +
       		resp := w.Result()

     

       301
       +
       		defer resp.Body.Close()

     

       302
       +
       

     

       303
       +
       		// Should NOT be 404 (handle resolution should work)

     

       304
       +
       		if resp.StatusCode == http.StatusNotFound {

     

       305
       +
       			t.Errorf("Handle resolution failed for unblock - got 404")

     

       306
       +
       		}

     

       307
       +
       

     

       308
       +
       		// Expected: 401 (no auth context)

     

       309
       +
       		if resp.StatusCode != http.StatusUnauthorized {

     

       310
       +
       			var errorResp map[string]interface{}

     

       311
       +
       			json.NewDecoder(resp.Body).Decode(&errorResp)

     

       312
       +
       			t.Logf("Response: status=%d, body=%+v", resp.StatusCode, errorResp)

     

       313
       +
       		}

     

       314
       +
       	})

     

       315
       +
       

     

       316
       +
       	t.Run("Unblock with invalid handle", func(t *testing.T) {

     

       317
       +
       		// Note: Without auth context, returns 401 before reaching resolution

     

       318
       +
       		reqBody := map[string]string{

     

       319
       +
       			"community": "fake.community.coves.social",

     

       320
       +
       		}

     

       321
       +
       		reqJSON, _ := json.Marshal(reqBody)

     

       322
       +
       

     

       323
       +
       		req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.community.unblockCommunity", bytes.NewBuffer(reqJSON))

     

       324
       +
       		req.Header.Set("Content-Type", "application/json")

     

       325
       +
       

     

       326
       +
       		w := httptest.NewRecorder()

     

       327
       +
       		blockHandler.HandleUnblock(w, req)

     

       328
       +
       

     

       329
       +
       		resp := w.Result()

     

       330
       +
       		defer resp.Body.Close()

     

       331
       +
       

     

       332
       +
       		// Expected: 401 (auth check happens before resolution)

     

       333
       +
       		if resp.StatusCode != http.StatusUnauthorized && resp.StatusCode != http.StatusNotFound {

     

       334
       +
       			t.Errorf("Expected 401 or 404, got %d", resp.StatusCode)

     

       335
       +
       		}

     

       336
       +
       	})

     

       337
       +
       }

+434

tests/integration/post_consumer_test.go

···

       1
       +
       package integration

     

       2
       +
       

     

       3
       +
       import (

     

       4
       +
       	"Coves/internal/atproto/jetstream"

     

       5
       +
       	"Coves/internal/core/users"

     

       6
       +
       	"Coves/internal/db/postgres"

     

       7
       +
       	"context"

     

       8
       +
       	"fmt"

     

       9
       +
       	"testing"

     

       10
       +
       	"time"

     

       11
       +
       )

     

       12
       +
       

     

       13
       +
       // TestPostConsumer_CommentCountReconciliation tests that post comment_count

     

       14
       +
       // is correctly reconciled when comments arrive before the parent post.

     

       15
       +
       //

     

       16
       +
       // This addresses the issue identified in comment_consumer.go:362 where the FIXME

     

       17
       +
       // comment suggests reconciliation is not implemented. This test verifies that

     

       18
       +
       // the reconciliation logic in post_consumer.go:210-226 works correctly.

     

       19
       +
       func TestPostConsumer_CommentCountReconciliation(t *testing.T) {

     

       20
       +
       	db := setupTestDB(t)

     

       21
       +
       	defer func() {

     

       22
       +
       		if err := db.Close(); err != nil {

     

       23
       +
       			t.Logf("Failed to close database: %v", err)

     

       24
       +
       		}

     

       25
       +
       	}()

     

       26
       +
       

     

       27
       +
       	ctx := context.Background()

     

       28
       +
       

     

       29
       +
       	// Set up repositories and consumers

     

       30
       +
       	postRepo := postgres.NewPostRepository(db)

     

       31
       +
       	commentRepo := postgres.NewCommentRepository(db)

     

       32
       +
       	communityRepo := postgres.NewCommunityRepository(db)

     

       33
       +
       	userRepo := postgres.NewUserRepository(db)

     

       34
       +
       	userService := users.NewUserService(userRepo, nil, getTestPDSURL())

     

       35
       +
       

     

       36
       +
       	commentConsumer := jetstream.NewCommentEventConsumer(commentRepo, db)

     

       37
       +
       	postConsumer := jetstream.NewPostEventConsumer(postRepo, communityRepo, userService, db)

     

       38
       +
       

     

       39
       +
       	// Setup test data

     

       40
       +
       	testUser := createTestUser(t, db, "reconcile.test", "did:plc:reconcile123")

     

       41
       +
       	testCommunity, err := createFeedTestCommunity(db, ctx, "reconcile-community", "owner.test")

     

       42
       +
       	if err != nil {

     

       43
       +
       		t.Fatalf("Failed to create test community: %v", err)

     

       44
       +
       	}

     

       45
       +
       

     

       46
       +
       	t.Run("Single comment arrives before post - count reconciled", func(t *testing.T) {

     

       47
       +
       		// Scenario: User creates a post

     

       48
       +
       		//           Another user creates a comment on that post

     

       49
       +
       		//           Due to Jetstream ordering, comment event arrives BEFORE post event

     

       50
       +
       		//           When post is finally indexed, comment_count should be 1, not 0

     

       51
       +
       

     

       52
       +
       		postRkey := generateTID()

     

       53
       +
       		postURI := fmt.Sprintf("at://%s/social.coves.community.post/%s", testCommunity, postRkey)

     

       54
       +
       

     

       55
       +
       		commentRkey := generateTID()

     

       56
       +
       		commentURI := fmt.Sprintf("at://%s/social.coves.community.comment/%s", testUser.DID, commentRkey)

     

       57
       +
       

     

       58
       +
       		// Step 1: Index comment FIRST (before parent post exists)

     

       59
       +
       		commentEvent := &jetstream.JetstreamEvent{

     

       60
       +
       			Did:  testUser.DID,

     

       61
       +
       			Kind: "commit",

     

       62
       +
       			Commit: &jetstream.CommitEvent{

     

       63
       +
       				Rev:        "comment-rev",

     

       64
       +
       				Operation:  "create",

     

       65
       +
       				Collection: "social.coves.community.comment",

     

       66
       +
       				RKey:       commentRkey,

     

       67
       +
       				CID:        "bafycomment",

     

       68
       +
       				Record: map[string]interface{}{

     

       69
       +
       					"$type":   "social.coves.community.comment",

     

       70
       +
       					"content": "Comment arriving before parent post!",

     

       71
       +
       					"reply": map[string]interface{}{

     

       72
       +
       						"root": map[string]interface{}{

     

       73
       +
       							"uri": postURI, // Points to post that doesn't exist yet

     

       74
       +
       							"cid": "bafypost",

     

       75
       +
       						},

     

       76
       +
       						"parent": map[string]interface{}{

     

       77
       +
       							"uri": postURI,

     

       78
       +
       							"cid": "bafypost",

     

       79
       +
       						},

     

       80
       +
       					},

     

       81
       +
       					"createdAt": time.Now().Format(time.RFC3339),

     

       82
       +
       				},

     

       83
       +
       			},

     

       84
       +
       		}

     

       85
       +
       

     

       86
       +
       		err := commentConsumer.HandleEvent(ctx, commentEvent)

     

       87
       +
       		if err != nil {

     

       88
       +
       			t.Fatalf("Failed to handle comment event: %v", err)

     

       89
       +
       		}

     

       90
       +
       

     

       91
       +
       		// Verify comment was indexed

     

       92
       +
       		comment, err := commentRepo.GetByURI(ctx, commentURI)

     

       93
       +
       		if err != nil {

     

       94
       +
       			t.Fatalf("Comment not indexed: %v", err)

     

       95
       +
       		}

     

       96
       +
       		if comment.ParentURI != postURI {

     

       97
       +
       			t.Errorf("Expected comment parent_uri %s, got %s", postURI, comment.ParentURI)

     

       98
       +
       		}

     

       99
       +
       

     

       100
       +
       		// Step 2: Now index post (arrives late due to Jetstream ordering)

     

       101
       +
       		postEvent := &jetstream.JetstreamEvent{

     

       102
       +
       			Did:  testCommunity,

     

       103
       +
       			Kind: "commit",

     

       104
       +
       			Commit: &jetstream.CommitEvent{

     

       105
       +
       				Rev:        "post-rev",

     

       106
       +
       				Operation:  "create",

     

       107
       +
       				Collection: "social.coves.community.post",

     

       108
       +
       				RKey:       postRkey,

     

       109
       +
       				CID:        "bafypost",

     

       110
       +
       				Record: map[string]interface{}{

     

       111
       +
       					"$type":     "social.coves.community.post",

     

       112
       +
       					"community": testCommunity,

     

       113
       +
       					"author":    testUser.DID,

     

       114
       +
       					"title":     "Post arriving after comment",

     

       115
       +
       					"content":   "This post's comment arrived first!",

     

       116
       +
       					"createdAt": time.Now().Format(time.RFC3339),

     

       117
       +
       				},

     

       118
       +
       			},

     

       119
       +
       		}

     

       120
       +
       

     

       121
       +
       		err = postConsumer.HandleEvent(ctx, postEvent)

     

       122
       +
       		if err != nil {

     

       123
       +
       			t.Fatalf("Failed to handle post event: %v", err)

     

       124
       +
       		}

     

       125
       +
       

     

       126
       +
       		// Step 3: Verify post was indexed with CORRECT comment_count

     

       127
       +
       		post, err := postRepo.GetByURI(ctx, postURI)

     

       128
       +
       		if err != nil {

     

       129
       +
       			t.Fatalf("Post not indexed: %v", err)

     

       130
       +
       		}

     

       131
       +
       

     

       132
       +
       		// THIS IS THE KEY TEST: Post should have comment_count = 1 due to reconciliation

     

       133
       +
       		if post.CommentCount != 1 {

     

       134
       +
       			t.Errorf("Expected post comment_count to be 1 (reconciled), got %d", post.CommentCount)

     

       135
       +
       			t.Logf("This indicates the reconciliation logic in post_consumer.go is not working!")

     

       136
       +
       			t.Logf("The FIXME comment at comment_consumer.go:362 may still be valid.")

     

       137
       +
       		}

     

       138
       +
       

     

       139
       +
       		// Verify via direct query as well

     

       140
       +
       		var dbCommentCount int

     

       141
       +
       		err = db.QueryRowContext(ctx, "SELECT comment_count FROM posts WHERE uri = $1", postURI).Scan(&dbCommentCount)

     

       142
       +
       		if err != nil {

     

       143
       +
       			t.Fatalf("Failed to query post comment_count: %v", err)

     

       144
       +
       		}

     

       145
       +
       		if dbCommentCount != 1 {

     

       146
       +
       			t.Errorf("Expected DB comment_count to be 1, got %d", dbCommentCount)

     

       147
       +
       		}

     

       148
       +
       	})

     

       149
       +
       

     

       150
       +
       	t.Run("Multiple comments arrive before post - count reconciled to correct total", func(t *testing.T) {

     

       151
       +
       		postRkey := generateTID()

     

       152
       +
       		postURI := fmt.Sprintf("at://%s/social.coves.community.post/%s", testCommunity, postRkey)

     

       153
       +
       

     

       154
       +
       		// Step 1: Index 3 comments BEFORE the post exists

     

       155
       +
       		for i := 1; i <= 3; i++ {

     

       156
       +
       			commentRkey := generateTID()

     

       157
       +
       			commentEvent := &jetstream.JetstreamEvent{

     

       158
       +
       				Did:  testUser.DID,

     

       159
       +
       				Kind: "commit",

     

       160
       +
       				Commit: &jetstream.CommitEvent{

     

       161
       +
       					Rev:        fmt.Sprintf("comment-%d-rev", i),

     

       162
       +
       					Operation:  "create",

     

       163
       +
       					Collection: "social.coves.community.comment",

     

       164
       +
       					RKey:       commentRkey,

     

       165
       +
       					CID:        fmt.Sprintf("bafycomment%d", i),

     

       166
       +
       					Record: map[string]interface{}{

     

       167
       +
       						"$type":   "social.coves.community.comment",

     

       168
       +
       						"content": fmt.Sprintf("Comment %d before post", i),

     

       169
       +
       						"reply": map[string]interface{}{

     

       170
       +
       							"root": map[string]interface{}{

     

       171
       +
       								"uri": postURI,

     

       172
       +
       								"cid": "bafypost2",

     

       173
       +
       							},

     

       174
       +
       							"parent": map[string]interface{}{

     

       175
       +
       								"uri": postURI,

     

       176
       +
       								"cid": "bafypost2",

     

       177
       +
       							},

     

       178
       +
       						},

     

       179
       +
       						"createdAt": time.Now().Format(time.RFC3339),

     

       180
       +
       					},

     

       181
       +
       				},

     

       182
       +
       			}

     

       183
       +
       

     

       184
       +
       			err := commentConsumer.HandleEvent(ctx, commentEvent)

     

       185
       +
       			if err != nil {

     

       186
       +
       				t.Fatalf("Failed to handle comment %d event: %v", i, err)

     

       187
       +
       			}

     

       188
       +
       		}

     

       189
       +
       

     

       190
       +
       		// Step 2: Now index the post

     

       191
       +
       		postEvent := &jetstream.JetstreamEvent{

     

       192
       +
       			Did:  testCommunity,

     

       193
       +
       			Kind: "commit",

     

       194
       +
       			Commit: &jetstream.CommitEvent{

     

       195
       +
       				Rev:        "post2-rev",

     

       196
       +
       				Operation:  "create",

     

       197
       +
       				Collection: "social.coves.community.post",

     

       198
       +
       				RKey:       postRkey,

     

       199
       +
       				CID:        "bafypost2",

     

       200
       +
       				Record: map[string]interface{}{

     

       201
       +
       					"$type":     "social.coves.community.post",

     

       202
       +
       					"community": testCommunity,

     

       203
       +
       					"author":    testUser.DID,

     

       204
       +
       					"title":     "Post with 3 pre-existing comments",

     

       205
       +
       					"content":   "All 3 comments arrived before this post!",

     

       206
       +
       					"createdAt": time.Now().Format(time.RFC3339),

     

       207
       +
       				},

     

       208
       +
       			},

     

       209
       +
       		}

     

       210
       +
       

     

       211
       +
       		err := postConsumer.HandleEvent(ctx, postEvent)

     

       212
       +
       		if err != nil {

     

       213
       +
       			t.Fatalf("Failed to handle post event: %v", err)

     

       214
       +
       		}

     

       215
       +
       

     

       216
       +
       		// Step 3: Verify post has comment_count = 3

     

       217
       +
       		post, err := postRepo.GetByURI(ctx, postURI)

     

       218
       +
       		if err != nil {

     

       219
       +
       			t.Fatalf("Post not indexed: %v", err)

     

       220
       +
       		}

     

       221
       +
       

     

       222
       +
       		if post.CommentCount != 3 {

     

       223
       +
       			t.Errorf("Expected post comment_count to be 3 (reconciled), got %d", post.CommentCount)

     

       224
       +
       		}

     

       225
       +
       	})

     

       226
       +
       

     

       227
       +
       	t.Run("Comments before and after post - count remains accurate", func(t *testing.T) {

     

       228
       +
       		postRkey := generateTID()

     

       229
       +
       		postURI := fmt.Sprintf("at://%s/social.coves.community.post/%s", testCommunity, postRkey)

     

       230
       +
       

     

       231
       +
       		// Step 1: Index 2 comments BEFORE post

     

       232
       +
       		for i := 1; i <= 2; i++ {

     

       233
       +
       			commentRkey := generateTID()

     

       234
       +
       			commentEvent := &jetstream.JetstreamEvent{

     

       235
       +
       				Did:  testUser.DID,

     

       236
       +
       				Kind: "commit",

     

       237
       +
       				Commit: &jetstream.CommitEvent{

     

       238
       +
       					Rev:        fmt.Sprintf("before-%d-rev", i),

     

       239
       +
       					Operation:  "create",

     

       240
       +
       					Collection: "social.coves.community.comment",

     

       241
       +
       					RKey:       commentRkey,

     

       242
       +
       					CID:        fmt.Sprintf("bafybefore%d", i),

     

       243
       +
       					Record: map[string]interface{}{

     

       244
       +
       						"$type":   "social.coves.community.comment",

     

       245
       +
       						"content": fmt.Sprintf("Before comment %d", i),

     

       246
       +
       						"reply": map[string]interface{}{

     

       247
       +
       							"root": map[string]interface{}{

     

       248
       +
       								"uri": postURI,

     

       249
       +
       								"cid": "bafypost3",

     

       250
       +
       							},

     

       251
       +
       							"parent": map[string]interface{}{

     

       252
       +
       								"uri": postURI,

     

       253
       +
       								"cid": "bafypost3",

     

       254
       +
       							},

     

       255
       +
       						},

     

       256
       +
       						"createdAt": time.Now().Format(time.RFC3339),

     

       257
       +
       					},

     

       258
       +
       				},

     

       259
       +
       			}

     

       260
       +
       

     

       261
       +
       			err := commentConsumer.HandleEvent(ctx, commentEvent)

     

       262
       +
       			if err != nil {

     

       263
       +
       				t.Fatalf("Failed to handle before-comment %d: %v", i, err)

     

       264
       +
       			}

     

       265
       +
       		}

     

       266
       +
       

     

       267
       +
       		// Step 2: Index the post (should reconcile to 2)

     

       268
       +
       		postEvent := &jetstream.JetstreamEvent{

     

       269
       +
       			Did:  testCommunity,

     

       270
       +
       			Kind: "commit",

     

       271
       +
       			Commit: &jetstream.CommitEvent{

     

       272
       +
       				Rev:        "post3-rev",

     

       273
       +
       				Operation:  "create",

     

       274
       +
       				Collection: "social.coves.community.post",

     

       275
       +
       				RKey:       postRkey,

     

       276
       +
       				CID:        "bafypost3",

     

       277
       +
       				Record: map[string]interface{}{

     

       278
       +
       					"$type":     "social.coves.community.post",

     

       279
       +
       					"community": testCommunity,

     

       280
       +
       					"author":    testUser.DID,

     

       281
       +
       					"title":     "Post with before and after comments",

     

       282
       +
       					"content":   "Testing mixed ordering",

     

       283
       +
       					"createdAt": time.Now().Format(time.RFC3339),

     

       284
       +
       				},

     

       285
       +
       			},

     

       286
       +
       		}

     

       287
       +
       

     

       288
       +
       		err := postConsumer.HandleEvent(ctx, postEvent)

     

       289
       +
       		if err != nil {

     

       290
       +
       			t.Fatalf("Failed to handle post event: %v", err)

     

       291
       +
       		}

     

       292
       +
       

     

       293
       +
       		// Verify count is 2

     

       294
       +
       		post, err := postRepo.GetByURI(ctx, postURI)

     

       295
       +
       		if err != nil {

     

       296
       +
       			t.Fatalf("Post not indexed: %v", err)

     

       297
       +
       		}

     

       298
       +
       		if post.CommentCount != 2 {

     

       299
       +
       			t.Errorf("Expected comment_count=2 after reconciliation, got %d", post.CommentCount)

     

       300
       +
       		}

     

       301
       +
       

     

       302
       +
       		// Step 3: Add 1 more comment AFTER post exists

     

       303
       +
       		commentRkey := generateTID()

     

       304
       +
       		afterCommentEvent := &jetstream.JetstreamEvent{

     

       305
       +
       			Did:  testUser.DID,

     

       306
       +
       			Kind: "commit",

     

       307
       +
       			Commit: &jetstream.CommitEvent{

     

       308
       +
       				Rev:        "after-rev",

     

       309
       +
       				Operation:  "create",

     

       310
       +
       				Collection: "social.coves.community.comment",

     

       311
       +
       				RKey:       commentRkey,

     

       312
       +
       				CID:        "bafyafter",

     

       313
       +
       				Record: map[string]interface{}{

     

       314
       +
       					"$type":   "social.coves.community.comment",

     

       315
       +
       					"content": "Comment after post exists",

     

       316
       +
       					"reply": map[string]interface{}{

     

       317
       +
       						"root": map[string]interface{}{

     

       318
       +
       							"uri": postURI,

     

       319
       +
       							"cid": "bafypost3",

     

       320
       +
       						},

     

       321
       +
       						"parent": map[string]interface{}{

     

       322
       +
       							"uri": postURI,

     

       323
       +
       							"cid": "bafypost3",

     

       324
       +
       						},

     

       325
       +
       					},

     

       326
       +
       					"createdAt": time.Now().Format(time.RFC3339),

     

       327
       +
       				},

     

       328
       +
       			},

     

       329
       +
       		}

     

       330
       +
       

     

       331
       +
       		err = commentConsumer.HandleEvent(ctx, afterCommentEvent)

     

       332
       +
       		if err != nil {

     

       333
       +
       			t.Fatalf("Failed to handle after-comment: %v", err)

     

       334
       +
       		}

     

       335
       +
       

     

       336
       +
       		// Verify count incremented to 3

     

       337
       +
       		post, err = postRepo.GetByURI(ctx, postURI)

     

       338
       +
       		if err != nil {

     

       339
       +
       			t.Fatalf("Failed to get post after increment: %v", err)

     

       340
       +
       		}

     

       341
       +
       		if post.CommentCount != 3 {

     

       342
       +
       			t.Errorf("Expected comment_count=3 after increment, got %d", post.CommentCount)

     

       343
       +
       		}

     

       344
       +
       	})

     

       345
       +
       

     

       346
       +
       	t.Run("Idempotent post indexing preserves comment_count", func(t *testing.T) {

     

       347
       +
       		postRkey := generateTID()

     

       348
       +
       		postURI := fmt.Sprintf("at://%s/social.coves.community.post/%s", testCommunity, postRkey)

     

       349
       +
       

     

       350
       +
       		// Create comment first

     

       351
       +
       		commentRkey := generateTID()

     

       352
       +
       		commentEvent := &jetstream.JetstreamEvent{

     

       353
       +
       			Did:  testUser.DID,

     

       354
       +
       			Kind: "commit",

     

       355
       +
       			Commit: &jetstream.CommitEvent{

     

       356
       +
       				Rev:        "idem-comment-rev",

     

       357
       +
       				Operation:  "create",

     

       358
       +
       				Collection: "social.coves.community.comment",

     

       359
       +
       				RKey:       commentRkey,

     

       360
       +
       				CID:        "bafyidemcomment",

     

       361
       +
       				Record: map[string]interface{}{

     

       362
       +
       					"$type":   "social.coves.community.comment",

     

       363
       +
       					"content": "Comment for idempotent test",

     

       364
       +
       					"reply": map[string]interface{}{

     

       365
       +
       						"root": map[string]interface{}{

     

       366
       +
       							"uri": postURI,

     

       367
       +
       							"cid": "bafyidempost",

     

       368
       +
       						},

     

       369
       +
       						"parent": map[string]interface{}{

     

       370
       +
       							"uri": postURI,

     

       371
       +
       							"cid": "bafyidempost",

     

       372
       +
       						},

     

       373
       +
       					},

     

       374
       +
       					"createdAt": time.Now().Format(time.RFC3339),

     

       375
       +
       				},

     

       376
       +
       			},

     

       377
       +
       		}

     

       378
       +
       

     

       379
       +
       		err := commentConsumer.HandleEvent(ctx, commentEvent)

     

       380
       +
       		if err != nil {

     

       381
       +
       			t.Fatalf("Failed to create comment: %v", err)

     

       382
       +
       		}

     

       383
       +
       

     

       384
       +
       		// Index post (should reconcile to 1)

     

       385
       +
       		postEvent := &jetstream.JetstreamEvent{

     

       386
       +
       			Did:  testCommunity,

     

       387
       +
       			Kind: "commit",

     

       388
       +
       			Commit: &jetstream.CommitEvent{

     

       389
       +
       				Rev:        "idem-post-rev",

     

       390
       +
       				Operation:  "create",

     

       391
       +
       				Collection: "social.coves.community.post",

     

       392
       +
       				RKey:       postRkey,

     

       393
       +
       				CID:        "bafyidempost",

     

       394
       +
       				Record: map[string]interface{}{

     

       395
       +
       					"$type":     "social.coves.community.post",

     

       396
       +
       					"community": testCommunity,

     

       397
       +
       					"author":    testUser.DID,

     

       398
       +
       					"title":     "Idempotent test post",

     

       399
       +
       					"content":   "Testing idempotent indexing",

     

       400
       +
       					"createdAt": time.Now().Format(time.RFC3339),

     

       401
       +
       				},

     

       402
       +
       			},

     

       403
       +
       		}

     

       404
       +
       

     

       405
       +
       		err = postConsumer.HandleEvent(ctx, postEvent)

     

       406
       +
       		if err != nil {

     

       407
       +
       			t.Fatalf("Failed to index post first time: %v", err)

     

       408
       +
       		}

     

       409
       +
       

     

       410
       +
       		// Verify count is 1

     

       411
       +
       		post, err := postRepo.GetByURI(ctx, postURI)

     

       412
       +
       		if err != nil {

     

       413
       +
       			t.Fatalf("Failed to get post: %v", err)

     

       414
       +
       		}

     

       415
       +
       		if post.CommentCount != 1 {

     

       416
       +
       			t.Errorf("Expected comment_count=1 after first index, got %d", post.CommentCount)

     

       417
       +
       		}

     

       418
       +
       

     

       419
       +
       		// Replay same post event (idempotent - should skip)

     

       420
       +
       		err = postConsumer.HandleEvent(ctx, postEvent)

     

       421
       +
       		if err != nil {

     

       422
       +
       			t.Fatalf("Idempotent post event should not error: %v", err)

     

       423
       +
       		}

     

       424
       +
       

     

       425
       +
       		// Verify count still 1 (not reset to 0)

     

       426
       +
       		post, err = postRepo.GetByURI(ctx, postURI)

     

       427
       +
       		if err != nil {

     

       428
       +
       			t.Fatalf("Failed to get post after replay: %v", err)

     

       429
       +
       		}

     

       430
       +
       		if post.CommentCount != 1 {

     

       431
       +
       			t.Errorf("Expected comment_count=1 after replay (idempotent), got %d", post.CommentCount)

     

       432
       +
       		}

     

       433
       +
       	})

     

       434
       +
       }