commit c73edab652a2a43c94e6a02534e9ed5e7fed2c85 · bretton.dev/coves

+44 -4
internal/core/comments/comment_service_test.go
···

       5
       5
        
       	"Coves/internal/core/posts"

     

       6
       6
        
       	"Coves/internal/core/users"

     

       7
       7
        
       	"context"

     

       8
       8
       +
       	"database/sql"

     

       8
       9
        
       	"errors"

     

       9
       10
        
       	"testing"

     

       10
       11
        
       	"time"

     
···

       51
       52
        
       func (m *mockCommentRepo) Delete(ctx context.Context, uri string) error {

     

       52
       53
        
       	delete(m.comments, uri)

     

       53
       54
        
       	return nil

     

       55
       55
       +
       }

     

       56
       56
       +
       

     

       57
       57
       +
       func (m *mockCommentRepo) SoftDeleteWithReason(ctx context.Context, uri, reason, deletedByDID string) error {

     

       58
       58
       +
       	// Validate deletion reason

     

       59
       59
       +
       	if reason != DeletionReasonAuthor && reason != DeletionReasonModerator {

     

       60
       60
       +
       		return errors.New("invalid deletion reason: " + reason)

     

       61
       61
       +
       	}

     

       62
       62
       +
       	_, err := m.SoftDeleteWithReasonTx(ctx, nil, uri, reason, deletedByDID)

     

       63
       63
       +
       	return err

     

       64
       64
       +
       }

     

       65
       65
       +
       

     

       66
       66
       +
       // SoftDeleteWithReasonTx implements RepositoryTx interface for transactional deletes

     

       67
       67
       +
       func (m *mockCommentRepo) SoftDeleteWithReasonTx(ctx context.Context, tx *sql.Tx, uri, reason, deletedByDID string) (int64, error) {

     

       68
       68
       +
       	if c, ok := m.comments[uri]; ok {

     

       69
       69
       +
       		if c.DeletedAt != nil {

     

       70
       70
       +
       			// Already deleted - idempotent

     

       71
       71
       +
       			return 0, nil

     

       72
       72
       +
       		}

     

       73
       73
       +
       		now := time.Now()

     

       74
       74
       +
       		c.DeletedAt = &now

     

       75
       75
       +
       		c.DeletionReason = &reason

     

       76
       76
       +
       		c.DeletedBy = &deletedByDID

     

       77
       77
       +
       		c.Content = ""

     

       78
       78
       +
       		return 1, nil

     

       79
       79
       +
       	}

     

       80
       80
       +
       	return 0, nil

     

       54
       81
        
       }

     

       55
       82
        
       

     

       56
       83
        
       func (m *mockCommentRepo) ListByRoot(ctx context.Context, rootURI string, limit, offset int) ([]*Comment, error) {

     
···

       831
       858
        
       	assert.Len(t, result, 0)

     

       832
       859
        
       }

     

       833
       860
        
       

     

       834
       834
       -
       func TestCommentService_buildThreadViews_SkipsDeletedComments(t *testing.T) {

     

       861
       861
       +
       func TestCommentService_buildThreadViews_IncludesDeletedCommentsAsPlaceholders(t *testing.T) {

     

       835
       862
        
       	// Setup

     

       836
       863
        
       	commentRepo := newMockCommentRepo()

     

       837
       864
        
       	userRepo := newMockUserRepo()

     
···

       840
       867
        
       

     

       841
       868
        
       	postURI := "at://did:plc:post123/app.bsky.feed.post/test"

     

       842
       869
        
       	deletedAt := time.Now()

     

       870
       870
       +
       	deletionReason := DeletionReasonAuthor

     

       843
       871
        
       

     

       844
       872
        
       	// Create a deleted comment

     

       845
       873
        
       	deletedComment := createTestComment("at://did:plc:commenter123/comment/1", "did:plc:commenter123", "commenter.test", postURI, postURI, 0)

     

       846
       874
        
       	deletedComment.DeletedAt = &deletedAt

     

       875
       875
       +
       	deletedComment.DeletionReason = &deletionReason

     

       876
       876
       +
       	deletedComment.Content = "" // Content is blanked on deletion

     

       847
       877
        
       

     

       848
       878
        
       	// Create a normal comment

     

       849
       879
        
       	normalComment := createTestComment("at://did:plc:commenter123/comment/2", "did:plc:commenter123", "commenter.test", postURI, postURI, 0)

     
···

       853
       883
        
       	// Execute

     

       854
       884
        
       	result := service.buildThreadViews(context.Background(), []*Comment{deletedComment, normalComment}, 10, "hot", nil)

     

       855
       885
        
       

     

       856
       856
       -
       	// Verify - should only include non-deleted comment

     

       857
       857
       -
       	assert.Len(t, result, 1)

     

       858
       858
       -
       	assert.Equal(t, normalComment.URI, result[0].Comment.URI)

     

       886
       886
       +
       	// Verify - both comments should be included to preserve thread structure

     

       887
       887
       +
       	assert.Len(t, result, 2)

     

       888
       888
       +
       

     

       889
       889
       +
       	// First comment should be the deleted one with placeholder info

     

       890
       890
       +
       	assert.Equal(t, deletedComment.URI, result[0].Comment.URI)

     

       891
       891
       +
       	assert.True(t, result[0].Comment.IsDeleted)

     

       892
       892
       +
       	assert.Equal(t, DeletionReasonAuthor, *result[0].Comment.DeletionReason)

     

       893
       893
       +
       	assert.Empty(t, result[0].Comment.Content)

     

       894
       894
       +
       

     

       895
       895
       +
       	// Second comment should be the normal one

     

       896
       896
       +
       	assert.Equal(t, normalComment.URI, result[1].Comment.URI)

     

       897
       897
       +
       	assert.False(t, result[1].Comment.IsDeleted)

     

       898
       898
       +
       	assert.Nil(t, result[1].Comment.DeletionReason)

     

       859
       899
        
       }

     

       860
       900
        
       

     

       861
       901
        
       func TestCommentService_buildThreadViews_WithNestedReplies(t *testing.T) {