commit e283f83b37d16035fd061b65dc99c042acf521b4 · bretton.dev/coves

+24 -12

docs/PRD_BACKLOG.md

···

       60
       60
        
       

     

       61
       61
        
       ---

     

       62
       62
        
       

     

       63
       63
       -
       ### Subscription Visibility Level (Feed Slider 1-5 Scale)

     

       64
       64
       -
       **Added:** 2025-10-15 | **Effort:** 4-6 hours | **Priority:** ALPHA BLOCKER

     

       63
       63
       +
       ### ✅ Subscription Visibility Level (Feed Slider 1-5 Scale) - COMPLETE

     

       64
       64
       +
       **Added:** 2025-10-15 | **Completed:** 2025-10-16 | **Effort:** 1 day | **Status:** ✅ DONE

     

       65
       65
        
       

     

       66
       66
       -
       **Problem:** Users can't control how much content they see from each community. Lexicon has `contentVisibility` (1-5 scale) but code doesn't use it.

     

       66
       66
       +
       **Problem:** Users couldn't control how much content they see from each community. Lexicon had `contentVisibility` (1-5 scale) but code didn't use it.

     

       67
       67
        
       

     

       68
       68
       -
       **Solution:**

     

       69
       69
       -
       - Update subscribe handler to accept `contentVisibility` parameter (1-5, default 3)

     

       70
       70
       -
       - Store in subscription record on PDS

     

       71
       71
       -
       - Update feed generation to respect visibility level (beta work, but data structure needed now)

     

       68
       68
       +
       **Solution Implemented:**

     

       69
       69
       +
       - ✅ Updated subscribe handler to accept `contentVisibility` parameter (1-5, default 3)

     

       70
       70
       +
       - ✅ Store in subscription record on PDS (`social.coves.community.subscription`)

     

       71
       71
       +
       - ✅ Migration 008 adds `content_visibility` column to database with CHECK constraint

     

       72
       72
       +
       - ✅ Clamping at all layers (handler, service, consumer) for defense in depth

     

       73
       73
       +
       - ✅ Atomic subscriber count updates (SubscribeWithCount/UnsubscribeWithCount)

     

       74
       74
       +
       - ✅ Idempotent operations (safe for Jetstream event replays)

     

       75
       75
       +
       - ✅ Fixed critical collection name bug (was using wrong namespace)

     

       76
       76
       +
       - ✅ Production Jetstream consumer now running

     

       77
       77
       +
       - ✅ 13 comprehensive integration tests - all passing

     

       72
       78
        
       

     

       73
       73
       -
       **Code:**

     

       74
       74
       -
       - Lexicon: [subscription.json:28-34](../internal/atproto/lexicon/social/coves/actor/subscription.json#L28-L34) ✅ Ready

     

       75
       75
       -
       - Handler: [community/subscribe.go](../internal/api/handlers/community/subscribe.go) - Add parameter

     

       76
       76
       -
       - Service: [communities/service.go:373-376](../internal/core/communities/service.go#L373-L376) - Add to record

     

       79
       79
       +
       **Files Modified:**

     

       80
       80
       +
       - Lexicon: [subscription.json](../internal/atproto/lexicon/social/coves/community/subscription.json) ✅ Updated to atProto conventions

     

       81
       81
       +
       - Handler: [community/subscribe.go](../internal/api/handlers/community/subscribe.go) ✅ Accepts contentVisibility

     

       82
       82
       +
       - Service: [communities/service.go](../internal/core/communities/service.go) ✅ Clamps and passes to PDS

     

       83
       83
       +
       - Consumer: [community_consumer.go](../internal/atproto/jetstream/community_consumer.go) ✅ Extracts and indexes

     

       84
       84
       +
       - Repository: [community_repo_subscriptions.go](../internal/db/postgres/community_repo_subscriptions.go) ✅ All queries updated

     

       85
       85
       +
       - Migration: [008_add_content_visibility_to_subscriptions.sql](../internal/db/migrations/008_add_content_visibility_to_subscriptions.sql) ✅ Schema changes

     

       86
       86
       +
       - Tests: [subscription_indexing_test.go](../tests/integration/subscription_indexing_test.go) ✅ Comprehensive coverage

     

       77
       87
        
       

     

       78
       78
       -
       **Impact:** Without this, users have no way to adjust feed volume per community (key feature from DOMAIN_KNOWLEDGE.md)

     

       88
       88
       +
       **Documentation:** See [IMPLEMENTATION_SUBSCRIPTION_INDEXING.md](../docs/IMPLEMENTATION_SUBSCRIPTION_INDEXING.md) for full details

     

       89
       89
       +
       

     

       90
       90
       +
       **Impact:** ✅ Users can now adjust feed volume per community (key feature from DOMAIN_KNOWLEDGE.md enabled)

     

       79
       91
        
       

     

       80
       92
        
       ---

     

       81
       93

+30 -23

docs/PRD_COMMUNITIES.md

···

       2
       2
        
       

     

       3
       3
        
       **Status:** In Development

     

       4
       4
        
       **Owner:** Platform Team

     

       5
       5
       -
       **Last Updated:** 2025-10-10

     

       5
       5
       +
       **Last Updated:** 2025-10-16

     

       6
       6
        
       

     

       7
       7
        
       ## Overview

     

       8
       8
        
       

     
···

       112
       112
        
       ## ⚠️ Alpha Blockers (Must Complete Before Alpha Launch)

     

       113
       113
        
       

     

       114
       114
        
       ### Critical Missing Features

     

       115
       115
       -
       - [ ] **Subscription Visibility Level (1-5 Scale):** Implement feed slider from DOMAIN_KNOWLEDGE.md

     

       116
       116
       -
         - Lexicon: ✅ Ready ([subscription.json:28-34](internal/atproto/lexicon/social/coves/actor/subscription.json))

     

       117
       117
       -
         - Service: ❌ Not using `contentVisibility` field

     

       118
       118
       -
         - Handler: ❌ Subscribe endpoint doesn't accept/store visibility level

     

       119
       119
       -
         - **Impact:** Users can't control how much content they see from each community

     

       120
       120
       -
       

     

       121
       115
        
       - [ ] **Community Blocking:** Users can block communities from their feeds

     

       122
       116
        
         - Lexicon: ❌ Need new record type (extend `social.coves.actor.block` or create new)

     

       123
       117
        
         - Service: ❌ No implementation (`BlockCommunity()` / `UnblockCommunity()`)

     
···

       125
       119
        
         - Repository: ❌ No methods

     

       126
       120
        
         - **Impact:** Users have no way to hide unwanted communities

     

       127
       121
        
       

     

       128
       128
       -
       ### Critical Infrastructure (BLOCKING)

     

       129
       129
       -
       - [ ] **⚠️ Subscription Indexing - NO PRODUCTION CONSUMER**

     

       130
       130
       -
         - **Status:** Subscriptions write to PDS but are NEVER indexed in AppView

     

       131
       131
       -
         - **Root Cause:** `CommunityEventConsumer` only runs in tests, not in production

     

       122
       122
       +
       ### ✅ Critical Infrastructure - RESOLVED (2025-10-16)

     

       123
       123
       +
       - [x] **✅ Subscription Indexing & ContentVisibility - COMPLETE**

     

       124
       124
       +
         - **Status:** Subscriptions now fully indexed in AppView with feed slider support

     

       125
       125
       +
         - **Completed:** 2025-10-16

     

       126
       126
       +
         - **What Was Fixed:**

     

       127
       127
       +
           1. ✅ Fixed critical collection name bug (`social.coves.actor.subscription` → `social.coves.community.subscription`)

     

       128
       128
       +
           2. ✅ Implemented ContentVisibility (1-5 slider) across all layers (handler, service, consumer, repository)

     

       129
       129
       +
           3. ✅ Production Jetstream consumer now running ([cmd/server/main.go:220-243](cmd/server/main.go#L220-L243))

     

       130
       130
       +
           4. ✅ Migration 008 adds `content_visibility` column with defaults and constraints

     

       131
       131
       +
           5. ✅ Atomic subscriber count updates (SubscribeWithCount/UnsubscribeWithCount)

     

       132
       132
       +
           6. ✅ DELETE operations properly handled (unsubscribe indexing)

     

       133
       133
       +
           7. ✅ Idempotent operations (safe for Jetstream event replays)

     

       134
       134
       +
           8. ✅ atProto naming compliance: singular namespace + `subject` field

     

       132
       135
        
         - **Impact:**

     

       133
       133
       -
           - ❌ Users CAN subscribe/unsubscribe (writes to their PDS repo) ✅

     

       134
       134
       -
           - ❌ AppView has NO KNOWLEDGE of subscriptions (not consuming from Jetstream)

     

       135
       135
       -
           - ❌ Cannot query user's subscriptions (data doesn't exist in AppView)

     

       136
       136
       -
           - ❌ Feed generation impossible (don't know who's subscribed to what)

     

       137
       137
       -
         - **Required Fixes:**

     

       138
       138
       -
           1. Start `CommunityEventConsumer` in production ([cmd/server/main.go](cmd/server/main.go))

     

       139
       139
       -
           2. Subscribe to local Jetstream: `ws://localhost:6008/subscribe?wantedCollections=social.coves.community.subscribe`

     

       140
       140
       -
           3. Fix unsubscribe handler - should handle `delete` operation on `social.coves.community.subscribe`, NOT a separate collection

     

       141
       141
       -
           4. Remove incorrect `social.coves.community.unsubscribe` case ([community_consumer.go:40](internal/atproto/jetstream/community_consumer.go#L40))

     

       136
       136
       +
           - ✅ Users CAN subscribe/unsubscribe (writes to their PDS repo)

     

       137
       137
       +
           - ✅ AppView INDEXES subscriptions from Jetstream in real-time

     

       138
       138
       +
           - ✅ Can query user's subscriptions (data persisted with contentVisibility)

     

       139
       139
       +
           - ✅ Feed generation ENABLED (know who's subscribed with visibility preferences)

     

       140
       140
       +
           - ✅ Subscriber counts accurate (atomic updates)

     

       141
       141
       +
         - **Testing:**

     

       142
       142
       +
           - ✅ 13 comprehensive integration tests (subscription_indexing_test.go) - ALL PASSING

     

       143
       143
       +
           - ✅ Enhanced E2E tests verify complete flow (HTTP → PDS → Jetstream → AppView)

     

       144
       144
       +
           - ✅ ContentVisibility clamping tested (0→1, 10→5, defaults to 3)

     

       145
       145
       +
           - ✅ Idempotency verified (duplicate events handled gracefully)

     

       142
       146
        
         - **Files:**

     

       143
       143
       -
           - Consumer: [internal/atproto/jetstream/community_consumer.go](internal/atproto/jetstream/community_consumer.go) (exists, needs fixes)

     

       144
       144
       -
           - Server: [cmd/server/main.go](cmd/server/main.go) (needs to instantiate consumer)

     

       145
       145
       -
         - **See:** Issue discovered 2025-10-16 during OAuth user token implementation

     

       147
       147
       +
           - Implementation Doc: [docs/IMPLEMENTATION_SUBSCRIPTION_INDEXING.md](docs/IMPLEMENTATION_SUBSCRIPTION_INDEXING.md)

     

       148
       148
       +
           - Lexicon: [internal/atproto/lexicon/social/coves/community/subscription.json](internal/atproto/lexicon/social/coves/community/subscription.json)

     

       149
       149
       +
           - Consumer: [internal/atproto/jetstream/community_consumer.go](internal/atproto/jetstream/community_consumer.go)

     

       150
       150
       +
           - Connector: [internal/atproto/jetstream/community_jetstream_connector.go](internal/atproto/jetstream/community_jetstream_connector.go)

     

       151
       151
       +
           - Migration: [internal/db/migrations/008_add_content_visibility_to_subscriptions.sql](internal/db/migrations/008_add_content_visibility_to_subscriptions.sql)

     

       152
       152
       +
           - Tests: [tests/integration/subscription_indexing_test.go](tests/integration/subscription_indexing_test.go)

     

       146
       153
        
       

     

       147
       154
        
       ### Critical Security (High Priority)

     

       148
       155
        
       - [x] **OAuth Authentication:** ✅ COMPLETE - User access tokens flow end-to-end