commit f499a73fa3ead2f0e1e7e9a5262877af071d4e5c · bretton.dev/coves

+922
tests/integration/comment_query_test.go
···

       1
       1
       +
       package integration

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"Coves/internal/atproto/jetstream"

     

       5
       5
       +
       	"Coves/internal/core/comments"

     

       6
       6
       +
       	"Coves/internal/db/postgres"

     

       7
       7
       +
       	"context"

     

       8
       8
       +
       	"database/sql"

     

       9
       9
       +
       	"encoding/json"

     

       10
       10
       +
       	"fmt"

     

       11
       11
       +
       	"net/http"

     

       12
       12
       +
       	"net/http/httptest"

     

       13
       13
       +
       	"strings"

     

       14
       14
       +
       	"testing"

     

       15
       15
       +
       	"time"

     

       16
       16
       +
       

     

       17
       17
       +
       	"github.com/stretchr/testify/assert"

     

       18
       18
       +
       	"github.com/stretchr/testify/require"

     

       19
       19
       +
       )

     

       20
       20
       +
       

     

       21
       21
       +
       // TestCommentQuery_BasicFetch tests fetching top-level comments with default params

     

       22
       22
       +
       func TestCommentQuery_BasicFetch(t *testing.T) {

     

       23
       23
       +
       	db := setupTestDB(t)

     

       24
       24
       +
       	defer func() {

     

       25
       25
       +
       		if err := db.Close(); err != nil {

     

       26
       26
       +
       			t.Logf("Failed to close database: %v", err)

     

       27
       27
       +
       		}

     

       28
       28
       +
       	}()

     

       29
       29
       +
       

     

       30
       30
       +
       	ctx := context.Background()

     

       31
       31
       +
       	testUser := createTestUser(t, db, "basicfetch.test", "did:plc:basicfetch123")

     

       32
       32
       +
       	testCommunity, err := createFeedTestCommunity(db, ctx, "basicfetchcomm", "ownerbasic.test")

     

       33
       33
       +
       	require.NoError(t, err, "Failed to create test community")

     

       34
       34
       +
       

     

       35
       35
       +
       	postURI := createTestPost(t, db, testCommunity, testUser.DID, "Basic Fetch Test Post", 0, time.Now())

     

       36
       36
       +
       

     

       37
       37
       +
       	// Create 3 top-level comments with different scores and ages

     

       38
       38
       +
       	comment1 := createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "First comment", 10, 2, time.Now().Add(-2*time.Hour))

     

       39
       39
       +
       	comment2 := createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "Second comment", 5, 1, time.Now().Add(-30*time.Minute))

     

       40
       40
       +
       	comment3 := createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "Third comment", 3, 0, time.Now().Add(-5*time.Minute))

     

       41
       41
       +
       

     

       42
       42
       +
       	// Fetch comments with default params (hot sort)

     

       43
       43
       +
       	service := setupCommentService(db)

     

       44
       44
       +
       	req := &comments.GetCommentsRequest{

     

       45
       45
       +
       		PostURI: postURI,

     

       46
       46
       +
       		Sort:    "hot",

     

       47
       47
       +
       		Depth:   10,

     

       48
       48
       +
       		Limit:   50,

     

       49
       49
       +
       	}

     

       50
       50
       +
       

     

       51
       51
       +
       	resp, err := service.GetComments(ctx, req)

     

       52
       52
       +
       	require.NoError(t, err, "GetComments should not return error")

     

       53
       53
       +
       	require.NotNil(t, resp, "Response should not be nil")

     

       54
       54
       +
       

     

       55
       55
       +
       	// Verify all 3 comments returned

     

       56
       56
       +
       	assert.Len(t, resp.Comments, 3, "Should return all 3 top-level comments")

     

       57
       57
       +
       

     

       58
       58
       +
       	// Verify stats are correct

     

       59
       59
       +
       	for _, threadView := range resp.Comments {

     

       60
       60
       +
       		commentView := threadView.Comment

     

       61
       61
       +
       		assert.NotNil(t, commentView.Stats, "Stats should not be nil")

     

       62
       62
       +
       

     

       63
       63
       +
       		// Verify upvotes, downvotes, score, reply count present

     

       64
       64
       +
       		assert.GreaterOrEqual(t, commentView.Stats.Upvotes, 0, "Upvotes should be non-negative")

     

       65
       65
       +
       		assert.GreaterOrEqual(t, commentView.Stats.Downvotes, 0, "Downvotes should be non-negative")

     

       66
       66
       +
       		assert.Equal(t, 0, commentView.Stats.ReplyCount, "Top-level comments should have 0 replies")

     

       67
       67
       +
       	}

     

       68
       68
       +
       

     

       69
       69
       +
       	// Verify URIs match

     

       70
       70
       +
       	commentURIs := []string{comment1, comment2, comment3}

     

       71
       71
       +
       	returnedURIs := make(map[string]bool)

     

       72
       72
       +
       	for _, tv := range resp.Comments {

     

       73
       73
       +
       		returnedURIs[tv.Comment.URI] = true

     

       74
       74
       +
       	}

     

       75
       75
       +
       

     

       76
       76
       +
       	for _, uri := range commentURIs {

     

       77
       77
       +
       		assert.True(t, returnedURIs[uri], "Comment URI %s should be in results", uri)

     

       78
       78
       +
       	}

     

       79
       79
       +
       }

     

       80
       80
       +
       

     

       81
       81
       +
       // TestCommentQuery_NestedReplies tests fetching comments with nested reply structure

     

       82
       82
       +
       func TestCommentQuery_NestedReplies(t *testing.T) {

     

       83
       83
       +
       	db := setupTestDB(t)

     

       84
       84
       +
       	defer func() {

     

       85
       85
       +
       		if err := db.Close(); err != nil {

     

       86
       86
       +
       			t.Logf("Failed to close database: %v", err)

     

       87
       87
       +
       		}

     

       88
       88
       +
       	}()

     

       89
       89
       +
       

     

       90
       90
       +
       	ctx := context.Background()

     

       91
       91
       +
       	testUser := createTestUser(t, db, "nested.test", "did:plc:nested123")

     

       92
       92
       +
       	testCommunity, err := createFeedTestCommunity(db, ctx, "nestedcomm", "ownernested.test")

     

       93
       93
       +
       	require.NoError(t, err)

     

       94
       94
       +
       

     

       95
       95
       +
       	postURI := createTestPost(t, db, testCommunity, testUser.DID, "Nested Test Post", 0, time.Now())

     

       96
       96
       +
       

     

       97
       97
       +
       	// Create nested structure:

     

       98
       98
       +
       	// Post

     

       99
       99
       +
       	//  |- Comment A (top-level)

     

       100
       100
       +
       	//      |- Reply A1

     

       101
       101
       +
       	//          |- Reply A1a

     

       102
       102
       +
       	//          |- Reply A1b

     

       103
       103
       +
       	//      |- Reply A2

     

       104
       104
       +
       	//  |- Comment B (top-level)

     

       105
       105
       +
       

     

       106
       106
       +
       	commentA := createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "Comment A", 5, 0, time.Now().Add(-1*time.Hour))

     

       107
       107
       +
       	replyA1 := createTestCommentWithScore(t, db, testUser.DID, postURI, commentA, "Reply A1", 3, 0, time.Now().Add(-50*time.Minute))

     

       108
       108
       +
       	replyA1a := createTestCommentWithScore(t, db, testUser.DID, postURI, replyA1, "Reply A1a", 2, 0, time.Now().Add(-40*time.Minute))

     

       109
       109
       +
       	replyA1b := createTestCommentWithScore(t, db, testUser.DID, postURI, replyA1, "Reply A1b", 1, 0, time.Now().Add(-30*time.Minute))

     

       110
       110
       +
       	replyA2 := createTestCommentWithScore(t, db, testUser.DID, postURI, commentA, "Reply A2", 2, 0, time.Now().Add(-20*time.Minute))

     

       111
       111
       +
       	commentB := createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "Comment B", 4, 0, time.Now().Add(-10*time.Minute))

     

       112
       112
       +
       

     

       113
       113
       +
       	// Fetch with depth=2 (should get 2 levels of nesting)

     

       114
       114
       +
       	service := setupCommentService(db)

     

       115
       115
       +
       	req := &comments.GetCommentsRequest{

     

       116
       116
       +
       		PostURI: postURI,

     

       117
       117
       +
       		Sort:    "new",

     

       118
       118
       +
       		Depth:   2,

     

       119
       119
       +
       		Limit:   50,

     

       120
       120
       +
       	}

     

       121
       121
       +
       

     

       122
       122
       +
       	resp, err := service.GetComments(ctx, req)

     

       123
       123
       +
       	require.NoError(t, err)

     

       124
       124
       +
       	require.Len(t, resp.Comments, 2, "Should return 2 top-level comments")

     

       125
       125
       +
       

     

       126
       126
       +
       	// Find Comment A in results

     

       127
       127
       +
       	var commentAThread *comments.ThreadViewComment

     

       128
       128
       +
       	for _, tv := range resp.Comments {

     

       129
       129
       +
       		if tv.Comment.URI == commentA {

     

       130
       130
       +
       			commentAThread = tv

     

       131
       131
       +
       			break

     

       132
       132
       +
       		}

     

       133
       133
       +
       	}

     

       134
       134
       +
       	require.NotNil(t, commentAThread, "Comment A should be in results")

     

       135
       135
       +
       

     

       136
       136
       +
       	// Verify Comment A has replies

     

       137
       137
       +
       	require.NotNil(t, commentAThread.Replies, "Comment A should have replies")

     

       138
       138
       +
       	assert.Len(t, commentAThread.Replies, 2, "Comment A should have 2 direct replies (A1 and A2)")

     

       139
       139
       +
       

     

       140
       140
       +
       	// Find Reply A1

     

       141
       141
       +
       	var replyA1Thread *comments.ThreadViewComment

     

       142
       142
       +
       	for _, reply := range commentAThread.Replies {

     

       143
       143
       +
       		if reply.Comment.URI == replyA1 {

     

       144
       144
       +
       			replyA1Thread = reply

     

       145
       145
       +
       			break

     

       146
       146
       +
       		}

     

       147
       147
       +
       	}

     

       148
       148
       +
       	require.NotNil(t, replyA1Thread, "Reply A1 should be in results")

     

       149
       149
       +
       

     

       150
       150
       +
       	// Verify Reply A1 has nested replies (at depth 2)

     

       151
       151
       +
       	require.NotNil(t, replyA1Thread.Replies, "Reply A1 should have nested replies at depth 2")

     

       152
       152
       +
       	assert.Len(t, replyA1Thread.Replies, 2, "Reply A1 should have 2 nested replies (A1a and A1b)")

     

       153
       153
       +
       

     

       154
       154
       +
       	// Verify reply URIs

     

       155
       155
       +
       	replyURIs := make(map[string]bool)

     

       156
       156
       +
       	for _, r := range replyA1Thread.Replies {

     

       157
       157
       +
       		replyURIs[r.Comment.URI] = true

     

       158
       158
       +
       	}

     

       159
       159
       +
       	assert.True(t, replyURIs[replyA1a], "Reply A1a should be present")

     

       160
       160
       +
       	assert.True(t, replyURIs[replyA1b], "Reply A1b should be present")

     

       161
       161
       +
       

     

       162
       162
       +
       	// Verify no deeper nesting (depth limit enforced)

     

       163
       163
       +
       	for _, r := range replyA1Thread.Replies {

     

       164
       164
       +
       		assert.Nil(t, r.Replies, "Replies at depth 2 should not have further nesting")

     

       165
       165
       +
       	}

     

       166
       166
       +
       

     

       167
       167
       +
       	_ = commentB

     

       168
       168
       +
       	_ = replyA2

     

       169
       169
       +
       }

     

       170
       170
       +
       

     

       171
       171
       +
       // TestCommentQuery_DepthLimit tests depth limiting works correctly

     

       172
       172
       +
       func TestCommentQuery_DepthLimit(t *testing.T) {

     

       173
       173
       +
       	db := setupTestDB(t)

     

       174
       174
       +
       	defer func() {

     

       175
       175
       +
       		if err := db.Close(); err != nil {

     

       176
       176
       +
       			t.Logf("Failed to close database: %v", err)

     

       177
       177
       +
       		}

     

       178
       178
       +
       	}()

     

       179
       179
       +
       

     

       180
       180
       +
       	ctx := context.Background()

     

       181
       181
       +
       	testUser := createTestUser(t, db, "depth.test", "did:plc:depth123")

     

       182
       182
       +
       	testCommunity, err := createFeedTestCommunity(db, ctx, "depthcomm", "ownerdepth.test")

     

       183
       183
       +
       	require.NoError(t, err)

     

       184
       184
       +
       

     

       185
       185
       +
       	postURI := createTestPost(t, db, testCommunity, testUser.DID, "Depth Test Post", 0, time.Now())

     

       186
       186
       +
       

     

       187
       187
       +
       	// Create deeply nested thread (5 levels)

     

       188
       188
       +
       	// Post -> C1 -> C2 -> C3 -> C4 -> C5

     

       189
       189
       +
       	c1 := createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "Level 1", 5, 0, time.Now().Add(-5*time.Minute))

     

       190
       190
       +
       	c2 := createTestCommentWithScore(t, db, testUser.DID, postURI, c1, "Level 2", 4, 0, time.Now().Add(-4*time.Minute))

     

       191
       191
       +
       	c3 := createTestCommentWithScore(t, db, testUser.DID, postURI, c2, "Level 3", 3, 0, time.Now().Add(-3*time.Minute))

     

       192
       192
       +
       	c4 := createTestCommentWithScore(t, db, testUser.DID, postURI, c3, "Level 4", 2, 0, time.Now().Add(-2*time.Minute))

     

       193
       193
       +
       	c5 := createTestCommentWithScore(t, db, testUser.DID, postURI, c4, "Level 5", 1, 0, time.Now().Add(-1*time.Minute))

     

       194
       194
       +
       

     

       195
       195
       +
       	t.Run("Depth 0 returns flat list", func(t *testing.T) {

     

       196
       196
       +
       		service := setupCommentService(db)

     

       197
       197
       +
       		req := &comments.GetCommentsRequest{

     

       198
       198
       +
       			PostURI: postURI,

     

       199
       199
       +
       			Sort:    "new",

     

       200
       200
       +
       			Depth:   0,

     

       201
       201
       +
       			Limit:   50,

     

       202
       202
       +
       		}

     

       203
       203
       +
       

     

       204
       204
       +
       		resp, err := service.GetComments(ctx, req)

     

       205
       205
       +
       		require.NoError(t, err)

     

       206
       206
       +
       		require.Len(t, resp.Comments, 1, "Should return 1 top-level comment")

     

       207
       207
       +
       

     

       208
       208
       +
       		// Verify no replies included

     

       209
       209
       +
       		assert.Nil(t, resp.Comments[0].Replies, "Depth 0 should not include replies")

     

       210
       210
       +
       

     

       211
       211
       +
       		// Verify HasMore flag is set (c1 has replies)

     

       212
       212
       +
       		assert.True(t, resp.Comments[0].HasMore, "HasMore should be true when replies exist but depth=0")

     

       213
       213
       +
       	})

     

       214
       214
       +
       

     

       215
       215
       +
       	t.Run("Depth 3 returns exactly 3 levels", func(t *testing.T) {

     

       216
       216
       +
       		service := setupCommentService(db)

     

       217
       217
       +
       		req := &comments.GetCommentsRequest{

     

       218
       218
       +
       			PostURI: postURI,

     

       219
       219
       +
       			Sort:    "new",

     

       220
       220
       +
       			Depth:   3,

     

       221
       221
       +
       			Limit:   50,

     

       222
       222
       +
       		}

     

       223
       223
       +
       

     

       224
       224
       +
       		resp, err := service.GetComments(ctx, req)

     

       225
       225
       +
       		require.NoError(t, err)

     

       226
       226
       +
       		require.Len(t, resp.Comments, 1, "Should return 1 top-level comment")

     

       227
       227
       +
       

     

       228
       228
       +
       		// Traverse and verify exactly 3 levels

     

       229
       229
       +
       		level1 := resp.Comments[0]

     

       230
       230
       +
       		require.NotNil(t, level1.Replies, "Level 1 should have replies")

     

       231
       231
       +
       		require.Len(t, level1.Replies, 1, "Level 1 should have 1 reply")

     

       232
       232
       +
       

     

       233
       233
       +
       		level2 := level1.Replies[0]

     

       234
       234
       +
       		require.NotNil(t, level2.Replies, "Level 2 should have replies")

     

       235
       235
       +
       		require.Len(t, level2.Replies, 1, "Level 2 should have 1 reply")

     

       236
       236
       +
       

     

       237
       237
       +
       		level3 := level2.Replies[0]

     

       238
       238
       +
       		require.NotNil(t, level3.Replies, "Level 3 should have replies")

     

       239
       239
       +
       		require.Len(t, level3.Replies, 1, "Level 3 should have 1 reply")

     

       240
       240
       +
       

     

       241
       241
       +
       		// Level 4 should NOT have replies (depth limit)

     

       242
       242
       +
       		level4 := level3.Replies[0]

     

       243
       243
       +
       		assert.Nil(t, level4.Replies, "Level 4 should not have replies (depth limit)")

     

       244
       244
       +
       

     

       245
       245
       +
       		// Verify HasMore is set correctly at depth boundary

     

       246
       246
       +
       		assert.True(t, level4.HasMore, "HasMore should be true at depth boundary when more replies exist")

     

       247
       247
       +
       	})

     

       248
       248
       +
       

     

       249
       249
       +
       	_ = c2

     

       250
       250
       +
       	_ = c3

     

       251
       251
       +
       	_ = c4

     

       252
       252
       +
       	_ = c5

     

       253
       253
       +
       }

     

       254
       254
       +
       

     

       255
       255
       +
       // TestCommentQuery_HotSorting tests hot sorting with Lemmy algorithm

     

       256
       256
       +
       func TestCommentQuery_HotSorting(t *testing.T) {

     

       257
       257
       +
       	db := setupTestDB(t)

     

       258
       258
       +
       	defer func() {

     

       259
       259
       +
       		if err := db.Close(); err != nil {

     

       260
       260
       +
       			t.Logf("Failed to close database: %v", err)

     

       261
       261
       +
       		}

     

       262
       262
       +
       	}()

     

       263
       263
       +
       

     

       264
       264
       +
       	ctx := context.Background()

     

       265
       265
       +
       	testUser := createTestUser(t, db, "hot.test", "did:plc:hot123")

     

       266
       266
       +
       	testCommunity, err := createFeedTestCommunity(db, ctx, "hotcomm", "ownerhot.test")

     

       267
       267
       +
       	require.NoError(t, err)

     

       268
       268
       +
       

     

       269
       269
       +
       	postURI := createTestPost(t, db, testCommunity, testUser.DID, "Hot Sorting Test", 0, time.Now())

     

       270
       270
       +
       

     

       271
       271
       +
       	// Create 3 comments with different scores and ages

     

       272
       272
       +
       	// Comment 1: score=10, created 1 hour ago

     

       273
       273
       +
       	c1 := createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "Old high score", 10, 0, time.Now().Add(-1*time.Hour))

     

       274
       274
       +
       

     

       275
       275
       +
       	// Comment 2: score=5, created 5 minutes ago (should rank higher due to recency)

     

       276
       276
       +
       	c2 := createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "Recent medium score", 5, 0, time.Now().Add(-5*time.Minute))

     

       277
       277
       +
       

     

       278
       278
       +
       	// Comment 3: score=-2, created now (negative score should rank lower)

     

       279
       279
       +
       	c3 := createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "Negative score", 0, 2, time.Now())

     

       280
       280
       +
       

     

       281
       281
       +
       	service := setupCommentService(db)

     

       282
       282
       +
       	req := &comments.GetCommentsRequest{

     

       283
       283
       +
       		PostURI: postURI,

     

       284
       284
       +
       		Sort:    "hot",

     

       285
       285
       +
       		Depth:   0,

     

       286
       286
       +
       		Limit:   50,

     

       287
       287
       +
       	}

     

       288
       288
       +
       

     

       289
       289
       +
       	resp, err := service.GetComments(ctx, req)

     

       290
       290
       +
       	require.NoError(t, err)

     

       291
       291
       +
       	require.Len(t, resp.Comments, 3, "Should return all 3 comments")

     

       292
       292
       +
       

     

       293
       293
       +
       	// Verify hot sorting order

     

       294
       294
       +
       	// Recent comment with medium score should rank higher than old comment with high score

     

       295
       295
       +
       	assert.Equal(t, c2, resp.Comments[0].Comment.URI, "Recent medium score should rank first")

     

       296
       296
       +
       	assert.Equal(t, c1, resp.Comments[1].Comment.URI, "Old high score should rank second")

     

       297
       297
       +
       	assert.Equal(t, c3, resp.Comments[2].Comment.URI, "Negative score should rank last")

     

       298
       298
       +
       

     

       299
       299
       +
       	// Verify negative scores are handled gracefully

     

       300
       300
       +
       	negativeComment := resp.Comments[2].Comment

     

       301
       301
       +
       	assert.Equal(t, -2, negativeComment.Stats.Score, "Negative score should be preserved")

     

       302
       302
       +
       	assert.Equal(t, 0, negativeComment.Stats.Upvotes, "Upvotes should be 0")

     

       303
       303
       +
       	assert.Equal(t, 2, negativeComment.Stats.Downvotes, "Downvotes should be 2")

     

       304
       304
       +
       }

     

       305
       305
       +
       

     

       306
       306
       +
       // TestCommentQuery_TopSorting tests top sorting with score-based ordering

     

       307
       307
       +
       func TestCommentQuery_TopSorting(t *testing.T) {

     

       308
       308
       +
       	db := setupTestDB(t)

     

       309
       309
       +
       	defer func() {

     

       310
       310
       +
       		if err := db.Close(); err != nil {

     

       311
       311
       +
       			t.Logf("Failed to close database: %v", err)

     

       312
       312
       +
       		}

     

       313
       313
       +
       	}()

     

       314
       314
       +
       

     

       315
       315
       +
       	ctx := context.Background()

     

       316
       316
       +
       	testUser := createTestUser(t, db, "top.test", "did:plc:top123")

     

       317
       317
       +
       	testCommunity, err := createFeedTestCommunity(db, ctx, "topcomm", "ownertop.test")

     

       318
       318
       +
       	require.NoError(t, err)

     

       319
       319
       +
       

     

       320
       320
       +
       	postURI := createTestPost(t, db, testCommunity, testUser.DID, "Top Sorting Test", 0, time.Now())

     

       321
       321
       +
       

     

       322
       322
       +
       	// Create comments with different scores

     

       323
       323
       +
       	c1 := createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "Low score", 2, 0, time.Now().Add(-30*time.Minute))

     

       324
       324
       +
       	c2 := createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "High score", 10, 0, time.Now().Add(-1*time.Hour))

     

       325
       325
       +
       	c3 := createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "Medium score", 5, 0, time.Now().Add(-15*time.Minute))

     

       326
       326
       +
       

     

       327
       327
       +
       	t.Run("Top sort without timeframe", func(t *testing.T) {

     

       328
       328
       +
       		service := setupCommentService(db)

     

       329
       329
       +
       		req := &comments.GetCommentsRequest{

     

       330
       330
       +
       			PostURI: postURI,

     

       331
       331
       +
       			Sort:    "top",

     

       332
       332
       +
       			Depth:   0,

     

       333
       333
       +
       			Limit:   50,

     

       334
       334
       +
       		}

     

       335
       335
       +
       

     

       336
       336
       +
       		resp, err := service.GetComments(ctx, req)

     

       337
       337
       +
       		require.NoError(t, err)

     

       338
       338
       +
       		require.Len(t, resp.Comments, 3)

     

       339
       339
       +
       

     

       340
       340
       +
       		// Verify highest score first

     

       341
       341
       +
       		assert.Equal(t, c2, resp.Comments[0].Comment.URI, "Highest score should be first")

     

       342
       342
       +
       		assert.Equal(t, c3, resp.Comments[1].Comment.URI, "Medium score should be second")

     

       343
       343
       +
       		assert.Equal(t, c1, resp.Comments[2].Comment.URI, "Low score should be third")

     

       344
       344
       +
       	})

     

       345
       345
       +
       

     

       346
       346
       +
       	t.Run("Top sort with hour timeframe", func(t *testing.T) {

     

       347
       347
       +
       		service := setupCommentService(db)

     

       348
       348
       +
       		req := &comments.GetCommentsRequest{

     

       349
       349
       +
       			PostURI:   postURI,

     

       350
       350
       +
       			Sort:      "top",

     

       351
       351
       +
       			Timeframe: "hour",

     

       352
       352
       +
       			Depth:     0,

     

       353
       353
       +
       			Limit:     50,

     

       354
       354
       +
       		}

     

       355
       355
       +
       

     

       356
       356
       +
       		resp, err := service.GetComments(ctx, req)

     

       357
       357
       +
       		require.NoError(t, err)

     

       358
       358
       +
       

     

       359
       359
       +
       		// Only comments from last hour should be included (c1 and c3, not c2)

     

       360
       360
       +
       		assert.LessOrEqual(t, len(resp.Comments), 2, "Should exclude comments older than 1 hour")

     

       361
       361
       +
       

     

       362
       362
       +
       		// Verify c2 (created 1 hour ago) is excluded

     

       363
       363
       +
       		for _, tv := range resp.Comments {

     

       364
       364
       +
       			assert.NotEqual(t, c2, tv.Comment.URI, "Comment older than 1 hour should be excluded")

     

       365
       365
       +
       		}

     

       366
       366
       +
       	})

     

       367
       367
       +
       }

     

       368
       368
       +
       

     

       369
       369
       +
       // TestCommentQuery_NewSorting tests chronological sorting

     

       370
       370
       +
       func TestCommentQuery_NewSorting(t *testing.T) {

     

       371
       371
       +
       	db := setupTestDB(t)

     

       372
       372
       +
       	defer func() {

     

       373
       373
       +
       		if err := db.Close(); err != nil {

     

       374
       374
       +
       			t.Logf("Failed to close database: %v", err)

     

       375
       375
       +
       		}

     

       376
       376
       +
       	}()

     

       377
       377
       +
       

     

       378
       378
       +
       	ctx := context.Background()

     

       379
       379
       +
       	testUser := createTestUser(t, db, "new.test", "did:plc:new123")

     

       380
       380
       +
       	testCommunity, err := createFeedTestCommunity(db, ctx, "newcomm", "ownernew.test")

     

       381
       381
       +
       	require.NoError(t, err)

     

       382
       382
       +
       

     

       383
       383
       +
       	postURI := createTestPost(t, db, testCommunity, testUser.DID, "New Sorting Test", 0, time.Now())

     

       384
       384
       +
       

     

       385
       385
       +
       	// Create comments at different times (different scores to verify time is priority)

     

       386
       386
       +
       	c1 := createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "Oldest", 10, 0, time.Now().Add(-1*time.Hour))

     

       387
       387
       +
       	c2 := createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "Middle", 5, 0, time.Now().Add(-30*time.Minute))

     

       388
       388
       +
       	c3 := createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "Newest", 2, 0, time.Now().Add(-5*time.Minute))

     

       389
       389
       +
       

     

       390
       390
       +
       	service := setupCommentService(db)

     

       391
       391
       +
       	req := &comments.GetCommentsRequest{

     

       392
       392
       +
       		PostURI: postURI,

     

       393
       393
       +
       		Sort:    "new",

     

       394
       394
       +
       		Depth:   0,

     

       395
       395
       +
       		Limit:   50,

     

       396
       396
       +
       	}

     

       397
       397
       +
       

     

       398
       398
       +
       	resp, err := service.GetComments(ctx, req)

     

       399
       399
       +
       	require.NoError(t, err)

     

       400
       400
       +
       	require.Len(t, resp.Comments, 3)

     

       401
       401
       +
       

     

       402
       402
       +
       	// Verify chronological order (newest first)

     

       403
       403
       +
       	assert.Equal(t, c3, resp.Comments[0].Comment.URI, "Newest comment should be first")

     

       404
       404
       +
       	assert.Equal(t, c2, resp.Comments[1].Comment.URI, "Middle comment should be second")

     

       405
       405
       +
       	assert.Equal(t, c1, resp.Comments[2].Comment.URI, "Oldest comment should be third")

     

       406
       406
       +
       }

     

       407
       407
       +
       

     

       408
       408
       +
       // TestCommentQuery_Pagination tests cursor-based pagination

     

       409
       409
       +
       func TestCommentQuery_Pagination(t *testing.T) {

     

       410
       410
       +
       	db := setupTestDB(t)

     

       411
       411
       +
       	defer func() {

     

       412
       412
       +
       		if err := db.Close(); err != nil {

     

       413
       413
       +
       			t.Logf("Failed to close database: %v", err)

     

       414
       414
       +
       		}

     

       415
       415
       +
       	}()

     

       416
       416
       +
       

     

       417
       417
       +
       	ctx := context.Background()

     

       418
       418
       +
       	testUser := createTestUser(t, db, "page.test", "did:plc:page123")

     

       419
       419
       +
       	testCommunity, err := createFeedTestCommunity(db, ctx, "pagecomm", "ownerpage.test")

     

       420
       420
       +
       	require.NoError(t, err)

     

       421
       421
       +
       

     

       422
       422
       +
       	postURI := createTestPost(t, db, testCommunity, testUser.DID, "Pagination Test", 0, time.Now())

     

       423
       423
       +
       

     

       424
       424
       +
       	// Create 60 comments

     

       425
       425
       +
       	allCommentURIs := make([]string, 60)

     

       426
       426
       +
       	for i := 0; i < 60; i++ {

     

       427
       427
       +
       		uri := createTestCommentWithScore(t, db, testUser.DID, postURI, postURI,

     

       428
       428
       +
       			fmt.Sprintf("Comment %d", i), i, 0, time.Now().Add(-time.Duration(60-i)*time.Minute))

     

       429
       429
       +
       		allCommentURIs[i] = uri

     

       430
       430
       +
       	}

     

       431
       431
       +
       

     

       432
       432
       +
       	service := setupCommentService(db)

     

       433
       433
       +
       

     

       434
       434
       +
       	// Fetch first page (limit=50)

     

       435
       435
       +
       	req1 := &comments.GetCommentsRequest{

     

       436
       436
       +
       		PostURI: postURI,

     

       437
       437
       +
       		Sort:    "new",

     

       438
       438
       +
       		Depth:   0,

     

       439
       439
       +
       		Limit:   50,

     

       440
       440
       +
       	}

     

       441
       441
       +
       

     

       442
       442
       +
       	resp1, err := service.GetComments(ctx, req1)

     

       443
       443
       +
       	require.NoError(t, err)

     

       444
       444
       +
       	assert.Len(t, resp1.Comments, 50, "First page should have 50 comments")

     

       445
       445
       +
       	require.NotNil(t, resp1.Cursor, "Cursor should be present for next page")

     

       446
       446
       +
       

     

       447
       447
       +
       	// Fetch second page with cursor

     

       448
       448
       +
       	req2 := &comments.GetCommentsRequest{

     

       449
       449
       +
       		PostURI: postURI,

     

       450
       450
       +
       		Sort:    "new",

     

       451
       451
       +
       		Depth:   0,

     

       452
       452
       +
       		Limit:   50,

     

       453
       453
       +
       		Cursor:  resp1.Cursor,

     

       454
       454
       +
       	}

     

       455
       455
       +
       

     

       456
       456
       +
       	resp2, err := service.GetComments(ctx, req2)

     

       457
       457
       +
       	require.NoError(t, err)

     

       458
       458
       +
       	assert.Len(t, resp2.Comments, 10, "Second page should have remaining 10 comments")

     

       459
       459
       +
       	assert.Nil(t, resp2.Cursor, "Cursor should be nil on last page")

     

       460
       460
       +
       

     

       461
       461
       +
       	// Verify no duplicates between pages

     

       462
       462
       +
       	page1URIs := make(map[string]bool)

     

       463
       463
       +
       	for _, tv := range resp1.Comments {

     

       464
       464
       +
       		page1URIs[tv.Comment.URI] = true

     

       465
       465
       +
       	}

     

       466
       466
       +
       

     

       467
       467
       +
       	for _, tv := range resp2.Comments {

     

       468
       468
       +
       		assert.False(t, page1URIs[tv.Comment.URI], "Comment %s should not appear in both pages", tv.Comment.URI)

     

       469
       469
       +
       	}

     

       470
       470
       +
       

     

       471
       471
       +
       	// Verify all comments eventually retrieved

     

       472
       472
       +
       	allRetrieved := make(map[string]bool)

     

       473
       473
       +
       	for _, tv := range resp1.Comments {

     

       474
       474
       +
       		allRetrieved[tv.Comment.URI] = true

     

       475
       475
       +
       	}

     

       476
       476
       +
       	for _, tv := range resp2.Comments {

     

       477
       477
       +
       		allRetrieved[tv.Comment.URI] = true

     

       478
       478
       +
       	}

     

       479
       479
       +
       	assert.Len(t, allRetrieved, 60, "All 60 comments should be retrieved across pages")

     

       480
       480
       +
       }

     

       481
       481
       +
       

     

       482
       482
       +
       // TestCommentQuery_EmptyThread tests fetching comments from a post with no comments

     

       483
       483
       +
       func TestCommentQuery_EmptyThread(t *testing.T) {

     

       484
       484
       +
       	db := setupTestDB(t)

     

       485
       485
       +
       	defer func() {

     

       486
       486
       +
       		if err := db.Close(); err != nil {

     

       487
       487
       +
       			t.Logf("Failed to close database: %v", err)

     

       488
       488
       +
       		}

     

       489
       489
       +
       	}()

     

       490
       490
       +
       

     

       491
       491
       +
       	ctx := context.Background()

     

       492
       492
       +
       	testUser := createTestUser(t, db, "empty.test", "did:plc:empty123")

     

       493
       493
       +
       	testCommunity, err := createFeedTestCommunity(db, ctx, "emptycomm", "ownerempty.test")

     

       494
       494
       +
       	require.NoError(t, err)

     

       495
       495
       +
       

     

       496
       496
       +
       	postURI := createTestPost(t, db, testCommunity, testUser.DID, "Empty Thread Test", 0, time.Now())

     

       497
       497
       +
       

     

       498
       498
       +
       	service := setupCommentService(db)

     

       499
       499
       +
       	req := &comments.GetCommentsRequest{

     

       500
       500
       +
       		PostURI: postURI,

     

       501
       501
       +
       		Sort:    "hot",

     

       502
       502
       +
       		Depth:   10,

     

       503
       503
       +
       		Limit:   50,

     

       504
       504
       +
       	}

     

       505
       505
       +
       

     

       506
       506
       +
       	resp, err := service.GetComments(ctx, req)

     

       507
       507
       +
       	require.NoError(t, err)

     

       508
       508
       +
       	require.NotNil(t, resp, "Response should not be nil")

     

       509
       509
       +
       

     

       510
       510
       +
       	// Verify empty array (not null)

     

       511
       511
       +
       	assert.NotNil(t, resp.Comments, "Comments array should not be nil")

     

       512
       512
       +
       	assert.Len(t, resp.Comments, 0, "Comments array should be empty")

     

       513
       513
       +
       

     

       514
       514
       +
       	// Verify no cursor returned

     

       515
       515
       +
       	assert.Nil(t, resp.Cursor, "Cursor should be nil for empty results")

     

       516
       516
       +
       }

     

       517
       517
       +
       

     

       518
       518
       +
       // TestCommentQuery_DeletedComments tests that soft-deleted comments are excluded

     

       519
       519
       +
       func TestCommentQuery_DeletedComments(t *testing.T) {

     

       520
       520
       +
       	db := setupTestDB(t)

     

       521
       521
       +
       	defer func() {

     

       522
       522
       +
       		if err := db.Close(); err != nil {

     

       523
       523
       +
       			t.Logf("Failed to close database: %v", err)

     

       524
       524
       +
       		}

     

       525
       525
       +
       	}()

     

       526
       526
       +
       

     

       527
       527
       +
       	ctx := context.Background()

     

       528
       528
       +
       	commentRepo := postgres.NewCommentRepository(db)

     

       529
       529
       +
       	consumer := jetstream.NewCommentEventConsumer(commentRepo, db)

     

       530
       530
       +
       

     

       531
       531
       +
       	testUser := createTestUser(t, db, "deleted.test", "did:plc:deleted123")

     

       532
       532
       +
       	testCommunity, err := createFeedTestCommunity(db, ctx, "deletedcomm", "ownerdeleted.test")

     

       533
       533
       +
       	require.NoError(t, err)

     

       534
       534
       +
       

     

       535
       535
       +
       	postURI := createTestPost(t, db, testCommunity, testUser.DID, "Deleted Comments Test", 0, time.Now())

     

       536
       536
       +
       

     

       537
       537
       +
       	// Create 5 comments via Jetstream consumer

     

       538
       538
       +
       	commentURIs := make([]string, 5)

     

       539
       539
       +
       	for i := 0; i < 5; i++ {

     

       540
       540
       +
       		rkey := generateTID()

     

       541
       541
       +
       		uri := fmt.Sprintf("at://%s/social.coves.feed.comment/%s", testUser.DID, rkey)

     

       542
       542
       +
       		commentURIs[i] = uri

     

       543
       543
       +
       

     

       544
       544
       +
       		event := &jetstream.JetstreamEvent{

     

       545
       545
       +
       			Did:  testUser.DID,

     

       546
       546
       +
       			Kind: "commit",

     

       547
       547
       +
       			Commit: &jetstream.CommitEvent{

     

       548
       548
       +
       				Operation:  "create",

     

       549
       549
       +
       				Collection: "social.coves.feed.comment",

     

       550
       550
       +
       				RKey:       rkey,

     

       551
       551
       +
       				CID:        fmt.Sprintf("bafyc%d", i),

     

       552
       552
       +
       				Record: map[string]interface{}{

     

       553
       553
       +
       					"$type":   "social.coves.feed.comment",

     

       554
       554
       +
       					"content": fmt.Sprintf("Comment %d", i),

     

       555
       555
       +
       					"reply": map[string]interface{}{

     

       556
       556
       +
       						"root": map[string]interface{}{

     

       557
       557
       +
       							"uri": postURI,

     

       558
       558
       +
       							"cid": "bafypost",

     

       559
       559
       +
       						},

     

       560
       560
       +
       						"parent": map[string]interface{}{

     

       561
       561
       +
       							"uri": postURI,

     

       562
       562
       +
       							"cid": "bafypost",

     

       563
       563
       +
       						},

     

       564
       564
       +
       					},

     

       565
       565
       +
       					"createdAt": time.Now().Add(time.Duration(i) * time.Minute).Format(time.RFC3339),

     

       566
       566
       +
       				},

     

       567
       567
       +
       			},

     

       568
       568
       +
       		}

     

       569
       569
       +
       

     

       570
       570
       +
       		require.NoError(t, consumer.HandleEvent(ctx, event))

     

       571
       571
       +
       	}

     

       572
       572
       +
       

     

       573
       573
       +
       	// Soft-delete 2 comments (index 1 and 3)

     

       574
       574
       +
       	deleteEvent1 := &jetstream.JetstreamEvent{

     

       575
       575
       +
       		Did:  testUser.DID,

     

       576
       576
       +
       		Kind: "commit",

     

       577
       577
       +
       		Commit: &jetstream.CommitEvent{

     

       578
       578
       +
       			Operation:  "delete",

     

       579
       579
       +
       			Collection: "social.coves.feed.comment",

     

       580
       580
       +
       			RKey:       strings.Split(commentURIs[1], "/")[4],

     

       581
       581
       +
       		},

     

       582
       582
       +
       	}

     

       583
       583
       +
       	require.NoError(t, consumer.HandleEvent(ctx, deleteEvent1))

     

       584
       584
       +
       

     

       585
       585
       +
       	deleteEvent2 := &jetstream.JetstreamEvent{

     

       586
       586
       +
       		Did:  testUser.DID,

     

       587
       587
       +
       		Kind: "commit",

     

       588
       588
       +
       		Commit: &jetstream.CommitEvent{

     

       589
       589
       +
       			Operation:  "delete",

     

       590
       590
       +
       			Collection: "social.coves.feed.comment",

     

       591
       591
       +
       			RKey:       strings.Split(commentURIs[3], "/")[4],

     

       592
       592
       +
       		},

     

       593
       593
       +
       	}

     

       594
       594
       +
       	require.NoError(t, consumer.HandleEvent(ctx, deleteEvent2))

     

       595
       595
       +
       

     

       596
       596
       +
       	// Fetch comments

     

       597
       597
       +
       	service := setupCommentService(db)

     

       598
       598
       +
       	req := &comments.GetCommentsRequest{

     

       599
       599
       +
       		PostURI: postURI,

     

       600
       600
       +
       		Sort:    "new",

     

       601
       601
       +
       		Depth:   0,

     

       602
       602
       +
       		Limit:   50,

     

       603
       603
       +
       	}

     

       604
       604
       +
       

     

       605
       605
       +
       	resp, err := service.GetComments(ctx, req)

     

       606
       606
       +
       	require.NoError(t, err)

     

       607
       607
       +
       

     

       608
       608
       +
       	// Verify only 3 comments returned (2 were deleted)

     

       609
       609
       +
       	assert.Len(t, resp.Comments, 3, "Should only return non-deleted comments")

     

       610
       610
       +
       

     

       611
       611
       +
       	// Verify deleted comments are not in results

     

       612
       612
       +
       	returnedURIs := make(map[string]bool)

     

       613
       613
       +
       	for _, tv := range resp.Comments {

     

       614
       614
       +
       		returnedURIs[tv.Comment.URI] = true

     

       615
       615
       +
       	}

     

       616
       616
       +
       

     

       617
       617
       +
       	assert.False(t, returnedURIs[commentURIs[1]], "Deleted comment 1 should not be in results")

     

       618
       618
       +
       	assert.False(t, returnedURIs[commentURIs[3]], "Deleted comment 3 should not be in results")

     

       619
       619
       +
       	assert.True(t, returnedURIs[commentURIs[0]], "Non-deleted comment 0 should be in results")

     

       620
       620
       +
       	assert.True(t, returnedURIs[commentURIs[2]], "Non-deleted comment 2 should be in results")

     

       621
       621
       +
       	assert.True(t, returnedURIs[commentURIs[4]], "Non-deleted comment 4 should be in results")

     

       622
       622
       +
       }

     

       623
       623
       +
       

     

       624
       624
       +
       // TestCommentQuery_InvalidInputs tests error handling for invalid inputs

     

       625
       625
       +
       func TestCommentQuery_InvalidInputs(t *testing.T) {

     

       626
       626
       +
       	db := setupTestDB(t)

     

       627
       627
       +
       	defer func() {

     

       628
       628
       +
       		if err := db.Close(); err != nil {

     

       629
       629
       +
       			t.Logf("Failed to close database: %v", err)

     

       630
       630
       +
       		}

     

       631
       631
       +
       	}()

     

       632
       632
       +
       

     

       633
       633
       +
       	ctx := context.Background()

     

       634
       634
       +
       	service := setupCommentService(db)

     

       635
       635
       +
       

     

       636
       636
       +
       	t.Run("Invalid post URI", func(t *testing.T) {

     

       637
       637
       +
       		req := &comments.GetCommentsRequest{

     

       638
       638
       +
       			PostURI: "not-an-at-uri",

     

       639
       639
       +
       			Sort:    "hot",

     

       640
       640
       +
       			Depth:   10,

     

       641
       641
       +
       			Limit:   50,

     

       642
       642
       +
       		}

     

       643
       643
       +
       

     

       644
       644
       +
       		_, err := service.GetComments(ctx, req)

     

       645
       645
       +
       		assert.Error(t, err, "Should return error for invalid AT-URI")

     

       646
       646
       +
       		assert.Contains(t, err.Error(), "invalid", "Error should mention invalid")

     

       647
       647
       +
       	})

     

       648
       648
       +
       

     

       649
       649
       +
       	t.Run("Negative depth", func(t *testing.T) {

     

       650
       650
       +
       		req := &comments.GetCommentsRequest{

     

       651
       651
       +
       			PostURI: "at://did:plc:test/social.coves.feed.post/abc123",

     

       652
       652
       +
       			Sort:    "hot",

     

       653
       653
       +
       			Depth:   -5,

     

       654
       654
       +
       			Limit:   50,

     

       655
       655
       +
       		}

     

       656
       656
       +
       

     

       657
       657
       +
       		resp, err := service.GetComments(ctx, req)

     

       658
       658
       +
       		// Should not error, but should clamp to default (10)

     

       659
       659
       +
       		require.NoError(t, err)

     

       660
       660
       +
       		// Depth is normalized in validation

     

       661
       661
       +
       		_ = resp

     

       662
       662
       +
       	})

     

       663
       663
       +
       

     

       664
       664
       +
       	t.Run("Depth exceeds max", func(t *testing.T) {

     

       665
       665
       +
       		req := &comments.GetCommentsRequest{

     

       666
       666
       +
       			PostURI: "at://did:plc:test/social.coves.feed.post/abc123",

     

       667
       667
       +
       			Sort:    "hot",

     

       668
       668
       +
       			Depth:   150, // Exceeds max of 100

     

       669
       669
       +
       			Limit:   50,

     

       670
       670
       +
       		}

     

       671
       671
       +
       

     

       672
       672
       +
       		resp, err := service.GetComments(ctx, req)

     

       673
       673
       +
       		// Should not error, but should clamp to 100

     

       674
       674
       +
       		require.NoError(t, err)

     

       675
       675
       +
       		_ = resp

     

       676
       676
       +
       	})

     

       677
       677
       +
       

     

       678
       678
       +
       	t.Run("Limit exceeds max", func(t *testing.T) {

     

       679
       679
       +
       		req := &comments.GetCommentsRequest{

     

       680
       680
       +
       			PostURI: "at://did:plc:test/social.coves.feed.post/abc123",

     

       681
       681
       +
       			Sort:    "hot",

     

       682
       682
       +
       			Depth:   10,

     

       683
       683
       +
       			Limit:   150, // Exceeds max of 100

     

       684
       684
       +
       		}

     

       685
       685
       +
       

     

       686
       686
       +
       		resp, err := service.GetComments(ctx, req)

     

       687
       687
       +
       		// Should not error, but should clamp to 100

     

       688
       688
       +
       		require.NoError(t, err)

     

       689
       689
       +
       		_ = resp

     

       690
       690
       +
       	})

     

       691
       691
       +
       

     

       692
       692
       +
       	t.Run("Invalid sort", func(t *testing.T) {

     

       693
       693
       +
       		req := &comments.GetCommentsRequest{

     

       694
       694
       +
       			PostURI: "at://did:plc:test/social.coves.feed.post/abc123",

     

       695
       695
       +
       			Sort:    "invalid",

     

       696
       696
       +
       			Depth:   10,

     

       697
       697
       +
       			Limit:   50,

     

       698
       698
       +
       		}

     

       699
       699
       +
       

     

       700
       700
       +
       		_, err := service.GetComments(ctx, req)

     

       701
       701
       +
       		assert.Error(t, err, "Should return error for invalid sort")

     

       702
       702
       +
       		assert.Contains(t, err.Error(), "invalid sort", "Error should mention invalid sort")

     

       703
       703
       +
       	})

     

       704
       704
       +
       

     

       705
       705
       +
       	t.Run("Empty post URI", func(t *testing.T) {

     

       706
       706
       +
       		req := &comments.GetCommentsRequest{

     

       707
       707
       +
       			PostURI: "",

     

       708
       708
       +
       			Sort:    "hot",

     

       709
       709
       +
       			Depth:   10,

     

       710
       710
       +
       			Limit:   50,

     

       711
       711
       +
       		}

     

       712
       712
       +
       

     

       713
       713
       +
       		_, err := service.GetComments(ctx, req)

     

       714
       714
       +
       		assert.Error(t, err, "Should return error for empty post URI")

     

       715
       715
       +
       	})

     

       716
       716
       +
       }

     

       717
       717
       +
       

     

       718
       718
       +
       // TestCommentQuery_HTTPHandler tests the HTTP handler end-to-end

     

       719
       719
       +
       func TestCommentQuery_HTTPHandler(t *testing.T) {

     

       720
       720
       +
       	db := setupTestDB(t)

     

       721
       721
       +
       	defer func() {

     

       722
       722
       +
       		if err := db.Close(); err != nil {

     

       723
       723
       +
       			t.Logf("Failed to close database: %v", err)

     

       724
       724
       +
       		}

     

       725
       725
       +
       	}()

     

       726
       726
       +
       

     

       727
       727
       +
       	ctx := context.Background()

     

       728
       728
       +
       	testUser := createTestUser(t, db, "http.test", "did:plc:http123")

     

       729
       729
       +
       	testCommunity, err := createFeedTestCommunity(db, ctx, "httpcomm", "ownerhttp.test")

     

       730
       730
       +
       	require.NoError(t, err)

     

       731
       731
       +
       

     

       732
       732
       +
       	postURI := createTestPost(t, db, testCommunity, testUser.DID, "HTTP Handler Test", 0, time.Now())

     

       733
       733
       +
       

     

       734
       734
       +
       	// Create test comments

     

       735
       735
       +
       	createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "Test comment 1", 5, 0, time.Now().Add(-30*time.Minute))

     

       736
       736
       +
       	createTestCommentWithScore(t, db, testUser.DID, postURI, postURI, "Test comment 2", 3, 0, time.Now().Add(-15*time.Minute))

     

       737
       737
       +
       

     

       738
       738
       +
       	// Setup service adapter for HTTP handler

     

       739
       739
       +
       	service := setupCommentServiceAdapter(db)

     

       740
       740
       +
       	handler := &testGetCommentsHandler{service: service}

     

       741
       741
       +
       

     

       742
       742
       +
       	t.Run("Valid GET request", func(t *testing.T) {

     

       743
       743
       +
       		req := httptest.NewRequest("GET", fmt.Sprintf("/xrpc/social.coves.feed.getComments?post=%s&sort=hot&depth=10&limit=50", postURI), nil)

     

       744
       744
       +
       		w := httptest.NewRecorder()

     

       745
       745
       +
       

     

       746
       746
       +
       		handler.ServeHTTP(w, req)

     

       747
       747
       +
       

     

       748
       748
       +
       		assert.Equal(t, http.StatusOK, w.Code)

     

       749
       749
       +
       		assert.Equal(t, "application/json", w.Header().Get("Content-Type"))

     

       750
       750
       +
       

     

       751
       751
       +
       		var resp comments.GetCommentsResponse

     

       752
       752
       +
       		err := json.NewDecoder(w.Body).Decode(&resp)

     

       753
       753
       +
       		require.NoError(t, err)

     

       754
       754
       +
       		assert.Len(t, resp.Comments, 2, "Should return 2 comments")

     

       755
       755
       +
       	})

     

       756
       756
       +
       

     

       757
       757
       +
       	t.Run("Missing post parameter", func(t *testing.T) {

     

       758
       758
       +
       		req := httptest.NewRequest("GET", "/xrpc/social.coves.feed.getComments?sort=hot", nil)

     

       759
       759
       +
       		w := httptest.NewRecorder()

     

       760
       760
       +
       

     

       761
       761
       +
       		handler.ServeHTTP(w, req)

     

       762
       762
       +
       

     

       763
       763
       +
       		assert.Equal(t, http.StatusBadRequest, w.Code)

     

       764
       764
       +
       	})

     

       765
       765
       +
       

     

       766
       766
       +
       	t.Run("Invalid depth parameter", func(t *testing.T) {

     

       767
       767
       +
       		req := httptest.NewRequest("GET", fmt.Sprintf("/xrpc/social.coves.feed.getComments?post=%s&depth=invalid", postURI), nil)

     

       768
       768
       +
       		w := httptest.NewRecorder()

     

       769
       769
       +
       

     

       770
       770
       +
       		handler.ServeHTTP(w, req)

     

       771
       771
       +
       

     

       772
       772
       +
       		assert.Equal(t, http.StatusBadRequest, w.Code)

     

       773
       773
       +
       	})

     

       774
       774
       +
       }

     

       775
       775
       +
       

     

       776
       776
       +
       // Helper: setupCommentService creates a comment service for testing

     

       777
       777
       +
       func setupCommentService(db *sql.DB) comments.Service {

     

       778
       778
       +
       	commentRepo := postgres.NewCommentRepository(db)

     

       779
       779
       +
       	return comments.NewCommentService(commentRepo, nil, nil)

     

       780
       780
       +
       }

     

       781
       781
       +
       

     

       782
       782
       +
       // Helper: createTestCommentWithScore creates a comment with specific vote counts

     

       783
       783
       +
       func createTestCommentWithScore(t *testing.T, db *sql.DB, commenterDID, rootURI, parentURI, content string, upvotes, downvotes int, createdAt time.Time) string {

     

       784
       784
       +
       	t.Helper()

     

       785
       785
       +
       

     

       786
       786
       +
       	ctx := context.Background()

     

       787
       787
       +
       	rkey := generateTID()

     

       788
       788
       +
       	uri := fmt.Sprintf("at://%s/social.coves.feed.comment/%s", commenterDID, rkey)

     

       789
       789
       +
       

     

       790
       790
       +
       	// Insert comment directly for speed

     

       791
       791
       +
       	_, err := db.ExecContext(ctx, `

     

       792
       792
       +
       		INSERT INTO comments (

     

       793
       793
       +
       			uri, cid, rkey, commenter_did,

     

       794
       794
       +
       			root_uri, root_cid, parent_uri, parent_cid,

     

       795
       795
       +
       			content, created_at, indexed_at,

     

       796
       796
       +
       			upvote_count, downvote_count, score

     

       797
       797
       +
       		) VALUES (

     

       798
       798
       +
       			$1, $2, $3, $4,

     

       799
       799
       +
       			$5, $6, $7, $8,

     

       800
       800
       +
       			$9, $10, NOW(),

     

       801
       801
       +
       			$11, $12, $13

     

       802
       802
       +
       		)

     

       803
       803
       +
       	`, uri, fmt.Sprintf("bafyc%s", rkey), rkey, commenterDID,

     

       804
       804
       +
       		rootURI, "bafyroot", parentURI, "bafyparent",

     

       805
       805
       +
       		content, createdAt,

     

       806
       806
       +
       		upvotes, downvotes, upvotes-downvotes)

     

       807
       807
       +
       

     

       808
       808
       +
       	require.NoError(t, err, "Failed to create test comment")

     

       809
       809
       +
       

     

       810
       810
       +
       	// Update reply count on parent if it's a nested comment

     

       811
       811
       +
       	if parentURI != rootURI {

     

       812
       812
       +
       		_, _ = db.ExecContext(ctx, `

     

       813
       813
       +
       			UPDATE comments

     

       814
       814
       +
       			SET reply_count = reply_count + 1

     

       815
       815
       +
       			WHERE uri = $1

     

       816
       816
       +
       		`, parentURI)

     

       817
       817
       +
       	} else {

     

       818
       818
       +
       		// Update comment count on post if top-level

     

       819
       819
       +
       		_, _ = db.ExecContext(ctx, `

     

       820
       820
       +
       			UPDATE posts

     

       821
       821
       +
       			SET comment_count = comment_count + 1

     

       822
       822
       +
       			WHERE uri = $1

     

       823
       823
       +
       		`, parentURI)

     

       824
       824
       +
       	}

     

       825
       825
       +
       

     

       826
       826
       +
       	return uri

     

       827
       827
       +
       }

     

       828
       828
       +
       

     

       829
       829
       +
       // Helper: Service adapter for HTTP handler testing

     

       830
       830
       +
       type testCommentServiceAdapter struct {

     

       831
       831
       +
       	service comments.Service

     

       832
       832
       +
       }

     

       833
       833
       +
       

     

       834
       834
       +
       func (s *testCommentServiceAdapter) GetComments(r *http.Request, req *testGetCommentsRequest) (*comments.GetCommentsResponse, error) {

     

       835
       835
       +
       	ctx := r.Context()

     

       836
       836
       +
       

     

       837
       837
       +
       	serviceReq := &comments.GetCommentsRequest{

     

       838
       838
       +
       		PostURI:   req.PostURI,

     

       839
       839
       +
       		Sort:      req.Sort,

     

       840
       840
       +
       		Timeframe: req.Timeframe,

     

       841
       841
       +
       		Depth:     req.Depth,

     

       842
       842
       +
       		Limit:     req.Limit,

     

       843
       843
       +
       		Cursor:    req.Cursor,

     

       844
       844
       +
       		ViewerDID: req.ViewerDID,

     

       845
       845
       +
       	}

     

       846
       846
       +
       

     

       847
       847
       +
       	return s.service.GetComments(ctx, serviceReq)

     

       848
       848
       +
       }

     

       849
       849
       +
       

     

       850
       850
       +
       type testGetCommentsRequest struct {

     

       851
       851
       +
       	PostURI   string

     

       852
       852
       +
       	Sort      string

     

       853
       853
       +
       	Timeframe string

     

       854
       854
       +
       	Depth     int

     

       855
       855
       +
       	Limit     int

     

       856
       856
       +
       	Cursor    *string

     

       857
       857
       +
       	ViewerDID *string

     

       858
       858
       +
       }

     

       859
       859
       +
       

     

       860
       860
       +
       func setupCommentServiceAdapter(db *sql.DB) *testCommentServiceAdapter {

     

       861
       861
       +
       	commentRepo := postgres.NewCommentRepository(db)

     

       862
       862
       +
       	service := comments.NewCommentService(commentRepo, nil, nil)

     

       863
       863
       +
       	return &testCommentServiceAdapter{service: service}

     

       864
       864
       +
       }

     

       865
       865
       +
       

     

       866
       866
       +
       // Helper: Simple HTTP handler wrapper for testing

     

       867
       867
       +
       type testGetCommentsHandler struct {

     

       868
       868
       +
       	service *testCommentServiceAdapter

     

       869
       869
       +
       }

     

       870
       870
       +
       

     

       871
       871
       +
       func (h *testGetCommentsHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {

     

       872
       872
       +
       	if r.Method != http.MethodGet {

     

       873
       873
       +
       		http.Error(w, "Method not allowed", http.StatusMethodNotAllowed)

     

       874
       874
       +
       		return

     

       875
       875
       +
       	}

     

       876
       876
       +
       

     

       877
       877
       +
       	query := r.URL.Query()

     

       878
       878
       +
       	post := query.Get("post")

     

       879
       879
       +
       

     

       880
       880
       +
       	if post == "" {

     

       881
       881
       +
       		http.Error(w, "post parameter is required", http.StatusBadRequest)

     

       882
       882
       +
       		return

     

       883
       883
       +
       	}

     

       884
       884
       +
       

     

       885
       885
       +
       	sort := query.Get("sort")

     

       886
       886
       +
       	if sort == "" {

     

       887
       887
       +
       		sort = "hot"

     

       888
       888
       +
       	}

     

       889
       889
       +
       

     

       890
       890
       +
       	depth := 10

     

       891
       891
       +
       	if d := query.Get("depth"); d != "" {

     

       892
       892
       +
       		if _, err := fmt.Sscanf(d, "%d", &depth); err != nil {

     

       893
       893
       +
       			http.Error(w, "invalid depth", http.StatusBadRequest)

     

       894
       894
       +
       			return

     

       895
       895
       +
       		}

     

       896
       896
       +
       	}

     

       897
       897
       +
       

     

       898
       898
       +
       	limit := 50

     

       899
       899
       +
       	if l := query.Get("limit"); l != "" {

     

       900
       900
       +
       		if _, err := fmt.Sscanf(l, "%d", &limit); err != nil {

     

       901
       901
       +
       			http.Error(w, "invalid limit", http.StatusBadRequest)

     

       902
       902
       +
       			return

     

       903
       903
       +
       		}

     

       904
       904
       +
       	}

     

       905
       905
       +
       

     

       906
       906
       +
       	req := &testGetCommentsRequest{

     

       907
       907
       +
       		PostURI: post,

     

       908
       908
       +
       		Sort:    sort,

     

       909
       909
       +
       		Depth:   depth,

     

       910
       910
       +
       		Limit:   limit,

     

       911
       911
       +
       	}

     

       912
       912
       +
       

     

       913
       913
       +
       	resp, err := h.service.GetComments(r, req)

     

       914
       914
       +
       	if err != nil {

     

       915
       915
       +
       		http.Error(w, err.Error(), http.StatusInternalServerError)

     

       916
       916
       +
       		return

     

       917
       917
       +
       	}

     

       918
       918
       +
       

     

       919
       919
       +
       	w.Header().Set("Content-Type", "application/json")

     

       920
       920
       +
       	w.WriteHeader(http.StatusOK)

     

       921
       921
       +
       	_ = json.NewEncoder(w).Encode(resp)

     

       922
       922
       +
       }