commit fed6fc71b15bced3a5451cd088bedf9d40e1c907 · bretton.dev/coves

+115

internal/api/handlers/vote/create_vote.go

···

       1
       1
       +
       package vote

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"Coves/internal/api/middleware"

     

       5
       5
       +
       	"Coves/internal/core/votes"

     

       6
       6
       +
       	"encoding/json"

     

       7
       7
       +
       	"log"

     

       8
       8
       +
       	"net/http"

     

       9
       9
       +
       )

     

       10
       10
       +
       

     

       11
       11
       +
       // CreateVoteHandler handles vote creation

     

       12
       12
       +
       type CreateVoteHandler struct {

     

       13
       13
       +
       	service votes.Service

     

       14
       14
       +
       }

     

       15
       15
       +
       

     

       16
       16
       +
       // NewCreateVoteHandler creates a new create vote handler

     

       17
       17
       +
       func NewCreateVoteHandler(service votes.Service) *CreateVoteHandler {

     

       18
       18
       +
       	return &CreateVoteHandler{

     

       19
       19
       +
       		service: service,

     

       20
       20
       +
       	}

     

       21
       21
       +
       }

     

       22
       22
       +
       

     

       23
       23
       +
       // CreateVoteInput represents the request body for creating a vote

     

       24
       24
       +
       type CreateVoteInput struct {

     

       25
       25
       +
       	Subject struct {

     

       26
       26
       +
       		URI string `json:"uri"`

     

       27
       27
       +
       		CID string `json:"cid"`

     

       28
       28
       +
       	} `json:"subject"`

     

       29
       29
       +
       	Direction string `json:"direction"`

     

       30
       30
       +
       }

     

       31
       31
       +
       

     

       32
       32
       +
       // CreateVoteOutput represents the response body for creating a vote

     

       33
       33
       +
       type CreateVoteOutput struct {

     

       34
       34
       +
       	URI string `json:"uri"`

     

       35
       35
       +
       	CID string `json:"cid"`

     

       36
       36
       +
       }

     

       37
       37
       +
       

     

       38
       38
       +
       // HandleCreateVote creates a vote on a post or comment

     

       39
       39
       +
       // POST /xrpc/social.coves.vote.create

     

       40
       40
       +
       //

     

       41
       41
       +
       // Request body: { "subject": { "uri": "at://...", "cid": "..." }, "direction": "up" }

     

       42
       42
       +
       // Response: { "uri": "at://...", "cid": "..." }

     

       43
       43
       +
       //

     

       44
       44
       +
       // Behavior:

     

       45
       45
       +
       // - If no vote exists: creates new vote with given direction

     

       46
       46
       +
       // - If vote exists with same direction: deletes vote (toggle off)

     

       47
       47
       +
       // - If vote exists with different direction: updates to new direction

     

       48
       48
       +
       func (h *CreateVoteHandler) HandleCreateVote(w http.ResponseWriter, r *http.Request) {

     

       49
       49
       +
       	if r.Method != http.MethodPost {

     

       50
       50
       +
       		http.Error(w, "Method not allowed", http.StatusMethodNotAllowed)

     

       51
       51
       +
       		return

     

       52
       52
       +
       	}

     

       53
       53
       +
       

     

       54
       54
       +
       	// Parse request body

     

       55
       55
       +
       	var input CreateVoteInput

     

       56
       56
       +
       	if err := json.NewDecoder(r.Body).Decode(&input); err != nil {

     

       57
       57
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "Invalid request body")

     

       58
       58
       +
       		return

     

       59
       59
       +
       	}

     

       60
       60
       +
       

     

       61
       61
       +
       	// Validate required fields

     

       62
       62
       +
       	if input.Subject.URI == "" {

     

       63
       63
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "subject.uri is required")

     

       64
       64
       +
       		return

     

       65
       65
       +
       	}

     

       66
       66
       +
       	if input.Subject.CID == "" {

     

       67
       67
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "subject.cid is required")

     

       68
       68
       +
       		return

     

       69
       69
       +
       	}

     

       70
       70
       +
       	if input.Direction == "" {

     

       71
       71
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "direction is required")

     

       72
       72
       +
       		return

     

       73
       73
       +
       	}

     

       74
       74
       +
       

     

       75
       75
       +
       	// Validate direction

     

       76
       76
       +
       	if input.Direction != "up" && input.Direction != "down" {

     

       77
       77
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "direction must be 'up' or 'down'")

     

       78
       78
       +
       		return

     

       79
       79
       +
       	}

     

       80
       80
       +
       

     

       81
       81
       +
       	// Get OAuth session from context (injected by auth middleware)

     

       82
       82
       +
       	session := middleware.GetOAuthSession(r)

     

       83
       83
       +
       	if session == nil {

     

       84
       84
       +
       		writeError(w, http.StatusUnauthorized, "AuthRequired", "Authentication required")

     

       85
       85
       +
       		return

     

       86
       86
       +
       	}

     

       87
       87
       +
       

     

       88
       88
       +
       	// Create vote request

     

       89
       89
       +
       	req := votes.CreateVoteRequest{

     

       90
       90
       +
       		Subject: votes.StrongRef{

     

       91
       91
       +
       			URI: input.Subject.URI,

     

       92
       92
       +
       			CID: input.Subject.CID,

     

       93
       93
       +
       		},

     

       94
       94
       +
       		Direction: input.Direction,

     

       95
       95
       +
       	}

     

       96
       96
       +
       

     

       97
       97
       +
       	// Call service to create vote

     

       98
       98
       +
       	response, err := h.service.CreateVote(r.Context(), session, req)

     

       99
       99
       +
       	if err != nil {

     

       100
       100
       +
       		handleServiceError(w, err)

     

       101
       101
       +
       		return

     

       102
       102
       +
       	}

     

       103
       103
       +
       

     

       104
       104
       +
       	// Return success response

     

       105
       105
       +
       	output := CreateVoteOutput{

     

       106
       106
       +
       		URI: response.URI,

     

       107
       107
       +
       		CID: response.CID,

     

       108
       108
       +
       	}

     

       109
       109
       +
       

     

       110
       110
       +
       	w.Header().Set("Content-Type", "application/json")

     

       111
       111
       +
       	w.WriteHeader(http.StatusOK)

     

       112
       112
       +
       	if err := json.NewEncoder(w).Encode(output); err != nil {

     

       113
       113
       +
       		log.Printf("Failed to encode response: %v", err)

     

       114
       114
       +
       	}

     

       115
       115
       +
       }

+490

internal/api/handlers/vote/create_vote_test.go

···

       1
       1
       +
       package vote

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"Coves/internal/api/middleware"

     

       5
       5
       +
       	"Coves/internal/core/votes"

     

       6
       6
       +
       	"bytes"

     

       7
       7
       +
       	"context"

     

       8
       8
       +
       	"encoding/json"

     

       9
       9
       +
       	"net/http"

     

       10
       10
       +
       	"net/http/httptest"

     

       11
       11
       +
       	"testing"

     

       12
       12
       +
       

     

       13
       13
       +
       	oauthlib "github.com/bluesky-social/indigo/atproto/auth/oauth"

     

       14
       14
       +
       	"github.com/bluesky-social/indigo/atproto/syntax"

     

       15
       15
       +
       )

     

       16
       16
       +
       

     

       17
       17
       +
       // mockVoteService implements votes.Service for testing

     

       18
       18
       +
       type mockVoteService struct {

     

       19
       19
       +
       	createFunc func(ctx context.Context, session *oauthlib.ClientSessionData, req votes.CreateVoteRequest) (*votes.CreateVoteResponse, error)

     

       20
       20
       +
       	deleteFunc func(ctx context.Context, session *oauthlib.ClientSessionData, req votes.DeleteVoteRequest) error

     

       21
       21
       +
       }

     

       22
       22
       +
       

     

       23
       23
       +
       func (m *mockVoteService) CreateVote(ctx context.Context, session *oauthlib.ClientSessionData, req votes.CreateVoteRequest) (*votes.CreateVoteResponse, error) {

     

       24
       24
       +
       	if m.createFunc != nil {

     

       25
       25
       +
       		return m.createFunc(ctx, session, req)

     

       26
       26
       +
       	}

     

       27
       27
       +
       	return &votes.CreateVoteResponse{

     

       28
       28
       +
       		URI: "at://did:plc:test123/social.coves.vote/abc123",

     

       29
       29
       +
       		CID: "bafyvote123",

     

       30
       30
       +
       	}, nil

     

       31
       31
       +
       }

     

       32
       32
       +
       

     

       33
       33
       +
       func (m *mockVoteService) DeleteVote(ctx context.Context, session *oauthlib.ClientSessionData, req votes.DeleteVoteRequest) error {

     

       34
       34
       +
       	if m.deleteFunc != nil {

     

       35
       35
       +
       		return m.deleteFunc(ctx, session, req)

     

       36
       36
       +
       	}

     

       37
       37
       +
       	return nil

     

       38
       38
       +
       }

     

       39
       39
       +
       

     

       40
       40
       +
       func TestCreateVoteHandler_Success(t *testing.T) {

     

       41
       41
       +
       	mockService := &mockVoteService{}

     

       42
       42
       +
       	handler := NewCreateVoteHandler(mockService)

     

       43
       43
       +
       

     

       44
       44
       +
       	// Create request body

     

       45
       45
       +
       	reqBody := CreateVoteInput{

     

       46
       46
       +
       		Subject: struct {

     

       47
       47
       +
       			URI string `json:"uri"`

     

       48
       48
       +
       			CID string `json:"cid"`

     

       49
       49
       +
       		}{

     

       50
       50
       +
       			URI: "at://did:plc:author123/social.coves.post/xyz789",

     

       51
       51
       +
       			CID: "bafypost123",

     

       52
       52
       +
       		},

     

       53
       53
       +
       		Direction: "up",

     

       54
       54
       +
       	}

     

       55
       55
       +
       	bodyBytes, err := json.Marshal(reqBody)

     

       56
       56
       +
       	if err != nil {

     

       57
       57
       +
       		t.Fatalf("Failed to marshal request: %v", err)

     

       58
       58
       +
       	}

     

       59
       59
       +
       

     

       60
       60
       +
       	// Create HTTP request

     

       61
       61
       +
       	req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.vote.create", bytes.NewBuffer(bodyBytes))

     

       62
       62
       +
       	req.Header.Set("Content-Type", "application/json")

     

       63
       63
       +
       

     

       64
       64
       +
       	// Inject OAuth session into context (simulates auth middleware)

     

       65
       65
       +
       	did, _ := syntax.ParseDID("did:plc:test123")

     

       66
       66
       +
       	session := &oauthlib.ClientSessionData{

     

       67
       67
       +
       		AccountDID:  did,

     

       68
       68
       +
       		AccessToken: "test_token",

     

       69
       69
       +
       	}

     

       70
       70
       +
       	ctx := context.WithValue(req.Context(), middleware.OAuthSessionKey, session)

     

       71
       71
       +
       	req = req.WithContext(ctx)

     

       72
       72
       +
       

     

       73
       73
       +
       	// Execute handler

     

       74
       74
       +
       	w := httptest.NewRecorder()

     

       75
       75
       +
       	handler.HandleCreateVote(w, req)

     

       76
       76
       +
       

     

       77
       77
       +
       	// Check status code

     

       78
       78
       +
       	if w.Code != http.StatusOK {

     

       79
       79
       +
       		t.Errorf("Expected status 200, got %d. Body: %s", w.Code, w.Body.String())

     

       80
       80
       +
       	}

     

       81
       81
       +
       

     

       82
       82
       +
       	// Check response

     

       83
       83
       +
       	var response CreateVoteOutput

     

       84
       84
       +
       	if err := json.NewDecoder(w.Body).Decode(&response); err != nil {

     

       85
       85
       +
       		t.Fatalf("Failed to decode response: %v", err)

     

       86
       86
       +
       	}

     

       87
       87
       +
       

     

       88
       88
       +
       	if response.URI != "at://did:plc:test123/social.coves.vote/abc123" {

     

       89
       89
       +
       		t.Errorf("Expected URI at://did:plc:test123/social.coves.vote/abc123, got %s", response.URI)

     

       90
       90
       +
       	}

     

       91
       91
       +
       	if response.CID != "bafyvote123" {

     

       92
       92
       +
       		t.Errorf("Expected CID bafyvote123, got %s", response.CID)

     

       93
       93
       +
       	}

     

       94
       94
       +
       }

     

       95
       95
       +
       

     

       96
       96
       +
       func TestCreateVoteHandler_RequiresAuth(t *testing.T) {

     

       97
       97
       +
       	mockService := &mockVoteService{}

     

       98
       98
       +
       	handler := NewCreateVoteHandler(mockService)

     

       99
       99
       +
       

     

       100
       100
       +
       	// Create request body

     

       101
       101
       +
       	reqBody := CreateVoteInput{

     

       102
       102
       +
       		Subject: struct {

     

       103
       103
       +
       			URI string `json:"uri"`

     

       104
       104
       +
       			CID string `json:"cid"`

     

       105
       105
       +
       		}{

     

       106
       106
       +
       			URI: "at://did:plc:author123/social.coves.post/xyz789",

     

       107
       107
       +
       			CID: "bafypost123",

     

       108
       108
       +
       		},

     

       109
       109
       +
       		Direction: "up",

     

       110
       110
       +
       	}

     

       111
       111
       +
       	bodyBytes, err := json.Marshal(reqBody)

     

       112
       112
       +
       	if err != nil {

     

       113
       113
       +
       		t.Fatalf("Failed to marshal request: %v", err)

     

       114
       114
       +
       	}

     

       115
       115
       +
       

     

       116
       116
       +
       	// Create HTTP request without auth context

     

       117
       117
       +
       	req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.vote.create", bytes.NewBuffer(bodyBytes))

     

       118
       118
       +
       	req.Header.Set("Content-Type", "application/json")

     

       119
       119
       +
       	// No OAuth session in context

     

       120
       120
       +
       

     

       121
       121
       +
       	// Execute handler

     

       122
       122
       +
       	w := httptest.NewRecorder()

     

       123
       123
       +
       	handler.HandleCreateVote(w, req)

     

       124
       124
       +
       

     

       125
       125
       +
       	// Check status code

     

       126
       126
       +
       	if w.Code != http.StatusUnauthorized {

     

       127
       127
       +
       		t.Errorf("Expected status 401, got %d. Body: %s", w.Code, w.Body.String())

     

       128
       128
       +
       	}

     

       129
       129
       +
       

     

       130
       130
       +
       	// Check error response

     

       131
       131
       +
       	var errResp XRPCError

     

       132
       132
       +
       	if err := json.NewDecoder(w.Body).Decode(&errResp); err != nil {

     

       133
       133
       +
       		t.Fatalf("Failed to decode error response: %v", err)

     

       134
       134
       +
       	}

     

       135
       135
       +
       	if errResp.Error != "AuthRequired" {

     

       136
       136
       +
       		t.Errorf("Expected error AuthRequired, got %s", errResp.Error)

     

       137
       137
       +
       	}

     

       138
       138
       +
       }

     

       139
       139
       +
       

     

       140
       140
       +
       func TestCreateVoteHandler_InvalidDirection(t *testing.T) {

     

       141
       141
       +
       	mockService := &mockVoteService{}

     

       142
       142
       +
       	handler := NewCreateVoteHandler(mockService)

     

       143
       143
       +
       

     

       144
       144
       +
       	tests := []struct {

     

       145
       145
       +
       		name      string

     

       146
       146
       +
       		direction string

     

       147
       147
       +
       	}{

     

       148
       148
       +
       		{"empty direction", ""},

     

       149
       149
       +
       		{"invalid direction", "sideways"},

     

       150
       150
       +
       		{"wrong case", "UP"},

     

       151
       151
       +
       		{"typo", "upp"},

     

       152
       152
       +
       	}

     

       153
       153
       +
       

     

       154
       154
       +
       	for _, tc := range tests {

     

       155
       155
       +
       		t.Run(tc.name, func(t *testing.T) {

     

       156
       156
       +
       			// Create request body

     

       157
       157
       +
       			reqBody := CreateVoteInput{

     

       158
       158
       +
       				Subject: struct {

     

       159
       159
       +
       					URI string `json:"uri"`

     

       160
       160
       +
       					CID string `json:"cid"`

     

       161
       161
       +
       				}{

     

       162
       162
       +
       					URI: "at://did:plc:author123/social.coves.post/xyz789",

     

       163
       163
       +
       					CID: "bafypost123",

     

       164
       164
       +
       				},

     

       165
       165
       +
       				Direction: tc.direction,

     

       166
       166
       +
       			}

     

       167
       167
       +
       			bodyBytes, err := json.Marshal(reqBody)

     

       168
       168
       +
       			if err != nil {

     

       169
       169
       +
       				t.Fatalf("Failed to marshal request: %v", err)

     

       170
       170
       +
       			}

     

       171
       171
       +
       

     

       172
       172
       +
       			// Create HTTP request

     

       173
       173
       +
       			req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.vote.create", bytes.NewBuffer(bodyBytes))

     

       174
       174
       +
       			req.Header.Set("Content-Type", "application/json")

     

       175
       175
       +
       

     

       176
       176
       +
       			// Inject OAuth session

     

       177
       177
       +
       			did, _ := syntax.ParseDID("did:plc:test123")

     

       178
       178
       +
       			session := &oauthlib.ClientSessionData{

     

       179
       179
       +
       				AccountDID:  did,

     

       180
       180
       +
       				AccessToken: "test_token",

     

       181
       181
       +
       			}

     

       182
       182
       +
       			ctx := context.WithValue(req.Context(), middleware.OAuthSessionKey, session)

     

       183
       183
       +
       			req = req.WithContext(ctx)

     

       184
       184
       +
       

     

       185
       185
       +
       			// Execute handler

     

       186
       186
       +
       			w := httptest.NewRecorder()

     

       187
       187
       +
       			handler.HandleCreateVote(w, req)

     

       188
       188
       +
       

     

       189
       189
       +
       			// Check status code

     

       190
       190
       +
       			if w.Code != http.StatusBadRequest {

     

       191
       191
       +
       				t.Errorf("Expected status 400, got %d. Body: %s", w.Code, w.Body.String())

     

       192
       192
       +
       			}

     

       193
       193
       +
       

     

       194
       194
       +
       			// Check error response

     

       195
       195
       +
       			var errResp XRPCError

     

       196
       196
       +
       			if err := json.NewDecoder(w.Body).Decode(&errResp); err != nil {

     

       197
       197
       +
       				t.Fatalf("Failed to decode error response: %v", err)

     

       198
       198
       +
       			}

     

       199
       199
       +
       			if errResp.Error != "InvalidRequest" {

     

       200
       200
       +
       				t.Errorf("Expected error InvalidRequest, got %s", errResp.Error)

     

       201
       201
       +
       			}

     

       202
       202
       +
       		})

     

       203
       203
       +
       	}

     

       204
       204
       +
       }

     

       205
       205
       +
       

     

       206
       206
       +
       func TestCreateVoteHandler_MissingFields(t *testing.T) {

     

       207
       207
       +
       	mockService := &mockVoteService{}

     

       208
       208
       +
       	handler := NewCreateVoteHandler(mockService)

     

       209
       209
       +
       

     

       210
       210
       +
       	tests := []struct {

     

       211
       211
       +
       		name          string

     

       212
       212
       +
       		subjectURI    string

     

       213
       213
       +
       		subjectCID    string

     

       214
       214
       +
       		direction     string

     

       215
       215
       +
       		expectedError string

     

       216
       216
       +
       	}{

     

       217
       217
       +
       		{

     

       218
       218
       +
       			name:          "missing subject URI",

     

       219
       219
       +
       			subjectURI:    "",

     

       220
       220
       +
       			subjectCID:    "bafypost123",

     

       221
       221
       +
       			direction:     "up",

     

       222
       222
       +
       			expectedError: "subject.uri is required",

     

       223
       223
       +
       		},

     

       224
       224
       +
       		{

     

       225
       225
       +
       			name:          "missing subject CID",

     

       226
       226
       +
       			subjectURI:    "at://did:plc:author123/social.coves.post/xyz789",

     

       227
       227
       +
       			subjectCID:    "",

     

       228
       228
       +
       			direction:     "up",

     

       229
       229
       +
       			expectedError: "subject.cid is required",

     

       230
       230
       +
       		},

     

       231
       231
       +
       		{

     

       232
       232
       +
       			name:          "missing direction",

     

       233
       233
       +
       			subjectURI:    "at://did:plc:author123/social.coves.post/xyz789",

     

       234
       234
       +
       			subjectCID:    "bafypost123",

     

       235
       235
       +
       			direction:     "",

     

       236
       236
       +
       			expectedError: "direction is required",

     

       237
       237
       +
       		},

     

       238
       238
       +
       	}

     

       239
       239
       +
       

     

       240
       240
       +
       	for _, tc := range tests {

     

       241
       241
       +
       		t.Run(tc.name, func(t *testing.T) {

     

       242
       242
       +
       			// Create request body

     

       243
       243
       +
       			reqBody := CreateVoteInput{

     

       244
       244
       +
       				Subject: struct {

     

       245
       245
       +
       					URI string `json:"uri"`

     

       246
       246
       +
       					CID string `json:"cid"`

     

       247
       247
       +
       				}{

     

       248
       248
       +
       					URI: tc.subjectURI,

     

       249
       249
       +
       					CID: tc.subjectCID,

     

       250
       250
       +
       				},

     

       251
       251
       +
       				Direction: tc.direction,

     

       252
       252
       +
       			}

     

       253
       253
       +
       			bodyBytes, err := json.Marshal(reqBody)

     

       254
       254
       +
       			if err != nil {

     

       255
       255
       +
       				t.Fatalf("Failed to marshal request: %v", err)

     

       256
       256
       +
       			}

     

       257
       257
       +
       

     

       258
       258
       +
       			// Create HTTP request

     

       259
       259
       +
       			req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.vote.create", bytes.NewBuffer(bodyBytes))

     

       260
       260
       +
       			req.Header.Set("Content-Type", "application/json")

     

       261
       261
       +
       

     

       262
       262
       +
       			// Inject OAuth session

     

       263
       263
       +
       			did, _ := syntax.ParseDID("did:plc:test123")

     

       264
       264
       +
       			session := &oauthlib.ClientSessionData{

     

       265
       265
       +
       				AccountDID:  did,

     

       266
       266
       +
       				AccessToken: "test_token",

     

       267
       267
       +
       			}

     

       268
       268
       +
       			ctx := context.WithValue(req.Context(), middleware.OAuthSessionKey, session)

     

       269
       269
       +
       			req = req.WithContext(ctx)

     

       270
       270
       +
       

     

       271
       271
       +
       			// Execute handler

     

       272
       272
       +
       			w := httptest.NewRecorder()

     

       273
       273
       +
       			handler.HandleCreateVote(w, req)

     

       274
       274
       +
       

     

       275
       275
       +
       			// Check status code

     

       276
       276
       +
       			if w.Code != http.StatusBadRequest {

     

       277
       277
       +
       				t.Errorf("Expected status 400, got %d. Body: %s", w.Code, w.Body.String())

     

       278
       278
       +
       			}

     

       279
       279
       +
       

     

       280
       280
       +
       			// Check error response

     

       281
       281
       +
       			var errResp XRPCError

     

       282
       282
       +
       			if err := json.NewDecoder(w.Body).Decode(&errResp); err != nil {

     

       283
       283
       +
       				t.Fatalf("Failed to decode error response: %v", err)

     

       284
       284
       +
       			}

     

       285
       285
       +
       			if errResp.Message != tc.expectedError {

     

       286
       286
       +
       				t.Errorf("Expected message '%s', got '%s'", tc.expectedError, errResp.Message)

     

       287
       287
       +
       			}

     

       288
       288
       +
       		})

     

       289
       289
       +
       	}

     

       290
       290
       +
       }

     

       291
       291
       +
       

     

       292
       292
       +
       func TestCreateVoteHandler_InvalidJSON(t *testing.T) {

     

       293
       293
       +
       	mockService := &mockVoteService{}

     

       294
       294
       +
       	handler := NewCreateVoteHandler(mockService)

     

       295
       295
       +
       

     

       296
       296
       +
       	// Create invalid JSON

     

       297
       297
       +
       	req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.vote.create", bytes.NewBufferString("{invalid json"))

     

       298
       298
       +
       	req.Header.Set("Content-Type", "application/json")

     

       299
       299
       +
       

     

       300
       300
       +
       	// Inject OAuth session

     

       301
       301
       +
       	did, _ := syntax.ParseDID("did:plc:test123")

     

       302
       302
       +
       	session := &oauthlib.ClientSessionData{

     

       303
       303
       +
       		AccountDID:  did,

     

       304
       304
       +
       		AccessToken: "test_token",

     

       305
       305
       +
       	}

     

       306
       306
       +
       	ctx := context.WithValue(req.Context(), middleware.OAuthSessionKey, session)

     

       307
       307
       +
       	req = req.WithContext(ctx)

     

       308
       308
       +
       

     

       309
       309
       +
       	// Execute handler

     

       310
       310
       +
       	w := httptest.NewRecorder()

     

       311
       311
       +
       	handler.HandleCreateVote(w, req)

     

       312
       312
       +
       

     

       313
       313
       +
       	// Check status code

     

       314
       314
       +
       	if w.Code != http.StatusBadRequest {

     

       315
       315
       +
       		t.Errorf("Expected status 400, got %d. Body: %s", w.Code, w.Body.String())

     

       316
       316
       +
       	}

     

       317
       317
       +
       

     

       318
       318
       +
       	// Check error response

     

       319
       319
       +
       	var errResp XRPCError

     

       320
       320
       +
       	if err := json.NewDecoder(w.Body).Decode(&errResp); err != nil {

     

       321
       321
       +
       		t.Fatalf("Failed to decode error response: %v", err)

     

       322
       322
       +
       	}

     

       323
       323
       +
       	if errResp.Error != "InvalidRequest" {

     

       324
       324
       +
       		t.Errorf("Expected error InvalidRequest, got %s", errResp.Error)

     

       325
       325
       +
       	}

     

       326
       326
       +
       }

     

       327
       327
       +
       

     

       328
       328
       +
       func TestCreateVoteHandler_MethodNotAllowed(t *testing.T) {

     

       329
       329
       +
       	mockService := &mockVoteService{}

     

       330
       330
       +
       	handler := NewCreateVoteHandler(mockService)

     

       331
       331
       +
       

     

       332
       332
       +
       	// Create GET request (should only accept POST)

     

       333
       333
       +
       	req := httptest.NewRequest(http.MethodGet, "/xrpc/social.coves.vote.create", nil)

     

       334
       334
       +
       

     

       335
       335
       +
       	// Execute handler

     

       336
       336
       +
       	w := httptest.NewRecorder()

     

       337
       337
       +
       	handler.HandleCreateVote(w, req)

     

       338
       338
       +
       

     

       339
       339
       +
       	// Check status code

     

       340
       340
       +
       	if w.Code != http.StatusMethodNotAllowed {

     

       341
       341
       +
       		t.Errorf("Expected status 405, got %d", w.Code)

     

       342
       342
       +
       	}

     

       343
       343
       +
       }

     

       344
       344
       +
       

     

       345
       345
       +
       func TestCreateVoteHandler_ServiceError(t *testing.T) {

     

       346
       346
       +
       	tests := []struct {

     

       347
       347
       +
       		name           string

     

       348
       348
       +
       		serviceError   error

     

       349
       349
       +
       		expectedStatus int

     

       350
       350
       +
       		expectedError  string

     

       351
       351
       +
       	}{

     

       352
       352
       +
       		{

     

       353
       353
       +
       			name:           "subject not found",

     

       354
       354
       +
       			serviceError:   votes.ErrSubjectNotFound,

     

       355
       355
       +
       			expectedStatus: http.StatusNotFound,

     

       356
       356
       +
       			expectedError:  "SubjectNotFound", // Per lexicon: social.coves.feed.vote.create#SubjectNotFound

     

       357
       357
       +
       		},

     

       358
       358
       +
       		{

     

       359
       359
       +
       			name:           "invalid direction",

     

       360
       360
       +
       			serviceError:   votes.ErrInvalidDirection,

     

       361
       361
       +
       			expectedStatus: http.StatusBadRequest,

     

       362
       362
       +
       			expectedError:  "InvalidRequest",

     

       363
       363
       +
       		},

     

       364
       364
       +
       		{

     

       365
       365
       +
       			name:           "invalid subject",

     

       366
       366
       +
       			serviceError:   votes.ErrInvalidSubject,

     

       367
       367
       +
       			expectedStatus: http.StatusBadRequest,

     

       368
       368
       +
       			expectedError:  "InvalidSubject", // Per lexicon: social.coves.feed.vote.create#InvalidSubject

     

       369
       369
       +
       		},

     

       370
       370
       +
       		{

     

       371
       371
       +
       			name:           "not authorized",

     

       372
       372
       +
       			serviceError:   votes.ErrNotAuthorized,

     

       373
       373
       +
       			expectedStatus: http.StatusForbidden,

     

       374
       374
       +
       			expectedError:  "NotAuthorized", // Per lexicon: social.coves.feed.vote.create#NotAuthorized

     

       375
       375
       +
       		},

     

       376
       376
       +
       		{

     

       377
       377
       +
       			name:           "banned",

     

       378
       378
       +
       			serviceError:   votes.ErrBanned,

     

       379
       379
       +
       			expectedStatus: http.StatusForbidden,

     

       380
       380
       +
       			expectedError:  "NotAuthorized", // Banned maps to NotAuthorized per lexicon

     

       381
       381
       +
       		},

     

       382
       382
       +
       	}

     

       383
       383
       +
       

     

       384
       384
       +
       	for _, tc := range tests {

     

       385
       385
       +
       		t.Run(tc.name, func(t *testing.T) {

     

       386
       386
       +
       			mockService := &mockVoteService{

     

       387
       387
       +
       				createFunc: func(ctx context.Context, session *oauthlib.ClientSessionData, req votes.CreateVoteRequest) (*votes.CreateVoteResponse, error) {

     

       388
       388
       +
       					return nil, tc.serviceError

     

       389
       389
       +
       				},

     

       390
       390
       +
       			}

     

       391
       391
       +
       			handler := NewCreateVoteHandler(mockService)

     

       392
       392
       +
       

     

       393
       393
       +
       			// Create request body

     

       394
       394
       +
       			reqBody := CreateVoteInput{

     

       395
       395
       +
       				Subject: struct {

     

       396
       396
       +
       					URI string `json:"uri"`

     

       397
       397
       +
       					CID string `json:"cid"`

     

       398
       398
       +
       				}{

     

       399
       399
       +
       					URI: "at://did:plc:author123/social.coves.post/xyz789",

     

       400
       400
       +
       					CID: "bafypost123",

     

       401
       401
       +
       				},

     

       402
       402
       +
       				Direction: "up",

     

       403
       403
       +
       			}

     

       404
       404
       +
       			bodyBytes, err := json.Marshal(reqBody)

     

       405
       405
       +
       			if err != nil {

     

       406
       406
       +
       				t.Fatalf("Failed to marshal request: %v", err)

     

       407
       407
       +
       			}

     

       408
       408
       +
       

     

       409
       409
       +
       			// Create HTTP request

     

       410
       410
       +
       			req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.vote.create", bytes.NewBuffer(bodyBytes))

     

       411
       411
       +
       			req.Header.Set("Content-Type", "application/json")

     

       412
       412
       +
       

     

       413
       413
       +
       			// Inject OAuth session

     

       414
       414
       +
       			did, _ := syntax.ParseDID("did:plc:test123")

     

       415
       415
       +
       			session := &oauthlib.ClientSessionData{

     

       416
       416
       +
       				AccountDID:  did,

     

       417
       417
       +
       				AccessToken: "test_token",

     

       418
       418
       +
       			}

     

       419
       419
       +
       			ctx := context.WithValue(req.Context(), middleware.OAuthSessionKey, session)

     

       420
       420
       +
       			req = req.WithContext(ctx)

     

       421
       421
       +
       

     

       422
       422
       +
       			// Execute handler

     

       423
       423
       +
       			w := httptest.NewRecorder()

     

       424
       424
       +
       			handler.HandleCreateVote(w, req)

     

       425
       425
       +
       

     

       426
       426
       +
       			// Check status code

     

       427
       427
       +
       			if w.Code != tc.expectedStatus {

     

       428
       428
       +
       				t.Errorf("Expected status %d, got %d. Body: %s", tc.expectedStatus, w.Code, w.Body.String())

     

       429
       429
       +
       			}

     

       430
       430
       +
       

     

       431
       431
       +
       			// Check error response

     

       432
       432
       +
       			var errResp XRPCError

     

       433
       433
       +
       			if err := json.NewDecoder(w.Body).Decode(&errResp); err != nil {

     

       434
       434
       +
       				t.Fatalf("Failed to decode error response: %v", err)

     

       435
       435
       +
       			}

     

       436
       436
       +
       			if errResp.Error != tc.expectedError {

     

       437
       437
       +
       				t.Errorf("Expected error %s, got %s", tc.expectedError, errResp.Error)

     

       438
       438
       +
       			}

     

       439
       439
       +
       		})

     

       440
       440
       +
       	}

     

       441
       441
       +
       }

     

       442
       442
       +
       

     

       443
       443
       +
       func TestCreateVoteHandler_ValidDirections(t *testing.T) {

     

       444
       444
       +
       	mockService := &mockVoteService{}

     

       445
       445
       +
       	handler := NewCreateVoteHandler(mockService)

     

       446
       446
       +
       

     

       447
       447
       +
       	directions := []string{"up", "down"}

     

       448
       448
       +
       

     

       449
       449
       +
       	for _, direction := range directions {

     

       450
       450
       +
       		t.Run("direction_"+direction, func(t *testing.T) {

     

       451
       451
       +
       			// Create request body

     

       452
       452
       +
       			reqBody := CreateVoteInput{

     

       453
       453
       +
       				Subject: struct {

     

       454
       454
       +
       					URI string `json:"uri"`

     

       455
       455
       +
       					CID string `json:"cid"`

     

       456
       456
       +
       				}{

     

       457
       457
       +
       					URI: "at://did:plc:author123/social.coves.post/xyz789",

     

       458
       458
       +
       					CID: "bafypost123",

     

       459
       459
       +
       				},

     

       460
       460
       +
       				Direction: direction,

     

       461
       461
       +
       			}

     

       462
       462
       +
       			bodyBytes, err := json.Marshal(reqBody)

     

       463
       463
       +
       			if err != nil {

     

       464
       464
       +
       				t.Fatalf("Failed to marshal request: %v", err)

     

       465
       465
       +
       			}

     

       466
       466
       +
       

     

       467
       467
       +
       			// Create HTTP request

     

       468
       468
       +
       			req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.vote.create", bytes.NewBuffer(bodyBytes))

     

       469
       469
       +
       			req.Header.Set("Content-Type", "application/json")

     

       470
       470
       +
       

     

       471
       471
       +
       			// Inject OAuth session

     

       472
       472
       +
       			did, _ := syntax.ParseDID("did:plc:test123")

     

       473
       473
       +
       			session := &oauthlib.ClientSessionData{

     

       474
       474
       +
       				AccountDID:  did,

     

       475
       475
       +
       				AccessToken: "test_token",

     

       476
       476
       +
       			}

     

       477
       477
       +
       			ctx := context.WithValue(req.Context(), middleware.OAuthSessionKey, session)

     

       478
       478
       +
       			req = req.WithContext(ctx)

     

       479
       479
       +
       

     

       480
       480
       +
       			// Execute handler

     

       481
       481
       +
       			w := httptest.NewRecorder()

     

       482
       482
       +
       			handler.HandleCreateVote(w, req)

     

       483
       483
       +
       

     

       484
       484
       +
       			// Check status code

     

       485
       485
       +
       			if w.Code != http.StatusOK {

     

       486
       486
       +
       				t.Errorf("Expected status 200 for direction '%s', got %d. Body: %s", direction, w.Code, w.Body.String())

     

       487
       487
       +
       			}

     

       488
       488
       +
       		})

     

       489
       489
       +
       	}

     

       490
       490
       +
       }

+93

internal/api/handlers/vote/delete_vote.go

···

       1
       1
       +
       package vote

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"Coves/internal/api/middleware"

     

       5
       5
       +
       	"Coves/internal/core/votes"

     

       6
       6
       +
       	"encoding/json"

     

       7
       7
       +
       	"log"

     

       8
       8
       +
       	"net/http"

     

       9
       9
       +
       )

     

       10
       10
       +
       

     

       11
       11
       +
       // DeleteVoteHandler handles vote deletion

     

       12
       12
       +
       type DeleteVoteHandler struct {

     

       13
       13
       +
       	service votes.Service

     

       14
       14
       +
       }

     

       15
       15
       +
       

     

       16
       16
       +
       // NewDeleteVoteHandler creates a new delete vote handler

     

       17
       17
       +
       func NewDeleteVoteHandler(service votes.Service) *DeleteVoteHandler {

     

       18
       18
       +
       	return &DeleteVoteHandler{

     

       19
       19
       +
       		service: service,

     

       20
       20
       +
       	}

     

       21
       21
       +
       }

     

       22
       22
       +
       

     

       23
       23
       +
       // DeleteVoteInput represents the request body for deleting a vote

     

       24
       24
       +
       type DeleteVoteInput struct {

     

       25
       25
       +
       	Subject struct {

     

       26
       26
       +
       		URI string `json:"uri"`

     

       27
       27
       +
       		CID string `json:"cid"`

     

       28
       28
       +
       	} `json:"subject"`

     

       29
       29
       +
       }

     

       30
       30
       +
       

     

       31
       31
       +
       // DeleteVoteOutput represents the response body for deleting a vote

     

       32
       32
       +
       // Per lexicon: output is an empty object

     

       33
       33
       +
       type DeleteVoteOutput struct{}

     

       34
       34
       +
       

     

       35
       35
       +
       // HandleDeleteVote removes a vote from a post or comment

     

       36
       36
       +
       // POST /xrpc/social.coves.vote.delete

     

       37
       37
       +
       //

     

       38
       38
       +
       // Request body: { "subject": { "uri": "at://...", "cid": "..." } }

     

       39
       39
       +
       // Response: { "success": true }

     

       40
       40
       +
       func (h *DeleteVoteHandler) HandleDeleteVote(w http.ResponseWriter, r *http.Request) {

     

       41
       41
       +
       	if r.Method != http.MethodPost {

     

       42
       42
       +
       		http.Error(w, "Method not allowed", http.StatusMethodNotAllowed)

     

       43
       43
       +
       		return

     

       44
       44
       +
       	}

     

       45
       45
       +
       

     

       46
       46
       +
       	// Parse request body

     

       47
       47
       +
       	var input DeleteVoteInput

     

       48
       48
       +
       	if err := json.NewDecoder(r.Body).Decode(&input); err != nil {

     

       49
       49
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "Invalid request body")

     

       50
       50
       +
       		return

     

       51
       51
       +
       	}

     

       52
       52
       +
       

     

       53
       53
       +
       	// Validate required fields

     

       54
       54
       +
       	if input.Subject.URI == "" {

     

       55
       55
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "subject.uri is required")

     

       56
       56
       +
       		return

     

       57
       57
       +
       	}

     

       58
       58
       +
       	if input.Subject.CID == "" {

     

       59
       59
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "subject.cid is required")

     

       60
       60
       +
       		return

     

       61
       61
       +
       	}

     

       62
       62
       +
       

     

       63
       63
       +
       	// Get OAuth session from context (injected by auth middleware)

     

       64
       64
       +
       	session := middleware.GetOAuthSession(r)

     

       65
       65
       +
       	if session == nil {

     

       66
       66
       +
       		writeError(w, http.StatusUnauthorized, "AuthRequired", "Authentication required")

     

       67
       67
       +
       		return

     

       68
       68
       +
       	}

     

       69
       69
       +
       

     

       70
       70
       +
       	// Create delete vote request

     

       71
       71
       +
       	req := votes.DeleteVoteRequest{

     

       72
       72
       +
       		Subject: votes.StrongRef{

     

       73
       73
       +
       			URI: input.Subject.URI,

     

       74
       74
       +
       			CID: input.Subject.CID,

     

       75
       75
       +
       		},

     

       76
       76
       +
       	}

     

       77
       77
       +
       

     

       78
       78
       +
       	// Call service to delete vote

     

       79
       79
       +
       	err := h.service.DeleteVote(r.Context(), session, req)

     

       80
       80
       +
       	if err != nil {

     

       81
       81
       +
       		handleServiceError(w, err)

     

       82
       82
       +
       		return

     

       83
       83
       +
       	}

     

       84
       84
       +
       

     

       85
       85
       +
       	// Return success response (empty object per lexicon)

     

       86
       86
       +
       	output := DeleteVoteOutput{}

     

       87
       87
       +
       

     

       88
       88
       +
       	w.Header().Set("Content-Type", "application/json")

     

       89
       89
       +
       	w.WriteHeader(http.StatusOK)

     

       90
       90
       +
       	if err := json.NewEncoder(w).Encode(output); err != nil {

     

       91
       91
       +
       		log.Printf("Failed to encode response: %v", err)

     

       92
       92
       +
       	}

     

       93
       93
       +
       }

+400

internal/api/handlers/vote/delete_vote_test.go

···

       1
       1
       +
       package vote

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"Coves/internal/api/middleware"

     

       5
       5
       +
       	"Coves/internal/core/votes"

     

       6
       6
       +
       	"bytes"

     

       7
       7
       +
       	"context"

     

       8
       8
       +
       	"encoding/json"

     

       9
       9
       +
       	"net/http"

     

       10
       10
       +
       	"net/http/httptest"

     

       11
       11
       +
       	"testing"

     

       12
       12
       +
       

     

       13
       13
       +
       	oauthlib "github.com/bluesky-social/indigo/atproto/auth/oauth"

     

       14
       14
       +
       	"github.com/bluesky-social/indigo/atproto/syntax"

     

       15
       15
       +
       )

     

       16
       16
       +
       

     

       17
       17
       +
       func TestDeleteVoteHandler_Success(t *testing.T) {

     

       18
       18
       +
       	mockService := &mockVoteService{}

     

       19
       19
       +
       	handler := NewDeleteVoteHandler(mockService)

     

       20
       20
       +
       

     

       21
       21
       +
       	// Create request body

     

       22
       22
       +
       	reqBody := DeleteVoteInput{

     

       23
       23
       +
       		Subject: struct {

     

       24
       24
       +
       			URI string `json:"uri"`

     

       25
       25
       +
       			CID string `json:"cid"`

     

       26
       26
       +
       		}{

     

       27
       27
       +
       			URI: "at://did:plc:author123/social.coves.post/xyz789",

     

       28
       28
       +
       			CID: "bafypost123",

     

       29
       29
       +
       		},

     

       30
       30
       +
       	}

     

       31
       31
       +
       	bodyBytes, err := json.Marshal(reqBody)

     

       32
       32
       +
       	if err != nil {

     

       33
       33
       +
       		t.Fatalf("Failed to marshal request: %v", err)

     

       34
       34
       +
       	}

     

       35
       35
       +
       

     

       36
       36
       +
       	// Create HTTP request

     

       37
       37
       +
       	req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.vote.delete", bytes.NewBuffer(bodyBytes))

     

       38
       38
       +
       	req.Header.Set("Content-Type", "application/json")

     

       39
       39
       +
       

     

       40
       40
       +
       	// Inject OAuth session into context (simulates auth middleware)

     

       41
       41
       +
       	did, _ := syntax.ParseDID("did:plc:test123")

     

       42
       42
       +
       	session := &oauthlib.ClientSessionData{

     

       43
       43
       +
       		AccountDID:  did,

     

       44
       44
       +
       		AccessToken: "test_token",

     

       45
       45
       +
       	}

     

       46
       46
       +
       	ctx := context.WithValue(req.Context(), middleware.OAuthSessionKey, session)

     

       47
       47
       +
       	req = req.WithContext(ctx)

     

       48
       48
       +
       

     

       49
       49
       +
       	// Execute handler

     

       50
       50
       +
       	w := httptest.NewRecorder()

     

       51
       51
       +
       	handler.HandleDeleteVote(w, req)

     

       52
       52
       +
       

     

       53
       53
       +
       	// Check status code

     

       54
       54
       +
       	if w.Code != http.StatusOK {

     

       55
       55
       +
       		t.Errorf("Expected status 200, got %d. Body: %s", w.Code, w.Body.String())

     

       56
       56
       +
       	}

     

       57
       57
       +
       

     

       58
       58
       +
       	// Check response is empty object per lexicon

     

       59
       59
       +
       	var response map[string]interface{}

     

       60
       60
       +
       	if err := json.NewDecoder(w.Body).Decode(&response); err != nil {

     

       61
       61
       +
       		t.Fatalf("Failed to decode response: %v", err)

     

       62
       62
       +
       	}

     

       63
       63
       +
       

     

       64
       64
       +
       	if len(response) != 0 {

     

       65
       65
       +
       		t.Errorf("Expected empty object per lexicon, got %v", response)

     

       66
       66
       +
       	}

     

       67
       67
       +
       }

     

       68
       68
       +
       

     

       69
       69
       +
       func TestDeleteVoteHandler_RequiresAuth(t *testing.T) {

     

       70
       70
       +
       	mockService := &mockVoteService{}

     

       71
       71
       +
       	handler := NewDeleteVoteHandler(mockService)

     

       72
       72
       +
       

     

       73
       73
       +
       	// Create request body

     

       74
       74
       +
       	reqBody := DeleteVoteInput{

     

       75
       75
       +
       		Subject: struct {

     

       76
       76
       +
       			URI string `json:"uri"`

     

       77
       77
       +
       			CID string `json:"cid"`

     

       78
       78
       +
       		}{

     

       79
       79
       +
       			URI: "at://did:plc:author123/social.coves.post/xyz789",

     

       80
       80
       +
       			CID: "bafypost123",

     

       81
       81
       +
       		},

     

       82
       82
       +
       	}

     

       83
       83
       +
       	bodyBytes, err := json.Marshal(reqBody)

     

       84
       84
       +
       	if err != nil {

     

       85
       85
       +
       		t.Fatalf("Failed to marshal request: %v", err)

     

       86
       86
       +
       	}

     

       87
       87
       +
       

     

       88
       88
       +
       	// Create HTTP request without auth context

     

       89
       89
       +
       	req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.vote.delete", bytes.NewBuffer(bodyBytes))

     

       90
       90
       +
       	req.Header.Set("Content-Type", "application/json")

     

       91
       91
       +
       	// No OAuth session in context

     

       92
       92
       +
       

     

       93
       93
       +
       	// Execute handler

     

       94
       94
       +
       	w := httptest.NewRecorder()

     

       95
       95
       +
       	handler.HandleDeleteVote(w, req)

     

       96
       96
       +
       

     

       97
       97
       +
       	// Check status code

     

       98
       98
       +
       	if w.Code != http.StatusUnauthorized {

     

       99
       99
       +
       		t.Errorf("Expected status 401, got %d. Body: %s", w.Code, w.Body.String())

     

       100
       100
       +
       	}

     

       101
       101
       +
       

     

       102
       102
       +
       	// Check error response

     

       103
       103
       +
       	var errResp XRPCError

     

       104
       104
       +
       	if err := json.NewDecoder(w.Body).Decode(&errResp); err != nil {

     

       105
       105
       +
       		t.Fatalf("Failed to decode error response: %v", err)

     

       106
       106
       +
       	}

     

       107
       107
       +
       	if errResp.Error != "AuthRequired" {

     

       108
       108
       +
       		t.Errorf("Expected error AuthRequired, got %s", errResp.Error)

     

       109
       109
       +
       	}

     

       110
       110
       +
       }

     

       111
       111
       +
       

     

       112
       112
       +
       func TestDeleteVoteHandler_MissingFields(t *testing.T) {

     

       113
       113
       +
       	mockService := &mockVoteService{}

     

       114
       114
       +
       	handler := NewDeleteVoteHandler(mockService)

     

       115
       115
       +
       

     

       116
       116
       +
       	tests := []struct {

     

       117
       117
       +
       		name          string

     

       118
       118
       +
       		subjectURI    string

     

       119
       119
       +
       		subjectCID    string

     

       120
       120
       +
       		expectedError string

     

       121
       121
       +
       	}{

     

       122
       122
       +
       		{

     

       123
       123
       +
       			name:          "missing subject URI",

     

       124
       124
       +
       			subjectURI:    "",

     

       125
       125
       +
       			subjectCID:    "bafypost123",

     

       126
       126
       +
       			expectedError: "subject.uri is required",

     

       127
       127
       +
       		},

     

       128
       128
       +
       		{

     

       129
       129
       +
       			name:          "missing subject CID",

     

       130
       130
       +
       			subjectURI:    "at://did:plc:author123/social.coves.post/xyz789",

     

       131
       131
       +
       			subjectCID:    "",

     

       132
       132
       +
       			expectedError: "subject.cid is required",

     

       133
       133
       +
       		},

     

       134
       134
       +
       	}

     

       135
       135
       +
       

     

       136
       136
       +
       	for _, tc := range tests {

     

       137
       137
       +
       		t.Run(tc.name, func(t *testing.T) {

     

       138
       138
       +
       			// Create request body

     

       139
       139
       +
       			reqBody := DeleteVoteInput{

     

       140
       140
       +
       				Subject: struct {

     

       141
       141
       +
       					URI string `json:"uri"`

     

       142
       142
       +
       					CID string `json:"cid"`

     

       143
       143
       +
       				}{

     

       144
       144
       +
       					URI: tc.subjectURI,

     

       145
       145
       +
       					CID: tc.subjectCID,

     

       146
       146
       +
       				},

     

       147
       147
       +
       			}

     

       148
       148
       +
       			bodyBytes, err := json.Marshal(reqBody)

     

       149
       149
       +
       			if err != nil {

     

       150
       150
       +
       				t.Fatalf("Failed to marshal request: %v", err)

     

       151
       151
       +
       			}

     

       152
       152
       +
       

     

       153
       153
       +
       			// Create HTTP request

     

       154
       154
       +
       			req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.vote.delete", bytes.NewBuffer(bodyBytes))

     

       155
       155
       +
       			req.Header.Set("Content-Type", "application/json")

     

       156
       156
       +
       

     

       157
       157
       +
       			// Inject OAuth session

     

       158
       158
       +
       			did, _ := syntax.ParseDID("did:plc:test123")

     

       159
       159
       +
       			session := &oauthlib.ClientSessionData{

     

       160
       160
       +
       				AccountDID:  did,

     

       161
       161
       +
       				AccessToken: "test_token",

     

       162
       162
       +
       			}

     

       163
       163
       +
       			ctx := context.WithValue(req.Context(), middleware.OAuthSessionKey, session)

     

       164
       164
       +
       			req = req.WithContext(ctx)

     

       165
       165
       +
       

     

       166
       166
       +
       			// Execute handler

     

       167
       167
       +
       			w := httptest.NewRecorder()

     

       168
       168
       +
       			handler.HandleDeleteVote(w, req)

     

       169
       169
       +
       

     

       170
       170
       +
       			// Check status code

     

       171
       171
       +
       			if w.Code != http.StatusBadRequest {

     

       172
       172
       +
       				t.Errorf("Expected status 400, got %d. Body: %s", w.Code, w.Body.String())

     

       173
       173
       +
       			}

     

       174
       174
       +
       

     

       175
       175
       +
       			// Check error response

     

       176
       176
       +
       			var errResp XRPCError

     

       177
       177
       +
       			if err := json.NewDecoder(w.Body).Decode(&errResp); err != nil {

     

       178
       178
       +
       				t.Fatalf("Failed to decode error response: %v", err)

     

       179
       179
       +
       			}

     

       180
       180
       +
       			if errResp.Message != tc.expectedError {

     

       181
       181
       +
       				t.Errorf("Expected message '%s', got '%s'", tc.expectedError, errResp.Message)

     

       182
       182
       +
       			}

     

       183
       183
       +
       		})

     

       184
       184
       +
       	}

     

       185
       185
       +
       }

     

       186
       186
       +
       

     

       187
       187
       +
       func TestDeleteVoteHandler_InvalidJSON(t *testing.T) {

     

       188
       188
       +
       	mockService := &mockVoteService{}

     

       189
       189
       +
       	handler := NewDeleteVoteHandler(mockService)

     

       190
       190
       +
       

     

       191
       191
       +
       	// Create invalid JSON

     

       192
       192
       +
       	req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.vote.delete", bytes.NewBufferString("{invalid json"))

     

       193
       193
       +
       	req.Header.Set("Content-Type", "application/json")

     

       194
       194
       +
       

     

       195
       195
       +
       	// Inject OAuth session

     

       196
       196
       +
       	did, _ := syntax.ParseDID("did:plc:test123")

     

       197
       197
       +
       	session := &oauthlib.ClientSessionData{

     

       198
       198
       +
       		AccountDID:  did,

     

       199
       199
       +
       		AccessToken: "test_token",

     

       200
       200
       +
       	}

     

       201
       201
       +
       	ctx := context.WithValue(req.Context(), middleware.OAuthSessionKey, session)

     

       202
       202
       +
       	req = req.WithContext(ctx)

     

       203
       203
       +
       

     

       204
       204
       +
       	// Execute handler

     

       205
       205
       +
       	w := httptest.NewRecorder()

     

       206
       206
       +
       	handler.HandleDeleteVote(w, req)

     

       207
       207
       +
       

     

       208
       208
       +
       	// Check status code

     

       209
       209
       +
       	if w.Code != http.StatusBadRequest {

     

       210
       210
       +
       		t.Errorf("Expected status 400, got %d. Body: %s", w.Code, w.Body.String())

     

       211
       211
       +
       	}

     

       212
       212
       +
       

     

       213
       213
       +
       	// Check error response

     

       214
       214
       +
       	var errResp XRPCError

     

       215
       215
       +
       	if err := json.NewDecoder(w.Body).Decode(&errResp); err != nil {

     

       216
       216
       +
       		t.Fatalf("Failed to decode error response: %v", err)

     

       217
       217
       +
       	}

     

       218
       218
       +
       	if errResp.Error != "InvalidRequest" {

     

       219
       219
       +
       		t.Errorf("Expected error InvalidRequest, got %s", errResp.Error)

     

       220
       220
       +
       	}

     

       221
       221
       +
       }

     

       222
       222
       +
       

     

       223
       223
       +
       func TestDeleteVoteHandler_MethodNotAllowed(t *testing.T) {

     

       224
       224
       +
       	mockService := &mockVoteService{}

     

       225
       225
       +
       	handler := NewDeleteVoteHandler(mockService)

     

       226
       226
       +
       

     

       227
       227
       +
       	// Create GET request (should only accept POST)

     

       228
       228
       +
       	req := httptest.NewRequest(http.MethodGet, "/xrpc/social.coves.vote.delete", nil)

     

       229
       229
       +
       

     

       230
       230
       +
       	// Execute handler

     

       231
       231
       +
       	w := httptest.NewRecorder()

     

       232
       232
       +
       	handler.HandleDeleteVote(w, req)

     

       233
       233
       +
       

     

       234
       234
       +
       	// Check status code

     

       235
       235
       +
       	if w.Code != http.StatusMethodNotAllowed {

     

       236
       236
       +
       		t.Errorf("Expected status 405, got %d", w.Code)

     

       237
       237
       +
       	}

     

       238
       238
       +
       }

     

       239
       239
       +
       

     

       240
       240
       +
       func TestDeleteVoteHandler_ServiceError(t *testing.T) {

     

       241
       241
       +
       	tests := []struct {

     

       242
       242
       +
       		name           string

     

       243
       243
       +
       		serviceError   error

     

       244
       244
       +
       		expectedStatus int

     

       245
       245
       +
       		expectedError  string

     

       246
       246
       +
       	}{

     

       247
       247
       +
       		{

     

       248
       248
       +
       			name:           "vote not found",

     

       249
       249
       +
       			serviceError:   votes.ErrVoteNotFound,

     

       250
       250
       +
       			expectedStatus: http.StatusNotFound,

     

       251
       251
       +
       			expectedError:  "VoteNotFound", // Per lexicon: social.coves.feed.vote.delete#VoteNotFound

     

       252
       252
       +
       		},

     

       253
       253
       +
       		{

     

       254
       254
       +
       			name:           "subject not found",

     

       255
       255
       +
       			serviceError:   votes.ErrSubjectNotFound,

     

       256
       256
       +
       			expectedStatus: http.StatusNotFound,

     

       257
       257
       +
       			expectedError:  "SubjectNotFound", // Per lexicon: social.coves.feed.vote.create#SubjectNotFound

     

       258
       258
       +
       		},

     

       259
       259
       +
       		{

     

       260
       260
       +
       			name:           "invalid subject",

     

       261
       261
       +
       			serviceError:   votes.ErrInvalidSubject,

     

       262
       262
       +
       			expectedStatus: http.StatusBadRequest,

     

       263
       263
       +
       			expectedError:  "InvalidSubject", // Per lexicon: social.coves.feed.vote.create#InvalidSubject

     

       264
       264
       +
       		},

     

       265
       265
       +
       		{

     

       266
       266
       +
       			name:           "not authorized",

     

       267
       267
       +
       			serviceError:   votes.ErrNotAuthorized,

     

       268
       268
       +
       			expectedStatus: http.StatusForbidden,

     

       269
       269
       +
       			expectedError:  "NotAuthorized", // Per lexicon: social.coves.feed.vote.delete#NotAuthorized

     

       270
       270
       +
       		},

     

       271
       271
       +
       		{

     

       272
       272
       +
       			name:           "banned",

     

       273
       273
       +
       			serviceError:   votes.ErrBanned,

     

       274
       274
       +
       			expectedStatus: http.StatusForbidden,

     

       275
       275
       +
       			expectedError:  "NotAuthorized", // Banned maps to NotAuthorized per lexicon

     

       276
       276
       +
       		},

     

       277
       277
       +
       	}

     

       278
       278
       +
       

     

       279
       279
       +
       	for _, tc := range tests {

     

       280
       280
       +
       		t.Run(tc.name, func(t *testing.T) {

     

       281
       281
       +
       			mockService := &mockVoteService{

     

       282
       282
       +
       				deleteFunc: func(ctx context.Context, session *oauthlib.ClientSessionData, req votes.DeleteVoteRequest) error {

     

       283
       283
       +
       					return tc.serviceError

     

       284
       284
       +
       				},

     

       285
       285
       +
       			}

     

       286
       286
       +
       			handler := NewDeleteVoteHandler(mockService)

     

       287
       287
       +
       

     

       288
       288
       +
       			// Create request body

     

       289
       289
       +
       			reqBody := DeleteVoteInput{

     

       290
       290
       +
       				Subject: struct {

     

       291
       291
       +
       					URI string `json:"uri"`

     

       292
       292
       +
       					CID string `json:"cid"`

     

       293
       293
       +
       				}{

     

       294
       294
       +
       					URI: "at://did:plc:author123/social.coves.post/xyz789",

     

       295
       295
       +
       					CID: "bafypost123",

     

       296
       296
       +
       				},

     

       297
       297
       +
       			}

     

       298
       298
       +
       			bodyBytes, err := json.Marshal(reqBody)

     

       299
       299
       +
       			if err != nil {

     

       300
       300
       +
       				t.Fatalf("Failed to marshal request: %v", err)

     

       301
       301
       +
       			}

     

       302
       302
       +
       

     

       303
       303
       +
       			// Create HTTP request

     

       304
       304
       +
       			req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.vote.delete", bytes.NewBuffer(bodyBytes))

     

       305
       305
       +
       			req.Header.Set("Content-Type", "application/json")

     

       306
       306
       +
       

     

       307
       307
       +
       			// Inject OAuth session

     

       308
       308
       +
       			did, _ := syntax.ParseDID("did:plc:test123")

     

       309
       309
       +
       			session := &oauthlib.ClientSessionData{

     

       310
       310
       +
       				AccountDID:  did,

     

       311
       311
       +
       				AccessToken: "test_token",

     

       312
       312
       +
       			}

     

       313
       313
       +
       			ctx := context.WithValue(req.Context(), middleware.OAuthSessionKey, session)

     

       314
       314
       +
       			req = req.WithContext(ctx)

     

       315
       315
       +
       

     

       316
       316
       +
       			// Execute handler

     

       317
       317
       +
       			w := httptest.NewRecorder()

     

       318
       318
       +
       			handler.HandleDeleteVote(w, req)

     

       319
       319
       +
       

     

       320
       320
       +
       			// Check status code

     

       321
       321
       +
       			if w.Code != tc.expectedStatus {

     

       322
       322
       +
       				t.Errorf("Expected status %d, got %d. Body: %s", tc.expectedStatus, w.Code, w.Body.String())

     

       323
       323
       +
       			}

     

       324
       324
       +
       

     

       325
       325
       +
       			// Check error response

     

       326
       326
       +
       			var errResp XRPCError

     

       327
       327
       +
       			if err := json.NewDecoder(w.Body).Decode(&errResp); err != nil {

     

       328
       328
       +
       				t.Fatalf("Failed to decode error response: %v", err)

     

       329
       329
       +
       			}

     

       330
       330
       +
       			if errResp.Error != tc.expectedError {

     

       331
       331
       +
       				t.Errorf("Expected error %s, got %s", tc.expectedError, errResp.Error)

     

       332
       332
       +
       			}

     

       333
       333
       +
       		})

     

       334
       334
       +
       	}

     

       335
       335
       +
       }

     

       336
       336
       +
       

     

       337
       337
       +
       func TestDeleteVoteHandler_MultipleSubjects(t *testing.T) {

     

       338
       338
       +
       	mockService := &mockVoteService{}

     

       339
       339
       +
       	handler := NewDeleteVoteHandler(mockService)

     

       340
       340
       +
       

     

       341
       341
       +
       	subjects := []struct {

     

       342
       342
       +
       		uri string

     

       343
       343
       +
       		cid string

     

       344
       344
       +
       	}{

     

       345
       345
       +
       		{"at://did:plc:author1/social.coves.post/post1", "bafypost1"},

     

       346
       346
       +
       		{"at://did:plc:author2/social.coves.post/post2", "bafypost2"},

     

       347
       347
       +
       		{"at://did:plc:author3/social.coves.comment/comment1", "bafycomment1"},

     

       348
       348
       +
       	}

     

       349
       349
       +
       

     

       350
       350
       +
       	for _, subject := range subjects {

     

       351
       351
       +
       		t.Run("subject_"+subject.uri, func(t *testing.T) {

     

       352
       352
       +
       			// Create request body

     

       353
       353
       +
       			reqBody := DeleteVoteInput{

     

       354
       354
       +
       				Subject: struct {

     

       355
       355
       +
       					URI string `json:"uri"`

     

       356
       356
       +
       					CID string `json:"cid"`

     

       357
       357
       +
       				}{

     

       358
       358
       +
       					URI: subject.uri,

     

       359
       359
       +
       					CID: subject.cid,

     

       360
       360
       +
       				},

     

       361
       361
       +
       			}

     

       362
       362
       +
       			bodyBytes, err := json.Marshal(reqBody)

     

       363
       363
       +
       			if err != nil {

     

       364
       364
       +
       				t.Fatalf("Failed to marshal request: %v", err)

     

       365
       365
       +
       			}

     

       366
       366
       +
       

     

       367
       367
       +
       			// Create HTTP request

     

       368
       368
       +
       			req := httptest.NewRequest(http.MethodPost, "/xrpc/social.coves.vote.delete", bytes.NewBuffer(bodyBytes))

     

       369
       369
       +
       			req.Header.Set("Content-Type", "application/json")

     

       370
       370
       +
       

     

       371
       371
       +
       			// Inject OAuth session

     

       372
       372
       +
       			did, _ := syntax.ParseDID("did:plc:test123")

     

       373
       373
       +
       			session := &oauthlib.ClientSessionData{

     

       374
       374
       +
       				AccountDID:  did,

     

       375
       375
       +
       				AccessToken: "test_token",

     

       376
       376
       +
       			}

     

       377
       377
       +
       			ctx := context.WithValue(req.Context(), middleware.OAuthSessionKey, session)

     

       378
       378
       +
       			req = req.WithContext(ctx)

     

       379
       379
       +
       

     

       380
       380
       +
       			// Execute handler

     

       381
       381
       +
       			w := httptest.NewRecorder()

     

       382
       382
       +
       			handler.HandleDeleteVote(w, req)

     

       383
       383
       +
       

     

       384
       384
       +
       			// Check status code

     

       385
       385
       +
       			if w.Code != http.StatusOK {

     

       386
       386
       +
       				t.Errorf("Expected status 200 for subject '%s', got %d. Body: %s", subject.uri, w.Code, w.Body.String())

     

       387
       387
       +
       			}

     

       388
       388
       +
       

     

       389
       389
       +
       			// Check response is empty object per lexicon

     

       390
       390
       +
       			var response map[string]interface{}

     

       391
       391
       +
       			if err := json.NewDecoder(w.Body).Decode(&response); err != nil {

     

       392
       392
       +
       				t.Fatalf("Failed to decode response: %v", err)

     

       393
       393
       +
       			}

     

       394
       394
       +
       

     

       395
       395
       +
       			if len(response) != 0 {

     

       396
       396
       +
       				t.Errorf("Expected empty object per lexicon, got %v", response)

     

       397
       397
       +
       			}

     

       398
       398
       +
       		})

     

       399
       399
       +
       	}

     

       400
       400
       +
       }

+55

internal/api/handlers/vote/errors.go

···

       1
       1
       +
       package vote

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"Coves/internal/core/votes"

     

       5
       5
       +
       	"encoding/json"

     

       6
       6
       +
       	"log"

     

       7
       7
       +
       	"net/http"

     

       8
       8
       +
       )

     

       9
       9
       +
       

     

       10
       10
       +
       // XRPCError represents an XRPC error response

     

       11
       11
       +
       type XRPCError struct {

     

       12
       12
       +
       	Error   string `json:"error"`

     

       13
       13
       +
       	Message string `json:"message"`

     

       14
       14
       +
       }

     

       15
       15
       +
       

     

       16
       16
       +
       // writeError writes an XRPC error response

     

       17
       17
       +
       func writeError(w http.ResponseWriter, status int, error, message string) {

     

       18
       18
       +
       	w.Header().Set("Content-Type", "application/json")

     

       19
       19
       +
       	w.WriteHeader(status)

     

       20
       20
       +
       	if err := json.NewEncoder(w).Encode(XRPCError{

     

       21
       21
       +
       		Error:   error,

     

       22
       22
       +
       		Message: message,

     

       23
       23
       +
       	}); err != nil {

     

       24
       24
       +
       		log.Printf("Failed to encode error response: %v", err)

     

       25
       25
       +
       	}

     

       26
       26
       +
       }

     

       27
       27
       +
       

     

       28
       28
       +
       // handleServiceError converts service errors to appropriate HTTP responses

     

       29
       29
       +
       // Error names MUST match lexicon definitions exactly (UpperCamelCase)

     

       30
       30
       +
       func handleServiceError(w http.ResponseWriter, err error) {

     

       31
       31
       +
       	switch err {

     

       32
       32
       +
       	case votes.ErrVoteNotFound:

     

       33
       33
       +
       		// Matches: social.coves.feed.vote.delete#VoteNotFound

     

       34
       34
       +
       		writeError(w, http.StatusNotFound, "VoteNotFound", "No vote found for this subject")

     

       35
       35
       +
       	case votes.ErrSubjectNotFound:

     

       36
       36
       +
       		// Matches: social.coves.feed.vote.create#SubjectNotFound

     

       37
       37
       +
       		writeError(w, http.StatusNotFound, "SubjectNotFound", "The subject post or comment was not found")

     

       38
       38
       +
       	case votes.ErrInvalidDirection:

     

       39
       39
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "Vote direction must be 'up' or 'down'")

     

       40
       40
       +
       	case votes.ErrInvalidSubject:

     

       41
       41
       +
       		// Matches: social.coves.feed.vote.create#InvalidSubject

     

       42
       42
       +
       		writeError(w, http.StatusBadRequest, "InvalidSubject", "The subject reference is invalid or malformed")

     

       43
       43
       +
       	case votes.ErrVoteAlreadyExists:

     

       44
       44
       +
       		writeError(w, http.StatusConflict, "AlreadyExists", "Vote already exists")

     

       45
       45
       +
       	case votes.ErrNotAuthorized:

     

       46
       46
       +
       		// Matches: social.coves.feed.vote.create#NotAuthorized, social.coves.feed.vote.delete#NotAuthorized

     

       47
       47
       +
       		writeError(w, http.StatusForbidden, "NotAuthorized", "User is not authorized to vote on this content")

     

       48
       48
       +
       	case votes.ErrBanned:

     

       49
       49
       +
       		writeError(w, http.StatusForbidden, "NotAuthorized", "User is not authorized to vote on this content")

     

       50
       50
       +
       	default:

     

       51
       51
       +
       		// Internal server error - log the actual error for debugging

     

       52
       52
       +
       		log.Printf("XRPC handler error: %v", err)

     

       53
       53
       +
       		writeError(w, http.StatusInternalServerError, "InternalServerError", "An internal error occurred")

     

       54
       54
       +
       	}

     

       55
       55
       +
       }