this repo has no description

refactor: clean up

- use language.ParseAcceptLanguage to get user prefs for langs
- use Accept-Language rather than the bind stuff
- langs are now typed
- move mostliked/view.go to mostliked/generator.go

Changed files
+140 -58
cmd
feedweb
pkg
+1 -1
Makefile
···
bin/mostliked: cmd/mostliked/main.go pkg/mostliked/handler.go db/mostliked/*.go pkg/feeds/*.go
go build -o $@ ./cmd/mostliked
-
bin/feedweb: cmd/feedweb/main.go pkg/*/view.go db/*/*.go pkg/feeds/*.go
+
bin/feedweb: cmd/feedweb/main.go pkg/*/generator.go db/*/*.go pkg/feeds/*.go
go build -o $@ ./cmd/feedweb
.PHONY: clean
+8 -9
cmd/feedweb/main.go
···
package main
import (
+
"golang.org/x/text/language"
"net/http"
appbsky "github.com/bluesky-social/indigo/api/bsky"
···
Offset string `query:"offset"`
}
-
type SkeletonHeader struct {
-
Langs []string `header:"Accept-Language"`
+
type FeedLookup map[string]func(feeds.FeedgenParams) appbsky.FeedGetFeedSkeleton_Output
+
+
func parseLangs(userPrefs string) []language.Tag {
+
t, _, _ := language.ParseAcceptLanguage(userPrefs)
+
return t
}
-
type FeedLookup map[string]func(feeds.FeedgenParams) appbsky.FeedGetFeedSkeleton_Output
-
func getFeedSkeleton(c echo.Context) error {
var req SkeletonRequest
if err := c.Bind(&req); err != nil {
return c.String(http.StatusBadRequest, "bad request")
}
-
var hdr SkeletonHeader
-
if err := (&echo.DefaultBinder{}).BindHeaders(c, &hdr); err != nil {
-
return c.String(http.StatusBadRequest, "bad request")
-
}
generators := FeedLookup{
"at://did:plc:4nsduwlpivpuur4mqkbfvm6a/app.bsky.feed.generator/most-liked": mostliked.Feed,
}
+
params := feeds.FeedgenParams{
Feed: req.Feed,
Limit: req.Limit,
Offset: req.Offset,
-
Langs: hdr.Langs,
+
Langs: parseLangs(c.Request().Header.Get("Accept-Language")),
}
feedFunc, ok := generators[req.Feed]
if !ok {
+3 -1
go.mod
···
github.com/labstack/echo/v4 v4.11.3
github.com/mattn/go-sqlite3 v1.14.22
github.com/pemistahl/lingua-go v1.4.0
+
github.com/sanggonlee/gosq v1.2.0
+
golang.org/x/text v0.16.0
)
require (
···
github.com/multiformats/go-multihash v0.2.3 // indirect
github.com/multiformats/go-varint v0.0.7 // indirect
github.com/opentracing/opentracing-go v1.2.0 // indirect
+
github.com/pkg/errors v0.9.1 // indirect
github.com/polydawn/refmt v0.89.1-0.20221221234430-40501e09de1f // indirect
github.com/shopspring/decimal v1.3.1 // indirect
github.com/spaolacci/murmur3 v1.1.0 // indirect
···
golang.org/x/exp v0.0.0-20240604190554-fc45aab8b7f8 // indirect
golang.org/x/net v0.24.0 // indirect
golang.org/x/sys v0.22.0 // indirect
-
golang.org/x/text v0.16.0 // indirect
golang.org/x/time v0.5.0 // indirect
golang.org/x/xerrors v0.0.0-20231012003039-104605ab7028 // indirect
google.golang.org/protobuf v1.34.2 // indirect
+11
go.sum
···
github.com/go-logr/logr v1.4.1/go.mod h1:9T104GzyrTigFIr8wt5mBrctHMim0Nb2HLGrmQ40KvY=
github.com/go-logr/stdr v1.2.2 h1:hSWxHoqTgW2S2qGc0LTAI563KZ5YKYRhT3MFKZMbjag=
github.com/go-logr/stdr v1.2.2/go.mod h1:mMo/vtBO5dYbehREoey6XUKy/eSumjCCveDpRre4VKE=
+
github.com/go-test/deep v1.0.7 h1:/VSMRlnY/JSyqxQUzQLKVMAskpY/NZKFA5j2P+0pP2M=
+
github.com/go-test/deep v1.0.7/go.mod h1:QV8Hv/iy04NyLBxAdO9njL0iVPN1S4d/A3NVv1V36o8=
github.com/go-yaml/yaml v2.1.0+incompatible/go.mod h1:w2MrLa16VYP0jy6N7M5kHaCkaLENm+P+Tv+MfurjSw0=
github.com/goccy/go-json v0.10.2 h1:CrxCmQqYDkv1z7lO7Wbh2HN93uovUHgrECaO5ZrCXAU=
github.com/goccy/go-json v0.10.2/go.mod h1:6MelG93GURQebXPDq3khkgXZkazVtN9CRI+MGFi0w8I=
···
github.com/pemistahl/lingua-go v1.4.0 h1:ifYhthrlW7iO4icdubwlduYnmwU37V1sbNrwhKBR4rM=
github.com/pemistahl/lingua-go v1.4.0/go.mod h1:ECuM1Hp/3hvyh7k8aWSqNCPlTxLemFZsRjocUf3KgME=
github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
+
github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
+
github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/polydawn/refmt v0.89.1-0.20221221234430-40501e09de1f h1:VXTQfuJj9vKR4TCkEuWIckKvdHFeJH/huIFJ9/cXOB0=
···
github.com/rogpeppe/go-internal v1.12.0 h1:exVL4IDcn6na9z1rAb56Vxr+CgyK3nn3O+epU5NdKM8=
github.com/rogpeppe/go-internal v1.12.0/go.mod h1:E+RYuTGaKKdloAfM02xzb0FW3Paa99yedzYV+kq4uf4=
github.com/russross/blackfriday/v2 v2.0.1/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
+
github.com/sanggonlee/gosq v1.2.0 h1:A0648wgV1ISRODDjy3/P5MV4OKGDOI16ol6xMyi0wj4=
+
github.com/sanggonlee/gosq v1.2.0/go.mod h1:sUXP8djVeH+9XxjsJt93mJJymuRLKSz1KJfS1ByXBe0=
github.com/shopspring/decimal v1.3.1 h1:2Usl1nmF/WZucqkFZhnfFYxxxu8LG21F6nPQBE5gKV8=
github.com/shopspring/decimal v1.3.1/go.mod h1:DKyhrW/HYNuLGql+MJL6WCR6knT2jwCFRcu2hWCYk4o=
github.com/shurcooL/sanitized_anchor_name v1.0.0/go.mod h1:1NzhyTcUVG4SuEtjjoZeVRXNmyL/1OwPU0+IJeTBvfc=
···
github.com/spaolacci/murmur3 v1.1.0 h1:7c1g84S4BPRrfL5Xrdp6fOJ206sU9y293DDHaoy0bLI=
github.com/spaolacci/murmur3 v1.1.0/go.mod h1:JwIasOWyU6f++ZhiEuf87xNszmSA2myDM2Kzu9HwQUA=
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
+
github.com/stretchr/objx v0.4.0/go.mod h1:YvHI0jy2hoMjB+UWwv71VJQ9isScKT/TqJzVSSt89Yw=
+
github.com/stretchr/objx v0.5.0/go.mod h1:Yh+to48EsGEfYuaHDzXPcE3xhTkx73EhmCGUpEOglKo=
github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=
github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4=
github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
+
github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
+
github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU=
+
github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
github.com/urfave/cli v1.22.10/go.mod h1:Gos4lmkARVdJ6EkW0WaNv/tZAAMe9V7XWyB60NtXRu0=
+5 -1
pkg/feeds/feeds.go
···
package feeds
+
import (
+
"golang.org/x/text/language"
+
)
+
type FeedgenParams struct {
Feed string
Limit int64
Offset string
-
Langs []string
+
Langs []language.Tag
}
+111
pkg/mostliked/generator.go
···
+
package mostliked
+
+
import (
+
"context"
+
"database/sql"
+
"log"
+
"strconv"
+
+
appbsky "github.com/bluesky-social/indigo/api/bsky"
+
"github.com/edavis/bsky-feeds/pkg/feeds"
+
_ "github.com/mattn/go-sqlite3"
+
"github.com/sanggonlee/gosq"
+
)
+
+
type PostRow struct {
+
Uri string
+
Likes int
+
}
+
+
func getPosts(ctx context.Context, dbCnx *sql.DB, params feeds.FeedgenParams) ([]PostRow, error) {
+
q, err := gosq.Execute(`
+
SELECT posts.uri, likes
+
FROM posts LEFT JOIN langs ON posts.uri = langs.uri
+
WHERE 1=1
+
{{if .Langs}}
+
AND (
+
{{- range $index, $lang := .Langs }}
+
{{- if $index }} OR {{ end }} lang = ?
+
{{- end }}
+
)
+
{{end}}
+
{{if .Offset}}
+
AND likes < ?
+
{{end}}
+
ORDER BY likes DESC, create_ts DESC
+
LIMIT ?
+
`, params)
+
if err != nil {
+
log.Println("error in sql template:", err)
+
}
+
+
log.Println(q)
+
+
var queryParams []any
+
for _, lang := range params.Langs {
+
queryParams = append(queryParams, lang.String())
+
}
+
+
if params.Offset != "" {
+
queryParams = append(queryParams, params.Offset)
+
}
+
+
queryParams = append(queryParams, params.Limit)
+
+
log.Println(queryParams)
+
+
rows, err := dbCnx.QueryContext(ctx, q, queryParams...)
+
if err != nil {
+
return nil, err
+
}
+
defer rows.Close()
+
+
var posts []PostRow
+
for rows.Next() {
+
var post PostRow
+
if err := rows.Scan(&post.Uri, &post.Likes); err != nil {
+
return nil, err
+
}
+
posts = append(posts, post)
+
}
+
if err := rows.Close(); err != nil {
+
return nil, err
+
}
+
if err := rows.Err(); err != nil {
+
return nil, err
+
}
+
+
return posts, nil
+
}
+
+
func Feed(params feeds.FeedgenParams) appbsky.FeedGetFeedSkeleton_Output {
+
ctx := context.Background()
+
dbCnx, err := sql.Open("sqlite3", "data/mostliked.db?_journal=WAL&_fk=on&mode=ro")
+
if err != nil {
+
log.Fatal("error opening db")
+
}
+
defer dbCnx.Close()
+
+
rows, err := getPosts(ctx, dbCnx, params)
+
if err != nil {
+
log.Println("error fetching rows:", err)
+
}
+
+
var cursor string
+
posts := make([]*appbsky.FeedDefs_SkeletonFeedPost, 0, params.Limit)
+
+
for _, row := range rows {
+
posts = append(posts, &appbsky.FeedDefs_SkeletonFeedPost{Post: row.Uri})
+
cursor = strconv.Itoa(row.Likes)
+
}
+
+
skeleton := appbsky.FeedGetFeedSkeleton_Output{
+
Feed: posts,
+
}
+
+
if len(rows) == int(params.Limit) {
+
skeleton.Cursor = &cursor
+
}
+
+
return skeleton
+
}
+1
pkg/mostliked/handler.go
···
func findDetectableText(post appbsky.FeedPost) string {
// if we have text, detect against that
// no text but we do have images, detect against first alt text
+
// log.Printf("%+v\n", post)
if post.Text != "" {
return post.Text
-46
pkg/mostliked/view.go
···
-
package mostliked
-
-
import (
-
"context"
-
"database/sql"
-
"log"
-
"strconv"
-
-
appbsky "github.com/bluesky-social/indigo/api/bsky"
-
db "github.com/edavis/bsky-feeds/db/mostliked"
-
"github.com/edavis/bsky-feeds/pkg/feeds"
-
_ "github.com/mattn/go-sqlite3"
-
)
-
-
func Feed(params feeds.FeedgenParams) appbsky.FeedGetFeedSkeleton_Output {
-
ctx := context.Background()
-
dbCnx, err := sql.Open("sqlite3", "data/mostliked.db?_journal=WAL&_fk=on&mode=ro")
-
if err != nil {
-
log.Fatal("error opening db")
-
}
-
defer dbCnx.Close()
-
-
offset, err := strconv.Atoi(params.Offset)
-
if err != nil {
-
log.Println("error converting offset to integer")
-
}
-
-
queries := db.New(dbCnx)
-
rows, err := queries.ViewFeed(ctx, db.ViewFeedParams{
-
Limit: params.Limit,
-
Offset: int64(offset),
-
})
-
if err != nil {
-
log.Println("error fetching rows")
-
}
-
var cursor string
-
posts := make([]*appbsky.FeedDefs_SkeletonFeedPost, 0, params.Limit)
-
for _, row := range rows {
-
posts = append(posts, &appbsky.FeedDefs_SkeletonFeedPost{Post: row.Uri})
-
cursor = row.Uri
-
}
-
return appbsky.FeedGetFeedSkeleton_Output{
-
Cursor: &cursor,
-
Feed: posts,
-
}
-
}