hailey.at / cocoon
An atproto PDS written in Go
fork atom

never return null for collections in describeRepo (#7)

in a repo with no records, the collections field here ends up being the
nil slice instead of an empty slice, so you get null in the response.

since collections is a required field in the rpc def we shouldn't do this,
it breaks pdsls at least.

charlotte ✨ affaa58b 155cf40d

options
unified split
Changed files
+1 -1
server
handle_repo_describe_repo.go
+1 -1
server/handle_repo_describe_repo.go 
···

       
69

       
 

       
		return helpers.ServerError(e, nil)


     

       
70

       
 

       
	}


     

       
71

       
 

       



     

       
72

       
-

       
	var collections []string


     

       
73

       
 

       
	for _, r := range records {


     

       
74

       
 

       
		collections = append(collections, r.Nsid)


     

       
75

       
 

       
	}


     
···

       
69

       
 

       
		return helpers.ServerError(e, nil)


     

       
70

       
 

       
	}


     

       
71

       
 

       



     

       
72

       
+

       
	var collections []string = make([]string, 0)


     

       
73

       
 

       
	for _, r := range records {


     

       
74

       
 

       
		collections = append(collections, r.Nsid)


     

       
75

       
 

       
	}