commit 8e739ab2569ac11cdc4e60c1ce7d5ffbae0f6aba · hauleth.dev/esl_hn

+2 -2

config/test.exs

···

       3
       3
        
       # We don't run a server during test. If one is required,

     

       4
       4
        
       # you can enable the server option below.

     

       5
       5
        
       config :esl_hn, EslHnWeb.Endpoint,

     

       6
       6
       -
         http: [ip: {127, 0, 0, 1}, port: 4002],

     

       6
       6
       +
         http: [ip: {127, 0, 0, 1}, port: 0],

     

       7
       7
        
         secret_key_base:

     

       8
       8
        
           "6iR9shI35kN7Xr5bOLgBVMHXTZQS49Gwu82WW4rsr0uhaia7D+NjfNrhhvcOp4rr",

     

       9
       9
       -
         server: false

     

       9
       9
       +
         server: true

     

       10
       10
        
       

     

       11
       11
        
       # Disable main refresher in tests

     

       12
       12
        
       config :esl_hn, refresh: 0

+2 -1

lib/esl_hn/hn.ex

···

       45
       45
        
           |> Task.async_stream(&story(&1, opts))

     

       46
       46
        
           |> map_while(fn

     

       47
       47
        
             {:ok, {:ok, data}} -> {:cont, data}

     

       48
       48
       -
             other -> {:halt, other}

     

       48
       48
       +
             {:ok, error} -> {:halt, error}

     

       49
       49
       +
             {:error, reason} -> {:halt, {:error, {:process_error, reason}}}

     

       49
       50
        
           end)

     

       50
       51
        
           |> case do

     

       51
       52
        
             list when is_list(list) -> {:ok, list}

+4 -1

mix.exs

···

       45
       45
        
       

     

       46
       46
        
             # Testing

     

       47
       47
        
             {:test_server, "~> 0.1.21", only: [:test]},

     

       48
       48
       -
             {:stream_data, "~> 1.0", only: [:dev, :test]}

     

       48
       48
       +
             {:stream_data, "~> 1.0", only: [:dev, :test]},

     

       49
       49
       +
             # Websocket client for testing custom socket transport, I have no idea how

     

       50
       50
       +
             # ti can test it better

     

       51
       51
       +
             {:fresh, "~> 0.4.4", only: [:test]}

     

       49
       52
        
           ]

     

       50
       53
        
         end

     

       51
       54

mix.lock

···

       9
       9
        
         "erlex": {:hex, :erlex, "0.2.7", "810e8725f96ab74d17aac676e748627a07bc87eb950d2b83acd29dc047a30595", [:mix], [], "hexpm", "3ed95f79d1a844c3f6bf0cea61e0d5612a42ce56da9c03f01df538685365efb0"},

     

       10
       10
        
         "file_system": {:hex, :file_system, "1.1.0", "08d232062284546c6c34426997dd7ef6ec9f8bbd090eb91780283c9016840e8f", [:mix], [], "hexpm", "bfcf81244f416871f2a2e15c1b515287faa5db9c6bcf290222206d120b3d43f6"},

     

       11
       11
        
         "finch": {:hex, :finch, "0.20.0", "5330aefb6b010f424dcbbc4615d914e9e3deae40095e73ab0c1bb0968933cadf", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:mint, "~> 1.6.2 or ~> 1.7", [hex: :mint, repo: "hexpm", optional: false]}, {:nimble_options, "~> 0.4 or ~> 1.0", [hex: :nimble_options, repo: "hexpm", optional: false]}, {:nimble_pool, "~> 1.1", [hex: :nimble_pool, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "2658131a74d051aabfcba936093c903b8e89da9a1b63e430bee62045fa9b2ee2"},

     

       12
       12
       +
         "fresh": {:hex, :fresh, "0.4.4", "9d67a1d97112e70f4dfabd63b40e4b182ef64dfa84a2d9ee175eb4e34591e9f7", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: false]}, {:mint, "~> 1.5", [hex: :mint, repo: "hexpm", optional: false]}, {:mint_web_socket, "~> 1.0", [hex: :mint_web_socket, repo: "hexpm", optional: false]}], "hexpm", "ba21d3fa0aa77bf18ca397e4c851de7432bb3f9c170a1645a16e09e4bba54315"},

     

       12
       13
        
         "hpax": {:hex, :hpax, "1.0.3", "ed67ef51ad4df91e75cc6a1494f851850c0bd98ebc0be6e81b026e765ee535aa", [:mix], [], "hexpm", "8eab6e1cfa8d5918c2ce4ba43588e894af35dbd8e91e6e55c817bca5847df34a"},

     

       13
       14
        
         "jason": {:hex, :jason, "1.4.4", "b9226785a9aa77b6857ca22832cffa5d5011a667207eb2a0ad56adb5db443b8a", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "c5eb0cab91f094599f94d55bc63409236a8ec69a21a67814529e8d5f6cc90b3b"},

     

       14
       15
        
         "mime": {:hex, :mime, "2.0.7", "b8d739037be7cd402aee1ba0306edfdef982687ee7e9859bee6198c1e7e2f128", [:mix], [], "hexpm", "6171188e399ee16023ffc5b76ce445eb6d9672e2e241d2df6050f3c771e80ccd"},

     

       15
       16
        
         "mint": {:hex, :mint, "1.7.1", "113fdb2b2f3b59e47c7955971854641c61f378549d73e829e1768de90fc1abf1", [:mix], [{:castore, "~> 0.1.0 or ~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:hpax, "~> 0.1.1 or ~> 0.2.0 or ~> 1.0", [hex: :hpax, repo: "hexpm", optional: false]}], "hexpm", "fceba0a4d0f24301ddee3024ae116df1c3f4bb7a563a731f45fdfeb9d39a231b"},

     

       17
       17
       +
         "mint_web_socket": {:hex, :mint_web_socket, "1.0.4", "0b539116dbb3d3f861cdf5e15e269a933cb501c113a14db7001a3157d96ffafd", [:mix], [{:mint, ">= 1.4.1 and < 2.0.0-0", [hex: :mint, repo: "hexpm", optional: false]}], "hexpm", "027d4c5529c45a4ba0ce27a01c0f35f284a5468519c045ca15f43decb360a991"},

     

       16
       18
        
         "nimble_options": {:hex, :nimble_options, "1.1.1", "e3a492d54d85fc3fd7c5baf411d9d2852922f66e69476317787a7b2bb000a61b", [:mix], [], "hexpm", "821b2470ca9442c4b6984882fe9bb0389371b8ddec4d45a9504f00a66f650b44"},

     

       17
       19
        
         "nimble_pool": {:hex, :nimble_pool, "1.1.0", "bf9c29fbdcba3564a8b800d1eeb5a3c58f36e1e11d7b7fb2e084a643f645f06b", [:mix], [], "hexpm", "af2e4e6b34197db81f7aad230c1118eac993acc0dae6bc83bac0126d4ae0813a"},

     

       18
       20
        
         "phoenix": {:hex, :phoenix, "1.7.21", "14ca4f1071a5f65121217d6b57ac5712d1857e40a0833aff7a691b7870fc9a3b", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.1", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.7", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:websock_adapter, "~> 0.5.3", [hex: :websock_adapter, repo: "hexpm", optional: false]}], "hexpm", "336dce4f86cba56fed312a7d280bf2282c720abb6074bdb1b61ec8095bdd0bc9"},

+64 -1

test/esl_hn/hn_test.exs

···

       32
       32
        
             assert {:error, {:http_response, 418, _}} =

     

       33
       33
        
                      @subject.top_stories_ids(base_url: TestServer.url())

     

       34
       34
        
           end

     

       35
       35
       +
       

     

       36
       36
       +
           test "returns error in case of network error" do

     

       37
       37
       +
             assert {:error, _} =

     

       38
       38
       +
                      @subject.top_stories_ids(

     

       39
       39
       +
                        adapter: fn request ->

     

       40
       40
       +
                          {request, %RuntimeError{message: "oops"}}

     

       41
       41
       +
                        end

     

       42
       42
       +
                      )

     

       43
       43
       +
           end

     

       35
       44
        
         end

     

       36
       45
        
       

     

       37
       46
        
         describe "story/2" do

     

       38
       38
       -
           test "returns error on non 200 response" do

     

       47
       47
       +
           test "returns story on 200 response" do

     

       39
       48
        
             data = %{

     

       40
       49
        
               id: 2137,

     

       41
       50
        
               title: "Foo"

     
···

       49
       58
        
       

     

       50
       59
        
             assert {:ok, %{title: "Foo"}} =

     

       51
       60
        
                      @subject.story(2137, base_url: TestServer.url())

     

       61
       61
       +
           end

     

       62
       62
       +
       

     

       63
       63
       +
           test "returns error in case of network error" do

     

       64
       64
       +
             assert {:error, _} =

     

       65
       65
       +
                      @subject.story(2137,

     

       66
       66
       +
                        adapter: fn request ->

     

       67
       67
       +
                          {request, %RuntimeError{message: "oops"}}

     

       68
       68
       +
                        end

     

       69
       69
       +
                      )

     

       70
       70
       +
           end

     

       71
       71
       +
         end

     

       72
       72
       +
       

     

       73
       73
       +
         describe "stories/2" do

     

       74
       74
       +
           test "returns stories on 200 response" do

     

       75
       75
       +
             TestServer.add("/item/2137.json",

     

       76
       76
       +
               to: fn conn ->

     

       77
       77
       +
                 Phoenix.Controller.json(conn, %{

     

       78
       78
       +
                   id: 2137,

     

       79
       79
       +
                   title: "Foo"

     

       80
       80
       +
                 })

     

       81
       81
       +
               end

     

       82
       82
       +
             )

     

       83
       83
       +
       

     

       84
       84
       +
             TestServer.add("/item/666.json",

     

       85
       85
       +
               to: fn conn ->

     

       86
       86
       +
                 Phoenix.Controller.json(conn, %{

     

       87
       87
       +
                   id: 666,

     

       88
       88
       +
                   title: "Bar"

     

       89
       89
       +
                 })

     

       90
       90
       +
               end

     

       91
       91
       +
             )

     

       92
       92
       +
       

     

       93
       93
       +
             assert {:ok, [_, _]} =

     

       94
       94
       +
                      @subject.stories([2137, 666], base_url: TestServer.url())

     

       95
       95
       +
           end

     

       96
       96
       +
       

     

       97
       97
       +
           test "returns error if at least one story returns error" do

     

       98
       98
       +
             TestServer.add("/item/2137.json",

     

       99
       99
       +
               to: fn conn ->

     

       100
       100
       +
                 Phoenix.Controller.json(conn, %{

     

       101
       101
       +
                   id: 2137,

     

       102
       102
       +
                   title: "Foo"

     

       103
       103
       +
                 })

     

       104
       104
       +
               end

     

       105
       105
       +
             )

     

       106
       106
       +
       

     

       107
       107
       +
             TestServer.add("/item/666.json",

     

       108
       108
       +
               to: fn conn ->

     

       109
       109
       +
                 Conn.send_resp(conn, 404, "")

     

       110
       110
       +
               end

     

       111
       111
       +
             )

     

       112
       112
       +
       

     

       113
       113
       +
             assert {:error, _} =

     

       114
       114
       +
                      @subject.stories([2137, 666], base_url: TestServer.url())

     

       52
       115
        
           end

     

       53
       116
        
         end

     

       54
       117
        
       end

+65

test/esl_hn_web/api/socket_test.exs

···

       1
       1
       +
       defmodule EslHnWeb.Api.SocketTest do

     

       2
       2
       +
         use ExUnit.Case, async: false

     

       3
       3
       +
       

     

       4
       4
       +
         import EslHn.Test.Data

     

       5
       5
       +
       

     

       6
       6
       +
         alias EslHn.Cache

     

       7
       7
       +
       

     

       8
       8
       +
         setup do

     

       9
       9
       +
           assert {:ok, {host, port}} = EslHnWeb.Endpoint.server_info(:http)

     

       10
       10
       +
       

     

       11
       11
       +
           on_exit(fn -> Cache.flush(EslHn) end)

     

       12
       12
       +
       

     

       13
       13
       +
           {:ok, host: host, port: port}

     

       14
       14
       +
         end

     

       15
       15
       +
       

     

       16
       16
       +
         defmodule Client do

     

       17
       17
       +
           use Fresh

     

       18
       18
       +
       

     

       19
       19
       +
           def handle_in({:text, data}, {parent, counter}) do

     

       20
       20
       +
             send(parent, {:ws, counter, JSON.decode!(data)})

     

       21
       21
       +
             {:ok, {parent, counter + 1}}

     

       22
       22
       +
           end

     

       23
       23
       +
         end

     

       24
       24
       +
       

     

       25
       25
       +
         test "receive initial list of stories", ctx do

     

       26
       26
       +
           stories = Enum.take(story(), 50)

     

       27
       27
       +
       

     

       28
       28
       +
           ids = Enum.map(stories, & &1.id)

     

       29
       29
       +
           Cache.write(EslHn, :index, ids)

     

       30
       30
       +
       

     

       31
       31
       +
           Cache.write_all(EslHn, Enum.map(stories, &{&1.id, &1}))

     

       32
       32
       +
       

     

       33
       33
       +
           start_supervised!(

     

       34
       34
       +
             {Client, uri: "ws://localhost:#{ctx.port}/websocket", state: {self(), 0}}

     

       35
       35
       +
           )

     

       36
       36
       +
       

     

       37
       37
       +
           assert_receive {:ws, 0, init}

     

       38
       38
       +
       

     

       39
       39
       +
           recv_ids = Enum.map(init, & &1["id"])

     

       40
       40
       +
       

     

       41
       41
       +
           assert Enum.all?(ids, &(&1 in recv_ids))

     

       42
       42
       +
           assert length(recv_ids) == length(ids)

     

       43
       43
       +
         end

     

       44
       44
       +
       

     

       45
       45
       +
         test "broadcasted events are sent over socket", ctx do

     

       46
       46
       +
           start_supervised!(

     

       47
       47
       +
             {Client, uri: "ws://localhost:#{ctx.port}/websocket", state: {self(), 0}}

     

       48
       48
       +
           )

     

       49
       49
       +
       

     

       50
       50
       +
           assert_receive {:ws, 0, []}

     

       51
       51
       +
       

     

       52
       52
       +
           for stories <- Enum.take(StreamData.list_of(story(), min_length: 1), 10) do

     

       53
       53
       +
             ids = Enum.map(stories, & &1.id)

     

       54
       54
       +
       

     

       55
       55
       +
             EslHn.broadcast_new(stories)

     

       56
       56
       +
       

     

       57
       57
       +
             assert_receive {:ws, _, msg}

     

       58
       58
       +
       

     

       59
       59
       +
             recv_ids = Enum.map(msg, & &1["id"])

     

       60
       60
       +
       

     

       61
       61
       +
             assert Enum.all?(ids, &(&1 in recv_ids))

     

       62
       62
       +
             assert length(recv_ids) == length(ids)

     

       63
       63
       +
           end

     

       64
       64
       +
         end

     

       65
       65
       +
       end