commit a94b9d1efd86161162644d15bb31cfc97740abb6 · hauleth.dev/esl_hn

config/test.exs

···

       8
       8
        
           "6iR9shI35kN7Xr5bOLgBVMHXTZQS49Gwu82WW4rsr0uhaia7D+NjfNrhhvcOp4rr",

     

       9
       9
        
         server: false

     

       10
       10
        
       

     

       11
       11
       +
       # Disable main refresher in tests

     

       12
       12
       +
       config :esl_hn, refresh: 0

     

       13
       13
       +
       

     

       11
       14
        
       # Print only warnings and errors during test

     

       12
       15
        
       config :logger, level: :warning

     

       13
       16

+5 -3

lib/esl_hn.ex

···

       7
       7
        
         if it comes from the database, an external API or others.

     

       8
       8
        
         """

     

       9
       9
        
       

     

       10
       10
       +
         alias EslHn.Cache

     

       11
       11
       +
       

     

       10
       12
        
         def all(page \\ 1, per_page \\ 10) do

     

       11
       13
        
           skip = per_page * (page - 1)

     

       12
       14
        
       

     

       13
       13
       -
           ids = EslHn.Cache.get(EslHn, :index, [])

     

       15
       15
       +
           ids = Cache.get(EslHn, :index, [])

     

       14
       16
        
       

     

       15
       17
        
           ids

     

       16
       18
        
           |> Enum.drop(skip)

     

       17
       19
        
           |> Enum.take(per_page)

     

       18
       18
       -
           |> Enum.map(&story/1)

     

       20
       20
       +
           |> Enum.map(&Cache.get(EslHn, &1))

     

       19
       21
        
         end

     

       20
       22
        
       

     

       21
       23
        
         def story(id) do

     

       22
       22
       -
           EslHn.Cache.get(EslHn, id)

     

       24
       24
       +
           Cache.fetch(EslHn, id)

     

       23
       25
        
         end

     

       24
       26
        
       

     

       25
       27
        
         def broadcast_new(stories) do

lib/esl_hn/cache.ex

···

       47
       47
        
           :ok

     

       48
       48
        
         end

     

       49
       49
        
       

     

       50
       50
       +
         def flush(tid) do

     

       51
       51
       +
           :ets.delete_all_objects(tid)

     

       52
       52
       +
       

     

       53
       53
       +
           :ok

     

       54
       54
       +
         end

     

       55
       55
       +
       

     

       50
       56
        
         @impl true

     

       51
       57
        
         def init(opts) do

     

       52
       58
        
           {name, opts} =

+11 -7

lib/esl_hn/refresher.ex

···

       12
       12
        
           {mod, tid} = Access.fetch!(opts, :cache)

     

       13
       13
        
           req_opts = Access.get(opts, :req_opts, [])

     

       14
       14
        
       

     

       15
       15
       -
           {:ok,

     

       16
       16
       -
            %{

     

       17
       17
       -
              refresh: refresh,

     

       18
       18
       -
              ids: MapSet.new(),

     

       19
       19
       -
              cache: {mod, tid},

     

       20
       20
       -
              req_opts: req_opts

     

       21
       21
       -
            }, {:continue, :refresh}}

     

       15
       15
       +
           if refresh > 0 do

     

       16
       16
       +
             {:ok,

     

       17
       17
       +
              %{

     

       18
       18
       +
                refresh: refresh,

     

       19
       19
       +
                ids: MapSet.new(),

     

       20
       20
       +
                cache: {mod, tid},

     

       21
       21
       +
                req_opts: req_opts

     

       22
       22
       +
              }, {:continue, :refresh}}

     

       23
       23
       +
           else

     

       24
       24
       +
             :ignore

     

       25
       25
       +
           end

     

       22
       26
        
         end

     

       23
       27
        
       

     

       24
       28
        
         @impl true

+18 -2

lib/esl_hn_web/api/controller.ex

···

       7
       7
        
           render(conn, items: EslHn.all(page))

     

       8
       8
        
         end

     

       9
       9
        
       

     

       10
       10
       -
         def show(conn, %{"id" => _id}) do

     

       11
       11
       -
           render(conn, item: %EslHn.Hn.Story{})

     

       10
       10
       +
         def show(conn, %{"id" => id}) do

     

       11
       11
       +
           with {:ok, id} <- try_int(id),

     

       12
       12
       +
                {:ok, story} <- EslHn.story(id) do

     

       13
       13
       +
             render(conn, item: story)

     

       14
       14
       +
           else

     

       15
       15
       +
             _ ->

     

       16
       16
       +
               conn

     

       17
       17
       +
               |> put_status(:not_found)

     

       18
       18
       +
               |> put_view(EslHnWeb.Error.JSON)

     

       19
       19
       +
               |> render(:"404", %{})

     

       20
       20
       +
           end

     

       12
       21
        
         end

     

       13
       22
        
       

     

       14
       23
        
         defp get_page(nil), do: 1

     

       15
       24
        
       

     

       16
       25
        
         defp get_page(input) do

     

       17
       26
        
           String.to_integer(input)

     

       27
       27
       +
         end

     

       28
       28
       +
       

     

       29
       29
       +
         defp try_int(value) do

     

       30
       30
       +
           case Integer.parse(value) do

     

       31
       31
       +
             {int, ""} -> {:ok, int}

     

       32
       32
       +
             _ -> :error

     

       33
       33
       +
           end

     

       18
       34
        
         end

     

       19
       35
        
       end

lib/esl_hn_web/router.ex

···

       9
       9
        
           pipe_through :api

     

       10
       10
        
       

     

       11
       11
        
           get "/", API.Controller, :index

     

       12
       12
       +
           get "/:id", API.Controller, :show

     

       12
       13
        
         end

     

       13
       14
        
       

     

       14
       15
        
         if Application.compile_env(:esl_hn, :dev_routes) do

+120

test/esl_hn_web/api/controller_test.exs

···

       1
       1
       +
       defmodule EslHnWeb.Api.ControllerTest do

     

       2
       2
       +
         use EslHnWeb.ConnCase, async: false

     

       3
       3
       +
         use ExUnitProperties

     

       4
       4
       +
       

     

       5
       5
       +
         import EslHn.Test.Data

     

       6
       6
       +
       

     

       7
       7
       +
         alias EslHn.Cache

     

       8
       8
       +
       

     

       9
       9
       +
         setup do

     

       10
       10
       +
           on_exit(fn -> Cache.flush(EslHn) end)

     

       11
       11
       +
         end

     

       12
       12
       +
       

     

       13
       13
       +
         describe "GET /" do

     

       14
       14
       +
           test "with empty cache returns empty list", %{conn: conn} do

     

       15
       15
       +
             resp =

     

       16
       16
       +
               conn

     

       17
       17
       +
               |> get(~p"/")

     

       18
       18
       +
               |> json_response(200)

     

       19
       19
       +
       

     

       20
       20
       +
             assert resp == []

     

       21
       21
       +
           end

     

       22
       22
       +
       

     

       23
       23
       +
           property "with some stories in index these are fetched", %{conn: conn} do

     

       24
       24
       +
             check all(stories <- list_of(story(), max_length: 10)) do

     

       25
       25
       +
               ids = Enum.map(stories, & &1.id)

     

       26
       26
       +
               Cache.write(EslHn, :index, ids)

     

       27
       27
       +
       

     

       28
       28
       +
               Cache.write_all(EslHn, Enum.map(stories, &{&1.id, &1}))

     

       29
       29
       +
       

     

       30
       30
       +
               resp_ids =

     

       31
       31
       +
                 conn

     

       32
       32
       +
                 |> get(~p"/")

     

       33
       33
       +
                 |> json_response(200)

     

       34
       34
       +
                 |> Enum.map(& &1["id"])

     

       35
       35
       +
       

     

       36
       36
       +
               assert Enum.all?(ids, &(&1 in resp_ids))

     

       37
       37
       +
             end

     

       38
       38
       +
           end

     

       39
       39
       +
       

     

       40
       40
       +
           property "return at most 10 elements at once", %{conn: conn} do

     

       41
       41
       +
             check all(stories <- list_of(story())) do

     

       42
       42
       +
               ids = Enum.map(stories, & &1.id)

     

       43
       43
       +
               Cache.write(EslHn, :index, ids)

     

       44
       44
       +
       

     

       45
       45
       +
               Cache.write_all(EslHn, Enum.map(stories, &{&1.id, &1}))

     

       46
       46
       +
       

     

       47
       47
       +
               resp =

     

       48
       48
       +
                 conn

     

       49
       49
       +
                 |> get(~p"/")

     

       50
       50
       +
                 |> json_response(200)

     

       51
       51
       +
       

     

       52
       52
       +
               assert length(resp) <= 10

     

       53
       53
       +
             end

     

       54
       54
       +
           end

     

       55
       55
       +
       

     

       56
       56
       +
           property "if more than 10 elements there are stories on second page", %{

     

       57
       57
       +
             conn: conn

     

       58
       58
       +
           } do

     

       59
       59
       +
             check all(stories <- list_of(story(), min_length: 11)) do

     

       60
       60
       +
               ids = Enum.map(stories, & &1.id)

     

       61
       61
       +
               Cache.write(EslHn, :index, ids)

     

       62
       62
       +
       

     

       63
       63
       +
               Cache.write_all(EslHn, Enum.map(stories, &{&1.id, &1}))

     

       64
       64
       +
       

     

       65
       65
       +
               resp =

     

       66
       66
       +
                 conn

     

       67
       67
       +
                 |> get(~p"/?page=2")

     

       68
       68
       +
                 |> json_response(200)

     

       69
       69
       +
       

     

       70
       70
       +
               assert length(resp) in 1..10

     

       71
       71
       +
             end

     

       72
       72
       +
           end

     

       73
       73
       +
       

     

       74
       74
       +
           property "if requested page is outside of the possible range, returns empty list",

     

       75
       75
       +
                    %{

     

       76
       76
       +
                      conn: conn

     

       77
       77
       +
                    } do

     

       78
       78
       +
             check all(stories <- list_of(story(), max_length: 50)) do

     

       79
       79
       +
               ids = Enum.map(stories, & &1.id)

     

       80
       80
       +
               Cache.write(EslHn, :index, ids)

     

       81
       81
       +
       

     

       82
       82
       +
               Cache.write_all(EslHn, Enum.map(stories, &{&1.id, &1}))

     

       83
       83
       +
       

     

       84
       84
       +
               resp =

     

       85
       85
       +
                 conn

     

       86
       86
       +
                 |> get(~p"/?page=2137")

     

       87
       87
       +
                 |> json_response(200)

     

       88
       88
       +
       

     

       89
       89
       +
               assert resp == []

     

       90
       90
       +
             end

     

       91
       91
       +
           end

     

       92
       92
       +
         end

     

       93
       93
       +
       

     

       94
       94
       +
         describe "GET /:id" do

     

       95
       95
       +
           test "for non-existent story returns 404", %{conn: conn} do

     

       96
       96
       +
             conn

     

       97
       97
       +
             |> get(~p"/2137")

     

       98
       98
       +
             |> json_response(404)

     

       99
       99
       +
           end

     

       100
       100
       +
       

     

       101
       101
       +
           test "for non-integer story ID returns 404", %{conn: conn} do

     

       102
       102
       +
             conn

     

       103
       103
       +
             |> get(~p"/foo-bar")

     

       104
       104
       +
             |> json_response(404)

     

       105
       105
       +
           end

     

       106
       106
       +
       

     

       107
       107
       +
           test "return data for existing story", %{conn: conn} do

     

       108
       108
       +
             Cache.write_all(EslHn, [

     

       109
       109
       +
               {2137, %EslHn.Hn.Story{id: 2137, title: "Foo"}}

     

       110
       110
       +
             ])

     

       111
       111
       +
       

     

       112
       112
       +
             resp =

     

       113
       113
       +
               conn

     

       114
       114
       +
               |> get(~p"/2137")

     

       115
       115
       +
               |> json_response(200)

     

       116
       116
       +
       

     

       117
       117
       +
             assert "Foo" == resp["title"]

     

       118
       118
       +
           end

     

       119
       119
       +
         end

     

       120
       120
       +
       end

+2 -16

test/esl_hn_web/api/json_test.exs

···

       2
       2
        
         use ExUnit.Case, async: true

     

       3
       3
        
         use ExUnitProperties

     

       4
       4
        
       

     

       5
       5
       -
         alias EslHn.Hn.Story

     

       5
       5
       +
         import EslHn.Test.Data

     

       6
       6
        
       

     

       7
       7
        
         @subject EslHnWeb.API.JSON

     

       8
       8
        
       

     

       9
       9
        
         doctest @subject

     

       10
       10
       -
       

     

       11
       11
       -
         defp story do

     

       12
       12
       -
           gen all(

     

       13
       13
       -
                 title <- string(:utf8, min_length: 1),

     

       14
       14
       -
                 score <- positive_integer()

     

       15
       15
       -
               ) do

     

       16
       16
       -
             %Story{

     

       17
       17
       -
               id: System.unique_integer([:positive]),

     

       18
       18
       -
               title: title,

     

       19
       19
       -
               score: score,

     

       20
       20
       -
               url: "https://example.com/#{URI.encode(title)}"

     

       21
       21
       -
             }

     

       22
       22
       -
           end

     

       23
       23
       -
         end

     

       24
       10
        
       

     

       25
       11
        
         describe "index/1" do

     

       26
       12
        
           test "for empty list renders empty list" do

     
···

       54
       40
        
       

     

       55
       41
        
         describe "show/1" do

     

       56
       42
        
           property "encoded title is the same as input title" do

     

       57
       57
       -
             check all story <- story() do

     

       43
       43
       +
             check all(story <- story()) do

     

       58
       44
        
               assert story.title == @subject.show(%{item: story}).title

     

       59
       45
        
             end

     

       60
       46
        
           end

+19

test/support/data.ex

···

       1
       1
       +
       defmodule EslHn.Test.Data do

     

       2
       2
       +
         use ExUnitProperties

     

       3
       3
       +
       

     

       4
       4
       +
         alias EslHn.Hn.Story

     

       5
       5
       +
       

     

       6
       6
       +
         def story do

     

       7
       7
       +
           gen all(

     

       8
       8
       +
                 title <- string(:utf8, min_length: 1),

     

       9
       9
       +
                 score <- positive_integer()

     

       10
       10
       +
               ) do

     

       11
       11
       +
             %Story{

     

       12
       12
       +
               id: System.unique_integer([:positive]),

     

       13
       13
       +
               title: title,

     

       14
       14
       +
               score: score,

     

       15
       15
       +
               url: "https://example.com/#{URI.encode(title)}"

     

       16
       16
       +
             }

     

       17
       17
       +
           end

     

       18
       18
       +
         end

     

       19
       19
       +
       end