commit a5fd37d1b21b7d884f1f951b059127dbe15f2981 · kitten.sh/graphql.web

.changeset/tiny-gifts-exercise.md

···

       1
       1
       +
       ---

     

       2
       2
       +
       '@0no-co/graphql.web': patch

     

       3
       3
       +
       ---

     

       4
       4
       +
       

     

       5
       5
       +
       Add `loc` getter to parsed `DocumentNode` fragment outputs to ensure that using fragments created by `gql.tada`'s `graphql()` function with `graphql-tag` doesn't crash. `graphql-tag` does not treat the `DocumentNode.loc` property as optional on interpolations, which leads to intercompatibility issues.

+1 -1

src/__tests__/parser.test.ts

···

       6
       6
        
       

     

       7
       7
        
       describe('parse', () => {

     

       8
       8
        
         it('parses the kitchen sink document like graphql.js does', () => {

     

       9
       9
       -
           const doc = parse(kitchenSinkDocument);

     

       9
       9
       +
           const doc = parse(kitchenSinkDocument, { noLocation: true });

     

       10
       10
        
           expect(doc).toMatchSnapshot();

     

       11
       11
        
         });

     

       12
       12

+35 -4

src/parser.ts

···

       6
       6
        
        */

     

       7
       7
        
       import type { Kind, OperationTypeNode } from './kind';

     

       8
       8
        
       import { GraphQLError } from './error';

     

       9
       9
       -
       import type { Source } from './types';

     

       9
       9
       +
       import type { Location, Source } from './types';

     

       10
       10
        
       import type * as ast from './ast';

     

       11
       11
        
       

     

       12
       12
        
       let input: string;

     
···

       483
       483
        
         }

     

       484
       484
        
       }

     

       485
       485
        
       

     

       486
       486
       -
       function document(): ast.DocumentNode {

     

       486
       486
       +
       function document(input: string, noLoc: boolean): ast.DocumentNode {

     

       487
       487
        
         let match: string | undefined;

     

       488
       488
        
         let definition: ast.OperationDefinitionNode | undefined;

     

       489
       489
        
         ignored();

     
···

       498
       498
        
             throw error('Document');

     

       499
       499
        
           }

     

       500
       500
        
         } while (idx < input.length);

     

       501
       501
       +
       

     

       502
       502
       +
         if (!noLoc) {

     

       503
       503
       +
           let loc: Location | undefined;

     

       504
       504
       +
           return {

     

       505
       505
       +
             kind: 'Document' as Kind.DOCUMENT,

     

       506
       506
       +
             definitions,

     

       507
       507
       +
             /* v8 ignore start */

     

       508
       508
       +
             set loc(_loc: Location) {

     

       509
       509
       +
               loc = _loc;

     

       510
       510
       +
             },

     

       511
       511
       +
             /* v8 ignore stop */

     

       512
       512
       +
             // @ts-ignore

     

       513
       513
       +
             get loc() {

     

       514
       514
       +
               if (!loc) {

     

       515
       515
       +
                 loc = {

     

       516
       516
       +
                   start: 0,

     

       517
       517
       +
                   end: input.length,

     

       518
       518
       +
                   startToken: undefined,

     

       519
       519
       +
                   endToken: undefined,

     

       520
       520
       +
                   source: {

     

       521
       521
       +
                     body: input,

     

       522
       522
       +
                     name: 'graphql.web',

     

       523
       523
       +
                     locationOffset: { line: 1, column: 1 },

     

       524
       524
       +
                   },

     

       525
       525
       +
                 };

     

       526
       526
       +
               }

     

       527
       527
       +
               return loc;

     

       528
       528
       +
             },

     

       529
       529
       +
           };

     

       530
       530
       +
         }

     

       531
       531
       +
       

     

       501
       532
        
         return {

     

       502
       533
        
           kind: 'Document' as Kind.DOCUMENT,

     

       503
       534
        
           definitions,

     
···

       510
       541
        
       

     

       511
       542
        
       export function parse(

     

       512
       543
        
         string: string | Source,

     

       513
       513
       -
         _options?: ParseOptions | undefined

     

       544
       544
       +
         options?: ParseOptions | undefined

     

       514
       545
        
       ): ast.DocumentNode {

     

       515
       546
        
         input = typeof string.body === 'string' ? string.body : string;

     

       516
       547
        
         idx = 0;

     

       517
       517
       -
         return document();

     

       548
       548
       +
         return document(input, options && options.noLocation);

     

       518
       549
        
       }

     

       519
       550
        
       

     

       520
       551
        
       export function parseValue(