commit a620d15376ebc4891ac465e05a655e0f737c048a · kitten.sh/urql

+5

.changeset/good-walls-obey.md

···

       1
       1
       +
       ---

     

       2
       2
       +
       '@urql/core': patch

     

       3
       3
       +
       ---

     

       4
       4
       +
       

     

       5
       5
       +
       Allow empty error messages when re-hydrating GraphQL errors

+10

packages/core/src/utils/error.test.ts

···

       60
       60
        
           expect(err.graphQLErrors).toEqual(graphQLErrors);

     

       61
       61
        
         });

     

       62
       62
        
       

     

       63
       63
       +
         it('accepts empty string errors for graphQLError', () => {

     

       64
       64
       +
           const graphQLErrors = [new Error('')];

     

       65
       65
       +
       

     

       66
       66
       +
           const err = new CombinedError({ graphQLErrors });

     

       67
       67
       +
       

     

       68
       68
       +
           expect(err.message).toBe('[GraphQL] ');

     

       69
       69
       +
       

     

       70
       70
       +
           expect(err.graphQLErrors).toEqual(graphQLErrors);

     

       71
       71
       +
         });

     

       72
       72
       +
       

     

       63
       73
        
         it('accepts a response that is attached to the resulting error', () => {

     

       64
       74
        
           const response = {};

     

       65
       75
        
           const err = new CombinedError({

+2 -2

packages/core/src/utils/error.ts

···

       19
       19
        
       const rehydrateGraphQlError = (error: any): GraphQLError => {

     

       20
       20
        
         if (

     

       21
       21
        
           error &&

     

       22
       22
       -
           error.message &&

     

       22
       22
       +
           typeof error.message === 'string' &&

     

       23
       23
        
           (error.extensions || error.name === 'GraphQLError')

     

       24
       24
        
         ) {

     

       25
       25
        
           return error;

     

       26
       26
       -
         } else if (typeof error === 'object' && error.message) {

     

       26
       26
       +
         } else if (typeof error === 'object' && typeof error.message === 'string') {

     

       27
       27
        
           return new GraphQLError(

     

       28
       28
        
             error.message,

     

       29
       29
        
             error.nodes,