commit b757332b0d05a9a79fea180dbd6e7942d27419a2 · kitten.sh/urql

.changeset/shaggy-taxis-grab.md

···

       1
       1
       +
       ---

     

       2
       2
       +
       '@urql/core': minor

     

       3
       3
       +
       ---

     

       4
       4
       +
       

     

       5
       5
       +
       Fix type definition for `GraphQLRequestParams` to make `variables` field optional if and only if **all** fields are optional or nullish

+10 -10

packages/core/src/types.ts

···

       386
       386
        
                 variables?: Variables;

     

       387
       387
        
               }

     

       388
       388
        
             : Variables extends {

     

       389
       389
       -
                   [P in keyof Variables]: Exclude<Variables[P], null | void>;

     

       389
       389
       +
                   [P in keyof Variables]: undefined extends Variables[P]

     

       390
       390
       +
                     ? unknown

     

       391
       391
       +
                     : null extends Variables[P]

     

       392
       392
       +
                       ? unknown

     

       393
       393
       +
                       : void extends Variables[P]

     

       394
       394
       +
                         ? unknown

     

       395
       395
       +
                         : never;

     

       390
       396
        
                 }

     

       391
       391
       -
               ? Variables extends {

     

       392
       392
       -
                   [P in keyof Variables]: never;

     

       397
       397
       +
               ? {

     

       398
       398
       +
                   variables?: Variables;

     

       393
       399
        
                 }

     

       394
       394
       -
                 ? {

     

       395
       395
       -
                     variables?: Variables;

     

       396
       396
       -
                   }

     

       397
       397
       -
                 : {

     

       398
       398
       -
                     variables: Variables;

     

       399
       399
       -
                   }

     

       400
       400
        
               : {

     

       401
       401
       -
                   variables?: Variables;

     

       401
       401
       +
                   variables: Variables;

     

       402
       402
        
                 }))

     

       403
       403
        
         | {

     

       404
       404
        
             query: DocumentInput<Data, Variables>;