commit 95c15e7694b90bd6f7b9649483f6d5f9099a028c · kitten.sh/wonka

.changeset/five-rules-bow.md

···

       1
       +
       ---

     

       2
       +
       'wonka': patch

     

       3
       +
       ---

     

       4
       +
       

     

       5
       +
       Make `closed: boolean` on `ObservableSubscription`s a required field to comply with the Observable proposal's type spec.

+2 -2

src/observable.ts

···

       26
        
          *

     

       27
        
          * @readonly

     

       28
        
          */

     

       29
       -
         closed?: boolean;

     

       30
        
         /** Cancels the subscription.

     

       31
        
          * @remarks

     

       32
        
          * This cancels the ongoing subscription and the {@link ObservableObserver}'s callbacks will

     
···

       76
        
          * @see {@link ObservableObserver} for the callbacks in an object that are called as Observables

     

       77
        
          * issue events.

     

       78
        
          */

     

       79
       -
         subscribe(observer: ObservableObserver<T>): ObservableSubscription;

     

       80
        
       

     

       81
        
         /** The well-known symbol specifying the default ES Observable for an object. */

     

       82
        
         [Symbol.observable]?(): Observable<T>;

···

       26
        
          *

     

       27
        
          * @readonly

     

       28
        
          */

     

       29
       +
         closed: boolean;

     

       30
        
         /** Cancels the subscription.

     

       31
        
          * @remarks

     

       32
        
          * This cancels the ongoing subscription and the {@link ObservableObserver}'s callbacks will

     
···

       76
        
          * @see {@link ObservableObserver} for the callbacks in an object that are called as Observables

     

       77
        
          * issue events.

     

       78
        
          */

     

       79
       +
         subscribe(observer: ObservableObserver<T>): { unsubscribe(): void };

     

       80
        
       

     

       81
        
         /** The well-known symbol specifying the default ES Observable for an object. */

     

       82
        
         [Symbol.observable]?(): Observable<T>;