notnite.com / moonlight
this repo has no description
fork atom

core/patch: Only insert into module cache if module was patched

This prevents patches that result in invalid JavaScript syntax from
hard-crashing the client. Noticed this issue with quietLoggers.

notnite.com 7e01dbab a4b0ca6d

options
unified split
Changed files
+3 -2
packages
core
src
patch.ts
+3 -2
packages/core/src/patch.ts 
···

       
193

       
193

       
 

       
    }


     

       
194

       
194

       
 

       



     

       
195

       
195

       
 

       
    if (modified) {


     

       
196

       

       
-

       
      if (!swappedModule) patchModule(id, patchedStr.join(", "), moduleString, entry);


     

       
197

       

       
-

       
      moduleCache[id] = moduleString;


     

       

       
196

       
+

       
      let shouldCache = true;


     

       

       
197

       
+

       
      if (!swappedModule) shouldCache = patchModule(id, patchedStr.join(", "), moduleString, entry);


     

       

       
198

       
+

       
      if (shouldCache) moduleCache[id] = moduleString;


     

       
198

       
199

       
 

       
      moonlight.patched.set(id, exts);


     

       
199

       
200

       
 

       
    }


     

       
200

       
201