pyrox.dev / nixpkgs
lol
fork atom

Revert "nixos/systemd-coredump: guard static gid for systemd-coredump behind state version"

This reverts commits f5483464d5726d05b6169017e6b0f64ebccc2f53 and
6b9583e5e121b26468d880bdb65302a9172fc041.

Ideally, we shouldn't cause friction for users that bump `stateVersion`,
and I'd consider having to switch and/or manually hardcode a UID/GID
to supress the warning friction. I think it'd be more beneficial to, in
this rare case of an ID being missed, just let it be until more
discussion happens surrounding this overall issue.

See https://github.com/NixOS/nixpkgs/pull/217785 for more context.

winter.bsky.social 15f1369b 0f487f2b

options
unified split
Changed files
+1 -4
nixos
modules
misc
ids.nix
system
boot
systemd
coredump.nix
-1
nixos/modules/misc/ids.nix 
···

       
510

       
510

       
 

       
      #seeks = 148; # removed 2020-06-21


     

       
511

       
511

       
 

       
      prosody = 149;


     

       
512

       
512

       
 

       
      i2pd = 150;


     

       
513

       

       
-

       
      systemd-coredump = 151;


     

       
514

       
513

       
 

       
      systemd-network = 152;


     

       
515

       
514

       
 

       
      systemd-resolve = 153;


     

       
516

       
515

       
 

       
      systemd-timesync = 154;
+1 -3
nixos/modules/system/boot/systemd/coredump.nix 
···

       
66

       
66

       
 

       
        uid = config.ids.uids.systemd-coredump;


     

       
67

       
67

       
 

       
        group = "systemd-coredump";


     

       
68

       
68

       
 

       
      };


     

       
69

       

       
-

       
      users.groups.systemd-coredump = {


     

       
70

       

       
-

       
        gid = mkIf (lib.versionAtLeast config.system.stateVersion "23.05") config.ids.gids.systemd-coredump;


     

       
71

       

       
-

       
      };


     

       

       
69

       
+

       
      users.groups.systemd-coredump = {};


     

       
72

       
70

       
 

       
    })


     

       
73

       
71

       
 

       



     

       
74

       
72

       
 

       
    (mkIf (!cfg.enable) {