pyrox.dev / nixpkgs
lol
fork atom

nixos/startx: remove graphical-session assertions

this assertion broke gnome sessions in very hard to debug way:

- gdm starts, but on successful login just returns to login screen
- journalctl isn't exactly helpful in this condition:
- a typical gnome login will involve many warnings and errors, that
aren't actually preventing login, but will lead affected users
on a merry chase for many hours
- the actual indicators in the log arent't even an errors, only info and warning
- graphical-session.target: Starting requested but asserts failed.
- Assertion failed for Current graphical user session.

startx is a power tool for power users, needing a certain level of
expertise for the user to even want it, let alone use correctly.
However, the expectation is, that the necessary expertise will be
contained within the domain of startx and that it not break tools for
regular users.

This partially reverts commit e1c30820858c767d1c77d0e24472b9424b2103ed.

Herwig Hochleitner 2107f032 47cecd80

options
unified split
Changed files
-8
nixos
modules
services
x11
display-managers
startx.nix
-8
nixos/modules/services/x11/display-managers/startx.nix 
···

       
102

       
102

       
 

       



     

       
103

       
103

       
 

       
    environment.systemPackages = with pkgs; [ xorg.xinit ];


     

       
104

       
104

       
 

       



     

       
105

       

       
-

       
    # Make graphical-session fail if the user environment has not been imported


     

       
106

       

       
-

       
    systemd.user.targets.graphical-session = {


     

       
107

       

       
-

       
      unitConfig.AssertEnvironment = [


     

       
108

       

       
-

       
        "DISPLAY"


     

       
109

       

       
-

       
        "XDG_SESSION_ID"


     

       
110

       

       
-

       
      ];


     

       
111

       

       
-

       
    };


     

       
112

       

       
-

       



     

       
113

       
105

       
 

       
  };


     

       
114

       
106

       
 

       



     

       
115

       
107

       
 

       
}