commit 24ace2abee4d9ae78cb79d3dc82cf7439d067bb2 · pyrox.dev/nixpkgs

+21 -1
nixos/modules/services/web-servers/garage.nix
···

       70
       70
        
             # to garage 1.0.0 while relying on the module-level default, they would be left

     

       71
       71
        
             # with a config which evaluates and builds, but then garage refuses to start

     

       72
       72
        
             # because either replication_factor or replication_mode is required.

     

       73
       73
       -
             # This assertion can be removed in NixOS 24.11, when all users have been warned once.

     

       73
       73
       +
             # The replication_factor option also was `toString`'ed before, which is

     

       74
       74
       +
             # now not possible anymore, so we prompt the user to change it to a string

     

       75
       75
       +
             # if present.

     

       76
       76
       +
             # These assertions can be removed in NixOS 24.11, when all users have been

     

       77
       77
       +
             # warned once.

     

       74
       78
        
             {

     

       75
       79
        
               assertion = (cfg.settings ? replication_factor || cfg.settings ? replication_mode) || lib.versionOlder cfg.package "1.0.0";

     

       76
       80
        
               message = ''

     
···

       78
       82
        
                 Please set replication_factor to 1 explicitly to preserve the previous behavior.

     

       79
       83
        
                 https://git.deuxfleurs.fr/Deuxfleurs/garage/src/tag/v1.0.0/doc/book/reference-manual/configuration.md#replication_factor

     

       80
       84
        
       

     

       85
       85
       +
               '';

     

       86
       86
       +
             }

     

       87
       87
       +
             {

     

       88
       88
       +
               assertion = lib.isString (cfg.settings.replication_mode or "");

     

       89
       89
       +
               message = ''

     

       90
       90
       +
                 The explicit `replication_mode` option in `services.garage.settings`

     

       91
       91
       +
                 has been removed and is now handled by the freeform settings in order

     

       92
       92
       +
                 to allow it being completely absent (for Garage 1.x).

     

       93
       93
       +
                 That module option previously `toString`'ed the value it's configured

     

       94
       94
       +
                 with, which is now no longer possible.

     

       95
       95
       +
       

     

       96
       96
       +
                 You're still using a non-string here, please manually set it to

     

       97
       97
       +
                 a string, or migrate to the separate setting keys introduced in 1.x.

     

       98
       98
       +
       

     

       99
       99
       +
                 Refer to https://garagehq.deuxfleurs.fr/documentation/working-documents/migration-1/

     

       100
       100
       +
                 for the migration guide.

     

       81
       101
        
               '';

     

       82
       102
        
             }

     

       83
       103
        
           ];