···
1
+
From c48f5d57b6e57f42b668c0c6b8744e4620c77320 Mon Sep 17 00:00:00 2001
2
+
From: Mikael Voss <mvs@nyantec.com>
3
+
Date: Tue, 19 Nov 2024 20:47:27 +0100
4
+
Subject: [PATCH] Use magick command from ImageMagick
6
+
With ImageMagick version 7 the convert command has been deprecated in
7
+
favour of magick. Calling convert instead results in the logs being
8
+
spammed with warning messages.
10
+
The mogrify Elixir wrapper also runs magick with the mogrify argument
11
+
in current releases.
13
+
lib/pleroma/application_requirements.ex | 8 ++++----
14
+
lib/pleroma/helpers/media_helper.ex | 4 ++--
15
+
2 files changed, 6 insertions(+), 6 deletions(-)
17
+
diff --git a/lib/pleroma/application_requirements.ex b/lib/pleroma/application_requirements.ex
18
+
index c3777d8f1..55ee674a2 100644
19
+
--- a/lib/pleroma/application_requirements.ex
20
+
+++ b/lib/pleroma/application_requirements.ex
21
+
@@ -166,10 +166,10 @@ defp check_system_commands!(:ok) do
22
+
filter_commands_statuses = [
23
+
check_filter(Pleroma.Upload.Filter.Exiftool.StripMetadata, "exiftool"),
24
+
check_filter(Pleroma.Upload.Filter.Exiftool.ReadDescription, "exiftool"),
25
+
- check_filter(Pleroma.Upload.Filter.Mogrify, "mogrify"),
26
+
- check_filter(Pleroma.Upload.Filter.Mogrifun, "mogrify"),
27
+
- check_filter(Pleroma.Upload.Filter.AnalyzeMetadata, "mogrify"),
28
+
- check_filter(Pleroma.Upload.Filter.AnalyzeMetadata, "convert"),
29
+
+ check_filter(Pleroma.Upload.Filter.Mogrify, "magick"),
30
+
+ check_filter(Pleroma.Upload.Filter.Mogrifun, "magick"),
31
+
+ check_filter(Pleroma.Upload.Filter.AnalyzeMetadata, "magick"),
32
+
+ check_filter(Pleroma.Upload.Filter.AnalyzeMetadata, "magick"),
33
+
check_filter(Pleroma.Upload.Filter.AnalyzeMetadata, "ffprobe")
36
+
diff --git a/lib/pleroma/helpers/media_helper.ex b/lib/pleroma/helpers/media_helper.ex
37
+
index cb95d0e68..17cd9629d 100644
38
+
--- a/lib/pleroma/helpers/media_helper.ex
39
+
+++ b/lib/pleroma/helpers/media_helper.ex
40
+
@@ -12,7 +12,7 @@ defmodule Pleroma.Helpers.MediaHelper do
43
+
def missing_dependencies do
44
+
- Enum.reduce([imagemagick: "convert", ffmpeg: "ffmpeg"], [], fn {sym, executable}, acc ->
45
+
+ Enum.reduce([imagemagick: "magick", ffmpeg: "ffmpeg"], [], fn {sym, executable}, acc ->
46
+
if Pleroma.Utils.command_available?(executable) do
49
+
@@ -22,7 +22,7 @@ def missing_dependencies do
52
+
def image_resize(url, options) do
53
+
- with executable when is_binary(executable) <- System.find_executable("convert"),
54
+
+ with executable when is_binary(executable) <- System.find_executable("magick"),
55
+
{:ok, args} <- prepare_image_resize_args(options),
56
+
{:ok, env} <- HTTP.get(url, [], []),
57
+
{:ok, fifo_path} <- mkfifo() do