pyrox.dev / nixpkgs
lol
fork atom

nixos/cron: Fix ShellCheck issue in preStart script

Fixes the following warning when setting
`systemd.enableStrictShellChecks = true`:

> SC2174 (warning): When used with -p, -m only applies to the deepest
> directory.

Since it could conceivably be possible for `/var` to not exist when
running this script, the fix also explicitly tries to create /var with
the normal 0755 permissions.

Victor Engmark 361c7f79 a1945f76

options
unified split
Changed files
+2 -1
nixos
modules
services
scheduling
cron.nix
+2 -1
nixos/modules/services/scheduling/cron.nix 
···

       
125

       
125

       
 

       
        wantedBy = [ "multi-user.target" ];


     

       
126

       
126

       
 

       



     

       
127

       
127

       
 

       
        preStart = ''


     

       
128

       

       
-

       
          mkdir -m 710 -p /var/cron


     

       

       
128

       
+

       
          (umask 022 && mkdir -p /var)


     

       

       
129

       
+

       
          (umask 067 && mkdir -p /var/cron)


     

       
129

       
130

       
 

       



     

       
130

       
131

       
 

       
          # By default, allow all users to create a crontab.  This


     

       
131

       
132

       
 

       
          # is denoted by the existence of an empty cron.deny file.