cppcheck: use recommended build options

From the readme:

> The recommended release build is:
> make MATCHCOMPILER=yes FILESDIR=/usr/share/cppcheck HAVE_RULES=yes
>
> Flags:
> MATCHCOMPILER=yes : Python is used to optimise cppcheck at compile time
> FILESDIR=/usr/share/cppcheck : Specify folder where cppcheck files are installed
> HAVE_RULES=yes : Enable rules (pcre is required if this is used)

This adds MATCHCOMPILER and fixes the location of FILESDIR into a
standard directory instead of that ugly '$out/cfg' directory.

The Makefile needs 'which' to locate Python.

Changed files
+14 -3
pkgs
development
tools
analysis
cppcheck
+14 -3
pkgs/development/tools/analysis/cppcheck/default.nix
···
-
{ lib, stdenv, fetchFromGitHub, libxslt, docbook_xsl, docbook_xml_dtd_45, pcre, withZ3 ? true, z3, python3 }:
stdenv.mkDerivation rec {
pname = "cppcheck";
···
buildInputs = [ pcre
(python3.withPackages (ps: [ps.pygments]))
] ++ lib.optionals withZ3 [ z3 ];
-
nativeBuildInputs = [ libxslt docbook_xsl docbook_xml_dtd_45 ];
-
makeFlags = [ "PREFIX=$(out)" "FILESDIR=$(out)/cfg" "HAVE_RULES=yes" ]
++ lib.optionals withZ3 [ "USE_Z3=yes" "CPPFLAGS=-DNEW_Z3=1" ];
outputs = [ "out" "man" ];
···
+
{ lib
+
, stdenv
+
, fetchFromGitHub
+
, pcre
+
, python3
+
, libxslt
+
, docbook_xsl
+
, docbook_xml_dtd_45
+
, withZ3 ? true
+
, z3
+
, which
+
}:
stdenv.mkDerivation rec {
pname = "cppcheck";
···
buildInputs = [ pcre
(python3.withPackages (ps: [ps.pygments]))
] ++ lib.optionals withZ3 [ z3 ];
+
nativeBuildInputs = [ libxslt docbook_xsl docbook_xml_dtd_45 which ];
+
makeFlags = [ "PREFIX=$(out)" "MATCHCOMPILER=yes" "FILESDIR=$(out)/share/cppcheck" "HAVE_RULES=yes" ]
++ lib.optionals withZ3 [ "USE_Z3=yes" "CPPFLAGS=-DNEW_Z3=1" ];
outputs = [ "out" "man" ];