webkitgtk24x: fix libwebp missing library path, add libobjc as dependency on OSX (#17198)

Jun Hao 5bf4a9ff 39da5752

Changed files
+25 -16
pkgs
development
top-level
+4 -4
pkgs/development/libraries/webkitgtk/2.4.nix
···
, pkgconfig, which, gettext, gobjectIntrospection
, gtk2, gtk3, wayland, libwebp, enchant, sqlite
, libxml2, libsoup, libsecret, libxslt, harfbuzz, xorg
-
, gst-plugins-base
+
, gst-plugins-base, libobjc
, withGtk2 ? false
, enableIntrospection ? !stdenv.isDarwin
, enableCredentialStorage ? !stdenv.isDarwin
···
description = "Web content rendering engine, GTK+ port";
homepage = "http://webkitgtk.org/";
license = licenses.bsd2;
-
platforms = platforms.linux;
+
platforms = with platforms; linux ++ darwin;
maintainers = [];
};
···
patches = [
./webcore-svg-libxml-cflags.patch
] ++ optionals stdenv.isDarwin [
-
./impure-icucore.patch
+
./configure.patch
./quartz-webcore.patch
./libc++.patch
./plugin-none.patch
···
] ++ optionals enableCredentialStorage [
libsecret
] ++ (if stdenv.isDarwin then [
-
readline libedit
+
readline libedit libobjc
] else [
wayland
]);
+20
pkgs/development/libraries/webkitgtk/configure.patch
···
+
--- webkitgtk-2.4.11-orig/configure 2016-04-10 17:00:06.000000000 +0800
+
+++ webkitgtk-2.4.11/configure 2016-07-21 23:04:10.000000000 +0800
+
@@ -17738,7 +17738,7 @@
+
cat >>confdefs.h <<_ACEOF
+
#define HAVE_WEBP_DECODE_H 1
+
_ACEOF
+
- WEBP_LIBS='-lwebp'
+
+ WEBP_LIBS=`$PKG_CONFIG --libs libwebp`
+
else
+
as_fn_error $? "WebP library (libwebp) not found" "$LINENO" 5
+
fi
+
@@ -18388,7 +18388,7 @@
+
case "$host" in
+
*-*-darwin*)
+
UNICODE_CFLAGS="-I$srcdir/Source/JavaScriptCore/icu -I$srcdir/Source/WebCore/icu"
+
- UNICODE_LIBS="-licucore"
+
+ UNICODE_LIBS="/usr/lib/libicucore.dylib"
+
;;
+
*-*-mingw*)
+
-12
pkgs/development/libraries/webkitgtk/impure-icucore.patch
···
-
diff -ru webkitgtk-2.4.9-orig/configure webkitgtk-2.4.9/configure
-
--- webkitgtk-2.4.9-orig/configure 2016-02-02 13:23:22.000000000 -0500
-
+++ webkitgtk-2.4.9/configure 2016-02-02 13:24:13.000000000 -0500
-
@@ -17715,7 +17715,7 @@
-
case "$host" in
-
*-*-darwin*)
-
UNICODE_CFLAGS="-I$srcdir/Source/JavaScriptCore/icu -I$srcdir/Source/WebCore/icu"
-
- UNICODE_LIBS="-licucore"
-
+ UNICODE_LIBS="/usr/lib/libicucore.dylib"
-
;;
-
*-*-mingw*)
-
+1
pkgs/top-level/all-packages.nix
···
webkitgtk24x = callPackage ../development/libraries/webkitgtk/2.4.nix {
harfbuzz = harfbuzz-icu;
gst-plugins-base = gst_all_1.gst-plugins-base;
+
inherit (darwin) libobjc;
};
webkitgtk212x = callPackage ../development/libraries/webkitgtk/2.12.nix {