commit 62779fbfa4499ebe9545047980933022e8a11bb0 · pyrox.dev/nixpkgs

+1 -8

.github/workflows/eval.yml

···

       294
       294
        
                 # There appears to be no API to request reviews based on GitHub IDs

     

       295
       295
        
                 jq -r 'keys[]' comparison/maintainers.json \

     

       296
       296
        
                   | while read -r id; do gh api /user/"$id" --jq .login; done \

     

       297
       297
       -
                   | GH_TOKEN=${{ steps.app-token.outputs.token }} result/bin/process-reviewers.sh "$REPOSITORY" "$NUMBER" "$AUTHOR" \

     

       298
       298
       -
                   > reviewers.json

     

       299
       299
       -
       

     

       300
       300
       -
                 # Request reviewers from maintainers of changed output paths

     

       301
       301
       -
                 GH_TOKEN=${{ steps.app-token.outputs.token }} gh api \

     

       302
       302
       -
                   --method POST \

     

       303
       303
       -
                   /repos/"$REPOSITORY"/pulls/"$NUMBER"/requested_reviewers \

     

       304
       304
       -
                   --input reviewers.json

     

       297
       297
       +
                   | GH_TOKEN=${{ steps.app-token.outputs.token }} result/bin/request-reviewers.sh "$REPOSITORY" "$NUMBER" "$AUTHOR"

     

       305
       298
        
       

     

       306
       299
        
               env:

     

       307
       300
        
                 GH_TOKEN: ${{ github.token }}

+1 -1

ci/request-reviews/default.nix

···

       15
       15
        
           root = ./.;

     

       16
       16
        
           fileset = lib.fileset.unions [

     

       17
       17
        
             ./get-code-owners.sh

     

       18
       18
       -
             ./process-reviewers.sh

     

       18
       18
       +
             ./request-reviewers.sh

     

       19
       19
        
             ./request-code-owner-reviews.sh

     

       20
       20
        
             ./verify-base-branch.sh

     

       21
       21
        
             ./dev-branches.txt

-65

ci/request-reviews/process-reviewers.sh

···

       1
       1
       -
       #!/usr/bin/env bash

     

       2
       2
       -
       

     

       3
       3
       -
       # Process reviewers for a PR, reading line-separated usernames on stdin,

     

       4
       4
       -
       # returning a JSON suitable to be consumed by the API endpoint to request reviews:

     

       5
       5
       -
       # https://docs.github.com/en/rest/pulls/review-requests?apiVersion=2022-11-28#request-reviewers-for-a-pull-request

     

       6
       6
       -
       

     

       7
       7
       -
       set -euo pipefail

     

       8
       8
       -
       

     

       9
       9
       -
       log() {

     

       10
       10
       -
           echo "$@" >&2

     

       11
       11
       -
       }

     

       12
       12
       -
       

     

       13
       13
       -
       if (( "$#" < 3 )); then

     

       14
       14
       -
           log "Usage: $0 BASE_REPO PR_NUMBER PR_AUTHOR"

     

       15
       15
       -
           exit 1

     

       16
       16
       -
       fi

     

       17
       17
       -
       

     

       18
       18
       -
       baseRepo=$1

     

       19
       19
       -
       prNumber=$2

     

       20
       20
       -
       prAuthor=$3

     

       21
       21
       -
       

     

       22
       22
       -
       tmp=$(mktemp -d)

     

       23
       23
       -
       trap 'rm -rf "$tmp"' exit

     

       24
       24
       -
       

     

       25
       25
       -
       declare -A users=()

     

       26
       26
       -
       while read -r handle && [[ -n "$handle" ]]; do

     

       27
       27
       -
           users[${handle,,}]=

     

       28
       28
       -
       done

     

       29
       29
       -
       

     

       30
       30
       -
       # Cannot request a review from the author

     

       31
       31
       -
       if [[ -v users[${prAuthor,,}] ]]; then

     

       32
       32
       -
           log "One or more files are owned by the PR author, ignoring"

     

       33
       33
       -
           unset 'users[${prAuthor,,}]'

     

       34
       34
       -
       fi

     

       35
       35
       -
       

     

       36
       36
       -
       gh api \

     

       37
       37
       -
           -H "Accept: application/vnd.github+json" \

     

       38
       38
       -
           -H "X-GitHub-Api-Version: 2022-11-28" \

     

       39
       39
       -
           "/repos/$baseRepo/pulls/$prNumber/reviews" \

     

       40
       40
       -
           --jq '.[].user.login' > "$tmp/already-reviewed-by"

     

       41
       41
       -
       

     

       42
       42
       -
       # And we don't want to rerequest reviews from people who already reviewed

     

       43
       43
       -
       while read -r user; do

     

       44
       44
       -
           if [[ -v users[${user,,}] ]]; then

     

       45
       45
       -
               log "User $user is a potential reviewer, but has already left a review, ignoring"

     

       46
       46
       -
               unset 'users[${user,,}]'

     

       47
       47
       -
           fi

     

       48
       48
       -
       done < "$tmp/already-reviewed-by"

     

       49
       49
       -
       

     

       50
       50
       -
       for user in "${!users[@]}"; do

     

       51
       51
       -
           if ! gh api \

     

       52
       52
       -
               -H "Accept: application/vnd.github+json" \

     

       53
       53
       -
               -H "X-GitHub-Api-Version: 2022-11-28" \

     

       54
       54
       -
               "/repos/$baseRepo/collaborators/$user" >&2; then

     

       55
       55
       -
               log "User $user is not a repository collaborator, probably missed the automated invite to the maintainers team (see <https://github.com/NixOS/nixpkgs/issues/234293>), ignoring"

     

       56
       56
       -
               unset 'users[$user]'

     

       57
       57
       -
           fi

     

       58
       58
       -
       done

     

       59
       59
       -
       

     

       60
       60
       -
       # Turn it into a JSON for the GitHub API call to request PR reviewers

     

       61
       61
       -
       jq -n \

     

       62
       62
       -
           --arg users "${!users[*]}" \

     

       63
       63
       -
           '{

     

       64
       64
       -
             reviewers: $users | split(" "),

     

       65
       65
       -
           }'

+2 -16

ci/request-reviews/request-code-owner-reviews.sh

···

       77
       77
        
           exit 1

     

       78
       78
        
       fi

     

       79
       79
        
       

     

       80
       80
       -
       log "Getting code owners to request reviews from"

     

       80
       80
       +
       log "Requesting reviews from code owners"

     

       81
       81
        
       "$SCRIPT_DIR"/get-code-owners.sh "$tmp/nixpkgs.git" "$ownersFile" "$baseBranch" "$headRef" | \

     

       82
       82
       -
           "$SCRIPT_DIR"/process-reviewers.sh "$baseRepo" "$prNumber" "$prAuthor" > "$tmp/reviewers.json"

     

       83
       83
       -
       

     

       84
       84
       -
       log "Requesting reviews from: $(<"$tmp/reviewers.json")"

     

       85
       85
       -
       

     

       86
       86
       -
       if ! response=$(effect gh api \

     

       87
       87
       -
           --method POST \

     

       88
       88
       -
           -H "Accept: application/vnd.github+json" \

     

       89
       89
       -
           -H "X-GitHub-Api-Version: 2022-11-28" \

     

       90
       90
       -
           "/repos/$baseRepo/pulls/$prNumber/requested_reviewers" \

     

       91
       91
       -
           --input "$tmp/reviewers.json"); then

     

       92
       92
       -
           log "Failed to request reviews: $response"

     

       93
       93
       -
           exit 1

     

       94
       94
       -
       fi

     

       95
       95
       -
       

     

       96
       96
       -
       log "Successfully requested reviews"

     

       82
       82
       +
           "$SCRIPT_DIR"/request-reviewers.sh "$baseRepo" "$prNumber" "$prAuthor"

+90

ci/request-reviews/request-reviewers.sh

···

       1
       1
       +
       #!/usr/bin/env bash

     

       2
       2
       +
       

     

       3
       3
       +
       # Request reviewers for a PR, reading line-separated usernames on stdin,

     

       4
       4
       +
       # filtering for valid reviewers before using the API endpoint to request reviews:

     

       5
       5
       +
       # https://docs.github.com/en/rest/pulls/review-requests?apiVersion=2022-11-28#request-reviewers-for-a-pull-request

     

       6
       6
       +
       

     

       7
       7
       +
       set -euo pipefail

     

       8
       8
       +
       

     

       9
       9
       +
       tmp=$(mktemp -d)

     

       10
       10
       +
       trap 'rm -rf "$tmp"' exit

     

       11
       11
       +
       

     

       12
       12
       +
       log() {

     

       13
       13
       +
           echo "$@" >&2

     

       14
       14
       +
       }

     

       15
       15
       +
       

     

       16
       16
       +
       effect() {

     

       17
       17
       +
           if [[ -n "${DRY_MODE:-}" ]]; then

     

       18
       18
       +
               log "Skipping in dry mode:" "${@@Q}"

     

       19
       19
       +
           else

     

       20
       20
       +
               "$@"

     

       21
       21
       +
           fi

     

       22
       22
       +
       }

     

       23
       23
       +
       

     

       24
       24
       +
       if (( "$#" < 3 )); then

     

       25
       25
       +
           log "Usage: $0 BASE_REPO PR_NUMBER PR_AUTHOR"

     

       26
       26
       +
           exit 1

     

       27
       27
       +
       fi

     

       28
       28
       +
       

     

       29
       29
       +
       baseRepo=$1

     

       30
       30
       +
       prNumber=$2

     

       31
       31
       +
       prAuthor=$3

     

       32
       32
       +
       

     

       33
       33
       +
       tmp=$(mktemp -d)

     

       34
       34
       +
       trap 'rm -rf "$tmp"' exit

     

       35
       35
       +
       

     

       36
       36
       +
       declare -A users=()

     

       37
       37
       +
       while read -r handle && [[ -n "$handle" ]]; do

     

       38
       38
       +
           users[${handle,,}]=

     

       39
       39
       +
       done

     

       40
       40
       +
       

     

       41
       41
       +
       # Cannot request a review from the author

     

       42
       42
       +
       if [[ -v users[${prAuthor,,}] ]]; then

     

       43
       43
       +
           log "One or more files are owned by the PR author, ignoring"

     

       44
       44
       +
           unset 'users[${prAuthor,,}]'

     

       45
       45
       +
       fi

     

       46
       46
       +
       

     

       47
       47
       +
       gh api \

     

       48
       48
       +
           -H "Accept: application/vnd.github+json" \

     

       49
       49
       +
           -H "X-GitHub-Api-Version: 2022-11-28" \

     

       50
       50
       +
           "/repos/$baseRepo/pulls/$prNumber/reviews" \

     

       51
       51
       +
           --jq '.[].user.login' > "$tmp/already-reviewed-by"

     

       52
       52
       +
       

     

       53
       53
       +
       # And we don't want to rerequest reviews from people who already reviewed

     

       54
       54
       +
       while read -r user; do

     

       55
       55
       +
           if [[ -v users[${user,,}] ]]; then

     

       56
       56
       +
               log "User $user is a potential reviewer, but has already left a review, ignoring"

     

       57
       57
       +
               unset 'users[${user,,}]'

     

       58
       58
       +
           fi

     

       59
       59
       +
       done < "$tmp/already-reviewed-by"

     

       60
       60
       +
       

     

       61
       61
       +
       for user in "${!users[@]}"; do

     

       62
       62
       +
           if ! gh api \

     

       63
       63
       +
               -H "Accept: application/vnd.github+json" \

     

       64
       64
       +
               -H "X-GitHub-Api-Version: 2022-11-28" \

     

       65
       65
       +
               "/repos/$baseRepo/collaborators/$user" >&2; then

     

       66
       66
       +
               log "User $user is not a repository collaborator, probably missed the automated invite to the maintainers team (see <https://github.com/NixOS/nixpkgs/issues/234293>), ignoring"

     

       67
       67
       +
               unset 'users[$user]'

     

       68
       68
       +
           fi

     

       69
       69
       +
       done

     

       70
       70
       +
       

     

       71
       71
       +
       # Turn it into a JSON for the GitHub API call to request PR reviewers

     

       72
       72
       +
       jq -n \

     

       73
       73
       +
           --arg users "${!users[*]}" \

     

       74
       74
       +
           '{

     

       75
       75
       +
             reviewers: $users | split(" "),

     

       76
       76
       +
           }' > "$tmp/reviewers.json"

     

       77
       77
       +
       

     

       78
       78
       +
       log "Requesting reviews from: $(<"$reviewersFile")"

     

       79
       79
       +
       

     

       80
       80
       +
       if ! response=$(effect gh api \

     

       81
       81
       +
           --method POST \

     

       82
       82
       +
           -H "Accept: application/vnd.github+json" \

     

       83
       83
       +
           -H "X-GitHub-Api-Version: 2022-11-28" \

     

       84
       84
       +
           "/repos/$baseRepo/pulls/$prNumber/requested_reviewers" \

     

       85
       85
       +
           --input "$tmp/reviewers.json"); then

     

       86
       86
       +
           log "Failed to request reviews: $response"

     

       87
       87
       +
           exit 1

     

       88
       88
       +
       fi

     

       89
       89
       +
       

     

       90
       90
       +
       log "Successfully requested reviews"