commit 6f6b4a1d4175d3f6fb72dbaceea8d6e4e79c5d6e · pyrox.dev/nixpkgs

pyrox.dev / nixpkgs

lol

systemd: default withLibBPF to false if isMips64

libBPF does not compile for mips64 targets using clang (rathern than
gcc) because clang lacks the necessary _MIPS_SZPTR compiler builtin.
Let's allow the rest of systemd to compile.

- The glibc people noticed this problem [way back in
2011](https://sourceware.org/pipermail/libc-ports/2011-June/001959.html)
and consider it to be a clang/llvm bug. I am inclined to agree.

- [clang has the `_MIPS_SZPTR`
builtin](https://github.com/llvm/clangir/blob/3af9cb5375084541165b4b63d36e3798801c95ab/clang/lib/Basic/Targets/Mips.cpp#L185)
and seems to have had it since before they switched to git.

This may in fact be a nixpkgs bug -- that we're not invoking clang
in a way that tells the frontend to make the mips builtins
available, even if the backend is emitting mips binaries. Or at
least we aren't tricking systemd's build machinery into doing that.

Adam Joseph 3 years ago 6f6b4a1d 956e4aa2

options

unified split

Changed files

pkgs

os-specific

linux

systemd

default.nix

pkgs/os-specific/linux/systemd/default.nix

···

       94
       94
        
       , withHwdb ? true

     

       95
       95
        
       , withImportd ? !stdenv.hostPlatform.isMusl

     

       96
       96
        
       , withLibBPF ? lib.versionAtLeast buildPackages.llvmPackages.clang.version "10.0"

     

       97
       97
       +
           && !stdenv.hostPlatform.isMips64   # see https://github.com/NixOS/nixpkgs/pull/194149#issuecomment-1266642211

     

       97
       98
        
       , withLocaled ? true

     

       98
       99
        
       , withLogind ? true

     

       99
       100
        
       , withMachined ? true