kanidm: use `finalAttrs` everywhere, nixos/tests/kanidm: restore eval when calling `nixosTests.kanidm` directly (#431869)

Changed files
+44 -54
nixos
pkgs
by-name
ka
kanidm
top-level
+2 -12
nixos/tests/all-tests.nix
···
k3s = handleTest ./k3s { };
kafka = handleTest ./kafka { };
kanboard = runTest ./web-apps/kanboard.nix;
-
kanidm =
-
kanidmVersion:
-
runTest {
-
imports = [ ./kanidm.nix ];
-
_module.args = { inherit kanidmVersion; };
-
};
-
kanidm-provisioning =
-
kanidmVersion:
-
runTest {
-
imports = [ ./kanidm-provisioning.nix ];
-
_module.args = { inherit kanidmVersion; };
-
};
+
kanidm = runTest ./kanidm.nix;
+
kanidm-provisioning = runTest ./kanidm-provisioning.nix;
karma = runTest ./karma.nix;
kavita = runTest ./kavita.nix;
kbd-setfont-decompress = runTest ./kbd-setfont-decompress.nix;
+4 -4
nixos/tests/kanidm-provisioning.nix
···
-
{ kanidmVersion, pkgs, ... }:
+
{ kanidmPackage, pkgs, ... }:
let
certs = import ./common/acme/server/snakeoil-certs.nix;
serverDomain = certs.domain;
···
provisionAdminPassword = "very-strong-password-for-admin";
provisionIdmAdminPassword = "very-strong-password-for-idm-admin";
provisionIdmAdminPassword2 = "very-strong-alternative-password-for-idm-admin";
-
-
kanidmPackage = pkgs."kanidmWithSecretProvisioning_${kanidmVersion}";
in
{
-
name = "kanidm-provisioning";
+
name = "kanidm-provisioning-${kanidmPackage.version}";
meta.maintainers = with pkgs.lib.maintainers; [ oddlama ];
+
+
_module.args.kanidmPackage = pkgs.lib.mkDefault pkgs.kanidmWithSecretProvisioning;
nodes.provision =
{ pkgs, lib, ... }:
+4 -4
nixos/tests/kanidm.nix
···
-
{ kanidmVersion, pkgs, ... }:
+
{ kanidmPackage, pkgs, ... }:
let
certs = import ./common/acme/server/snakeoil-certs.nix;
serverDomain = certs.domain;
···
cp ${certs."${serverDomain}".cert} $out/snakeoil.crt
cp ${certs."${serverDomain}".key} $out/snakeoil.key
'';
-
-
kanidmPackage = pkgs."kanidm_${kanidmVersion}";
in
{
-
name = "kanidm";
+
name = "kanidm-${kanidmPackage.version}";
meta.maintainers = with pkgs.lib.maintainers; [
Flakebi
oddlama
];
+
+
_module.args.kanidmPackage = pkgs.lib.mkDefault pkgs.kanidm;
nodes.server =
{ pkgs, ... }:
+23 -20
pkgs/by-name/ka/kanidm/generic.nix
···
pam,
bashInteractive,
rust-jemalloc-sys,
-
kanidm,
+
kanidmWithSecretProvisioning,
# If this is enabled, kanidm will be built with two patches allowing both
# oauth2 basic secrets and admin credentials to be provisioned.
# This is NOT officially supported (and will likely never be),
···
let
arch = if stdenv.hostPlatform.isx86_64 then "x86_64" else "generic";
-
versionUnderscored = builtins.replaceStrings [ "." ] [ "_" ] (
-
lib.versions.majorMinor kanidm.version
-
);
-
-
provisionPatches = [
-
(./. + "/provision-patches/${versionUnderscored}/oauth2-basic-secret-modify.patch")
-
(./. + "/provision-patches/${versionUnderscored}/recover-account.patch")
-
];
+
versionUnderscored =
+
finalAttrs: lib.replaceStrings [ "." ] [ "_" ] (lib.versions.majorMinor finalAttrs.version);
upgradeNote = ''
Please upgrade by verifying `kanidmd domain upgrade-check` and choosing the
···
src = fetchFromGitHub {
owner = "kanidm";
repo = "kanidm";
-
rev = "refs/tags/v${version}";
+
tag = "v${finalAttrs.version}";
inherit hash;
};
env.KANIDM_BUILD_PROFILE = "release_nixpkgs_${arch}";
-
patches = lib.optionals enableSecretProvisioning provisionPatches;
+
patches = lib.optionals enableSecretProvisioning [
+
(./. + "/provision-patches/${versionUnderscored finalAttrs}/oauth2-basic-secret-modify.patch")
+
(./. + "/provision-patches/${versionUnderscored finalAttrs}/recover-account.patch")
+
];
postPatch =
let
···
profile = {
cpu_flags = if stdenv.hostPlatform.isx86_64 then "x86_64_legacy" else "none";
}
-
// lib.optionalAttrs (lib.versionAtLeast version "1.5") {
+
// lib.optionalAttrs (lib.versionAtLeast finalAttrs.version "1.5") {
client_config_path = "/etc/kanidm/config";
resolver_config_path = "/etc/kanidm/unixd";
resolver_unix_shell_path = "${lib.getBin bashInteractive}/bin/bash";
···
passthru = {
tests = {
-
kanidm = nixosTests.kanidm versionUnderscored;
-
kanidm-provisioning = nixosTests.kanidm-provisioning versionUnderscored;
+
kanidm = nixosTests.kanidm.extend {
+
modules = [ { _module.args.kanidmPackage = finalAttrs.finalPackage; } ];
+
};
+
kanidm-provisioning = nixosTests.kanidm-provisioning.extend {
+
modules = [ { _module.args.kanidmPackage = finalAttrs.finalPackage.withSecretProvisioning; } ];
+
};
};
updateScript = lib.optionals (!enableSecretProvisioning) (nix-update-script {
extraArgs = [
"-vr"
-
"v(${lib.versions.major kanidm.version}\\.${lib.versions.minor kanidm.version}\\.[0-9]*)"
+
"v(${lib.versions.major finalAttrs.version}\\.${lib.versions.minor finalAttrs.version}\\.[0-9]*)"
"--override-filename"
-
"pkgs/by-name/ka/kanidm/${versionUnderscored}.nix"
+
"pkgs/by-name/ka/kanidm/${versionUnderscored finalAttrs}.nix"
];
});
inherit enableSecretProvisioning;
-
withSecretProvisioning = kanidm.override { enableSecretProvisioning = true; };
+
# Unfortunately there is no such thing as finalAttrs.finalPackage.override,
+
# so we have to resort to this.
+
withSecretProvisioning = kanidmWithSecretProvisioning;
eolMessage = lib.optionalString (eolDate != null) ''
-
kanidm ${lib.versions.majorMinor version} is deprecated and will reach end-of-life on ${eolDate}
+
kanidm ${lib.versions.majorMinor finalAttrs.version} is deprecated and will reach end-of-life on ${eolDate}
${upgradeNote}
'';
···
requiredSystemFeatures = [ "big-parallel" ];
meta = {
-
changelog = "https://github.com/kanidm/kanidm/releases/tag/v${version}";
+
changelog = "https://github.com/kanidm/kanidm/releases/tag/v${finalAttrs.version}";
description = "Simple, secure and fast identity management platform";
homepage = "https://github.com/kanidm/kanidm";
license = lib.licenses.mpl20;
···
];
knownVulnerabilities = lib.optionals unsupported [
''
-
kanidm ${lib.versions.majorMinor version} has reached end-of-life.
+
kanidm ${lib.versions.majorMinor finalAttrs.version} has reached end-of-life.
${upgradeNote}
''
+11 -14
pkgs/top-level/all-packages.nix
···
jetty = jetty_12;
-
kanidm_1_5 = callPackage ../by-name/ka/kanidm/1_5.nix { kanidm = kanidm_1_5; };
-
kanidm_1_6 = callPackage ../by-name/ka/kanidm/1_6.nix { kanidm = kanidm_1_6; };
-
kanidm_1_7 = callPackage ../by-name/ka/kanidm/1_7.nix { kanidm = kanidm_1_7; };
-
-
kanidmWithSecretProvisioning = kanidmWithSecretProvisioning_1_6;
-
-
kanidmWithSecretProvisioning_1_5 = callPackage ../by-name/ka/kanidm/1_5.nix {
-
enableSecretProvisioning = true;
+
kanidm_1_5 = callPackage ../by-name/ka/kanidm/1_5.nix {
+
kanidmWithSecretProvisioning = kanidmWithSecretProvisioning_1_5;
+
};
+
kanidm_1_6 = callPackage ../by-name/ka/kanidm/1_6.nix {
+
kanidmWithSecretProvisioning = kanidmWithSecretProvisioning_1_6;
-
-
kanidmWithSecretProvisioning_1_6 = callPackage ../by-name/ka/kanidm/1_6.nix {
-
enableSecretProvisioning = true;
+
kanidm_1_7 = callPackage ../by-name/ka/kanidm/1_7.nix {
+
kanidmWithSecretProvisioning = kanidmWithSecretProvisioning_1_7;
-
kanidmWithSecretProvisioning_1_7 = callPackage ../by-name/ka/kanidm/1_7.nix {
-
enableSecretProvisioning = true;
-
};
+
kanidmWithSecretProvisioning = kanidm.override { enableSecretProvisioning = true; };
+
kanidmWithSecretProvisioning_1_5 = kanidm_1_5.override { enableSecretProvisioning = true; };
+
kanidmWithSecretProvisioning_1_6 = kanidm_1_6.override { enableSecretProvisioning = true; };
+
kanidmWithSecretProvisioning_1_7 = kanidm_1_7.override { enableSecretProvisioning = true; };
knot-resolver = callPackage ../servers/dns/knot-resolver {
systemd = systemdMinimal; # in closure already anyway