Revert "nixos: add option for bind to not resolve local queries (#29503)"

This reverts commit 670b4e29adc16e0a29aa5b4c126703dcca56aeb6. The change
added in this commit was controversial when it was originally suggested
in https://github.com/NixOS/nixpkgs/pull/29205. Then that PR was closed
and a new one opened, https://github.com/NixOS/nixpkgs/pull/29503,
effectively circumventing the review process. I don't agree with this
modification. Adding an option 'resolveLocalQueries' to tell the locally
running name server that it should resolve local DNS queries feels
outright nuts. I agree that the current state is unsatisfactory and that
it should be improved, but this is not the right way.

(cherry picked from commit 23a021d12e8f939cd0bfddb1c7adeb125028c1e3)

Changed files
+3 -14
nixos
modules
+1 -3
nixos/modules/config/networking.nix
···
cfg = config.networking;
dnsmasqResolve = config.services.dnsmasq.enable &&
config.services.dnsmasq.resolveLocalQueries;
-
bindResolve = config.services.bind.enable &&
-
config.services.bind.resolveLocalQueries;
-
hasLocalResolver = bindResolve || dnsmasqResolve;
+
hasLocalResolver = config.services.bind.enable || dnsmasqResolve;
resolvconfOptions = cfg.resolvconfOptions
++ optional cfg.dnsSingleRequest "single-request"
-9
nixos/modules/services/networking/bind.nix
···
";
};
-
resolveLocalQueries = mkOption {
-
type = types.bool;
-
default = true;
-
description = ''
-
Whether bind should resolve local queries (i.e. add 127.0.0.1 to
-
/etc/resolv.conf, overriding networking.nameserver).
-
'';
-
};
-
};
};
+1 -1
nixos/modules/services/networking/dnsmasq.nix
···
default = true;
description = ''
Whether dnsmasq should resolve local queries (i.e. add 127.0.0.1 to
-
/etc/resolv.conf overriding networking.nameservers).
+
/etc/resolv.conf).
'';
};
+1 -1
nixos/modules/tasks/network-interfaces-scripted.nix
···
''
# Set the static DNS configuration, if given.
${pkgs.openresolv}/sbin/resolvconf -m 1 -a static <<EOF
-
${optionalString (cfg.domain != null) ''
+
${optionalString (cfg.nameservers != [] && cfg.domain != null) ''
domain ${cfg.domain}
''}
${optionalString (cfg.search != []) ("search " + concatStringsSep " " cfg.search)}