Merge pull request #29002 from NeQuissimus/docker_edge_module_test

docker: Package in module, tests

Changed files
+68 -5
nixos
+13 -4
nixos/modules/virtualisation/docker.nix
···
'';
};
};
+
+
package = mkOption {
+
default = pkgs.docker;
+
type = types.package;
+
example = pkgs.docker-edge;
+
description = ''
+
Docker package to be used in the module.
+
'';
+
};
};
###### implementation
config = mkIf cfg.enable (mkMerge [{
-
environment.systemPackages = [ pkgs.docker ];
+
environment.systemPackages = [ cfg.package ];
users.extraGroups.docker.gid = config.ids.gids.docker;
-
systemd.packages = [ pkgs.docker ];
+
systemd.packages = [ cfg.package ];
systemd.services.docker = {
wantedBy = optional cfg.enableOnBoot "multi-user.target";
···
ExecStart = [
""
''
-
${pkgs.docker}/bin/dockerd \
+
${cfg.package}/bin/dockerd \
--group=docker \
--host=fd:// \
--log-driver=${cfg.logDriver} \
···
serviceConfig.Type = "oneshot";
script = ''
-
${pkgs.docker}/bin/docker system prune -f ${toString cfg.autoPrune.flags}
+
${cfg.package}/bin/docker system prune -f ${toString cfg.autoPrune.flags}
'';
startAt = optional cfg.autoPrune.enable cfg.autoPrune.dates;
+2
nixos/release-combined.nix
···
(all nixos.tests.boot.uefiUsb)
(all nixos.tests.boot-stage1)
nixos.tests.hibernate.x86_64-linux # i686 is flaky, see #23107
+
nixos.tests.docker.x86_64-linux
+
nixos.tests.docker-edge.x86_64-linux
(all nixos.tests.ecryptfs)
(all nixos.tests.ipv6)
(all nixos.tests.i3wm)
+1
nixos/release.nix
···
tests.containers-hosts = callTest tests/containers-hosts.nix {};
tests.containers-macvlans = callTest tests/containers-macvlans.nix {};
tests.docker = hydraJob (import tests/docker.nix { system = "x86_64-linux"; });
+
tests.docker-edge = hydraJob (import tests/docker-edge.nix { system = "x86_64-linux"; });
tests.dnscrypt-proxy = callTest tests/dnscrypt-proxy.nix { system = "x86_64-linux"; };
tests.ecryptfs = callTest tests/ecryptfs.nix {};
tests.etcd = hydraJob (import tests/etcd.nix { system = "x86_64-linux"; });
+47
nixos/tests/docker-edge.nix
···
+
# This test runs docker and checks if simple container starts
+
+
import ./make-test.nix ({ pkgs, ...} : {
+
name = "docker";
+
meta = with pkgs.stdenv.lib.maintainers; {
+
maintainers = [ nequissimus offline ];
+
};
+
+
nodes = {
+
docker =
+
{ config, pkgs, ... }:
+
{
+
virtualisation.docker.enable = true;
+
virtualisation.docker.package = pkgs.docker-edge;
+
+
users.users = {
+
noprivs = {
+
isNormalUser = true;
+
description = "Can't access the docker daemon";
+
password = "foobar";
+
};
+
+
hasprivs = {
+
isNormalUser = true;
+
description = "Can access the docker daemon";
+
password = "foobar";
+
extraGroups = [ "docker" ];
+
};
+
};
+
};
+
};
+
+
testScript = ''
+
startAll;
+
+
$docker->waitForUnit("sockets.target");
+
$docker->succeed("tar cv --files-from /dev/null | docker import - scratchimg");
+
$docker->succeed("docker run -d --name=sleeping -v /nix/store:/nix/store -v /run/current-system/sw/bin:/bin scratchimg /bin/sleep 10");
+
$docker->succeed("docker ps | grep sleeping");
+
$docker->succeed("sudo -u hasprivs docker ps");
+
$docker->fail("sudo -u noprivs docker ps");
+
$docker->succeed("docker stop sleeping");
+
+
# Must match version twice to ensure client and server versions are correct
+
$docker->succeed('[ $(docker version | grep ${pkgs.docker-edge.version} | wc -l) = "2" ]');
+
'';
+
})
+5 -1
nixos/tests/docker.nix
···
import ./make-test.nix ({ pkgs, ...} : {
name = "docker";
meta = with pkgs.stdenv.lib.maintainers; {
-
maintainers = [ offline ];
+
maintainers = [ nequissimus offline ];
};
nodes = {
···
{ config, pkgs, ... }:
{
virtualisation.docker.enable = true;
+
virtualisation.docker.package = pkgs.docker;
users.users = {
noprivs = {
···
$docker->succeed("sudo -u hasprivs docker ps");
$docker->fail("sudo -u noprivs docker ps");
$docker->succeed("docker stop sleeping");
+
+
# Must match version twice to ensure client and server versions are correct
+
$docker->succeed('[ $(docker version | grep ${pkgs.docker.version} | wc -l) = "2" ]');
'';
})