pyrox.dev / nixpkgs
lol
fork atom

nixos/testing/nodes: Do allow aliases

Aliases exist for a reason. Sure it is nice to make sure that
some aliases aren't used within Nixpkgs, but this creates two problems
which are far worse than your failing to meet your neatness compulsions.

- Users encounter missing attributes, https://github.com/NixOS/nixpkgs/issues/264577
wasting their time, stalling their progress, and even occupying others
time that would be better spent on fixing *real* issues.

- Hydra doesn't treat evaluation errors seriously enough, with the
effect that actual relevant test failures are masked by evaluation
failures such as those caused by this no aliases business.

- We don't even have the infrastructure to get rid of aliases, because
all warnings in package attributes are disallowed by Nixpkgs CI
tooling, last I checked.

Before re-disabling this, make sure that

- An actually helpful deprecation process is in place.

- Aliases are still allowed when `nixos-lib.runTests` and
`pkgs.testers.runNixOSTest` are invoked by external projects.
For instance, `all-tests.nix` could provide such an
override (e.g. with `newScope`).

Robert Hensing ae5cb919 f9ef870c

options
unified split
Changed files
-3
nixos
lib
testing
nodes.nix
-3
nixos/lib/testing/nodes.nix 
···

       
32

       
32

       
 

       
            key = "nodes.nix-pkgs";


     

       
33

       
33

       
 

       
            config = optionalAttrs (!config.node.pkgsReadOnly) (


     

       
34

       
34

       
 

       
              mkIf (!options.nixpkgs.pkgs.isDefined) {


     

       
35

       

       
-

       
                # Ensure we do not use aliases. Ideally this is only set


     

       
36

       

       
-

       
                # when the test framework is used by Nixpkgs NixOS tests.


     

       
37

       

       
-

       
                nixpkgs.config.allowAliases = false;


     

       
38

       
35

       
 

       
                # TODO: switch to nixpkgs.hostPlatform and make sure containers-imperative test still evaluates.


     

       
39

       
36

       
 

       
                nixpkgs.system = hostPkgs.stdenv.hostPlatform.system;


     

       
40

       
37

       
 

       
              }