pyrox.dev / nixpkgs
lol
fork atom

vala: remove unconditional work around for clang 16 function pointer errors

Hook accumulates the flag over sereval executions as observed in:

- https://github.com/NixOS/nixpkgs/issues/301592
- https://github.com/NixOS/nixpkgs/pull/252484#issuecomment-2089095268

Since this has been committed, gcc started emitting a warning on
`-Wno-incompatible-function-poniter-types` being an unrecognized flag
and additionally upstream vala added its own meassure to reduce these
new pointer errors to warnings in its generated sources.

https://gitlab.gnome.org/GNOME/vala/-/commit/23ec71b1a5c4cead3d1bdac82e184d0a63fa7b79

Which is part of the current release
branch (https://gitlab.gnome.org/GNOME/vala/-/commits/0.56?ref_type=heads)
and released on 0.56.15

```
Vala 0.56.15
============
* Various improvements and bug fixes:
- codegen:
...
+ Emit diagnostic pragmas for GCC 14, Clang 16 compatibility [#1408]
```

https://gitlab.gnome.org/GNOME/vala/-/merge_requests/369

Fabián Heredia Montiel b2d88d41 7208220b

options
unified split
Changed files
-9
pkgs
development
compilers
vala
setup-hook.sh
-9
pkgs/development/compilers/vala/setup-hook.sh 
···

       
7

       
7

       
 

       



     

       
8

       
8

       
 

       
addEnvHooks "$targetOffset" make_vala_find_vapi_files


     

       
9

       
9

       
 

       



     

       
10

       

       
-

       
disable_incompabile_pointer_conversion_warning() {


     

       
11

       

       
-

       
    # Work around incompatible function pointer conversion errors with clang 16


     

       
12

       

       
-

       
    # by setting ``-Wno-incompatible-function-pointer-types` in an env hook.


     

       
13

       

       
-

       
    # See https://gitlab.gnome.org/GNOME/vala/-/issues/1413.


     

       
14

       

       
-

       
    NIX_CFLAGS_COMPILE+=" -Wno-incompatible-function-pointer-types"


     

       
15

       

       
-

       
}


     

       
16

       

       
-

       



     

       
17

       

       
-

       
addEnvHooks "$hostOffset" disable_incompabile_pointer_conversion_warning


     

       
18

       

       
-

       



     

       
19

       
10

       
 

       
_multioutMoveVapiDirs() {


     

       
20

       
11

       
 

       
  moveToOutput share/vala/vapi "${!outputDev}"


     

       
21

       
12

       
 

       
  moveToOutput share/vala-@apiVersion@/vapi "${!outputDev}"