···

       
23
       
 
       


     

       
24
       
 
       
For critical packages, this convention needs to be negotiated with the

     

       
25
       
 
       
maintainer. A critical package is one that causes mass-rebuild, or where an

     

       
26
       
-
       
author is listed in the [`CODEOWNERS`](../.github/CODEOWNERS) file.

     

       
27
       
 
       


     

       
28
       
 
       
In case of critical security updates, the [security team](https://nixos.org/community/teams/security) might override these

     

       
29
       
 
       
heuristics in order to get the fixes in as fast as possible.

     

···

       
23
       
 
       


     

       
24
       
 
       
For critical packages, this convention needs to be negotiated with the

     

       
25
       
 
       
maintainer. A critical package is one that causes mass-rebuild, or where an

     

       
26
       
+
       
author is listed in the [`OWNERS`](../ci/OWNERS) file.

     

       
27
       
 
       


     

       
28
       
 
       
In case of critical security updates, the [security team](https://nixos.org/community/teams/security) might override these

     

       
29
       
 
       
heuristics in order to get the fixes in as fast as possible.

     

···

       
40
       
 
       
Reviewing process:

     

       
41
       
 
       


     

       
42
       
 
       
- Ensure that the module maintainers are notified.

     

       
43
       
-
       
  - [CODEOWNERS](https://help.github.com/articles/about-codeowners/) will make GitHub notify users based on the submitted changes, but it can happen that it misses some of the package maintainers.

     

       
44
       
 
       
- Ensure that the module tests, if any, are succeeding.

     

       
45
       
 
       
  - You may invoke OfBorg with `@ofborg test <module>` to build `nixosTests.<module>`

     

       
46
       
 
       
- Ensure that the introduced options are correct.

     

···

       
40
       
 
       
Reviewing process:

     

       
41
       
 
       


     

       
42
       
 
       
- Ensure that the module maintainers are notified.

     

       
43
       
+
       
  - The continuous integration system will make GitHub notify users based on the submitted changes, but it can happen that it misses some of the package maintainers.

     

       
44
       
 
       
- Ensure that the module tests, if any, are succeeding.

     

       
45
       
 
       
  - You may invoke OfBorg with `@ofborg test <module>` to build `nixosTests.<module>`

     

       
46
       
 
       
- Ensure that the introduced options are correct.

     

···

       
914
       
 
       
- Ensure that the package versioning [fits the guidelines](#versioning).

     

       
915
       
 
       
- Ensure that the commit text [fits the guidelines](../CONTRIBUTING.md#commit-conventions).

     

       
916
       
 
       
- Ensure that the package maintainers are notified.

     

       
917
       
-
       
  - [CODEOWNERS](https://help.github.com/articles/about-codeowners) will make GitHub notify users based on the submitted changes, but it can happen that it misses some of the package maintainers.

     

       
918
       
 
       
- Ensure that the meta field information [fits the guidelines](#meta-attributes) and is correct:

     

       
919
       
 
       
  - License can change with version updates, so it should be checked to match the upstream license.

     

       
920
       
 
       
  - If the package has no maintainer, a maintainer must be set. This can be the update submitter or a community member that accepts to take maintainership of the package.

     

···

       
914
       
 
       
- Ensure that the package versioning [fits the guidelines](#versioning).

     

       
915
       
 
       
- Ensure that the commit text [fits the guidelines](../CONTRIBUTING.md#commit-conventions).

     

       
916
       
 
       
- Ensure that the package maintainers are notified.

     

       
917
       
+
       
  - The continuous integration system will make GitHub notify users based on the submitted changes, but it can happen that it misses some of the package maintainers.

     

       
918
       
 
       
- Ensure that the meta field information [fits the guidelines](#meta-attributes) and is correct:

     

       
919
       
 
       
  - License can change with version updates, so it should be checked to match the upstream license.

     

       
920
       
 
       
  - If the package has no maintainer, a maintainer must be set. This can be the update submitter or a community member that accepts to take maintainership of the package.

     

···

       
351
       
 
       
        and work the new member into the `haskell-updates` rotation.

     

       
352
       
 
       


     

       
353
       
 
       
    1.  Optionally, have the new member add themselves to the Haskell

     

       
354
       
-
       
        section in [`CODEOWNERS`](../../../.github/CODEOWNERS).  This

     

       
355
       
 
       
        will cause them to get pinged on most Haskell-related PRs.

     

···

       
351
       
 
       
        and work the new member into the `haskell-updates` rotation.

     

       
352
       
 
       


     

       
353
       
 
       
    1.  Optionally, have the new member add themselves to the Haskell

     

       
354
       
+
       
        section in [`OWNERS`](../../../ci/CODEOWNERS).  This

     

       
355
       
 
       
        will cause them to get pinged on most Haskell-related PRs.