···
# Processing, video codecs, containers
···
# for now we disable GTK GUI support on Darwin. (It may be possible to remove
# this restriction later.)
, useGtk ? !stdenv.isDarwin
73
+
, desktop-file-utils
···
95
-
sha256 = "sha256-0MJ1inMNA6s8l2S0wnpM2c7FxOoOHxs9u4E/rgKfjJo=";
99
+
hash = "sha256-4Q//UU/CPgWvhtpROfNPLzBvZlB02hbFe9Z9FA7mX04=";
# Handbrake maintains a set of ffmpeg patches. In particular, these
# patches are required for subtitle timing to work correctly. See:
# https://github.com/HandBrake/HandBrake/issues/4029
101
-
ffmpeg-version = "5.1.2";
102
-
ffmpeg-hb = ffmpeg_5-full.overrideAttrs (old: {
105
+
# base ffmpeg version is specified in:
106
+
# https://github.com/HandBrake/HandBrake/blob/master/contrib/ffmpeg/module.defs
107
+
ffmpeg-version = "6.1";
108
+
ffmpeg-hb = ffmpeg-full.overrideAttrs (old: {
version = ffmpeg-version;
url = "https://www.ffmpeg.org/releases/ffmpeg-${ffmpeg-version}.tar.bz2";
106
-
hash = "sha256-OaC8yNmFSfFsVwYkZ4JGpqxzbAZs69tAn5UC6RWyLys=";
112
+
hash = "sha256-632j3n3TzkiplGq0R6c0a9EaOoXm77jyws5jfn9UdhE=";
108
-
patches = old.patches or [ ] ++ [
109
-
"${src}/contrib/ffmpeg/A01-qsv-libavfilter-qsvvpp-change-the-output-frame-s-width-a.patch"
110
-
"${src}/contrib/ffmpeg/A02-qsv-configure-ensure-enable-libmfx-uses-libmfx-1.x.patch"
111
-
"${src}/contrib/ffmpeg/A03-qsv-configure-fix-the-check-for-MFX_CODEC_VP9.patch"
112
-
"${src}/contrib/ffmpeg/A04-qsv-remove-mfx-prefix-from-mfx-headers.patch"
113
-
"${src}/contrib/ffmpeg/A05-qsv-load-user-plugin-for-MFX_VERSION-2.0.patch"
114
-
"${src}/contrib/ffmpeg/A06-qsv-build-audio-related-code-when-MFX_VERSION-2.0.patch"
115
-
"${src}/contrib/ffmpeg/A07-qsvenc-support-multi-frame-encode-when-MFX_VERSION-2.patch"
116
-
"${src}/contrib/ffmpeg/A08-qsvenc-support-MFX_RATECONTROL_LA_EXT-when-MFX_VERSI.patch"
117
-
"${src}/contrib/ffmpeg/A09-qsv-support-OPAQUE-memory-when-MFX_VERSION-2.0.patch"
118
-
"${src}/contrib/ffmpeg/A10-qsv-configure-add-enable-libvpl-option.patch"
119
-
"${src}/contrib/ffmpeg/A11-qsv-use-a-new-method-to-create-mfx-session-when-usin.patch"
120
-
"${src}/contrib/ffmpeg/A12-qsv-fix-decode-10bit-hdr.patch"
121
-
"${src}/contrib/ffmpeg/A13-mov-read-name-track-tag-written-by-movenc.patch"
122
-
"${src}/contrib/ffmpeg/A14-movenc-write-3gpp-track-titl-tag.patch"
123
-
"${src}/contrib/ffmpeg/A15-mov-read-3gpp-udta-tags.patch"
124
-
"${src}/contrib/ffmpeg/A16-movenc-write-3gpp-track-names-tags-for-all-available.patch"
125
-
"${src}/contrib/ffmpeg/A17-FFmpeg-devel-amfenc-Add-support-for-pict_type-field.patch"
126
-
"${src}/contrib/ffmpeg/A18-dvdsubdec-fix-processing-of-partial-packets.patch"
127
-
"${src}/contrib/ffmpeg/A19-ccaption_dec-return-number-of-bytes-used.patch"
128
-
"${src}/contrib/ffmpeg/A20-dvdsubdec-return-number-of-bytes-used.patch"
129
-
"${src}/contrib/ffmpeg/A21-dvdsubdec-use-pts-of-initial-packet.patch"
130
-
"${src}/contrib/ffmpeg/A22-matroskaenc-aac-extradata-updated.patch"
131
-
"${src}/contrib/ffmpeg/A23-ccaption_dec-fix-pts-in-real_time-mode.patch"
132
-
"${src}/contrib/ffmpeg/A24-fix-eac3-dowmix.patch"
133
-
"${src}/contrib/ffmpeg/A25-enable-truehd-pass.patch"
134
-
"${src}/contrib/ffmpeg/A26-Update-the-min-version-to-1.4.23.0-for-AMF-SDK.patch"
135
-
"${src}/contrib/ffmpeg/A27-avcodec-amfenc-Fixes-the-color-information-in-the-ou.patch"
136
-
"${src}/contrib/ffmpeg/A28-avcodec-amfenc-HDR-metadata.patch"
137
-
# This patch is not applying since ffmpeg 5.1.1, probably it was backported by upstream
138
-
# "${src}/contrib/ffmpeg/A30-svt-av1-backports.patch"
140
-
name = "vulkan-remove-extensions.patch";
141
-
url = "https://git.ffmpeg.org/gitweb/ffmpeg.git/commitdiff_plain/eb0455d64690";
142
-
hash = "sha256-qvLrb7b+9/bel8A2lZuSmBiJtHXsABw0Lvgn1ggnmCU=";
114
+
patches = (old.patches or [ ]) ++ [
115
+
"${src}/contrib/ffmpeg/A01-mov-read-name-track-tag-written-by-movenc.patch"
116
+
"${src}/contrib/ffmpeg/A02-movenc-write-3gpp-track-titl-tag.patch"
117
+
"${src}/contrib/ffmpeg/A03-mov-read-3gpp-udta-tags.patch"
118
+
"${src}/contrib/ffmpeg/A04-movenc-write-3gpp-track-names-tags-for-all-available.patch"
119
+
"${src}/contrib/ffmpeg/A05-dvdsubdec-fix-processing-of-partial-packets.patch"
120
+
"${src}/contrib/ffmpeg/A06-dvdsubdec-return-number-of-bytes-used.patch"
121
+
"${src}/contrib/ffmpeg/A07-dvdsubdec-use-pts-of-initial-packet.patch"
122
+
"${src}/contrib/ffmpeg/A08-ccaption_dec-fix-pts-in-real_time-mode.patch"
123
+
"${src}/contrib/ffmpeg/A09-matroskaenc-aac-extradata-updated.patch"
124
+
"${src}/contrib/ffmpeg/A10-amfenc-Add-support-for-pict_type-field.patch"
125
+
"${src}/contrib/ffmpeg/A11-amfenc-Fixes-the-color-information-in-the-ou.patch"
126
+
"${src}/contrib/ffmpeg/A12-amfenc-HDR-metadata.patch"
127
+
"${src}/contrib/ffmpeg/A13-libavcodec-amfenc-Fix-issue-with-missing-headers-in-.patch"
128
+
"${src}/contrib/ffmpeg/A14-avcodec-add-ambient-viewing-environment-packet-side-.patch"
129
+
"${src}/contrib/ffmpeg/A15-avformat-mov-add-support-for-amve-ambient-viewing-en.patch"
130
+
"${src}/contrib/ffmpeg/A16-videotoolbox-dec-h264.patch"
132
+
# patch to fix <https://github.com/HandBrake/HandBrake/issues/5011>
133
+
# commented out because it causes ffmpeg's filter-pixdesc-p010le test to fail.
134
+
# "${src}/contrib/ffmpeg/A17-libswscale-fix-yuv420p-to-p01xle-color-conversion-bu.patch"
136
+
"${src}/contrib/ffmpeg/A18-qsv-fix-decode-10bit-hdr.patch"
137
+
"${src}/contrib/ffmpeg/A19-ffbuild-common-use-gzip-n-flag-for-cuda.patch"
141
+
x265-hb = x265.overrideAttrs (old: {
142
+
# nixpkgs' x265 sourceRoot is x265-.../source whereas handbrake's x265 patches
143
+
# are written with respect to the parent directory instead of that source directory.
144
+
# patches which don't cleanly apply are commented out.
145
+
postPatch = (old.postPatch or "") + ''
147
+
# patch -p1 < ${src}/contrib/x265/A00-crosscompile-fix.patch
148
+
patch -p1 < ${src}/contrib/x265/A01-threads-priority.patch
149
+
patch -p1 < ${src}/contrib/x265/A02-threads-pool-adjustments.patch
150
+
patch -p1 < ${src}/contrib/x265/A03-sei-length-crash-fix.patch
151
+
patch -p1 < ${src}/contrib/x265/A04-ambient-viewing-enviroment-sei.patch
152
+
# patch -p1 < ${src}/contrib/x265/A05-memory-leaks.patch
versionFile = writeText "version.txt" ''
···
# Use the Nix-provided libxml2 instead of the system-provided one.
substituteInPlace libhb/module.defs \
--replace /usr/include/libxml2 ${libxml2.dev}/include/libxml2
202
+
'' + optionalString useGtk ''
203
+
substituteInPlace gtk/module.rules \
204
+
--replace-fail '$(MESON.exe)' 'meson' \
205
+
--replace-fail '$(NINJA.exe)' 'ninja' \
206
+
# Force using nixpkgs dependencies
207
+
substituteInPlace gtk/meson.build \
208
+
--replace-fail "cc.find_library('bz2', dirs: hb_libdirs)" "cc.find_library('bz2')" \
209
+
--replace-fail "cc.find_library('mp3lame', dirs: hb_libdirs)" "cc.find_library('mp3lame')" \
211
+
"hb_incdirs = include_directories(hb_dir / 'libhb', hb_dir / 'contrib/include')" \
212
+
"hb_incdirs = include_directories(hb_dir / 'libhb')" \
···
202
-
++ optionals useGtk [ intltool wrapGAppsHook ];
223
+
++ optionals useGtk [ desktop-file-utils intltool meson ninja wrapGAppsHook ];
···
++ optional (!stdenv.isDarwin) numactl
gst_all_1.gst-plugins-base
···
257
-
"--disable-gtk-update-checks"
++ optional (!useGtk) "--disable-gtk"
++ optional useFdk "--enable-fdk-aac"
···
# NOTE: 2018-12-27: Check NixOS HandBrake test if changing
NIX_LDFLAGS = [ "-lx265" ];
288
+
# meson/ninja are used only for the subprojects, not the toplevel
289
+
dontUseMesonConfigure = true;
290
+
dontUseMesonInstall = true;
291
+
dontUseNinjaBuild = true;
292
+
dontUseNinjaInstall = true;
makeFlags = [ "--directory=build" ];
298
+
inherit ffmpeg-hb x265-hb;
300
+
tests.basic-conversion =
# Big Buck Bunny example, licensed under CC Attribution 3.0.
···
HandBrakeCLI -i ${testMkv} -o test.mkv -e x264 -q 20 -B 160
286
-
version = testers.testVersion { package = self; command = "HandBrakeCLI --version"; };
317
+
tests.version = testers.testVersion { package = self; command = "HandBrakeCLI --version"; };
···
license = licenses.gpl2Only;
maintainers = with maintainers; [ Anton-Latukha wmertens ];
platforms = with platforms; unix;
303
-
broken = stdenv.isDarwin && lib.versionOlder stdenv.hostPlatform.darwinMinVersion "10.13";
334
+
broken = stdenv.isDarwin; # https://github.com/NixOS/nixpkgs/pull/297984#issuecomment-2016503434
pyrox.dev