Merge pull request #112458 from thefloweringash/shebangs

Changed files
+64 -22
pkgs
build-support
setup-hooks
test
patch-shebangs
+4 -6
pkgs/build-support/setup-hooks/patch-shebangs.sh
···
isScript "$f" || continue
read -r oldInterpreterLine < "$f"
-
read -r oldPath arg0 args <<< "${oldInterpreterLine:3}"
if [[ -z "$pathName" ]]; then
if [[ -n $strictDeps && $f == "$NIX_STORE"* ]]; then
···
newInterpreterLine=${newInterpreterLine%${newInterpreterLine##*[![:space:]]}}
if [[ -n "$oldPath" && "${oldPath:0:${#NIX_STORE}}" != "$NIX_STORE" ]]; then
-
if [[ -n "$newPath" ]] && [[ "$newPath" != "$oldPath" ]]; then
echo "$f: interpreter directive changed from \"$oldInterpreterLine\" to \"$newInterpreterLine\""
# escape the escape chars so that sed doesn't interpret them
escapedInterpreterLine=${newInterpreterLine//\\/\\\\}
# Preserve times, see: https://github.com/NixOS/nixpkgs/pull/33281
-
timestamp=$(mktemp)
-
touch -r "$f" "$timestamp"
sed -i -e "1 s|.*|#\!$escapedInterpreterLine|" "$f"
-
touch -r "$timestamp" "$f"
-
rm "$timestamp"
fi
fi
done < <(find "$@" -type f -perm -0100 -print0)
···
isScript "$f" || continue
read -r oldInterpreterLine < "$f"
+
read -r oldPath arg0 args <<< "${oldInterpreterLine:2}"
if [[ -z "$pathName" ]]; then
if [[ -n $strictDeps && $f == "$NIX_STORE"* ]]; then
···
newInterpreterLine=${newInterpreterLine%${newInterpreterLine##*[![:space:]]}}
if [[ -n "$oldPath" && "${oldPath:0:${#NIX_STORE}}" != "$NIX_STORE" ]]; then
+
if [[ -n "$newPath" && "$newPath" != "$oldPath" ]]; then
echo "$f: interpreter directive changed from \"$oldInterpreterLine\" to \"$newInterpreterLine\""
# escape the escape chars so that sed doesn't interpret them
escapedInterpreterLine=${newInterpreterLine//\\/\\\\}
# Preserve times, see: https://github.com/NixOS/nixpkgs/pull/33281
+
timestamp=$(stat --printf "%y" "$f")
sed -i -e "1 s|.*|#\!$escapedInterpreterLine|" "$f"
+
touch --date "$timestamp" "$f"
fi
fi
done < <(find "$@" -type f -perm -0100 -print0)
+60 -16
pkgs/test/patch-shebangs/default.nix
···
{ lib, stdenv, runCommand }:
let
-
bad-shebang = stdenv.mkDerivation {
-
name = "bad-shebang";
-
dontUnpack = true;
-
installPhase = ''
-
mkdir -p $out/bin
-
echo "#!/bin/sh" > $out/bin/test
-
echo "echo -n hello" >> $out/bin/test
-
chmod +x $out/bin/test
-
'';
};
in runCommand "patch-shebangs-test" {
-
passthru = { inherit bad-shebang; };
meta.platforms = lib.platforms.all;
} ''
-
printf "checking whether patchShebangs works properly... ">&2
-
if ! grep -q '^#!/bin/sh' ${bad-shebang}/bin/test; then
-
echo "yes" >&2
-
touch $out
-
else
-
echo "no" >&2
exit 1
fi
''
···
{ lib, stdenv, runCommand }:
let
+
tests = {
+
bad-shebang = stdenv.mkDerivation {
+
name = "bad-shebang";
+
dontUnpack = true;
+
installPhase = ''
+
mkdir -p $out/bin
+
echo "#!/bin/sh" > $out/bin/test
+
echo "echo -n hello" >> $out/bin/test
+
chmod +x $out/bin/test
+
'';
+
passthru = {
+
assertion = "grep -v '^#!/bin/sh' $out/bin/test > /dev/null";
+
};
+
};
+
+
ignores-nix-store = stdenv.mkDerivation {
+
name = "ignores-nix-store";
+
dontUnpack = true;
+
installPhase = ''
+
mkdir -p $out/bin
+
echo "#!$NIX_STORE/path/to/sh" > $out/bin/test
+
echo "echo -n hello" >> $out/bin/test
+
chmod +x $out/bin/test
+
'';
+
passthru = {
+
assertion = "grep \"^#!$NIX_STORE/path/to/sh\" $out/bin/test > /dev/null";
+
};
+
};
};
in runCommand "patch-shebangs-test" {
+
passthru = { inherit (tests) bad-shebang ignores-nix-store; };
meta.platforms = lib.platforms.all;
} ''
+
validate() {
+
local name=$1
+
local testout=$2
+
local assertion=$3
+
+
echo -n "... $name: " >&2
+
+
local rc=0
+
(out=$testout eval "$assertion") || rc=1
+
+
if [ "$rc" -eq 0 ]; then
+
echo "yes" >&2
+
else
+
echo "no" >&2
+
fi
+
+
return "$rc"
+
}
+
+
echo "checking whether patchShebangs works properly... ">&2
+
+
fail=
+
${lib.concatStringsSep "\n" (lib.mapAttrsToList (_: test: ''
+
validate "${test.name}" "${test}" ${lib.escapeShellArg test.assertion} || fail=1
+
'') tests)}
+
+
if [ "$fail" ]; then
+
echo "failed"
exit 1
+
else
+
echo "succeeded"
+
touch $out
fi
''