···

       
1
       
1
       
-
       
Disable v8 system instrumentation on Darwin

     

       
2
       
2
       
-
       


     

       
3
       
3
       
-
       
On Darwin, the v8 system instrumentation requires the header "os/signpost.h"

     

       
4
       
4
       
-
       
which is available since apple_sdk 11+. See: https://github.com/nodejs/node/issues/39584

     

       
5
       
5
       
-
       


     

       
6
       
6
       
-
       
--- old/tools/v8_gypfiles/features.gypi

     

       
7
       
7
       
-
       
+++ new/tools/v8_gypfiles/features.gypi

     

       
8
       
8
       
-
       
@@ -62,7 +62,7 @@

     

       
9
       
9
       
-
       
       }, {

     

       
10
       
10
       
-
       
         'is_component_build': 0,

     

       
11
       
11
       
-
       
       }],

     

       
12
       
12
       
-
       
-      ['OS == "win" or OS == "mac"', {

     

       
13
       
13
       
-
       
+      ['OS == "win"', {

     

       
14
       
14
       
-
       
         # Sets -DENABLE_SYSTEM_INSTRUMENTATION. Enables OS-dependent event tracing

     

       
15
       
15
       
-
       
         'v8_enable_system_instrumentation': 1,

     

       
16
       
16
       
-
       
       }, {

     

···

       
40
       
40
       
 
       
  patches = [

     

       
41
       
41
       
 
       
    ./configure-emulator.patch

     

       
42
       
42
       
 
       
    ./configure-armv6-vfpv2.patch

     

       
43
       
43
       
-
       
    ./disable-darwin-v8-system-instrumentation-node19.patch

     

       
44
       
43
       
 
       
    ./node-npm-build-npm-package-logic.patch

     

       
45
       
44
       
 
       
    ./use-correct-env-in-tests.patch

     

       
46
       
45
       
 
       


     

···

       
56
       
56
       
 
       
    ++ gypPatches

     

       
57
       
57
       
 
       
    ++ [

     

       
58
       
58
       
 
       
      ./configure-armv6-vfpv2.patch

     

       
59
       
59
       
-
       
      ./disable-darwin-v8-system-instrumentation-node19.patch

     

       
60
       
59
       
 
       
      ./node-npm-build-npm-package-logic.patch

     

       
61
       
60
       
 
       
      ./use-correct-env-in-tests.patch

     

       
62
       
61
       
 
       
      ./bin-sh-node-run-v22.patch

     

···

       
55
       
55
       
 
       
    ]

     

       
56
       
56
       
 
       
    ++ [

     

       
57
       
57
       
 
       
      ./configure-armv6-vfpv2.patch

     

       
58
       
58
       
-
       
      ./disable-darwin-v8-system-instrumentation-node19.patch

     

       
59
       
58
       
 
       
      ./node-npm-build-npm-package-logic.patch

     

       
60
       
59
       
 
       
      ./use-correct-env-in-tests.patch

     

       
61
       
60
       
 
       
      ./bin-sh-node-run-v22.patch