commit e04cc18f18011471ffe0e693758bfcc0b4cf5393 · pyrox.dev/nixpkgs

pyrox.dev / nixpkgs

lol

find-tarballs.nix: Avoid all passthru attrs

Avoiding passthru itself was the right direction, but not a
complete solution. Passthru attributes typically do not contain
dependencies, but rather extra paths that are not relevant to
the build itself.

Whether we want to include all (passthru) test dependencies this
way can be debated, but removing them makes this expression more
robust.

Robert Hensing 4 years ago e04cc18f 642292c8

options

unified split

Changed files

+1 -1

maintainers

scripts

find-tarballs.nix

+1 -1

maintainers/scripts/find-tarballs.nix

···

       37
       37
        
         keyDrv = drv: if canEval drv.drvPath then { key = drv.drvPath; value = drv; } else { };

     

       38
       38
        
       

     

       39
       39
        
         immediateDependenciesOf = drv:

     

       40
       40
       -
           concatLists (mapAttrsToList (n: v: derivationsIn v) (removeAttrs drv ["meta" "passthru"]));

     

       40
       40
       +
           concatLists (mapAttrsToList (n: v: derivationsIn v) (removeAttrs drv (["meta" "passthru"] ++ optionals (drv?passthru) (attrNames drv.passthru))));

     

       41
       41
        
       

     

       42
       42
        
         derivationsIn = x:

     

       43
       43
        
           if !canEval x then []