commit e5db80ae487b59b4e9f950d68983ffb0575e26c6 · pyrox.dev/nixpkgs

+13

flake.nix

···

       57
       57
        
       

     

       58
       58
        
             nixosModules = {

     

       59
       59
        
               notDetected = ./nixos/modules/installer/scan/not-detected.nix;

     

       60
       60
       +
       

     

       61
       61
       +
               /*

     

       62
       62
       +
                 Make the `nixpkgs.*` configuration read-only. Guarantees that `pkgs`

     

       63
       63
       +
                 is the way you initialize it.

     

       64
       64
       +
       

     

       65
       65
       +
                 Example:

     

       66
       66
       +
       

     

       67
       67
       +
                     {

     

       68
       68
       +
                       imports = [ nixpkgs.nixosModules.readOnlyPkgs ];

     

       69
       69
       +
                       nixpkgs.pkgs = nixpkgs.legacyPackages.x86_64-linux;

     

       70
       70
       +
                     }

     

       71
       71
       +
               */

     

       72
       72
       +
               readOnlyPkgs = ./nixos/modules/misc/nixpkgs/read-only.nix;

     

       60
       73
        
             };

     

       61
       74
        
           };

     

       62
       75
        
       }

+74

nixos/modules/misc/nixpkgs/read-only.nix

···

       1
       1
       +
       # A replacement for the traditional nixpkgs module, such that none of the modules

     

       2
       2
       +
       # can add their own configuration. This ensures that the Nixpkgs configuration is

     

       3
       3
       +
       # exactly as the user intends.

     

       4
       4
       +
       # This may also be used as a performance optimization when evaluating multiple

     

       5
       5
       +
       # configurations at once, with a shared `pkgs`.

     

       6
       6
       +
       

     

       7
       7
       +
       # This is a separate module, because merging this logic into the nixpkgs module

     

       8
       8
       +
       # is too burdensome, considering that it is already burdened with legacy.

     

       9
       9
       +
       # Moving this logic into a module does not lose any composition benefits, because

     

       10
       10
       +
       # its purpose is not something that composes anyway.

     

       11
       11
       +
       

     

       12
       12
       +
       { lib, config, ... }:

     

       13
       13
       +
       

     

       14
       14
       +
       let

     

       15
       15
       +
         cfg = config.nixpkgs;

     

       16
       16
       +
         inherit (lib) mkOption types;

     

       17
       17
       +
       

     

       18
       18
       +
       in

     

       19
       19
       +
       {

     

       20
       20
       +
         disabledModules = [

     

       21
       21
       +
           ../nixpkgs.nix

     

       22
       22
       +
         ];

     

       23
       23
       +
         options = {

     

       24
       24
       +
           nixpkgs = {

     

       25
       25
       +
             pkgs = mkOption {

     

       26
       26
       +
               type = lib.types.pkgs;

     

       27
       27
       +
               description = lib.mdDoc ''The pkgs module argument.'';

     

       28
       28
       +
             };

     

       29
       29
       +
             config = mkOption {

     

       30
       30
       +
               internal = true;

     

       31
       31
       +
               type = types.unique { message = "nixpkgs.config is set to read-only"; } types.anything;

     

       32
       32
       +
               description = lib.mdDoc ''

     

       33
       33
       +
                 The Nixpkgs `config` that `pkgs` was initialized with.

     

       34
       34
       +
               '';

     

       35
       35
       +
             };

     

       36
       36
       +
             overlays = mkOption {

     

       37
       37
       +
               internal = true;

     

       38
       38
       +
               type = types.unique { message = "nixpkgs.overlays is set to read-only"; } types.anything;

     

       39
       39
       +
               description = lib.mdDoc ''

     

       40
       40
       +
                 The Nixpkgs overlays that `pkgs` was initialized with.

     

       41
       41
       +
               '';

     

       42
       42
       +
             };

     

       43
       43
       +
             hostPlatform = mkOption {

     

       44
       44
       +
               internal = true;

     

       45
       45
       +
               readOnly = true;

     

       46
       46
       +
               description = lib.mdDoc ''

     

       47
       47
       +
                 The platform of the machine that is running the NixOS configuration.

     

       48
       48
       +
               '';

     

       49
       49
       +
             };

     

       50
       50
       +
             buildPlatform = mkOption {

     

       51
       51
       +
               internal = true;

     

       52
       52
       +
               readOnly = true;

     

       53
       53
       +
               description = lib.mdDoc ''

     

       54
       54
       +
                 The platform of the machine that built the NixOS configuration.

     

       55
       55
       +
               '';

     

       56
       56
       +
             };

     

       57
       57
       +
             # NOTE: do not add the legacy options such as localSystem here. Let's keep

     

       58
       58
       +
             #       this module simple and let module authors upgrade their code instead.

     

       59
       59
       +
           };

     

       60
       60
       +
         };

     

       61
       61
       +
         config = {

     

       62
       62
       +
           _module.args.pkgs =

     

       63
       63
       +
             # find mistaken definitions

     

       64
       64
       +
             builtins.seq cfg.config

     

       65
       65
       +
             builtins.seq cfg.overlays

     

       66
       66
       +
             builtins.seq cfg.hostPlatform

     

       67
       67
       +
             builtins.seq cfg.buildPlatform

     

       68
       68
       +
             cfg.pkgs;

     

       69
       69
       +
           nixpkgs.config = cfg.pkgs.config;

     

       70
       70
       +
           nixpkgs.overlays = cfg.pkgs.overlays;

     

       71
       71
       +
           nixpkgs.hostPlatform = cfg.pkgs.stdenv.hostPlatform;

     

       72
       72
       +
           nixpkgs.buildPlatform = cfg.pkgs.stdenv.buildPlatform;

     

       73
       73
       +
         };

     

       74
       74
       +
       }

+59

nixos/modules/misc/nixpkgs/test.nix

···

       1
       1
       +
       # [nixpkgs]$ nix-build -A nixosTests.nixpkgs --show-trace

     

       2
       2
       +
       

     

       1
       3
        
       { evalMinimalConfig, pkgs, lib, stdenv }:

     

       2
       4
        
       let

     

       3
       5
        
         eval = mod: evalMinimalConfig {

     
···

       27
       29
        
           let

     

       28
       30
        
             uncheckedEval = lib.evalModules { modules = [ ../nixpkgs.nix module ]; };

     

       29
       31
        
           in map (ass: ass.message) (lib.filter (ass: !ass.assertion) uncheckedEval.config.assertions);

     

       32
       32
       +
       

     

       33
       33
       +
         readOnlyUndefined = evalMinimalConfig {

     

       34
       34
       +
           imports = [ ./read-only.nix ];

     

       35
       35
       +
         };

     

       36
       36
       +
       

     

       37
       37
       +
         readOnlyBad = evalMinimalConfig {

     

       38
       38
       +
           imports = [ ./read-only.nix ];

     

       39
       39
       +
           nixpkgs.pkgs = { };

     

       40
       40
       +
         };

     

       41
       41
       +
       

     

       42
       42
       +
         readOnly = evalMinimalConfig {

     

       43
       43
       +
           imports = [ ./read-only.nix ];

     

       44
       44
       +
           nixpkgs.pkgs = pkgs;

     

       45
       45
       +
         };

     

       46
       46
       +
       

     

       47
       47
       +
         readOnlyBadConfig = evalMinimalConfig {

     

       48
       48
       +
           imports = [ ./read-only.nix ];

     

       49
       49
       +
           nixpkgs.pkgs = pkgs;

     

       50
       50
       +
           nixpkgs.config.allowUnfree = true; # do in pkgs instead!

     

       51
       51
       +
         };

     

       52
       52
       +
       

     

       53
       53
       +
         readOnlyBadOverlays = evalMinimalConfig {

     

       54
       54
       +
           imports = [ ./read-only.nix ];

     

       55
       55
       +
           nixpkgs.pkgs = pkgs;

     

       56
       56
       +
           nixpkgs.overlays = [ (_: _: {}) ]; # do in pkgs instead!

     

       57
       57
       +
         };

     

       58
       58
       +
       

     

       59
       59
       +
         readOnlyBadHostPlatform = evalMinimalConfig {

     

       60
       60
       +
           imports = [ ./read-only.nix ];

     

       61
       61
       +
           nixpkgs.pkgs = pkgs;

     

       62
       62
       +
           nixpkgs.hostPlatform = "foo-linux"; # do in pkgs instead!

     

       63
       63
       +
         };

     

       64
       64
       +
       

     

       65
       65
       +
         readOnlyBadBuildPlatform = evalMinimalConfig {

     

       66
       66
       +
           imports = [ ./read-only.nix ];

     

       67
       67
       +
           nixpkgs.pkgs = pkgs;

     

       68
       68
       +
           nixpkgs.buildPlatform = "foo-linux"; # do in pkgs instead!

     

       69
       69
       +
         };

     

       70
       70
       +
       

     

       71
       71
       +
         throws = x: ! (builtins.tryEval x).success;

     

       72
       72
       +
       

     

       30
       73
        
       in

     

       31
       74
        
       lib.recurseIntoAttrs {

     

       32
       75
        
         invokeNixpkgsSimple =

     
···

       64
       107
        
               nixpkgs.hostPlatform = pkgs.stdenv.hostPlatform;

     

       65
       108
        
               nixpkgs.pkgs = pkgs;

     

       66
       109
        
             } == [];

     

       110
       110
       +
       

     

       111
       111
       +
       

     

       112
       112
       +
           # Tests for the read-only.nix module

     

       113
       113
       +
           assert readOnly._module.args.pkgs.stdenv.hostPlatform.system == pkgs.stdenv.hostPlatform.system;

     

       114
       114
       +
           assert throws readOnlyBad._module.args.pkgs.stdenv;

     

       115
       115
       +
           assert throws readOnlyUndefined._module.args.pkgs.stdenv;

     

       116
       116
       +
           assert throws readOnlyBadConfig._module.args.pkgs.stdenv;

     

       117
       117
       +
           assert throws readOnlyBadOverlays._module.args.pkgs.stdenv;

     

       118
       118
       +
           assert throws readOnlyBadHostPlatform._module.args.pkgs.stdenv;

     

       119
       119
       +
           assert throws readOnlyBadBuildPlatform._module.args.pkgs.stdenv;

     

       120
       120
       +
           # read-only.nix does not provide legacy options, for the sake of simplicity

     

       121
       121
       +
           # If you're bothered by this, upgrade your configs to use the new *Platform

     

       122
       122
       +
           # options.

     

       123
       123
       +
           assert !readOnly.options.nixpkgs?system;

     

       124
       124
       +
           assert !readOnly.options.nixpkgs?localSystem;

     

       125
       125
       +
           assert !readOnly.options.nixpkgs?crossSystem;

     

       67
       126
        
       

     

       68
       127
        
           pkgs.emptyFile;

     

       69
       128
        
       }