pyrox.dev / nixpkgs
lol
fork atom

Revert "nixos/polkit: guard static gid for polkituser behind state version"

This reverts commit 2265160fc0b4cc9a38b392ec3b3a3fe18c2e5413 and
e56db577a1f69c02e80d8bc26d514c01a2c5cc61.

Ideally, we shouldn't cause friction for users that bump `stateVersion`,
and I'd consider having to switch and/or manually hardcode a UID/GID
to supress the warning friction. I think it'd be more beneficial to, in
this rare case of an ID being missed, just let it be until more
discussion happens surrounding this overall issue.

See https://github.com/NixOS/nixpkgs/pull/217785 for more context.

winter.bsky.social ee6517a9 15f1369b

options
unified split
Changed files
+2 -4
nixos
modules
misc
ids.nix
security
polkit.nix
+1 -1
nixos/modules/misc/ids.nix 
···

       
392

       
392

       
 

       
      tape = 25;


     

       
393

       
393

       
 

       
      video = 26;


     

       
394

       
394

       
 

       
      dialout = 27;


     

       
395

       

       
-

       
      polkituser = 28;


     

       

       
395

       
+

       
      #polkituser = 28; # currently unused, polkitd doesn't need a group


     

       
396

       
396

       
 

       
      utmp = 29;


     

       
397

       
397

       
 

       
      # ddclient = 30; # converted to DynamicUser = true


     

       
398

       
398

       
 

       
      davfs2 = 31;
+1 -3
nixos/modules/security/polkit.nix 
···

       
113

       
113

       
 

       
      group = "polkituser";


     

       
114

       
114

       
 

       
    };


     

       
115

       
115

       
 

       



     

       
116

       

       
-

       
    users.groups.polkituser = {


     

       
117

       

       
-

       
      gid = mkIf (lib.versionAtLeast config.system.stateVersion "23.05") config.ids.gids.polkituser;


     

       
118

       

       
-

       
    };


     

       

       
116

       
+

       
    users.groups.polkituser = {};


     

       
119

       
117

       
 

       
  };


     

       
120

       
118

       
 

       



     

       
121

       
119

       
 

       
}