···

       
169
       
169
       
 
       
  })

     

       
170
       
170
       
 
       
  ```

     

       
171
       
171
       
 
       


     

       
172
       
172
       
+
       
- Unnecessary string conversions should be avoided. Do

     

       
173
       
173
       
+
       


     

       
174
       
174
       
+
       
  ```nix

     

       
175
       
175
       
+
       
  rev = version;

     

       
176
       
176
       
+
       
  ```

     

       
177
       
177
       
+
       


     

       
178
       
178
       
+
       
  instead of

     

       
179
       
179
       
+
       


     

       
180
       
180
       
+
       
  ```nix

     

       
181
       
181
       
+
       
  rev = "${version}";

     

       
182
       
182
       
+
       
  ```

     

       
183
       
183
       
+
       


     

       
172
       
184
       
 
       
- Arguments should be listed in the order they are used, with the exception of `lib`, which always goes first.

     

       
173
       
185
       
 
       


     

       
174
       
186
       
 
       
- The top-level `lib` must be used in the master and 21.05 branch over its alias `stdenv.lib` as it now causes evaluation errors when aliases are disabled which is the case for ofborg.