nixos: Fix ordering of firewall.service

Follow-up to the following commits:

abdc5961c3cdf9f5893ea1e91ba08ff5089f53a4: Fix starting the firewall
e090701e2d09aec3e8866ab9a8e53c37973ffeb4: Order before sysinit

Solely use sysinit.target here instead of multi-user.target because we
want to make sure that the iptables rules are applied *before* any
socket units are started.

The reason I've dropped the wantedBy on multi-user.target is that
sysinit.target is already a part of the dependency chain of
multi-user.target.

To make sure that this holds true, I've added a small test case to
ensure that during switch of the configuration the firewall.service is
considered as well.

Tested using the firewall NixOS test.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Cc: @edolstra

aszlig fb46df8a 10b33599

Changed files
+36 -20
nixos
modules
services
networking
tests
+2 -1
nixos/modules/services/networking/firewall.nix
···
systemd.services.firewall = {
description = "Firewall";
-
wantedBy = [ "multi-user.target" "sysinit.target" ];
+
wantedBy = [ "sysinit.target" ];
wants = [ "network-pre.target" ];
before = [ "network-pre.target" ];
after = [ "systemd-modules-load.service" ];
···
# containers don't have CAP_SYS_MODULE. So the host system had
# better have all necessary modules already loaded.
unitConfig.ConditionCapability = "CAP_NET_ADMIN";
+
unitConfig.DefaultDependencies = false;
reloadIfChanged = true;
+34 -19
nixos/tests/firewall.nix
···
services.httpd.adminAddr = "foo@example.org";
};
+
# Dummy configuration to check whether firewall.service will be honored
+
# during system activation. This only needs to be different to the
+
# original walled configuration so that there is a change in the service
+
# file.
+
walled2 =
+
{ config, pkgs, nodes, ... }:
+
{ networking.firewall.enable = true;
+
networking.firewall.rejectPackets = true;
+
};
+
attacker =
{ config, pkgs, ... }:
{ services.httpd.enable = true;
···
};
};
-
testScript =
-
{ nodes, ... }:
-
''
-
startAll;
+
testScript = { nodes, ... }: let
+
newSystem = nodes.walled2.config.system.build.toplevel;
+
in ''
+
$walled->start;
+
$attacker->start;
+
+
$walled->waitForUnit("firewall");
+
$walled->waitForUnit("httpd");
+
$attacker->waitForUnit("network.target");
-
$walled->waitForUnit("firewall");
-
$walled->waitForUnit("httpd");
-
$attacker->waitForUnit("network.target");
+
# Local connections should still work.
+
$walled->succeed("curl -v http://localhost/ >&2");
-
# Local connections should still work.
-
$walled->succeed("curl -v http://localhost/ >&2");
+
# Connections to the firewalled machine should fail, but ping should succeed.
+
$attacker->fail("curl --fail --connect-timeout 2 http://walled/ >&2");
+
$attacker->succeed("ping -c 1 walled >&2");
-
# Connections to the firewalled machine should fail, but ping should succeed.
-
$attacker->fail("curl --fail --connect-timeout 2 http://walled/ >&2");
-
$attacker->succeed("ping -c 1 walled >&2");
+
# Outgoing connections/pings should still work.
+
$walled->succeed("curl -v http://attacker/ >&2");
+
$walled->succeed("ping -c 1 attacker >&2");
-
# Outgoing connections/pings should still work.
-
$walled->succeed("curl -v http://attacker/ >&2");
-
$walled->succeed("ping -c 1 attacker >&2");
+
# If we stop the firewall, then connections should succeed.
+
$walled->stopJob("firewall");
+
$attacker->succeed("curl -v http://walled/ >&2");
-
# If we stop the firewall, then connections should succeed.
-
$walled->stopJob("firewall");
-
$attacker->succeed("curl -v http://walled/ >&2");
-
'';
+
# Check whether activation of a new configuration reloads the firewall.
+
$walled->succeed("${newSystem}/bin/switch-to-configuration test 2>&1" .
+
" | grep -qF firewall.service");
+
'';
})