comparing v0.0.1 and feature/tangled-ci on seiso.moe/magna

+26

message.go

···

       7
        
       

     

       8
        
       // Decode decodes a DNS packet.

     

       9
        
       func (m *Message) Decode(buf []byte) (err error) {

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       10
        
       	offset, err := m.Header.Decode(buf, 0)

     

       11
        
       	if err != nil {

     

       12
        
       		return fmt.Errorf("failed to decode message header: %w", err)

     
···

       53
        
       			return fmt.Errorf("failed to decode additional record #%d: %w", i+1, err)

     

       54
        
       		}

     

       55
        
       

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       56
        
       		m.Additional = append(m.Additional, rr)

     

       57
        
       	}

     

       58
        
       

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       59
        
       	return nil

     

       60
        
       }

     

       61

···

       7
        
       

     

       8
        
       // Decode decodes a DNS packet.

     

       9
        
       func (m *Message) Decode(buf []byte) (err error) {

     

       10
       +
       	// gets checked when parsing additional records

     

       11
       +
       	m.HasEDNS = false

     

       12
       +
       

     

       13
        
       	offset, err := m.Header.Decode(buf, 0)

     

       14
        
       	if err != nil {

     

       15
        
       		return fmt.Errorf("failed to decode message header: %w", err)

     
···

       56
        
       			return fmt.Errorf("failed to decode additional record #%d: %w", i+1, err)

     

       57
        
       		}

     

       58
        
       

     

       59
       +
       		if rr.RType == OPTType {

     

       60
       +
       			opt, ok := rr.RData.(*OPT)

     

       61
       +
       			if !ok {

     

       62
       +
       				// this should never fail

     

       63
       +
       				return fmt.Errorf("unable to parse RData as OPT")

     

       64
       +
       			}

     

       65
       +
       

     

       66
       +
       			m.HasEDNS = true

     

       67
       +
       			m.ExtendedRCode = uint8(rr.TTL >> 24 & 0xFF000000)

     

       68
       +
       			m.EDNSVersion = uint8((rr.TTL & 0x00FF0000) >> 16)

     

       69
       +
       			m.EDNSFlags = uint16(rr.TTL & 0x0000FFFF)

     

       70
       +
       			m.EDNSOptions = opt.Options

     

       71
       +
       			m.UDPSize = uint16(rr.RClass)

     

       72
       +
       		}

     

       73
       +
       

     

       74
        
       		m.Additional = append(m.Additional, rr)

     

       75
        
       	}

     

       76
        
       

     

       77
       +
       	if !m.HasEDNS {

     

       78
       +
       		m.ExtendedRCode = 0

     

       79
       +
       		m.EDNSVersion = 0

     

       80
       +
       		m.EDNSFlags = 0

     

       81
       +
       		m.EDNSOptions = make([]EDNSOption, 0)

     

       82
       +
       		m.UDPSize = 512 // default in rfc-1035 section 2.3.4.

     

       83
       +
       	}

     

       84
       +
       

     

       85
        
       	return nil

     

       86
        
       }

     

       87

+11

.golangci.toml

···

       1
       +
       version = "2"

     

       2
       +
       [linters.settings.govet]

     

       3
       +
       enable_all = true

     

       4
       +
       [linters.settings.staticcheck]

     

       5
       +
       checks = ["all"]

     

       6
       +
       [linters.settings.exhaustive]

     

       7
       +
       check = ["switch"]

     

       8
       +
       [linters.settings.exhaustruct]

     

       9
       +
       [linters.settings.goconst]

     

       10
       +
       [linters.settings.testifylint]

     

       11
       +
       enable-all = true

+7

Justfile

···

       1
       +
       format:

     

       2
       +
         go fmt ./...

     

       3
       +
         gofumpt -l -w $(fd .go)

     

       4
       +
       

     

       5
       +
       verify:

     

       6
       +
         go vet ./...

     

       7
       +
         golangci-lint run

+1 -1

message_test.go

···

       226
        
       					},

     

       227
        
       				},

     

       228
        
       				EDNSVersion: 0x64,

     

       229
       -
       				UDPSize: 0x4d0,

     

       230
        
       			},

     

       231
        
       		},

     

       232
        
       	}

···

       226
        
       					},

     

       227
        
       				},

     

       228
        
       				EDNSVersion: 0x64,

     

       229
       +
       				UDPSize:     0x4d0,

     

       230
        
       			},

     

       231
        
       		},

     

       232
        
       	}

+6

README.md

···

       1
        
       # Magna

     

       2
        
       

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       3
        
       this is a go package for packing/unpacking dns packets.

     

       4
        
       

     

       5
        
       > which we expect to be so popular that it would be a waste of wire space

···

       1
        
       # Magna

     

       2
        
       

     

       3
       +
       ## Contributing

     

       4
       +
       Dependencies:

     

       5
       +
       - go 1.24

     

       6
       +
       - just

     

       7
       +
       - golint-ci

     

       8
       +
       

     

       9
        
       this is a go package for packing/unpacking dns packets.

     

       10
        
       

     

       11
        
       > which we expect to be so popular that it would be a waste of wire space

+30 -1

resource_record.go

···

       26
        
       		return nil, fmt.Errorf("A record: cannot encode non-IPv4 address %s", a.Address.String())

     

       27
        
       	}

     

       28
        
       

     

       29
       -
       	return append(bytes, a.Address.To4()...), nil

     

       30
        
       }

     

       31
        
       

     

       32
        
       func (a A) String() string {

     
···

       751
        
       	return fmt.Sprintf("%d %s", rt.Preference, rt.IntermediateHost)

     

       752
        
       }

     

       753
        
       

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       754
        
       func (opt *OPT) Decode(buf []byte, offset int, rdlength int) (int, error) {

     

       755
        
       	// s := offset

     

       756
        
       	opt.Options = make([]EDNSOption, 0)

     
···

       915
        
       		r.RData = &ISDN{}

     

       916
        
       	case 21:

     

       917
        
       		r.RData = &RT{}

     

       0
        
       
     

       0
        
       
     

       918
        
       	case 41:

     

       919
        
       		r.RData = &OPT{}

     

       920
        
       	default:

···

       26
        
       		return nil, fmt.Errorf("A record: cannot encode non-IPv4 address %s", a.Address.String())

     

       27
        
       	}

     

       28
        
       

     

       29
       +
       	return append(bytes, ipv4...), nil

     

       30
        
       }

     

       31
        
       

     

       32
        
       func (a A) String() string {

     
···

       751
        
       	return fmt.Sprintf("%d %s", rt.Preference, rt.IntermediateHost)

     

       752
        
       }

     

       753
        
       

     

       754
       +
       func (a *AAAA) Decode(buf []byte, offset int, rdlength int) (int, error) {

     

       755
       +
       	bytes, offset, err := getSlice(buf, offset, rdlength)

     

       756
       +
       	if err != nil {

     

       757
       +
       		return offset, fmt.Errorf("AAAA record: failed to read address data: %w", err)

     

       758
       +
       	}

     

       759
       +
       

     

       760
       +
       	a.Address = net.IP(bytes)

     

       761
       +
       	if a.Address.To16() == nil {

     

       762
       +
       		return offset, fmt.Errorf("AAAA record: decoded data is not a valid IPv6 address: %v", bytes)

     

       763
       +
       	}

     

       764
       +
       	return offset, nil

     

       765
       +
       }

     

       766
       +
       

     

       767
       +
       func (a *AAAA) Encode(bytes []byte, offsets *map[string]uint16) ([]byte, error) {

     

       768
       +
       	ipv6 := a.Address.To16()

     

       769
       +
       	// XXX: ipv6 encodes ipv4 so need to check its not ipv4

     

       770
       +
       	if a.Address.To4() != nil || ipv6 == nil {

     

       771
       +
       		return nil, fmt.Errorf("AAAA record: cannot encode non-IPv6 address %s", a.Address.String())

     

       772
       +
       	}

     

       773
       +
       

     

       774
       +
       	return append(bytes, ipv6...), nil

     

       775
       +
       }

     

       776
       +
       

     

       777
       +
       func (a AAAA) String() string {

     

       778
       +
       	return a.Address.String()

     

       779
       +
       }

     

       780
       +
       

     

       781
        
       func (opt *OPT) Decode(buf []byte, offset int, rdlength int) (int, error) {

     

       782
        
       	// s := offset

     

       783
        
       	opt.Options = make([]EDNSOption, 0)

     
···

       942
        
       		r.RData = &ISDN{}

     

       943
        
       	case 21:

     

       944
        
       		r.RData = &RT{}

     

       945
       +
       	case 28:

     

       946
       +
       		r.RData = &AAAA{}

     

       947
        
       	case 41:

     

       948
        
       		r.RData = &OPT{}

     

       949
        
       	default:

+30

resource_record_test.go

···

       516
        
       		})

     

       517
        
       	}

     

       518
        
       }

     

       519
       +
       

     

       520
       +
       func TestAAAARecord(t *testing.T) {

     

       521
       +
       	addr := net.ParseIP("2001:db8::1")

     

       522
       +
       	rdataBytes := []byte(addr)

     

       523
       +
       	aaaa := &AAAA{}

     

       524
       +
       

     

       525
       +
       	offset, err := aaaa.Decode([]byte{}, 0, 16)

     

       526
       +
       	assert.Error(t, err, "Decode should fail with empty buffer")

     

       527
       +
       	assert.True(t, errors.Is(err, &BufferOverflowError{}))

     

       528
       +
       

     

       529
       +
       	offset, err = aaaa.Decode(rdataBytes, 0, 16)

     

       530
       +
       	assert.NoError(t, err)

     

       531
       +
       	assert.Equal(t, 16, offset)

     

       532
       +
       	assert.Equal(t, addr, aaaa.Address)

     

       533
       +
       

     

       534
       +
       	_, err = aaaa.Decode([]byte{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15}, 0, 15)

     

       535
       +
       	assert.Error(t, err)

     

       536
       +
       	assert.Contains(t, err.Error(), "AAAA record:")

     

       537
       +
       

     

       538
       +
       	aaaaEncode := &AAAA{Address: addr}

     

       539
       +
       	encoded := encodeRData(t, aaaaEncode)

     

       540
       +
       	assert.Equal(t, rdataBytes, encoded)

     

       541
       +
       

     

       542
       +
       	ipv4 := net.ParseIP("192.168.1.1")

     

       543
       +
       	aaaaEncodeInvalid := &AAAA{Address: ipv4}

     

       544
       +
       	_, err = aaaaEncodeInvalid.Encode([]byte{}, &map[string]uint16{})

     

       545
       +
       

     

       546
       +
       	assert.Error(t, err)

     

       547
       +
       	assert.Contains(t, err.Error(), "cannot encode non-IPv6 address")

     

       548
       +
       }

+7 -1

.tangled/workflows/lint.yml

···

       1
        
       when:

     

       2
       -
         - event: ["push", "pull_request"]

     

       3
        
           branch: ["main"]

     

       4
        
       

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       5
        
       dependencies:

     

       6
        
         nixpkgs:

     

       7
        
           - go

···

       1
        
       when:

     

       2
       +
         - event: ["push", "pull_request", "manual"]

     

       3
        
           branch: ["main"]

     

       4
        
       

     

       5
       +
       engine: "nixery"

     

       6
       +
       

     

       7
       +
       clone:

     

       8
       +
         depth: 1

     

       9
       +
         submodules: false

     

       10
       +
       

     

       11
        
       dependencies:

     

       12
        
         nixpkgs:

     

       13
        
           - go

+7 -2

.tangled/workflows/test.yml

···

       1
        
       when:

     

       2
       -
         - event: ["push", "pull_request"]

     

       3
        
           branch: ["main"]

     

       4
       -
         - event: ["manual"]

     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       0
        
       
     

       5
        
       

     

       6
        
       dependencies:

     

       7
        
         nixpkgs:

···

       1
        
       when:

     

       2
       +
         - event: ["push", "pull_request", "manual"]

     

       3
        
           branch: ["main"]

     

       4
       +
       

     

       5
       +
       engine: "nixery"

     

       6
       +
       

     

       7
       +
       clone:

     

       8
       +
         depth: 1

     

       9
       +
         submodules: false

     

       10
        
       

     

       11
        
       dependencies:

     

       12
        
         nixpkgs:

+18

.tangled/workflows/staticcheck.yml

···

       1
       +
       when:

     

       2
       +
         - event: ["push", "pull_request", "manual"]

     

       3
       +
           branch: ["main"]

     

       4
       +
       

     

       5
       +
       engine: "nixery"

     

       6
       +
       

     

       7
       +
       clone:

     

       8
       +
         depth: 1

     

       9
       +
         submodules: false

     

       10
       +
       

     

       11
       +
       dependencies:

     

       12
       +
         nixpkgs:

     

       13
       +
           - go

     

       14
       +
       

     

       15
       +
       steps:

     

       16
       +
         - name: "staticcheck"

     

       17
       +
           command: |

     

       18
       +
              go run honnef.co/go/tools/cmd/staticcheck@latest

Compare changes