appview: add user in 404 error pages #9

closed
opened by serendipty01.dev targeting master from push-prquzlvztlul
Changed files
+52 -21
appview
issues
middleware
pages
repo
state
strings
+30 -10
appview/issues/issues.go
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
-
rp.pages.Error404(w)
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
-
rp.pages.Error404(w)
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
-
rp.pages.Error404(w)
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
-
rp.pages.Error404(w)
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
-
rp.pages.Error404(w)
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
-
rp.pages.Error404(w)
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
-
rp.pages.Error404(w)
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
-
rp.pages.Error404(w)
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
-
rp.pages.Error404(w)
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
-
rp.pages.Error404(w)
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
+
rp.pages.Error404(w, pages.ErrorPageParams{
+
LoggedInUser: user,
+
})
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
+
rp.pages.Error404(w, pages.ErrorPageParams{
+
LoggedInUser: user,
+
})
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
+
rp.pages.Error404(w, pages.ErrorPageParams{
+
LoggedInUser: user,
+
})
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
+
rp.pages.Error404(w, pages.ErrorPageParams{
+
LoggedInUser: user,
+
})
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
+
rp.pages.Error404(w, pages.ErrorPageParams{
+
LoggedInUser: user,
+
})
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
+
rp.pages.Error404(w, pages.ErrorPageParams{
+
LoggedInUser: user,
+
})
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
+
rp.pages.Error404(w, pages.ErrorPageParams{
+
LoggedInUser: user,
+
})
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
+
rp.pages.Error404(w, pages.ErrorPageParams{
+
LoggedInUser: user,
+
})
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
+
rp.pages.Error404(w, pages.ErrorPageParams{
+
LoggedInUser: user,
+
})
return
}
···
issue, ok := r.Context().Value("issue").(*models.Issue)
if !ok {
l.Error("failed to get issue")
+
rp.pages.Error404(w, pages.ErrorPageParams{
+
LoggedInUser: user,
+
})
return
}
+1 -1
appview/middleware/middleware.go
···
if err != nil {
// invalid did or handle
log.Printf("failed to resolve did/handle '%s': %s\n", didOrHandle, err)
-
mw.pages.Error404(w)
return
}
···
if err != nil {
// invalid did or handle
log.Printf("failed to resolve did/handle '%s': %s\n", didOrHandle, err)
+
mw.pages.Error404(w, pages.ErrorPageParams{})
return
}
+2 -2
appview/pages/pages.go
···
return p.execute("errors/500", w, params)
}
-
func (p *Pages) Error404(w io.Writer) error {
-
return p.execute("errors/404", w, nil)
}
func (p *Pages) ErrorKnot404(w io.Writer) error {
···
return p.execute("errors/500", w, params)
}
+
func (p *Pages) Error404(w io.Writer, params ErrorPageParams) error {
+
return p.execute("errors/404", w, params)
}
func (p *Pages) ErrorKnot404(w io.Writer) error {
+7 -3
appview/repo/repo.go
···
func (rp *Repo) RepoCommit(w http.ResponseWriter, r *http.Request) {
l := rp.logger.With("handler", "RepoCommit")
f, err := rp.repoResolver.Resolve(r)
if err != nil {
···
}
if !plumbing.IsHash(ref) {
-
rp.pages.Error404(w)
return
}
···
l.Error("failed to GetVerifiedCommits", "err", err)
}
-
user := rp.oauth.GetUser(r)
repoInfo := f.RepoInfo(user)
pipelines, err := getPipelineStatuses(rp.db, repoInfo, []string{result.Diff.Commit.This})
if err != nil {
···
if base == "" || head == "" {
l.Error("invalid comparison")
-
rp.pages.Error404(w)
return
}
···
func (rp *Repo) RepoCommit(w http.ResponseWriter, r *http.Request) {
l := rp.logger.With("handler", "RepoCommit")
+
user := rp.oauth.GetUser(r)
f, err := rp.repoResolver.Resolve(r)
if err != nil {
···
}
if !plumbing.IsHash(ref) {
+
rp.pages.Error404(w, pages.ErrorPageParams{
+
LoggedInUser: user,
+
})
return
}
···
l.Error("failed to GetVerifiedCommits", "err", err)
}
repoInfo := f.RepoInfo(user)
pipelines, err := getPipelineStatuses(rp.db, repoInfo, []string{result.Diff.Commit.This})
if err != nil {
···
if base == "" || head == "" {
l.Error("invalid comparison")
+
rp.pages.Error404(w, pages.ErrorPageParams{
+
LoggedInUser: user,
+
})
return
}
+5 -2
appview/state/profile.go
···
func (s *State) AtomFeedPage(w http.ResponseWriter, r *http.Request) {
ident, ok := r.Context().Value("resolvedId").(identity.Identity)
if !ok {
-
s.pages.Error404(w)
return
}
-
user := s.oauth.GetUser(r)
feed, err := s.getProfileFeed(r.Context(), &ident)
if err != nil {
···
func (s *State) AtomFeedPage(w http.ResponseWriter, r *http.Request) {
ident, ok := r.Context().Value("resolvedId").(identity.Identity)
+
user := s.oauth.GetUser(r)
+
if !ok {
+
s.pages.Error404(w, pages.ErrorPageParams{
+
LoggedInUser: user,
+
})
return
}
feed, err := s.getProfileFeed(r.Context(), &ident)
if err != nil {
+3 -2
appview/state/router.go
···
"tangled.org/core/appview/labels"
"tangled.org/core/appview/middleware"
"tangled.org/core/appview/notifications"
"tangled.org/core/appview/pipelines"
"tangled.org/core/appview/pulls"
"tangled.org/core/appview/repo"
···
})
r.NotFound(func(w http.ResponseWriter, r *http.Request) {
-
s.pages.Error404(w)
})
return r
···
r.Get("/brand", s.Brand)
r.NotFound(func(w http.ResponseWriter, r *http.Request) {
-
s.pages.Error404(w)
})
return r
}
···
"tangled.org/core/appview/labels"
"tangled.org/core/appview/middleware"
"tangled.org/core/appview/notifications"
+
"tangled.org/core/appview/pages"
"tangled.org/core/appview/pipelines"
"tangled.org/core/appview/pulls"
"tangled.org/core/appview/repo"
···
})
r.NotFound(func(w http.ResponseWriter, r *http.Request) {
+
s.pages.Error404(w, pages.ErrorPageParams{})
})
return r
···
r.Get("/brand", s.Brand)
r.NotFound(func(w http.ResponseWriter, r *http.Request) {
+
s.pages.Error404(w, pages.ErrorPageParams{})
})
return r
}
+4 -1
appview/strings/strings.go
···
func (s *Strings) contents(w http.ResponseWriter, r *http.Request) {
l := s.Logger.With("handler", "contents")
id, ok := r.Context().Value("resolvedId").(identity.Identity)
if !ok {
···
}
if len(strings) < 1 {
l.Error("string not found")
-
s.Pages.Error404(w)
return
}
if len(strings) != 1 {
···
func (s *Strings) contents(w http.ResponseWriter, r *http.Request) {
l := s.Logger.With("handler", "contents")
+
user := s.OAuth.GetUser(r)
id, ok := r.Context().Value("resolvedId").(identity.Identity)
if !ok {
···
}
if len(strings) < 1 {
l.Error("string not found")
+
s.Pages.Error404(w, pages.ErrorPageParams{
+
LoggedInUser: user,
+
})
return
}
if len(strings) != 1 {