Change "Primary Domain" to "Primary Namespace" #1

open

opened by

tynanpurdy.com 2 months ago targeting main from tynanpurdy.com/slices: main

Settings field for the primary namespace of a slice's lexicon was confusing, referred to both as Domain and Namespace. This made it unclear whether the namespace should be in a forward URL or reversed Namespace format. The example is in reversed namespace so I have updated the label of the field for consistency.

options

unified split

Changed files

+2 -2

frontend

src

features

dashboard

templates

fragments

CreateSliceDialog.tsx

slices

settings

templates

SliceSettings.tsx

+1 -1

frontend/src/features/dashboard/templates/fragments/CreateSliceDialog.tsx

···

       48
        
                     type="text"

     

       49
        
                     id="domain"

     

       50
        
                     name="domain"

     

       51
       -
                     label="Primary Domain"

     

       52
        
                     required

     

       53
        
                     defaultValue={domain}

     

       54
        
                     placeholder="e.g. social.grain"

···

       48
        
                     type="text"

     

       49
        
                     id="domain"

     

       50
        
                     name="domain"

     

       51
       +
                     label="Primary Namespace"

     

       52
        
                     required

     

       53
        
                     defaultValue={domain}

     

       54
        
                     placeholder="e.g. social.grain"

+1 -1

frontend/src/features/slices/settings/templates/SliceSettings.tsx

···

       101
        
       

     

       102
        
                   <div>

     

       103
        
                     <Input

     

       104
       -
                       label="Primary Domain"

     

       105
        
                       type="text"

     

       106
        
                       id="slice-domain"

     

       107
        
                       name="domain"

···

       101
        
       

     

       102
        
                   <div>

     

       103
        
                     <Input

     

       104
       +
                       label="Primary Namespace"

     

       105
        
                       type="text"

     

       106
        
                       id="slice-domain"

     

       107
        
                       name="domain"