appview: pulls: supply posthog client to PullsRouter #203

merged

opened by

oppi.li 6 months ago targeting master from push-zrkqwwrtxvzn

if the client is nil, posthog fails to enqueue a request, it crashes the route and prevents redirect (as seen while creating pull comments and pull requests)

Signed-off-by: oppiliappan me@oppi.li

options

unified split

Changed files

+3 -1

appview

pulls

pulls.go

state

router.go

appview/pulls/pulls.go

···

       51
        
       	resolver *idresolver.Resolver,

     

       52
        
       	db *db.DB,

     

       53
        
       	config *config.Config,

     

       0
        
       
     

       54
        
       ) *Pulls {

     

       55
        
       	return &Pulls{

     

       56
        
       		oauth:        oauth,

     
···

       59
        
       		idResolver:   resolver,

     

       60
        
       		db:           db,

     

       61
        
       		config:       config,

     

       0
        
       
     

       62
        
       	}

     

       63
        
       }

     

       64

···

       51
        
       	resolver *idresolver.Resolver,

     

       52
        
       	db *db.DB,

     

       53
        
       	config *config.Config,

     

       54
       +
       	posthog posthog.Client,

     

       55
        
       ) *Pulls {

     

       56
        
       	return &Pulls{

     

       57
        
       		oauth:        oauth,

     
···

       60
        
       		idResolver:   resolver,

     

       61
        
       		db:           db,

     

       62
        
       		config:       config,

     

       63
       +
       		posthog:      posthog,

     

       64
        
       	}

     

       65
        
       }

     

       66

+1 -1

appview/state/router.go

···

       178
        
       }

     

       179
        
       

     

       180
        
       func (s *State) PullsRouter(mw *middleware.Middleware) http.Handler {

     

       181
       -
       	pulls := pulls.New(s.oauth, s.repoResolver, s.pages, s.idResolver, s.db, s.config)

     

       182
        
       	return pulls.Router(mw)

     

       183
        
       }

     

       184

···

       178
        
       }

     

       179
        
       

     

       180
        
       func (s *State) PullsRouter(mw *middleware.Middleware) http.Handler {

     

       181
       +
       	pulls := pulls.New(s.oauth, s.repoResolver, s.pages, s.idResolver, s.db, s.config, s.posthog)

     

       182
        
       	return pulls.Router(mw)

     

       183
        
       }

     

       184