Monorepo for Tangled โ€” https://tangled.org

appview: oauth: swap out db store for redis cache #212

merged
opened by anirudh.fi targeting master from push-ruoqnsmttnxx
0
by anirudh.fi 0 comments
expand 1 commit
appview: oauth: swap out db store for redis cache
sign up or login to add to the discussion
1
by anirudh.fi 2 comments
expand 1 commit
appview: oauth: swap out db store for redis cache

lgtm, only nit: logout does not redirect, it should respond with a hx-redirect because the logout button the FE is a hx-post, we can also get rid of the Logout handler in appview/state/state.go.

we could make this work universally too:

  • if the hx-request header is set to true, we can use a hx-redirect,
  • if not, we can do a standard http.Redirect
sign up or login to add to the discussion
2
by anirudh.fi 1 comment
expand 1 commit
appview: oauth: swap out db store for redis cache
pull request successfully merged
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:hwevmowznbiukdf6uk5dwrrq/sh.tangled.repo.pull/3lqro3lcq4722